From 3369c4441e56cb1263967a81518a99d56b1c42ad Mon Sep 17 00:00:00 2001 From: =?utf8?q?Tim=20D=C3=BCsterhus?= Date: Mon, 7 Jan 2013 22:26:27 +0100 Subject: [PATCH] Improve SortedUseDeclarationSniff --- .../WCF/Sniffs/Namespaces/SortedUseDeclarationSniff.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/CodeSniff/WCF/Sniffs/Namespaces/SortedUseDeclarationSniff.php b/CodeSniff/WCF/Sniffs/Namespaces/SortedUseDeclarationSniff.php index be72338a55..dc8b87ae5f 100644 --- a/CodeSniff/WCF/Sniffs/Namespaces/SortedUseDeclarationSniff.php +++ b/CodeSniff/WCF/Sniffs/Namespaces/SortedUseDeclarationSniff.php @@ -82,9 +82,11 @@ class WCF_Sniffs_Namespaces_SortedUseDeclarationSniff implements PHP_CodeSniffer $classA = array_values($classA); $classB = array_values($classB); - for ($i = 0, $max = min(count($classA), count($classB)); $i < $max; $i++) { - if (ucfirst($classB[$i]) == $classB[$i] && ucfirst($classA[$i]) != $classA[$i]) return true; - if (ucfirst($classB[$i]) != $classB[$i] && ucfirst($classA[$i]) == $classA[$i]) return false; + $classALength = count($classA); + $classBLength = count($classB); + for ($i = 0, $max = min($classALength, $classBLength); $i < $max; $i++) { + if ($i + 1 === $classBLength && $i + 1 !== $classALength) return true; + if ($i + 1 !== $classBLength && $i + 1 === $classALength) return false; if (strcasecmp($classA[$i], $classB[$i]) < 0) { return true; -- 2.20.1