From 3327978e0d7ff1aa279c7c7be418a17220171669 Mon Sep 17 00:00:00 2001
From: Marcel Werk <burntime@woltlab.com>
Date: Sun, 7 Oct 2018 13:20:58 +0200
Subject: [PATCH] Use aria-hidden to hide elements used purely for decoration

See #2713
---
 com.woltlab.wcf/templates/boxFollowingsOnline.tpl         | 2 +-
 com.woltlab.wcf/templates/boxStaffOnline.tpl              | 2 +-
 com.woltlab.wcf/templates/boxTodaysBirthdays.tpl          | 2 +-
 com.woltlab.wcf/templates/boxTodaysFollowingBirthdays.tpl | 2 +-
 com.woltlab.wcf/templates/boxUserList.tpl                 | 2 +-
 com.woltlab.wcf/templates/messageQuoteList.tpl            | 2 +-
 com.woltlab.wcf/templates/messageSidebar.tpl              | 2 +-
 com.woltlab.wcf/templates/moderationArticle.tpl           | 2 +-
 com.woltlab.wcf/templates/moderationComment.tpl           | 2 +-
 com.woltlab.wcf/templates/pageHeaderUser.tpl              | 2 +-
 com.woltlab.wcf/templates/quoteMetaCode.tpl               | 2 +-
 com.woltlab.wcf/templates/recentActivityListItem.tpl      | 2 +-
 com.woltlab.wcf/templates/searchResultList.tpl            | 2 +-
 com.woltlab.wcf/templates/userBirthdayList.tpl            | 2 +-
 com.woltlab.wcf/templates/userListItem.tpl                | 2 +-
 com.woltlab.wcf/templates/userProfileLikeItem.tpl         | 2 +-
 com.woltlab.wcf/templates/usersOnlineList.tpl             | 2 +-
 17 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/com.woltlab.wcf/templates/boxFollowingsOnline.tpl b/com.woltlab.wcf/templates/boxFollowingsOnline.tpl
index 9a05c84a7a..cf328bf506 100644
--- a/com.woltlab.wcf/templates/boxFollowingsOnline.tpl
+++ b/com.woltlab.wcf/templates/boxFollowingsOnline.tpl
@@ -1,7 +1,7 @@
 <ul class="sidebarItemList">
 	{foreach from=$usersOnlineList item=userOnline}
 		<li class="box32">
-			<a href="{link controller='User' object=$userOnline}{/link}">{@$userOnline->getAvatar()->getImageTag(32)}</a>
+			<a href="{link controller='User' object=$userOnline}{/link}" aria-hidden="true">{@$userOnline->getAvatar()->getImageTag(32)}</a>
 			
 			<div class="sidebarItemTitle">
 				<h3><a href="{link controller='User' object=$userOnline}{/link}" class="userLink" data-user-id="{@$userOnline->userID}">{$userOnline->username}</a></h3>
diff --git a/com.woltlab.wcf/templates/boxStaffOnline.tpl b/com.woltlab.wcf/templates/boxStaffOnline.tpl
index d6e306cede..fe2b9172f2 100644
--- a/com.woltlab.wcf/templates/boxStaffOnline.tpl
+++ b/com.woltlab.wcf/templates/boxStaffOnline.tpl
@@ -1,7 +1,7 @@
 <ul class="sidebarItemList">
 	{foreach from=$usersOnlineList item=userOnline}
 		<li class="box32">
-			<a href="{link controller='User' object=$userOnline}{/link}">{@$userOnline->getAvatar()->getImageTag(32)}</a>
+			<a href="{link controller='User' object=$userOnline}{/link}" aria-hidden="true">{@$userOnline->getAvatar()->getImageTag(32)}</a>
 			
 			<div class="sidebarItemTitle">
 				<h3><a href="{link controller='User' object=$userOnline}{/link}" class="userLink" data-user-id="{@$userOnline->userID}">{$userOnline->username}</a></h3>
diff --git a/com.woltlab.wcf/templates/boxTodaysBirthdays.tpl b/com.woltlab.wcf/templates/boxTodaysBirthdays.tpl
index a63bba297d..8c7a0daac9 100644
--- a/com.woltlab.wcf/templates/boxTodaysBirthdays.tpl
+++ b/com.woltlab.wcf/templates/boxTodaysBirthdays.tpl
@@ -1,7 +1,7 @@
 <ul class="sidebarItemList">
 	{foreach from=$birthdayUserProfiles item=birthdayUserProfile}
 		<li class="box32">
-			<a href="{link controller='User' object=$birthdayUserProfile}{/link}">{@$birthdayUserProfile->getAvatar()->getImageTag(32)}</a>
+			<a href="{link controller='User' object=$birthdayUserProfile}{/link}" aria-hidden="true">{@$birthdayUserProfile->getAvatar()->getImageTag(32)}</a>
 			
 			<div class="sidebarItemTitle">
 				<h3><a href="{link controller='User' object=$birthdayUserProfile}{/link}" class="userLink" data-user-id="{@$birthdayUserProfile->userID}">{$birthdayUserProfile->username}</a></h3>
diff --git a/com.woltlab.wcf/templates/boxTodaysFollowingBirthdays.tpl b/com.woltlab.wcf/templates/boxTodaysFollowingBirthdays.tpl
index 742e894e69..657133e1e6 100644
--- a/com.woltlab.wcf/templates/boxTodaysFollowingBirthdays.tpl
+++ b/com.woltlab.wcf/templates/boxTodaysFollowingBirthdays.tpl
@@ -1,7 +1,7 @@
 <ul class="sidebarItemList">
 	{foreach from=$birthdayUserProfiles item=birthdayUserProfile}
 		<li class="box32">
-			<a href="{link controller='User' object=$birthdayUserProfile}{/link}">{@$birthdayUserProfile->getAvatar()->getImageTag(32)}</a>
+			<a href="{link controller='User' object=$birthdayUserProfile}{/link}" aria-hidden="true">{@$birthdayUserProfile->getAvatar()->getImageTag(32)}</a>
 			
 			<div class="sidebarItemTitle">
 				<h3><a href="{link controller='User' object=$birthdayUserProfile}{/link}" class="userLink" data-user-id="{@$birthdayUserProfile->userID}">{$birthdayUserProfile->username}</a></h3>
diff --git a/com.woltlab.wcf/templates/boxUserList.tpl b/com.woltlab.wcf/templates/boxUserList.tpl
index 58925017fa..69b4f987e3 100644
--- a/com.woltlab.wcf/templates/boxUserList.tpl
+++ b/com.woltlab.wcf/templates/boxUserList.tpl
@@ -1,7 +1,7 @@
 <ul class="sidebarItemList">
 	{foreach from=$boxUsers item=boxUser}
 		<li class="box24">
-			<a href="{link controller='User' object=$boxUser}{/link}">{@$boxUser->getAvatar()->getImageTag(24)}</a>
+			<a href="{link controller='User' object=$boxUser}{/link}" aria-hidden="true">{@$boxUser->getAvatar()->getImageTag(24)}</a>
 			
 			<div class="sidebarItemTitle">
 				<h3><a href="{link controller='User' object=$boxUser}{/link}" class="userLink" data-user-id="{@$boxUser->userID}">{$boxUser->username}</a></h3>
diff --git a/com.woltlab.wcf/templates/messageQuoteList.tpl b/com.woltlab.wcf/templates/messageQuoteList.tpl
index 1e10c7752d..aca61802a9 100644
--- a/com.woltlab.wcf/templates/messageQuoteList.tpl
+++ b/com.woltlab.wcf/templates/messageQuoteList.tpl
@@ -5,7 +5,7 @@
 			<header class="messageHeader">
 				<div class="box32 messageHeaderWrapper">
 					{if $userProfiles[$message->getUserID()]|isset}
-						<a href="{link controller='User' object=$userProfiles[$message->getUserID()]}{/link}">{@$userProfiles[$message->getUserID()]->getAvatar()->getImageTag(32)}</a>
+						<a href="{link controller='User' object=$userProfiles[$message->getUserID()]}{/link}" aria-hidden="true">{@$userProfiles[$message->getUserID()]->getAvatar()->getImageTag(32)}</a>
 					{else}
 						<span><img src="{@$__wcf->getPath()}images/avatars/avatar-default.svg" alt="" class="userAvatarImage" style="width: 32px; height: 32px"></span>
 					{/if}
diff --git a/com.woltlab.wcf/templates/messageSidebar.tpl b/com.woltlab.wcf/templates/messageSidebar.tpl
index c1034d8a1b..7737777e4f 100644
--- a/com.woltlab.wcf/templates/messageSidebar.tpl
+++ b/com.woltlab.wcf/templates/messageSidebar.tpl
@@ -17,7 +17,7 @@
 			
 			{if $userProfile->getAvatar()}
 				<div class="userAvatar">
-					<a href="{link controller='User' object=$userProfile->getDecoratedObject()}{/link}">{@$userProfile->getAvatar()->getImageTag(128)}</a>
+					<a href="{link controller='User' object=$userProfile->getDecoratedObject()}{/link}" aria-hidden="true">{@$userProfile->getAvatar()->getImageTag(128)}</a>
 					
 					{if MESSAGE_SIDEBAR_ENABLE_ONLINE_STATUS && !$isReply && $userProfile->isOnline()}<span class="badge green badgeOnline" title="{lang}wcf.user.online.title{/lang}">{lang}wcf.user.online{/lang}</span>{/if}
 				</div>
diff --git a/com.woltlab.wcf/templates/moderationArticle.tpl b/com.woltlab.wcf/templates/moderationArticle.tpl
index b385eef986..ba03e64ce0 100644
--- a/com.woltlab.wcf/templates/moderationArticle.tpl
+++ b/com.woltlab.wcf/templates/moderationArticle.tpl
@@ -3,7 +3,7 @@
 		<header class="messageHeader">
 			<div class="box32 messageHeaderWrapper">
 				{if $article->getUserProfile()->userID}
-					<a href="{link controller='User' object=$article->getUserProfile()->getDecoratedObject()}{/link}">{@$article->getUserProfile()->getAvatar()->getImageTag(32)}</a>
+					<a href="{link controller='User' object=$article->getUserProfile()->getDecoratedObject()}{/link}" aria-hidden="true">{@$article->getUserProfile()->getAvatar()->getImageTag(32)}</a>
 				{else}
 					<span>{@$article->getUserProfile()->getAvatar()->getImageTag(32)}</span>
 				{/if}
diff --git a/com.woltlab.wcf/templates/moderationComment.tpl b/com.woltlab.wcf/templates/moderationComment.tpl
index a846600619..54dca5a1ab 100644
--- a/com.woltlab.wcf/templates/moderationComment.tpl
+++ b/com.woltlab.wcf/templates/moderationComment.tpl
@@ -3,7 +3,7 @@
 		<header class="messageHeader">
 			<div class="box32 messageHeaderWrapper">
 				{if $message->userID}
-					<a href="{link controller='User' object=$message->getUserProfile()->getDecoratedObject()}{/link}">{@$message->getUserProfile()->getAvatar()->getImageTag(32)}</a>
+					<a href="{link controller='User' object=$message->getUserProfile()->getDecoratedObject()}{/link}" aria-hidden="true">{@$message->getUserProfile()->getAvatar()->getImageTag(32)}</a>
 				{else}
 					<span>{@$message->getUserProfile()->getAvatar()->getImageTag(32)}</span>
 				{/if}
diff --git a/com.woltlab.wcf/templates/pageHeaderUser.tpl b/com.woltlab.wcf/templates/pageHeaderUser.tpl
index 5cd367eca1..0bb61596fc 100644
--- a/com.woltlab.wcf/templates/pageHeaderUser.tpl
+++ b/com.woltlab.wcf/templates/pageHeaderUser.tpl
@@ -24,7 +24,7 @@
 						<ul class="interactiveDropdownItems interactiveDropdownItemsUserMenu">
 							<li>
 								<div class="box48">
-									<a href="{link controller='User' object=$__wcf->user}{/link}">{@$__wcf->getUserProfileHandler()->getAvatar()->getImageTag(48)}</a>
+									<a href="{link controller='User' object=$__wcf->user}{/link}" aria-hidden="true">{@$__wcf->getUserProfileHandler()->getAvatar()->getImageTag(48)}</a>
 									
 									<div class="containerHeadline">
 										<h3>
diff --git a/com.woltlab.wcf/templates/quoteMetaCode.tpl b/com.woltlab.wcf/templates/quoteMetaCode.tpl
index f695da1f9a..66dff97acf 100644
--- a/com.woltlab.wcf/templates/quoteMetaCode.tpl
+++ b/com.woltlab.wcf/templates/quoteMetaCode.tpl
@@ -1,7 +1,7 @@
 <blockquote class="quoteBox collapsibleBbcode jsCollapsibleBbcode{if $collapseQuote} collapsed{/if}{if !$quoteAuthorObject} quoteBoxSimple{/if}"{if $quoteLink} cite="{$quoteLink}"{/if}>
 	<div class="quoteBoxIcon">
 		{if $quoteAuthorObject}
-			<a href="{link controller='User' object=$quoteAuthorObject}{/link}" class="userLink" data-user-id="{@$quoteAuthorObject->userID}">{@$quoteAuthorObject->getAvatar()->getImageTag(64)}</a>
+			<a href="{link controller='User' object=$quoteAuthorObject}{/link}" class="userLink" data-user-id="{@$quoteAuthorObject->userID}" aria-hidden="true">{@$quoteAuthorObject->getAvatar()->getImageTag(64)}</a>
 		{else}
 			<span class="quoteBoxQuoteSymbol"></span>
 		{/if}
diff --git a/com.woltlab.wcf/templates/recentActivityListItem.tpl b/com.woltlab.wcf/templates/recentActivityListItem.tpl
index d824d03b3a..5e609c54e9 100644
--- a/com.woltlab.wcf/templates/recentActivityListItem.tpl
+++ b/com.woltlab.wcf/templates/recentActivityListItem.tpl
@@ -1,7 +1,7 @@
 {foreach from=$eventList item=event}
 	<li>
 		<div class="box48{if $__wcf->getUserProfileHandler()->isIgnoredUser($event->getUserProfile()->userID)} ignoredUserContent{/if}">
-			<a href="{link controller='User' object=$event->getUserProfile()}{/link}" title="{$event->getUserProfile()->username}">{@$event->getUserProfile()->getAvatar()->getImageTag(48)}</a>
+			<a href="{link controller='User' object=$event->getUserProfile()}{/link}" title="{$event->getUserProfile()->username}" aria-hidden="true">{@$event->getUserProfile()->getAvatar()->getImageTag(48)}</a>
 			
 			<div>
 				<div class="containerHeadline">
diff --git a/com.woltlab.wcf/templates/searchResultList.tpl b/com.woltlab.wcf/templates/searchResultList.tpl
index b9b62eee57..73cfcb75a4 100644
--- a/com.woltlab.wcf/templates/searchResultList.tpl
+++ b/com.woltlab.wcf/templates/searchResultList.tpl
@@ -8,7 +8,7 @@
 					{if $_messageCustomIcon === ''}
 						{if $message->getUserProfile()}
 							{if $message->getUserProfile()->userID}
-								<a href="{link controller='User' object=$message->getUserProfile()}{/link}" title="{$message->getUserProfile()->username}">{@$message->getUserProfile()->getAvatar()->getImageTag(48)}</a>
+								<a href="{link controller='User' object=$message->getUserProfile()}{/link}" title="{$message->getUserProfile()->username}" aria-hidden="true">{@$message->getUserProfile()->getAvatar()->getImageTag(48)}</a>
 							{else}
 								<p>{@$message->getUserProfile()->getAvatar()->getImageTag(48)}</p>
 							{/if}
diff --git a/com.woltlab.wcf/templates/userBirthdayList.tpl b/com.woltlab.wcf/templates/userBirthdayList.tpl
index 779769c6bb..d9538b725e 100644
--- a/com.woltlab.wcf/templates/userBirthdayList.tpl
+++ b/com.woltlab.wcf/templates/userBirthdayList.tpl
@@ -4,7 +4,7 @@
 			{foreach from=$users item=user}
 				<li data-object-id="{@$user->userID}">
 					<div class="box48">
-						<a href="{link controller='User' object=$user}{/link}" title="{$user->username}">{@$user->getAvatar()->getImageTag(48)}</a>
+						<a href="{link controller='User' object=$user}{/link}" title="{$user->username}" aria-hidden="true">{@$user->getAvatar()->getImageTag(48)}</a>
 						
 						<div class="details userInformation">
 							<div class="containerHeadline">
diff --git a/com.woltlab.wcf/templates/userListItem.tpl b/com.woltlab.wcf/templates/userListItem.tpl
index 15abe6e632..8f42dd8d6b 100644
--- a/com.woltlab.wcf/templates/userListItem.tpl
+++ b/com.woltlab.wcf/templates/userListItem.tpl
@@ -1,6 +1,6 @@
 <li data-object-id="{@$user->userID}">
 	<div class="box48">
-		<a href="{link controller='User' object=$user}{/link}" title="{$user->username}">{@$user->getAvatar()->getImageTag(48)}</a>
+		<a href="{link controller='User' object=$user}{/link}" title="{$user->username}" aria-hidden="true">{@$user->getAvatar()->getImageTag(48)}</a>
 		
 		<div class="details userInformation">
 			{include file='userInformation'}
diff --git a/com.woltlab.wcf/templates/userProfileLikeItem.tpl b/com.woltlab.wcf/templates/userProfileLikeItem.tpl
index e5d7bd6c56..37f666e605 100644
--- a/com.woltlab.wcf/templates/userProfileLikeItem.tpl
+++ b/com.woltlab.wcf/templates/userProfileLikeItem.tpl
@@ -1,7 +1,7 @@
 {foreach from=$likeList item=like}
 	<li>
 		<div class="box48">
-			<a href="{link controller='User' object=$like->getUserProfile()}{/link}" title="{$like->getUserProfile()->username}">{@$like->getUserProfile()->getAvatar()->getImageTag(48)}</a>
+			<a href="{link controller='User' object=$like->getUserProfile()}{/link}" title="{$like->getUserProfile()->username}" aria-hidden="true">{@$like->getUserProfile()->getAvatar()->getImageTag(48)}</a>
 			
 			<div>
 				<div class="containerHeadline">
diff --git a/com.woltlab.wcf/templates/usersOnlineList.tpl b/com.woltlab.wcf/templates/usersOnlineList.tpl
index 4d0931e84f..a2defa19da 100644
--- a/com.woltlab.wcf/templates/usersOnlineList.tpl
+++ b/com.woltlab.wcf/templates/usersOnlineList.tpl
@@ -109,7 +109,7 @@
 		{capture append=usersOnlineList}
 			<li>
 				<div class="box48">
-					<a href="{link controller='User' object=$user}{/link}" title="{$user->username}">{@$user->getAvatar()->getImageTag(48)}</a>
+					<a href="{link controller='User' object=$user}{/link}" title="{$user->username}" aria-hidden="true">{@$user->getAvatar()->getImageTag(48)}</a>
 					
 					<div class="details userInformation">
 						<div class="containerHeadline">
-- 
2.20.1