From 3154de71258a32040214fda174e67b975b0810ef Mon Sep 17 00:00:00 2001 From: Dan Streetman Date: Tue, 2 Jun 2015 15:22:10 -0400 Subject: [PATCH] crypto: nx - fix nx-842 pSeries driver minimum buffer size Reduce the nx-842 pSeries driver minimum buffer size from 128 to 8. Also replace the single use of IO_BUFFER_ALIGN macro with the standard and correct DDE_BUFFER_ALIGN. The hw sometimes rejects buffers that contain padding past the end of the 8-byte aligned section where it sees the "end" marker. With the minimum buffer size set too high, some highly compressed buffers were being padded and the hw was incorrectly rejecting them; this sets the minimum correctly so there will be no incorrect padding. Signed-off-by: Dan Streetman Signed-off-by: Herbert Xu --- drivers/crypto/nx/nx-842-pseries.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/nx/nx-842-pseries.c b/drivers/crypto/nx/nx-842-pseries.c index 17f191777139..41bc551ccaf3 100644 --- a/drivers/crypto/nx/nx-842-pseries.c +++ b/drivers/crypto/nx/nx-842-pseries.c @@ -30,13 +30,10 @@ MODULE_LICENSE("GPL"); MODULE_AUTHOR("Robert Jennings "); MODULE_DESCRIPTION("842 H/W Compression driver for IBM Power processors"); -/* IO buffer must be 128 byte aligned */ -#define IO_BUFFER_ALIGN 128 - static struct nx842_constraints nx842_pseries_constraints = { - .alignment = IO_BUFFER_ALIGN, + .alignment = DDE_BUFFER_ALIGN, .multiple = DDE_BUFFER_LAST_MULT, - .minimum = IO_BUFFER_ALIGN, + .minimum = DDE_BUFFER_LAST_MULT, .maximum = PAGE_SIZE, /* dynamic, max_sync_size */ }; -- 2.20.1