From 2d26aeb77357678e38c931c760d57bda084112ea Mon Sep 17 00:00:00 2001 From: David Kershner Date: Mon, 21 Nov 2016 12:15:46 -0500 Subject: [PATCH] staging: unisys: visorbus: controlvm_respond add error handling The function visorchanel_signalinsert now returns an error, propagate the error up the stack to be handled. Signed-off-by: David Kershner Reported-by: Greg Kroah-Hartman Signed-off-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorbus/visorchipset.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c index 331f6b1929b8..0c454f66beed 100644 --- a/drivers/staging/unisys/visorbus/visorchipset.c +++ b/drivers/staging/unisys/visorbus/visorchipset.c @@ -548,19 +548,17 @@ out_respond: return res; } -static void +static int controlvm_respond(struct controlvm_message_header *msg_hdr, int response) { struct controlvm_message outmsg; controlvm_init_response(&outmsg, msg_hdr, response); if (outmsg.hdr.flags.test_message == 1) - return; + return -EINVAL; - if (visorchannel_signalinsert(controlvm_channel, - CONTROLVM_QUEUE_REQUEST, &outmsg)) { - return; - } + return visorchannel_signalinsert(controlvm_channel, + CONTROLVM_QUEUE_REQUEST, &outmsg); } static void controlvm_respond_physdev_changestate( -- 2.20.1