From 2cc817c09e30e56da3a54e3183dc178927d5b5e2 Mon Sep 17 00:00:00 2001 From: Ana Rey Date: Wed, 19 Mar 2014 12:47:24 +0100 Subject: [PATCH] staging: rtl8192u: make in r819xU_firmware.c some local functions static Make some local functions static (firmware_init_param, fw_download_code, CPUcheck_maincodeok_turnonCPU and CPUcheck_firmware_ready) and fix coding style in these function declarations when It is necessary. Fixed the following sparse warnings in r819xU_firmware.c CHECK drivers/staging/rtl8192u/r819xU_firmware.c drivers/staging/rtl8192u/r819xU_firmware.c:20:6: warning: symbol 'firmware_init_param' was not declared. Should it be static? drivers/staging/rtl8192u/r819xU_firmware.c:32:6: warning: symbol 'fw_download_code' was not declared. Should it be static? drivers/staging/rtl8192u/r819xU_firmware.c:159:6: warning: symbol 'CPUcheck_maincodeok_turnonCPU' was not declared. Should it be static? drivers/staging/rtl8192u/r819xU_firmware.c:208:6: warning: symbol 'CPUcheck_firmware_ready' was not declared. Should it be static? Signed-off-by: Ana Rey Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8192u/r819xU_firmware.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c b/drivers/staging/rtl8192u/r819xU_firmware.c index d6a6de3a64f5..edb842cf2d9e 100644 --- a/drivers/staging/rtl8192u/r819xU_firmware.c +++ b/drivers/staging/rtl8192u/r819xU_firmware.c @@ -17,7 +17,8 @@ #include "r819xU_firmware_img.h" #include "r819xU_firmware.h" #include -void firmware_init_param(struct net_device *dev) + +static void firmware_init_param(struct net_device *dev) { struct r8192_priv *priv = ieee80211_priv(dev); rt_firmware *pfirmware = priv->pFirmware; @@ -29,7 +30,8 @@ void firmware_init_param(struct net_device *dev) * segment the img and use the ptr and length to remember info on each segment * */ -bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, u32 buffer_len) +static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, + u32 buffer_len) { struct r8192_priv *priv = ieee80211_priv(dev); bool rt_status = true; @@ -156,7 +158,7 @@ fwSendNullPacket( // NDIS_STATUS_FAILURE - the following initialization process should be terminated // NDIS_STATUS_SUCCESS - if firmware initialization process success //----------------------------------------------------------------------------- -bool CPUcheck_maincodeok_turnonCPU(struct net_device *dev) +static bool CPUcheck_maincodeok_turnonCPU(struct net_device *dev) { bool rt_status = true; int check_putcodeOK_time = 200000, check_bootOk_time = 200000; @@ -205,7 +207,7 @@ CPUCheckMainCodeOKAndTurnOnCPU_Fail: return rt_status; } -bool CPUcheck_firmware_ready(struct net_device *dev) +static bool CPUcheck_firmware_ready(struct net_device *dev) { bool rt_status = true; -- 2.20.1