From 28ab4fee0a600a7e7458fe3a6e702ed8ac94f002 Mon Sep 17 00:00:00 2001 From: Marcel Werk Date: Sun, 31 Oct 2021 18:26:19 +0100 Subject: [PATCH] Improve error handling in GDImageAdapter::loadFile() Closes #4413 --- .../files/lib/system/image/adapter/GDImageAdapter.class.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/wcfsetup/install/files/lib/system/image/adapter/GDImageAdapter.class.php b/wcfsetup/install/files/lib/system/image/adapter/GDImageAdapter.class.php index 6e654a8aaa..b53bebbaf6 100644 --- a/wcfsetup/install/files/lib/system/image/adapter/GDImageAdapter.class.php +++ b/wcfsetup/install/files/lib/system/image/adapter/GDImageAdapter.class.php @@ -99,7 +99,11 @@ class GDImageAdapter implements IImageAdapter, IWebpImageAdapter switch ($this->type) { case \IMAGETYPE_GIF: - $this->image = \imagecreatefromgif($file); + // suppress warnings and properly handle errors + $this->image = @\imagecreatefromgif($file); + if ($this->image === false) { + throw new SystemException("Could not read gif image '" . $file . "'."); + } break; case \IMAGETYPE_JPEG: -- 2.20.1