From 25ad998892c05cf1a3f14ac882af8edbb8f62cc8 Mon Sep 17 00:00:00 2001 From: H Hartley Sweeten Date: Thu, 5 Dec 2013 16:54:11 -0700 Subject: [PATCH] staging: comedi: pcmuio: document the spinlock_t variables Add some comments about the two spinlock_t variables in the private data. Also, add come comments for the functions that do not need to lock/unlock the spinlock. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmuio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/pcmuio.c b/drivers/staging/comedi/drivers/pcmuio.c index 6ee876d9905a..c83f5bd686cc 100644 --- a/drivers/staging/comedi/drivers/pcmuio.c +++ b/drivers/staging/comedi/drivers/pcmuio.c @@ -128,8 +128,8 @@ static const struct pcmuio_board pcmuio_boards[] = { }; struct pcmuio_asic { - spinlock_t pagelock; - spinlock_t spinlock; + spinlock_t pagelock; /* protects the page registers */ + spinlock_t spinlock; /* protects member variables */ int enabled_mask; int active; int stop_count; @@ -295,6 +295,7 @@ static void pcmuio_reset(struct comedi_device *dev) } } +/* chip->spinlock is already locked */ static void pcmuio_stop_intr(struct comedi_device *dev, struct comedi_subdevice *s) { @@ -403,6 +404,7 @@ static irqreturn_t pcmuio_interrupt(int irq, void *d) return handled ? IRQ_HANDLED : IRQ_NONE; } +/* chip->spinlock is already locked */ static int pcmuio_start_intr(struct comedi_device *dev, struct comedi_subdevice *s) { -- 2.20.1