From 22322c474551c208625d3b95ffba39b1882fa645 Mon Sep 17 00:00:00 2001 From: Viresh Kumar Date: Thu, 13 Aug 2015 10:35:29 +0530 Subject: [PATCH] greybus: connection: Destroy wq on failure Need to destroy the wq created earlier, do it. Fixes: d0f1778a6b67 ("greybus/connection: add a timestamp kfifo to track connection handoff") Signed-off-by: Viresh Kumar Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/connection.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c index 27b64d6c8f2e..d0f499d509ba 100644 --- a/drivers/staging/greybus/connection.c +++ b/drivers/staging/greybus/connection.c @@ -252,7 +252,7 @@ gb_connection_create_range(struct greybus_host_device *hd, if (kfifo_alloc(&connection->ts_kfifo, GB_CONNECTION_TS_KFIFO_LEN, GFP_KERNEL)) - goto err_free_connection; + goto err_destroy_wq; connection->dev.parent = parent; connection->dev.bus = &greybus_bus_type; @@ -298,6 +298,8 @@ gb_connection_create_range(struct greybus_host_device *hd, err_free_kfifo: kfifo_free(&connection->ts_kfifo); +err_destroy_wq: + destroy_workqueue(connection->wq); err_free_connection: kfree(connection); err_remove_ida: -- 2.20.1