From 208c66f2fb3d9cd398386785aae116753a27e8c4 Mon Sep 17 00:00:00 2001 From: "Tobin C. Harding" Date: Thu, 27 Apr 2017 11:25:12 +1000 Subject: [PATCH] staging: ks7010: remove unnecessary address check Currently source and destination ethernet addresses are checked twice, once in hostif_data_indication() and then again in hostif_data_indication_wpa(). The second of these functions is called from the first right after the address check is done. This check is a duplicate and is unnecessary. Remove unnecessary duplicate address check. Signed-off-by: Tobin C. Harding Signed-off-by: Greg Kroah-Hartman --- drivers/staging/ks7010/ks_hostif.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index 7151f16e2f9c..2216409bcb3d 100644 --- a/drivers/staging/ks7010/ks_hostif.c +++ b/drivers/staging/ks7010/ks_hostif.c @@ -326,10 +326,6 @@ int hostif_data_indication_wpa(struct ks_wlan_private *priv, eth_hdr = (struct ether_hdr *)(priv->rxp); eth_proto = ntohs(eth_hdr->h_proto); - /* source address check */ - if (memcmp(ð_hdr->h_source[0], &priv->eth_addr[0], ETH_ALEN) == 0) - return 0; - if (eth_hdr->h_dest_snap != eth_hdr->h_source_snap) { DPRINTK(1, "invalid data format\n"); priv->nstats.rx_errors++; -- 2.20.1