From 1c3dcd1cf66d078bc273275c754000ba0d397ac0 Mon Sep 17 00:00:00 2001 From: Ben Widawsky Date: Thu, 12 Sep 2013 22:28:28 -0700 Subject: [PATCH] drm/i915: Round l3 parity reads down MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit We always read a register for l3 parity reads, and we don't really want to ever let userspace trick us into giving back less than the dword. Writes are okay because we assume everything will be 0 filled, and as such, if a user really wants to write less than a dword, let them. Signed-off-by: Ben Widawsky Reviewed-by: Ville Syrjälä Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_sysfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_sysfs.c b/drivers/gpu/drm/i915/i915_sysfs.c index c8c4112de110..9070f503d332 100644 --- a/drivers/gpu/drm/i915/i915_sysfs.c +++ b/drivers/gpu/drm/i915/i915_sysfs.c @@ -121,6 +121,8 @@ i915_l3_read(struct file *filp, struct kobject *kobj, uint32_t misccpctl; int i, ret; + count = round_down(count, 4); + ret = l3_access_valid(drm_dev, offset); if (ret) return ret; -- 2.20.1