From 1bdf45352e1897ab02632a4ed3648db8cc183f71 Mon Sep 17 00:00:00 2001 From: Abhi Das Date: Mon, 8 Jun 2015 11:20:50 -0500 Subject: [PATCH] gfs2: s64 cast for negative quota value One-line fix to cast quota value to s64 before comparison. By default the quantity is treated as u64. Signed-off-by: Abhi Das Signed-off-by: Bob Peterson Acked-by: Steven Whitehouse --- fs/gfs2/quota.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index dcd598aa2691..c2607a26be89 100644 --- a/fs/gfs2/quota.c +++ b/fs/gfs2/quota.c @@ -798,7 +798,7 @@ static int gfs2_adjust_quota(struct gfs2_inode *ip, loff_t loc, loc -= sizeof(q); /* gfs2_internal_read would've advanced the loc ptr */ err = -EIO; be64_add_cpu(&q.qu_value, change); - if (be64_to_cpu(q.qu_value) < 0) + if (((s64)be64_to_cpu(q.qu_value)) < 0) q.qu_value = 0; /* Never go negative on quota usage */ qd->qd_qb.qb_value = q.qu_value; if (fdq) { -- 2.20.1