From 1407edcb8454b2c21fffc3952958f2d337aed921 Mon Sep 17 00:00:00 2001
From: Alexander Ebert <ebert@woltlab.com>
Date: Thu, 26 Oct 2017 19:45:27 +0200
Subject: [PATCH] Improved image paste support in Safari on macOS

---
 .../redactor2/plugins/WoltLabPaste.js         | 79 ++++++++++++-------
 1 file changed, 52 insertions(+), 27 deletions(-)

diff --git a/wcfsetup/install/files/js/3rdParty/redactor2/plugins/WoltLabPaste.js b/wcfsetup/install/files/js/3rdParty/redactor2/plugins/WoltLabPaste.js
index 66056bd087..ccd68afde9 100644
--- a/wcfsetup/install/files/js/3rdParty/redactor2/plugins/WoltLabPaste.js
+++ b/wcfsetup/install/files/js/3rdParty/redactor2/plugins/WoltLabPaste.js
@@ -143,7 +143,7 @@ $.Redactor.prototype.WoltLabPaste = function() {
 			this.paste.detectClipboardUpload = (function (e) {
 				e = e.originalEvent || e;
 				
-				var file;
+				var file = null;
 				if (isIe) {
 					if (!window.clipboardData.files.length) {
 						return false;
@@ -157,45 +157,70 @@ $.Redactor.prototype.WoltLabPaste = function() {
 				else {
 					var clipboard = e.clipboardData;
 					
-					// prevent safari fake url
+					// Safari
 					var types = clipboard.types;
 					if (Array.isArray(types) && types.indexOf('public.tiff') !== -1) {
-						e.preventDefault();
-						return false;
-					}
-					
-					if (!clipboard.items || !clipboard.items.length) {
-						return;
-					}
-					
-					if (this.detect.isWebkit()) {
-						var item, hasFile = false, hasHtml = false;
-						for (var i = 0, length = clipboard.items.length; i < length; i++) {
-							item = clipboard.items[i];
-							if (item.kind === 'string' && item.type === 'text/html') hasHtml = true;
-							else if (item.kind === 'file') hasFile = true;
+						if (clipboard.files.length === 0) {
+							// pasted an `<img>` element from clipboard
+							return;
 						}
-						
-						// pasted an `<img>` element from clipboard
-						if (hasFile && hasHtml) {
+						else if (clipboard.files.length === 1) {
+							// This may not work if the file was copied from Finder for whatever
+							// reasons and it is not possible to try/catch this error (wow!).
+							// 
+							// It does not have any side-effects when failing other than canceling
+							// out the `paste` event, which is pretty much what we're looking for
+							// anyway. It does work from certain apps, but Safari exposes too little
+							// information to tell them apart, so we just have to try it.
+							// 
+							// See https://bugs.webkit.org/show_bug.cgi?id=171504
+							file = clipboard.files[0];
+							cancelPaste = true;
+							
+							if (file !== null) {
+								e.preventDefault();
+							}
+						}
+						else {
+							e.preventDefault();
 							return false;
 						}
 					}
 					
-					var cancelPaste = false;
-					file = clipboard.items[0].getAsFile();
 					if (file === null) {
-						if (this.detect.isWebkit() && clipboard.items.length > 1) {
-							file = clipboard.items[1].getAsFile();
-							cancelPaste = true;
+						if (!clipboard.items || !clipboard.items.length) {
+							return;
+						}
+						
+						if (this.detect.isWebkit()) {
+							var item, hasFile = false, hasHtml = false;
+							for (var i = 0, length = clipboard.items.length; i < length; i++) {
+								item = clipboard.items[i];
+								if (item.kind === 'string' && item.type === 'text/html') hasHtml = true;
+								else if (item.kind === 'file') hasFile = true;
+							}
 							
-							if (file !== null) {
-								e.preventDefault();
+							// pasted an `<img>` element from clipboard
+							if (hasFile && hasHtml) {
+								return false;
 							}
 						}
 						
+						var cancelPaste = false;
+						file = clipboard.items[0].getAsFile();
 						if (file === null) {
-							return false;
+							if (this.detect.isWebkit() && clipboard.items.length > 1) {
+								file = clipboard.items[1].getAsFile();
+								cancelPaste = true;
+								
+								if (file !== null) {
+									e.preventDefault();
+								}
+							}
+							
+							if (file === null) {
+								return false;
+							}
 						}
 					}
 				}
-- 
2.20.1