From 0d89f94afb76cbaf6b1d81abc357c1c35eeb5949 Mon Sep 17 00:00:00 2001 From: David Binder Date: Mon, 17 Jul 2017 16:16:48 -0400 Subject: [PATCH] staging: unisys: visorhba: viosrhba_main.c: Remove unnecessary checks Removes unnecessary checks for a NULL pointer in a non-API function. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: David Binder Signed-off-by: Greg Kroah-Hartman --- drivers/staging/unisys/visorhba/visorhba_main.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers/staging/unisys/visorhba/visorhba_main.c index 17468bfd8863..1b4b338aa582 100644 --- a/drivers/staging/unisys/visorhba/visorhba_main.c +++ b/drivers/staging/unisys/visorhba/visorhba_main.c @@ -141,9 +141,6 @@ static struct task_struct *visor_thread_start */ static void visor_thread_stop(struct task_struct *task) { - /* no thread running */ - if (!task) - return; kthread_stop(task); } @@ -829,7 +826,7 @@ do_scsi_linuxstat(struct uiscmdrsp *cmdrsp, struct scsi_cmnd *scsicmd) static int set_no_disk_inquiry_result(unsigned char *buf, size_t len, bool is_lun0) { - if (!buf || len < NO_DISK_INQUIRY_RESULT_LEN) + if (len < NO_DISK_INQUIRY_RESULT_LEN) return -EINVAL; memset(buf, 0, NO_DISK_INQUIRY_RESULT_LEN); buf[2] = SCSI_SPC2_VER; -- 2.20.1