From 0a4c9ffbd47669d1a0534dbbd45c2855531a6e7d Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Thu, 24 Nov 2016 14:35:45 +0300 Subject: [PATCH] drm/hisilicon/hibmc: Checking for NULL instead of IS_ERR() The drm_dev_alloc() function returns error pointers. It never returns NULLs. Fixes: 5e0df3a08f3d ("drm/hisilicon/hibmc: Add hisilicon hibmc drm master driver") Signed-off-by: Dan Carpenter Signed-off-by: Daniel Vetter Link: http://patchwork.freedesktop.org/patch/msgid/20161124113545.GP17225@mwanda --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c index 73ba8b05f1da..d94e3495c9b2 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c @@ -377,9 +377,9 @@ static int hibmc_pci_probe(struct pci_dev *pdev, int ret; dev = drm_dev_alloc(&hibmc_driver, &pdev->dev); - if (!dev) { + if (IS_ERR(dev)) { DRM_ERROR("failed to allocate drm_device\n"); - return -ENOMEM; + return PTR_ERR(dev); } dev->pdev = pdev; -- 2.20.1