From 081df946c619ce1ccfd8009f7ea38b9ec5f8d05b Mon Sep 17 00:00:00 2001 From: Alexander Ebert Date: Thu, 19 Nov 2020 16:56:12 +0100 Subject: [PATCH] Skip DOM updates when the article is not present --- .../Core/Acp/Ui/Article/InlineEditor.js | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/Article/InlineEditor.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/Article/InlineEditor.js index 0c2a10d855..dcbfd07372 100644 --- a/wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/Article/InlineEditor.js +++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/Article/InlineEditor.js @@ -254,6 +254,10 @@ define(['Ajax', 'Core', 'Dictionary', 'Dom/Util', 'EventHandler', 'Language', 'U */ _triggerDelete: function(articleId) { var article = _articles.get(articleId); + if (!article) { + // The affected article might be hidden by the filter settings. + return; + } if (article.isArticleEdit) { window.location = this._options.redirectUrl; @@ -275,6 +279,10 @@ define(['Ajax', 'Core', 'Dictionary', 'Dom/Util', 'EventHandler', 'Language', 'U */ _triggerPublish: function(articleId) { var article = _articles.get(articleId); + if (!article) { + // The affected article might be hidden by the filter settings. + return; + } if (article.isArticleEdit) { // unsupported @@ -291,6 +299,10 @@ define(['Ajax', 'Core', 'Dictionary', 'Dom/Util', 'EventHandler', 'Language', 'U */ _triggerRestore: function(articleId) { var article = _articles.get(articleId); + if (!article) { + // The affected article might be hidden by the filter settings. + return; + } elHide(article.buttons.delete); elHide(article.buttons.restore); @@ -311,6 +323,10 @@ define(['Ajax', 'Core', 'Dictionary', 'Dom/Util', 'EventHandler', 'Language', 'U */ _triggerTrash: function(articleId) { var article = _articles.get(articleId); + if (!article) { + // The affected article might be hidden by the filter settings. + return; + } elShow(article.buttons.delete); elShow(article.buttons.restore); @@ -336,6 +352,10 @@ define(['Ajax', 'Core', 'Dictionary', 'Dom/Util', 'EventHandler', 'Language', 'U */ _triggerUnpublish: function(articleId) { var article = _articles.get(articleId); + if (!article) { + // The affected article might be hidden by the filter settings. + return; + } if (article.isArticleEdit) { // unsupported -- 2.20.1