From 07783f39e1433574cff20ca774684c3921162b59 Mon Sep 17 00:00:00 2001 From: Stefan Assmann Date: Thu, 4 Apr 2013 06:57:08 +0000 Subject: [PATCH] enic: be less verbose about non-critical firmware errors If a feature is not supported by firmware no need to print an error message. This surpresses the following harmless message on boot up and ethtool query. enic: Error 1 devcmd 36 Signed-off-by: Stefan Assmann Signed-off-by: David S. Miller --- drivers/net/ethernet/cisco/enic/vnic_dev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/cisco/enic/vnic_dev.c b/drivers/net/ethernet/cisco/enic/vnic_dev.c index 605b22283be..97455c573db 100644 --- a/drivers/net/ethernet/cisco/enic/vnic_dev.c +++ b/drivers/net/ethernet/cisco/enic/vnic_dev.c @@ -308,6 +308,9 @@ static int _vnic_dev_cmd(struct vnic_dev *vdev, enum vnic_devcmd_cmd cmd, if (status & STAT_ERROR) { err = (int)readq(&devcmd->args[0]); + if (err == ERR_EINVAL && + cmd == CMD_CAPABILITY) + return err; if (err != ERR_ECMDUNKNOWN || cmd != CMD_CAPABILITY) pr_err("Error %d devcmd %d\n", -- 2.20.1