From 04cef49e84d4e2ddf739cd92f98e938cbab347a5 Mon Sep 17 00:00:00 2001 From: Cong Ding Date: Thu, 17 Jan 2013 03:28:43 +0000 Subject: [PATCH] sparc: kernel/sbus.c: fix memory leakage The variable iommu and strbuf are not freed properly if it goes to error. Signed-off-by: Cong Ding Reviewed-by: Richard Mortimer Signed-off-by: David S. Miller --- arch/sparc/kernel/sbus.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/sparc/kernel/sbus.c b/arch/sparc/kernel/sbus.c index 1271b3a27d4e..be5bdf93c767 100644 --- a/arch/sparc/kernel/sbus.c +++ b/arch/sparc/kernel/sbus.c @@ -554,10 +554,8 @@ static void __init sbus_iommu_init(struct platform_device *op) regs = pr->phys_addr; iommu = kzalloc(sizeof(*iommu), GFP_ATOMIC); - if (!iommu) - goto fatal_memory_error; strbuf = kzalloc(sizeof(*strbuf), GFP_ATOMIC); - if (!strbuf) + if (!iommu || !strbuf) goto fatal_memory_error; op->dev.archdata.iommu = iommu; @@ -656,6 +654,8 @@ static void __init sbus_iommu_init(struct platform_device *op) return; fatal_memory_error: + kfree(iommu); + kfree(strbuf); prom_printf("sbus_iommu_init: Fatal memory allocation error.\n"); } -- 2.20.1