From 0109808145180d0ed3da05361f80839e6c80caeb Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Fri, 19 May 2017 18:56:17 +0100 Subject: [PATCH] drm/i915: Check for allocation failure The memory allocation for C is not being null checked and hence we could end up with a null pointer dereference. Fix this with a null pointer check. (I really should have noticed this when I was fixing an earlier issue.) Detected by CoverityScan, CID#1436406 ("Dereference null return") Fixes: 47624cc3301b60 ("drm/i915: Import the kfence selftests for i915_sw_fence") Signed-off-by: Colin Ian King Link: http://patchwork.freedesktop.org/patch/msgid/20170519175617.7036-1-colin.king@canonical.com Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/i915_sw_fence.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/selftests/i915_sw_fence.c b/drivers/gpu/drm/i915/selftests/i915_sw_fence.c index c31d439fae3a..19d145d6bf52 100644 --- a/drivers/gpu/drm/i915/selftests/i915_sw_fence.c +++ b/drivers/gpu/drm/i915/selftests/i915_sw_fence.c @@ -123,6 +123,11 @@ static int test_dag(void *arg) } C = alloc_fence(); + if (!C) { + ret = -ENOMEM; + goto err_B; + } + if (i915_sw_fence_await_sw_fence_gfp(B, C, GFP_KERNEL) == -EINVAL) { pr_err("invalid cycle detected\n"); goto err_C; -- 2.20.1