From 987c7f2f57771a511e6bea4b872a4699418e2ec1 Mon Sep 17 00:00:00 2001
From: Matthias Schmidt <gravatronics@live.com>
Date: Sat, 27 Oct 2018 17:33:47 +0200
Subject: [PATCH] Add missing `page` for ad locations in object type PIP GUI

See #2545
---
 ...ectTypePackageInstallationPlugin.class.php | 28 +++++++++++++++++++
 wcfsetup/install/lang/en.xml                  |  2 ++
 2 files changed, 30 insertions(+)

diff --git a/wcfsetup/install/files/lib/system/package/plugin/ObjectTypePackageInstallationPlugin.class.php b/wcfsetup/install/files/lib/system/package/plugin/ObjectTypePackageInstallationPlugin.class.php
index debb0b571e..fb49904f7e 100644
--- a/wcfsetup/install/files/lib/system/package/plugin/ObjectTypePackageInstallationPlugin.class.php
+++ b/wcfsetup/install/files/lib/system/package/plugin/ObjectTypePackageInstallationPlugin.class.php
@@ -4,6 +4,8 @@ use wcf\data\object\type\definition\ObjectTypeDefinitionList;
 use wcf\data\object\type\ObjectTypeCache;
 use wcf\data\object\type\ObjectTypeEditor;
 use wcf\data\DatabaseObjectList;
+use wcf\data\page\PageNode;
+use wcf\data\page\PageNodeTree;
 use wcf\system\application\ApplicationHandler;
 use wcf\system\condition\AbstractIntegerCondition;
 use wcf\system\condition\UserGroupCondition;
@@ -305,6 +307,32 @@ class ObjectTypePackageInstallationPlugin extends AbstractXMLPackageInstallation
 		// com.woltlab.wcf.adLocation
 		$this->getObjectTypeDefinitionDataContainer($form, 'com.woltlab.wcf.adLocation')
 			->appendChildren([
+				SingleSelectionFormField::create('adLocationPage')
+					->objectProperty('page')
+					->label('wcf.acp.pip.objectType.com.woltlab.wcf.adLocation.page')
+					->description('wcf.acp.pip.objectType.com.woltlab.wcf.adLocation.page.description')
+					->options(function() {
+						$options = [
+							[
+								'depth' => 0,
+								'label' => 'wcf.global.noSelection',
+								'value' => ''
+							]
+						];
+						
+						$pageNodeTree = new PageNodeTree();
+						
+						/** @var PageNode $pageNode */
+						foreach ($pageNodeTree->getNodeList() as $pageNode) {
+							$options[] = [
+								'depth' => $pageNode->getDepth() - 1,
+								'label' => $pageNode->name,
+								'value' => $pageNode->identifier
+							];
+						}
+						
+						return $options;
+					}, true),
 				TextFormField::create('adLocationCategoryName')
 					->objectProperty('categoryname')
 					->label('wcf.acp.pip.objectType.com.woltlab.wcf.adLocation.categoryName')
diff --git a/wcfsetup/install/lang/en.xml b/wcfsetup/install/lang/en.xml
index 8a46330609..da84969f4c 100644
--- a/wcfsetup/install/lang/en.xml
+++ b/wcfsetup/install/lang/en.xml
@@ -1756,6 +1756,8 @@ If you have <strong>already bought the licenses for the listed apps</strong>, th
 		<item name="wcf.acp.pip.objectType.com.woltlab.wcf.adLocation.cssClassName"><![CDATA[CSS Classes]]></item>
 		<item name="wcf.acp.pip.objectType.com.woltlab.wcf.adLocation.cssClassName.description"><![CDATA[The entered comma-separated CSS classes are assigned to the element that wraps all ads at the specific location. ]]></item>
 		<item name="wcf.acp.pip.objectType.com.woltlab.wcf.adLocation.cssClassName.error.invalid"><![CDATA[The following CSS classes are invalid: {implode from=$invalidClasses item=invalidClass}<code>{$invalidClass}</code>{/implode}.]]></item>
+		<item name="wcf.acp.pip.objectType.com.woltlab.wcf.adLocation.page"><![CDATA[Page]]></item>
+		<item name="wcf.acp.pip.objectType.com.woltlab.wcf.adLocation.page.description"><![CDATA[Page on which the ad location is positioned.]]></item>
 		<item name="wcf.acp.pip.objectType.com.woltlab.wcf.attachment.objectType.data.title"><![CDATA[Attachment Type Data]]></item>
 		<item name="wcf.acp.pip.objectType.com.woltlab.wcf.attachment.objectType.private"><![CDATA[Attachments are Private]]></item>
 		<item name="wcf.acp.pip.objectType.com.woltlab.wcf.attachment.objectType.private.description"><![CDATA[Private attachments are ignored by the attachment management in the ACP.]]></item>
-- 
2.20.1