[media] rainshadow-cec: avoid -Wmaybe-uninitialized warning
authorArnd Bergmann <arnd@arndb.de>
Fri, 21 Apr 2017 10:51:21 +0000 (07:51 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Thu, 18 May 2017 10:28:38 +0000 (07:28 -0300)
commitea6a69defd3311014d8a0ea89245410593c8d00c
treee366ccb402428c2a654fb0789d17fcc52b28434d
parent5c621744b4270976f2dba71c49d92883afaf1604
[media] rainshadow-cec: avoid -Wmaybe-uninitialized warning

The barrier implied by spin_unlock() in rain_irq_work_handler makes it hard
for gcc to figure out the state of the variables, leading to a false-positive
warning:

drivers/media/usb/rainshadow-cec/rainshadow-cec.c: In function 'rain_irq_work_handler':
drivers/media/usb/rainshadow-cec/rainshadow-cec.c:171:31: error: 'data' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Slightly rearranging the code makes it easier for the compiler to see that the
code is correct, and gets rid of the warning.

Fixes: 0f314f6c2e77 ("[media] rainshadow-cec: new RainShadow Tech HDMI CEC driver")

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/usb/rainshadow-cec/rainshadow-cec.c