Add whitespace before condition in UserSearchForm
authorTim Düsterhus <duesterhus@woltlab.com>
Mon, 15 Mar 2021 11:16:06 +0000 (12:16 +0100)
committerTim Düsterhus <duesterhus@woltlab.com>
Mon, 15 Mar 2021 11:16:06 +0000 (12:16 +0100)
commitdec19b25cdf21b81d73c5897cd3c885d5ec62ef4
tree34a6e769186389e16fa1ee4fc2471cd706c3c0cc
parent7355935cdef66bf48805cc22f18c87ff123f6bc2
Add whitespace before condition in UserSearchForm

Currently a query like the following is generated:

    SELECT user_table.userID
    FROM wcf1_user user_table
    LEFT JOIN wcf1_user_option_value option_value
    ON (option_value.userID = user_table.userID)WHERE option_value.userOption4 = ?

This works due to the parentheses around the `ON` part of the `JOIN`, but it
certainly is not pretty and it will cause issues if the parentheses are removed
(as it happened for WoltLab Suite 5.4).

Insert a newline between the base query and the condition to fix the issue.

Resolves #4078

Co-Authored-By: mutec <mysterycode@mysterycode.de>
wcfsetup/install/files/lib/form/UserSearchForm.class.php