ACPI / battery: Fix warning message in acpi_battery_get_state()
authorMariusz Ceier <mceier+kernel@gmail.com>
Sat, 9 Aug 2014 09:43:31 +0000 (11:43 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Sun, 10 Aug 2014 14:19:31 +0000 (16:19 +0200)
commitd719870b41e00baf64d028c2668ae1fc3eb50e79
tree6f49962a2622fbdd72c25c0782011d43570d3856
parent3a54a57dceed78f7f3c35991d6d4a064a0c2e343
ACPI / battery: Fix warning message in acpi_battery_get_state()

capacity_now should be assigned after comparing it to design_capacity.

Otherwise warning is printed even when capacity_now before assignment is
equal to design_capacity, making the check useless and "current charge level"
wrong (it should be higher than, not equal to, "maximum charge level", which
is full_charge_capacity):

"battery: reported current charge level (56410) is higher than reported
maximum charge level (56410)."

Fixes: 232de5143790 (ACPI / battery: fix wrong value of capacity_now reported when fully charged)
Signed-off-by: Mariusz Ceier <mceier+kernel@gmail.com>
Cc: 3.16+ <stable@vger.kernel.org> # 3.16+
[rjw: Subject]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/battery.c