xfs: fix Q_XQUOTARM ioctl
authorEric Sandeen <sandeen@sandeen.net>
Mon, 5 May 2014 07:25:50 +0000 (17:25 +1000)
committerDave Chinner <david@fromorbit.com>
Mon, 5 May 2014 07:25:50 +0000 (17:25 +1000)
commit9da93f9b7cdf8ab28da6b364cdc1fafc8670b4dc
treea0315376046dce4cfcfd498af5617e4088c8e86c
parentc9eaa447e77efe77b7fa4c953bd62de8297fd6c5
xfs: fix Q_XQUOTARM ioctl

The Q_XQUOTARM quotactl was not working properly, because
we weren't passing around proper flags.  The xfs_fs_set_xstate()
ioctl handler used the same flags for Q_XQUOTAON/OFF as
well as for Q_XQUOTARM, but Q_XQUOTAON/OFF look for
XFS_UQUOTA_ACCT, XFS_UQUOTA_ENFD, XFS_GQUOTA_ACCT etc,
i.e. quota type + state, while Q_XQUOTARM looks only for
the type of quota, i.e. XFS_DQ_USER, XFS_DQ_GROUP etc.

Unfortunately these flag spaces overlap a bit, so we
got semi-random results for Q_XQUOTARM; i.e. the value
for XFS_DQ_USER == XFS_UQUOTA_ACCT, etc.  yeargh.

Add a new quotactl op vector specifically for the QUOTARM
operation, since it operates with a different flag space.

This has been broken more or less forever, AFAICT.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Acked-by: Jan Kara <jack@suse.cz>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/quota/quota.c
fs/xfs/xfs_quotaops.c
include/linux/quota.h