USB: serial: digi_acceleport: fix OOB data sanity check
authorJohan Hovold <johan@kernel.org>
Tue, 31 Jan 2017 16:17:27 +0000 (17:17 +0100)
committerJohan Hovold <johan@kernel.org>
Tue, 31 Jan 2017 17:32:21 +0000 (18:32 +0100)
commit2d380889215fe20b8523345649dee0579821800c
tree1b4eacc7201b00fa36aa35d1e335c97315fdf043
parent6fdb7b0c0e6412a351deb1eaab0e5eb9635d6086
USB: serial: digi_acceleport: fix OOB data sanity check

Make sure to check for short transfers to avoid underflow in a loop
condition when parsing the receive buffer.

Also fix an off-by-one error in the incomplete sanity check which could
lead to invalid data being parsed.

Fixes: 8c209e6782ca ("USB: make actual_length in struct urb field u32")
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable <stable@vger.kernel.org> # v2.6.30
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/digi_acceleport.c