drm/vc4: Fix VBLANK handling in crtc->enable() path
authorBoris Brezillon <boris.brezillon@free-electrons.com>
Thu, 22 Jun 2017 20:25:26 +0000 (22:25 +0200)
committerEric Anholt <eric@anholt.net>
Fri, 14 Jul 2017 20:19:48 +0000 (13:19 -0700)
commit1ed134e6526b1b513a14fba938f6d96aa1c7f3dd
treed57d2e7a6373cf7d9536d30f7b65c84dc462733f
parent6f6e0b217a93011f8e11b9a2d5521a08fcf36990
drm/vc4: Fix VBLANK handling in crtc->enable() path

When we are enabling a CRTC, drm_crtc_vblank_get() is called before
drm_crtc_vblank_on(), which is not supposed to happen (hence the
WARN_ON() in the code). To solve the problem, we delay the 'update
display list' operation after the CRTC is actually enabled.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Link: http://patchwork.freedesktop.org/patch/msgid/1498163126-26678-1-git-send-email-boris.brezillon@free-electrons.com
Fixes: 34c8ea400ff6 ("drm/vc4: Mimic drm_atomic_helper_commit() behavior")
drivers/gpu/drm/vc4/vc4_crtc.c