target: Drop iSCSI use of mutex around max_cmd_sn increment
authorRoland Dreier <roland@purestorage.com>
Thu, 23 Jul 2015 21:53:32 +0000 (14:53 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Mon, 3 Aug 2015 06:11:52 +0000 (23:11 -0700)
commit109e2381749c1cfd94a0d22b2b54142539024973
tree9695ecd3738a7bad43edcca4eb641339e7a30060
parent24c7d6c7316c72301bf8ecfc1189fd476176fd75
target: Drop iSCSI use of mutex around max_cmd_sn increment

In a performance profile, taking a mutex in iscsit_increment_maxcmdsn()
shows up very high.  However taking a mutex around "sess->max_cmd_sn += 1"
seems pretty silly: we're not serializing against other contexts in
any useful way.

I did a quick audit and there don't appear to be any other places that
use max_cmd_sn within the mutex more than once, so this lock can't be
providing any useful serialization.

(Get correct values for logging - fix whitespace damage)

Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Spencer Baugh <sbaugh@catern.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/iscsi/iscsi_target.c
drivers/target/iscsi/iscsi_target_configfs.c
drivers/target/iscsi/iscsi_target_device.c
drivers/target/iscsi/iscsi_target_login.c
drivers/target/iscsi/iscsi_target_nego.c
drivers/target/iscsi/iscsi_target_tmr.c
drivers/target/iscsi/iscsi_target_util.c
include/target/iscsi/iscsi_target_core.h