sched/deadline: Fix stale yield state
authorPeter Zijlstra <peterz@infradead.org>
Wed, 26 Nov 2014 00:44:03 +0000 (08:44 +0800)
committerIngo Molnar <mingo@kernel.org>
Wed, 4 Feb 2015 06:52:26 +0000 (07:52 +0100)
commit1019a359d3dc4b64d0e1e5a5efcb725d5e83994d
treee3ea8601967f078e09dc436670cf8dfcd903311d
parenta7bebf488791aa1036f3e6629daf01d01f705dcb
sched/deadline: Fix stale yield state

When we fail to start the deadline timer in update_curr_dl(), we
forget to clear ->dl_yielded, resulting in wrecked time keeping.

Since the natural place to clear both ->dl_yielded and ->dl_throttled
is in replenish_dl_entity(); both are after all waiting for that event;
make it so.

Luckily since 67dfa1b756f2 ("sched/deadline: Implement
cancel_dl_timer() to use in switched_from_dl()") the
task_on_rq_queued() condition in dl_task_timer() must be true, and can
therefore call enqueue_task_dl() unconditionally.

Reported-by: Wanpeng Li <wanpeng.li@linux.intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Kirill Tkhai <ktkhai@parallels.com>
Cc: Juri Lelli <juri.lelli@arm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/1416962647-76792-4-git-send-email-wanpeng.li@linux.intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/deadline.c