Matthias Schmidt [Wed, 30 Jun 2021 11:48:45 +0000 (13:48 +0200)]
Use `.toString(16)` for `ColorUtil.rgbToHex()`
Matthias Schmidt [Wed, 30 Jun 2021 11:45:56 +0000 (13:45 +0200)]
Export color interfaces from `ColorUtil`
Tim Düsterhus [Wed, 23 Jun 2021 07:45:52 +0000 (09:45 +0200)]
Merge branch '5.4'
Tim Düsterhus [Wed, 23 Jun 2021 07:44:38 +0000 (09:44 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Wed, 23 Jun 2021 07:43:22 +0000 (09:43 +0200)]
Merge branch '5.2' into 5.3
Tim Düsterhus [Wed, 23 Jun 2021 07:42:23 +0000 (09:42 +0200)]
Merge branch '3.1' into 5.2
Tim Düsterhus [Wed, 23 Jun 2021 07:40:44 +0000 (09:40 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Wed, 23 Jun 2021 07:39:40 +0000 (09:39 +0200)]
Merge branch '5.2' into 5.3
Tim Düsterhus [Wed, 23 Jun 2021 07:39:21 +0000 (09:39 +0200)]
Fix typo in de.xml
Tim Düsterhus [Wed, 23 Jun 2021 07:37:13 +0000 (09:37 +0200)]
Use “Moderation” instead of “Moderatoren” in de.xml
Matthias Schmidt [Wed, 23 Jun 2021 07:34:14 +0000 (09:34 +0200)]
Merge branch '5.4'
Matthias Schmidt [Wed, 23 Jun 2021 07:33:25 +0000 (09:33 +0200)]
Update XSD paths in XML files generated by PHP code
See #4268
Matthias Schmidt [Wed, 23 Jun 2021 07:31:21 +0000 (09:31 +0200)]
Update XSD paths in XML files
See #4268
Matthias Schmidt [Tue, 22 Jun 2021 14:46:15 +0000 (16:46 +0200)]
Remove `ModerationQueueEditor::markAsDone` (#4317)
This method has been deprecated for many years since
35e19e581a5e61f13d37e536710604283b1f0ebf.
Matthias Schmidt [Tue, 22 Jun 2021 14:45:24 +0000 (16:45 +0200)]
Remove `UserGroupOptionForm::verifyPermissions()` (#4312)
This method has been deprecated for many years since
c1b907f345397a5604f8ceca8af257d61938639a.
Matthias Schmidt [Tue, 22 Jun 2021 14:44:37 +0000 (16:44 +0200)]
Remove `SearchKeywordManager` (#4313)
Since
8d04d7bd18a910393ebb2000f21babca260fde24, the action `upsert` does not exist anymore resulting in an exception when calling `SearchKeywordManager::add()`, illustrating that this class is unused in practice.
Matthias Schmidt [Tue, 22 Jun 2021 14:43:38 +0000 (16:43 +0200)]
Remove obsolete social media privacy settings-related methods (#4308)
These methods have had no effect for several years (since
527a8fc63908aa175c60b08b4d3ee368dbfdb274).
Matthias Schmidt [Tue, 22 Jun 2021 14:41:21 +0000 (16:41 +0200)]
Remove deprecated `PackageArchive::getPhpRequirements` (#4311)
This method has been deprecated for several years since
89a60e0e4942e48904999ec75cec782ba3fe03cf.
Matthias Schmidt [Tue, 22 Jun 2021 14:39:23 +0000 (16:39 +0200)]
Remove deprecated avatar-cropping related methods (#4310)
These methods are useless and have been deprecated for several years since
2772d4eb46511bc1cdc431bb80c184f8172dd500.
Marcel Werk [Tue, 22 Jun 2021 09:25:57 +0000 (11:25 +0200)]
Merge branch 'master' of https://github.com/WoltLab/WCF
Marcel Werk [Tue, 22 Jun 2021 09:25:54 +0000 (11:25 +0200)]
Missing CSS class
Tim Düsterhus [Tue, 22 Jun 2021 08:09:19 +0000 (10:09 +0200)]
Set `accept-encoding: gzip` for URL Unfurling requests
see #4218
Tim Düsterhus [Tue, 22 Jun 2021 07:12:06 +0000 (09:12 +0200)]
Merge pull request #4329 from WoltLab/sfs-gzip
Set `accept-encoding: gzip` for SFS list requests
Matthias Schmidt [Tue, 22 Jun 2021 05:39:41 +0000 (07:39 +0200)]
Remove `WCF.ACP.Style.ImageUpload` (#4323)
This component has been deprecated for many years since
59ab4d0f66ddd21bc800b49ebbedcd91e6ae0c5c and even the suggested replacement has already been removed since
40132f4b2e00dd7896d31247a40144bc85b11d28.
Matthias Schmidt [Mon, 21 Jun 2021 15:37:00 +0000 (17:37 +0200)]
Remove deprecated TagCloud-related constants and methods (#4325)
These constants and methods have been deprecated for several years since
3d21a963c9348a63ecafc11abbee8923efbcdcbc.
Matthias Schmidt [Mon, 21 Jun 2021 15:35:02 +0000 (17:35 +0200)]
Remove `WCF.Message.UserMention` (#4324)
This component has been deprecated for many years since
d3cbe17e57fb2111af02ca7e11d9c60dce3c6de7 and has only been throwing an error since then.
Alexander Ebert [Mon, 21 Jun 2021 14:47:42 +0000 (16:47 +0200)]
Embedded object ids are now explicitly casted to int
https://wiki.php.net/rfc/string_to_number_comparison changed the behavior of PHP when comparing strings to numbers.
`123 == "123foo"` is true in PHP <8.0, but false starting with PHP 8.0.
Alexander Ebert [Mon, 21 Jun 2021 14:39:57 +0000 (16:39 +0200)]
Revert "Cast values of simple embedded objects to int"
This reverts commit
2e3b2fcc855f50238dbe930ea3392cf48894b85f.
Tim Düsterhus [Mon, 21 Jun 2021 14:14:59 +0000 (16:14 +0200)]
Set `accept-encoding: gzip` for SFS list requests
see #4218
Alexander Ebert [Mon, 21 Jun 2021 14:13:38 +0000 (16:13 +0200)]
Cast values of simple embedded objects to int
These values are not guaranteed to be pure numbers. Any value could be followed by a helper comment, such as `13#Fancy page`. Explicitly calling `intval()` truncates the value to just contain the leading digits as it was intended to be.
Alexander Ebert [Mon, 21 Jun 2021 14:08:30 +0000 (16:08 +0200)]
Improved the regex for simple embedded objects
The previous version was borderline erroneous and while it worked so far, it could easily break in future versions of PHP.
Matthias Schmidt [Mon, 21 Jun 2021 08:20:51 +0000 (10:20 +0200)]
Add form field dependency for interval of values (#4328)
Tim Düsterhus [Mon, 21 Jun 2021 07:08:17 +0000 (09:08 +0200)]
Merge pull request #4322 from WoltLab/guzzle-sfs
Migrate the SFS list download to Guzzle
Matthias Schmidt [Mon, 21 Jun 2021 06:50:16 +0000 (08:50 +0200)]
Merge branch '5.4'
Matthias Schmidt [Mon, 21 Jun 2021 06:49:37 +0000 (08:49 +0200)]
Merge branch '5.3' into 5.4
Matthias Schmidt [Mon, 21 Jun 2021 06:48:22 +0000 (08:48 +0200)]
Reset link-related fields after creating box
Matthias Schmidt [Sun, 20 Jun 2021 11:38:00 +0000 (13:38 +0200)]
Remove `WCF.UserPanel` (#4316)
This component has been deprecated for many years since
611bfec845fba517504f186d7c97dc6c559f8f7d.
Matthias Schmidt [Sun, 20 Jun 2021 11:37:29 +0000 (13:37 +0200)]
Remove `BBCodeParser::validateBBCodes()` (#4319)
This method has been deprecated for many years since
25863cff5dcb31c893b073aedf678b778a14d9fa and has resulted in an exception since then.
Matthias Schmidt [Sun, 20 Jun 2021 11:36:59 +0000 (13:36 +0200)]
Remove `BBCodeHandler::setAllowedBBCodes()` (#4318)
This method has been deprecated for many years since
25863cff5dcb31c893b073aedf678b778a14d9fa and has resulted in an exception since then.
Tim Düsterhus [Fri, 18 Jun 2021 14:10:41 +0000 (16:10 +0200)]
Merge remote-tracking branch 'origin/master'
Tim Düsterhus [Fri, 18 Jun 2021 13:57:50 +0000 (15:57 +0200)]
Merge branch '5.4'
Tim Düsterhus [Fri, 18 Jun 2021 13:57:18 +0000 (15:57 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Fri, 18 Jun 2021 13:47:39 +0000 (15:47 +0200)]
Merge branch '5.2' into 5.3
Tim Düsterhus [Fri, 18 Jun 2021 13:47:18 +0000 (15:47 +0200)]
Merge branch '3.1' into 5.2
Tim Düsterhus [Fri, 18 Jun 2021 13:44:21 +0000 (15:44 +0200)]
Set 'accept-encoding: identity' by default in HTTPRequest
RFC 7231#5.3.4 allows a server to use an arbitrary 'content-encoding' when no
'accept-encoding' request header is sent.
Make it clear that no 'content-encoding' is acceptable by only accepting the
'identity' encoding.
Marcel Werk [Fri, 18 Jun 2021 13:31:33 +0000 (15:31 +0200)]
Merge pull request #4315 from WoltLab/content-interaction-buttons
Content interaction buttons
Tim Düsterhus [Fri, 18 Jun 2021 11:51:24 +0000 (13:51 +0200)]
Remove check for 'userID' cookie in RescueModeForm
Tim Düsterhus [Fri, 18 Jun 2021 10:34:48 +0000 (12:34 +0200)]
Use Guzzle to download a SFS delta file
see #4281
Tim Düsterhus [Fri, 18 Jun 2021 10:29:51 +0000 (12:29 +0200)]
Use Guzzle to download the SFS index
see #4281
Tim Düsterhus [Fri, 18 Jun 2021 09:44:45 +0000 (11:44 +0200)]
Merge branch '5.4'
Tim Düsterhus [Fri, 18 Jun 2021 09:37:24 +0000 (11:37 +0200)]
Revert "Ignore security token for guests"
Due to the age of this commit it's a bit unclear why exactly it was necessary
at that time, but records indicate that it was related to the URL based session
system (`?s=…`) in combination with with virtual sessions effectively changing
the session ID during login, the `SID` constants being constant and the CSRF
token being stored in the session.
As none of this applies any longer, this workaround should no longer be
necessary and thus reverted. It certainly violates the principle of least
astonishment, because it only applies to AbstractSecureAction, but not forms
and it's questionable from a security perspective.
This reverts commit
e5c2467f717632b47f935a0e59a310de2e2867f3.
Marcel Werk [Fri, 18 Jun 2021 09:11:38 +0000 (11:11 +0200)]
Handle active status of the subscribe button
Matthias Schmidt [Fri, 18 Jun 2021 07:09:17 +0000 (09:09 +0200)]
Merge pull request #4321 from WoltLab/media_noCategory_filter
Support filtering media lists for media with no category
Matthias Schmidt [Fri, 18 Jun 2021 06:29:54 +0000 (08:29 +0200)]
Support filtering media list in media manager for media with no category
Matthias Schmidt [Fri, 18 Jun 2021 06:29:29 +0000 (08:29 +0200)]
Support filtering media list in ACP for media with no category
Marcel Werk [Thu, 17 Jun 2021 16:43:28 +0000 (18:43 +0200)]
Merge branch 'master' into content-interaction-buttons
Marcel Werk [Thu, 17 Jun 2021 16:41:59 +0000 (18:41 +0200)]
Implemented content interaction buttons
Tim Düsterhus [Thu, 17 Jun 2021 15:16:10 +0000 (17:16 +0200)]
Merge branch '5.4'
Tim Düsterhus [Thu, 17 Jun 2021 15:15:56 +0000 (17:15 +0200)]
Merge pull request #4309 from WoltLab/acp-cannotuse
Set __isLogin if a logged-in user lacks `admin.general.canUseAcp`
Tim Düsterhus [Thu, 17 Jun 2021 13:23:21 +0000 (15:23 +0200)]
Deprecate PasswordUtil itself
Tim Düsterhus [Thu, 17 Jun 2021 13:22:47 +0000 (15:22 +0200)]
Deprecate PasswordUtil::getRandomPassword()
Tim Düsterhus [Thu, 17 Jun 2021 13:19:36 +0000 (15:19 +0200)]
Deprecate PasswordUtil methods that will become useless after removal of the algorithms
Tim Düsterhus [Thu, 17 Jun 2021 13:02:14 +0000 (15:02 +0200)]
Rename the third gender from 'Other' to 'Non-Binary' in en.xml
Tim Düsterhus [Thu, 17 Jun 2021 12:52:15 +0000 (14:52 +0200)]
Improve name of the 'image_proxy_host_whitelist' option
Whitelist implies that only the given domains will be passes through the proxy.
Additionally the German version already uses “Ausnahme” which translates to
“Exception”.
Tim Düsterhus [Thu, 17 Jun 2021 12:43:15 +0000 (14:43 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Thu, 17 Jun 2021 12:42:53 +0000 (14:42 +0200)]
Merge branch '5.2' into 5.3
Tim Düsterhus [Thu, 17 Jun 2021 12:42:42 +0000 (14:42 +0200)]
Merge branch '3.1' into 5.2
Tim Düsterhus [Thu, 17 Jun 2021 12:41:10 +0000 (14:41 +0200)]
Fix 'to its full extent' in en.xml
Tim Düsterhus [Thu, 17 Jun 2021 12:09:34 +0000 (14:09 +0200)]
Set __isLogin if a logged-in user lacks `admin.general.canUseAcp`
Resolves #4307
Tim Düsterhus [Thu, 17 Jun 2021 11:54:36 +0000 (13:54 +0200)]
Merge branch '5.4'
Matthias Schmidt [Thu, 17 Jun 2021 11:24:34 +0000 (13:24 +0200)]
Remove deprecated `Category::$permissions` (#4303)
This property has been deprecated for many years (since
2b59736b2592a01ee880f0cc4439622b437acd85) and is just an (internal) copy of `$this->userPermissions[$user->userID]`.
Matthias Schmidt [Thu, 17 Jun 2021 11:24:14 +0000 (13:24 +0200)]
Delete deprecated option `module_system_recaptcha` (#4305)
This option has been deprecated since version 2.1 (since
d802ca93dd49463642a35489e8be5423aee86ede) and due to its age, it is not preserved by defining the matching constant in `WCF::defineLegacyOptions()`.
Matthias Schmidt [Thu, 17 Jun 2021 11:23:57 +0000 (13:23 +0200)]
Remove deprecated phrases (#4306)
Matthias Schmidt [Thu, 17 Jun 2021 09:18:22 +0000 (11:18 +0200)]
Merge pull request #4301 from WoltLab/IEvent
Update event handling for `IEvent`s
Matthias Schmidt [Thu, 17 Jun 2021 06:06:54 +0000 (08:06 +0200)]
Fix code style issues
Matthias Schmidt [Thu, 17 Jun 2021 05:39:26 +0000 (07:39 +0200)]
Update event listener GUI validation to consider new `IEvent` interface
Matthias Schmidt [Thu, 17 Jun 2021 05:26:34 +0000 (07:26 +0200)]
Invoke event listener objects for listeners to `IEvent`s
Matthias Schmidt [Thu, 17 Jun 2021 05:05:58 +0000 (07:05 +0200)]
Replace `SystemException` with `\LogicException` in `EventHandler`
Matthias Schmidt [Thu, 17 Jun 2021 05:03:59 +0000 (07:03 +0200)]
Add `EventHandler::executeListeners()`
Instead of having the same code in `EventHandler::executeInheritedActions()` and `EventHandler::fireAction()`, it is now just in one method.
Matthias Schmidt [Thu, 17 Jun 2021 04:57:55 +0000 (06:57 +0200)]
Refactor code in `EventHandler`
… to reduce code complexity and nesting levels.
Matthias Schmidt [Thu, 17 Jun 2021 04:52:22 +0000 (06:52 +0200)]
Add `EventHandler::getListenerObject()`
Instead of having the same code in `EventHandler::executeInheritedActions()` and `EventHandler::fireAction()`, it is now just in one method.
Matthias Schmidt [Thu, 17 Jun 2021 04:40:20 +0000 (06:40 +0200)]
Delete `WCF.Like.js` (#4300)
As this component would result in an error when used for many versions, it is safe to remove it.
Matthias Schmidt [Thu, 17 Jun 2021 04:40:13 +0000 (06:40 +0200)]
Remove `MessageEmbeddedObjectManager::parseTemporaryMessage()` (#4299)
As this method would result in an exception for many versions, it is safe to remove it.
Alexander Ebert [Wed, 16 Jun 2021 15:27:06 +0000 (17:27 +0200)]
Release 5.4.0 Beta 2
WoltLab [Wed, 16 Jun 2021 13:58:51 +0000 (13:58 +0000)]
Updating minified JavaScript files
Matthias Schmidt [Wed, 16 Jun 2021 12:21:11 +0000 (14:21 +0200)]
Remove obsolete `Breadcrumbs` methods (#4298)
As these methods would result in exceptions for many versions, it is safe to remove them.
Matthias Schmidt [Wed, 16 Jun 2021 12:20:56 +0000 (14:20 +0200)]
Delete `TemplateListenerCacheBuilder` (#4297)
Alexander Ebert [Wed, 16 Jun 2021 12:08:27 +0000 (14:08 +0200)]
Revert "Strip the `loading` attribute from smileys for AMP output"
This reverts commit
4cfc175da480a13704dd6b52e49723c9a84cb62d.
Alexander Ebert [Wed, 16 Jun 2021 12:01:20 +0000 (14:01 +0200)]
Incorrect use of DOM attributes
See #4290
Alexander Ebert [Wed, 16 Jun 2021 12:00:24 +0000 (14:00 +0200)]
Strip the `loading` attribute from smileys for AMP output
See #4290
Alexander Ebert [Wed, 16 Jun 2021 09:31:55 +0000 (11:31 +0200)]
Merge pull request #4292 from WoltLab/verify-webp-support
Verify WebP support in GD/Imagick
Tim Düsterhus [Wed, 16 Jun 2021 07:03:56 +0000 (09:03 +0200)]
Merge pull request #4293 from WoltLab/guzzle-recaptcha
Migrate RecaptchaHandler to Guzzle
Alexander Ebert [Tue, 15 Jun 2021 16:53:08 +0000 (18:53 +0200)]
Verify the support for WebP images during the setup
Tim Düsterhus [Tue, 15 Jun 2021 15:30:27 +0000 (17:30 +0200)]
Merge pull request #4294 from WoltLab/suhosin
Remove Suhosin compatibility layer in PackageInstallationDispatcher
Tim Düsterhus [Tue, 15 Jun 2021 15:06:28 +0000 (17:06 +0200)]
Remove Suhosin compatibility layer in PackageInstallationDispatcher
Suhosin is no more. The last / final release was in 2015.
Tim Düsterhus [Tue, 15 Jun 2021 14:14:50 +0000 (16:14 +0200)]
Migrate RecaptchaHandler to Guzzle
see #4281
Alexander Ebert [Tue, 15 Jun 2021 13:58:49 +0000 (15:58 +0200)]
Verify WebP support in the test script
Alexander Ebert [Tue, 15 Jun 2021 13:47:53 +0000 (15:47 +0200)]
Helper method to check for WebP support
Matthias Schmidt [Tue, 15 Jun 2021 13:11:11 +0000 (15:11 +0200)]
Merge branch '5.4'
Matthias Schmidt [Tue, 15 Jun 2021 13:10:55 +0000 (15:10 +0200)]
Merge branch '5.3' into 5.4