joshuaruesweg [Fri, 29 Jan 2021 12:32:24 +0000 (13:32 +0100)]
Merge branch '3.1' into 5.2
joshuaruesweg [Fri, 29 Jan 2021 12:30:56 +0000 (13:30 +0100)]
Fix converting float value to integer
Joshua Rüsweg [Wed, 27 Jan 2021 14:57:30 +0000 (15:57 +0100)]
Merge pull request #3908 from WoltLab/pr_build_package
Add wcfsetup workflow
joshuaruesweg [Wed, 27 Jan 2021 14:30:47 +0000 (15:30 +0100)]
Add wcfsetup workflow
This workflow generates the WCFSetup and stores it as an artifact.
Tim Düsterhus [Tue, 26 Jan 2021 14:11:49 +0000 (15:11 +0100)]
Merge pull request #3900 from WoltLab/hasOwnerAccess
Fix User::hasOwnerAccess()
Tim Düsterhus [Tue, 26 Jan 2021 14:03:22 +0000 (15:03 +0100)]
Check owner access after checking controller blacklist in RequestHandler
This ensures that the check only happens when absolute required.
Tim Düsterhus [Tue, 26 Jan 2021 14:00:28 +0000 (15:00 +0100)]
Remove caching from User::hasOwnerAccess()
The current caching logic is buggy as reported in issue #3899. This patch
removes this caching, as this method already is quite fast and it also is
seldomly called. Within the frontend it is only called when the user is banned.
Fixes #3899
Tim Düsterhus [Mon, 25 Jan 2021 08:17:56 +0000 (09:17 +0100)]
Whitelist `array_fill` in enterprise mode
WoltLab [Wed, 20 Jan 2021 12:12:17 +0000 (12:12 +0000)]
Updating minified JavaScript files
Marcel Werk [Mon, 18 Jan 2021 15:19:54 +0000 (16:19 +0100)]
Merge branch '3.1' into 5.2
Marcel Werk [Mon, 18 Jan 2021 15:19:25 +0000 (16:19 +0100)]
Permissions for media were not saved correctly
joshuaruesweg [Mon, 18 Jan 2021 12:54:21 +0000 (13:54 +0100)]
Fix double html encoding in trophy activity events
joshuaruesweg [Fri, 15 Jan 2021 12:46:45 +0000 (13:46 +0100)]
Merge branch '3.1' into 5.2
joshuaruesweg [Fri, 15 Jan 2021 12:45:59 +0000 (13:45 +0100)]
Set explicit value for invalid select options
Titus Kirch [Wed, 30 Dec 2020 01:11:55 +0000 (02:11 +0100)]
Support WysiwygFormContainer as children of ITabMenuFormContainer
Matthias Schmidt [Fri, 15 Jan 2021 08:53:37 +0000 (09:53 +0100)]
Fix displaying error messages for devtool projects' instructions
Matthias Schmidt [Fri, 15 Jan 2021 08:50:00 +0000 (09:50 +0100)]
Remove incorrect devtools form field description
Matthias Schmidt [Fri, 15 Jan 2021 08:37:54 +0000 (09:37 +0100)]
Improve variable name
joshuaruesweg [Wed, 6 Jan 2021 15:39:26 +0000 (16:39 +0100)]
Merge branch '3.1' into 5.2
Joshua Rüsweg [Wed, 6 Jan 2021 15:38:31 +0000 (16:38 +0100)]
Merge pull request #3844 from WoltLab/fix-failing-cronjobs
Fix failing cronjobs
Tim Düsterhus [Wed, 6 Jan 2021 11:18:29 +0000 (12:18 +0100)]
Fix VarbinaryDatabaseTableColumn
> Call to undefined method wcf\system\database\table\column\VarbinaryDatabaseTableColumn::traitGetLength()
see
4a65b1e27cc85fc9fb9bbcdf6a6d7a5f9cc76187
Matthias Schmidt [Sun, 3 Jan 2021 16:20:06 +0000 (17:20 +0100)]
Hide article-related notification events if articles are disabled
Close #3845
joshuaruesweg [Sun, 3 Jan 2021 16:10:32 +0000 (17:10 +0100)]
fixup! Disable disabling of failed system cronjobs Fixes #3841
joshuaruesweg [Sat, 2 Jan 2021 15:10:37 +0000 (16:10 +0100)]
Disable disabling of failed system cronjobs
Fixes #3841
joshuaruesweg [Sat, 2 Jan 2021 15:06:56 +0000 (16:06 +0100)]
Prevent failing cronjobs from blocking other cronjobs by executing them last
Matthias Schmidt [Mon, 28 Dec 2020 15:29:17 +0000 (16:29 +0100)]
Fix validation of required single media form fields
Matthias Schmidt [Sun, 27 Dec 2020 13:11:32 +0000 (14:11 +0100)]
Improve readability of form field template code
Matthias Schmidt [Sun, 27 Dec 2020 13:10:31 +0000 (14:10 +0100)]
Fix validation of form builder node attributes
Close #3827
Matthias Schmidt [Sun, 27 Dec 2020 12:54:55 +0000 (13:54 +0100)]
Throw exception for VARBINARY columns without length
Close #3827
Matthias Schmidt [Tue, 22 Dec 2020 13:07:39 +0000 (14:07 +0100)]
Validate column names in indices when using PHP DB API (#3832)
Close #3828
Matthias Schmidt [Tue, 22 Dec 2020 12:04:22 +0000 (13:04 +0100)]
Fix case of non-existing table in DatabaseTableChangeProcessor::getColumnByName()
Close #3829
Matthias Schmidt [Tue, 22 Dec 2020 11:59:18 +0000 (12:59 +0100)]
Consider package during event listeners' name validation in PIP GUI
Close #3831
Matthias Schmidt [Fri, 18 Dec 2020 18:33:23 +0000 (19:33 +0100)]
Fix DatabaseTableChangeProcessor::getColumnByName() for WSC < 5.4
See #3792
Matthias Schmidt [Fri, 18 Dec 2020 18:32:51 +0000 (19:32 +0100)]
Fix missing variable error in DatabaseTableChangeProcessor
See #3792
Matthias Schmidt [Fri, 18 Dec 2020 18:26:29 +0000 (19:26 +0100)]
Matthias Schmidt [Tue, 15 Dec 2020 17:19:21 +0000 (18:19 +0100)]
Fix hiding/showing tab menu entries due to form builder dependencies
Alexander Ebert [Mon, 14 Dec 2020 19:13:04 +0000 (20:13 +0100)]
Excempt the admin panel from application overrides
Fixes #3762
Matthias Schmidt [Sat, 12 Dec 2020 14:00:52 +0000 (15:00 +0100)]
Merge pull request #3799 from WoltLab/nonnull_in_primary_key
Validate primary indices with null columns in PHP DB API
Matthias Schmidt [Wed, 9 Dec 2020 17:42:41 +0000 (18:42 +0100)]
Fix doubled validation errors for CaptchaFormField
Matthias Schmidt [Wed, 9 Dec 2020 16:13:59 +0000 (17:13 +0100)]
Validate primary indices with null columns in PHP DB API
Close #3792
Alexander Ebert [Mon, 7 Dec 2020 20:00:11 +0000 (21:00 +0100)]
Merge branch '3.1' into 5.2
Alexander Ebert [Mon, 7 Dec 2020 19:58:02 +0000 (20:58 +0100)]
Force the use of the attachment thumbnail if the original is inaccessible
Tim Düsterhus [Mon, 7 Dec 2020 15:52:12 +0000 (16:52 +0100)]
Merge pull request #3793 from WoltLab/style-import-permissions
Validate package installation permissions in StyleImportForm
Tim Düsterhus [Mon, 7 Dec 2020 14:56:53 +0000 (15:56 +0100)]
Validate package installation permissions in StyleImportForm
Joshua Rüsweg [Mon, 7 Dec 2020 12:59:44 +0000 (13:59 +0100)]
Merge pull request #3786 from WoltLab/like-rebuild
Optimize LikeRebuildDataWorker performance
Matthias Schmidt [Sun, 6 Dec 2020 14:09:17 +0000 (15:09 +0100)]
Fix dependencies for single media form field
Tim Düsterhus [Fri, 4 Dec 2020 14:59:43 +0000 (15:59 +0100)]
Simplify selection of existing like objects in LikeRebuildDataWorker
Since the previous commit it is expected that only a single objectTypeID is hit
per worker execution in the usual case, because all objects for a single
objectTypeID are processed before proceeding to the next objectTypeID. This
patch optimizes this case by sending a separate query per objectTypeID to fetch
the existing like objects instead of combining all the objects in a single
query.
This should help MySQL in optimizing the query, because the objectTypeID (which
is the first column in the UNIQUE KEY on wcf1_like_object) is fixed for a
single query and this is immediately obvious without needing to scan all the
tuples passed to the IN(…) condition.
In the general case the number of queries does not change. In the iterations
where the last objectID for an objectTypeID is reached two queries will be sent
instead of a single one. Those two combined should be more efficient that the
single old query, though.
Tim Düsterhus [Fri, 4 Dec 2020 14:52:10 +0000 (15:52 +0100)]
Allow LikeRebuildDataWorker to leverage the wcf1_like.objectTypeID key for sorting
joshuaruesweg [Fri, 4 Dec 2020 10:33:53 +0000 (11:33 +0100)]
Ignore invalid file ids during deleting uploaded files
There can be several reasons why the files are no longer known. We can ignore this and simply return a success message so that it doesn't pop up in the frontend when unknown files are deleted.
joshuaruesweg [Fri, 4 Dec 2020 10:23:53 +0000 (11:23 +0100)]
Fix detecting images with capitalised file extensions
Alexander Ebert [Tue, 1 Dec 2020 12:34:59 +0000 (13:34 +0100)]
Merge branch '3.1' into 5.2
Alexander Ebert [Tue, 1 Dec 2020 12:32:47 +0000 (13:32 +0100)]
Incorrect version comparison for accessible packages
Tim Düsterhus [Wed, 25 Nov 2020 08:18:46 +0000 (09:18 +0100)]
Update the orphanedComments remark in package.xml
Alexander Ebert [Mon, 23 Nov 2020 15:11:56 +0000 (16:11 +0100)]
Missing check for empty object ids
Alexander Ebert [Mon, 23 Nov 2020 13:43:06 +0000 (14:43 +0100)]
Release 5.2.10
Alexander Ebert [Mon, 23 Nov 2020 13:36:42 +0000 (14:36 +0100)]
Merge branch '3.1' into 5.2
Alexander Ebert [Mon, 23 Nov 2020 13:29:11 +0000 (14:29 +0100)]
Release 3.1.18
Tim Düsterhus [Mon, 23 Nov 2020 08:27:54 +0000 (09:27 +0100)]
Whitelist `iterator_count` in enterprise mode
Alexander Ebert [Sun, 22 Nov 2020 17:31:49 +0000 (18:31 +0100)]
Merge branch '3.1' into 5.2
Alexander Ebert [Sun, 22 Nov 2020 16:58:44 +0000 (17:58 +0100)]
Merge pull request #3744 from Krymonota/patch-18
Add missing JSDoc to `EmailSmtpTest`
Alexander Ebert [Sun, 22 Nov 2020 16:58:12 +0000 (17:58 +0100)]
Merge pull request #3745 from Krymonota/patch-19
Fix JSDoc module typo in `RewriteGenerator`
joshuaruesweg [Sat, 21 Nov 2020 20:56:27 +0000 (21:56 +0100)]
Fix point calculation for removing reactions from an object
Niklas [Sat, 21 Nov 2020 18:41:47 +0000 (19:41 +0100)]
Fix JSDoc module typo in `RewriteGenerator`
Niklas [Sat, 21 Nov 2020 18:39:56 +0000 (19:39 +0100)]
Add missing JSDoc to `EmailSmtpTest`
WoltLab [Fri, 20 Nov 2020 19:03:30 +0000 (19:03 +0000)]
Updating minified JavaScript files
Alexander Ebert [Fri, 20 Nov 2020 18:59:24 +0000 (19:59 +0100)]
Merge branch '3.1' into 5.2
WoltLab [Fri, 20 Nov 2020 18:06:23 +0000 (18:06 +0000)]
Updating minified JavaScript files
Alexander Ebert [Fri, 20 Nov 2020 17:39:33 +0000 (18:39 +0100)]
Workaround for a Chromium bug on Windows
Alexander Ebert [Thu, 19 Nov 2020 18:24:52 +0000 (19:24 +0100)]
Clean up comments when removing moderation queues (#3740)
* Delete comments when moderation queues are being removed
See #3707
* Clean-up script for orphaned comments
* Use the `CommentHandler` to remove comments
* Apply suggestions from code review
Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
Tim Düsterhus [Thu, 19 Nov 2020 13:06:01 +0000 (14:06 +0100)]
Replace the selector for the font-family in email_html.tpl
The Emogrifier version used in 5.2 does not fully support all features
of the `:not()` selector. Depending on the environment the use of
`:not()` results in slightly different output. Specifically the number
of `:not()`s chained there caused the result to have a very large
specificity, possibly overriding the font-size of the headline tags.
Use `body, body *` instead, it will not put any useless CSS onto heading
tags and still catch all relevant elements. The biggest difference is
that the `<br>` tag will carry a `font-family` and `font-size`.
Alexander Ebert [Wed, 18 Nov 2020 19:01:46 +0000 (20:01 +0100)]
Merge branch '3.1' into 5.2
Alexander Ebert [Wed, 18 Nov 2020 19:00:04 +0000 (20:00 +0100)]
Mutable variable access inside a callback
Matthias Schmidt [Wed, 18 Nov 2020 16:32:41 +0000 (17:32 +0100)]
Merge branch '3.1' into 5.2
Matthias Schmidt [Wed, 18 Nov 2020 16:32:21 +0000 (17:32 +0100)]
Fix ACL buttons when editing media files successively
Replaces
3a7740a3704339c79d08fd2f5094fa1a1973318b by backporting and using parts of
6ee58cd2865980cd7fa16a1f3ebc660131fc7fd6.
Matthias Schmidt [Wed, 18 Nov 2020 16:26:26 +0000 (17:26 +0100)]
Revert "Fix ACL buttons when editing media files successively"
This reverts commit
3a7740a3704339c79d08fd2f5094fa1a1973318b.
Matthias Schmidt [Wed, 18 Nov 2020 16:24:30 +0000 (17:24 +0100)]
Fix ACL buttons when editing media files successively
Matthias Schmidt [Wed, 18 Nov 2020 15:28:18 +0000 (16:28 +0100)]
Fix file icon update after upload on media list page
Tim Düsterhus [Tue, 17 Nov 2020 11:10:32 +0000 (12:10 +0100)]
Encode HTML special chars in form builder's action
Alexander Ebert [Thu, 12 Nov 2020 18:04:01 +0000 (19:04 +0100)]
Workaround for nested paragraphs after pasting in Firefox
Matthias Schmidt [Thu, 12 Nov 2020 16:30:28 +0000 (17:30 +0100)]
Disallow changing time support after setting value in `DateFormField`
Matthias Schmidt [Thu, 12 Nov 2020 15:07:33 +0000 (16:07 +0100)]
Delete FK logs after removing FKs due to column removal
Tim Düsterhus [Thu, 12 Nov 2020 08:56:12 +0000 (09:56 +0100)]
Merge branch '3.1' into 5.2
Niklas [Thu, 12 Nov 2020 08:16:32 +0000 (09:16 +0100)]
Fix BBCodeHandler::setDisallowedBBCodes(...) PHPDoc (#3722)
Matthias Schmidt [Mon, 9 Nov 2020 13:08:14 +0000 (14:08 +0100)]
Fix deleting obsolete nodes in form builder dependeny manager
Alexander Ebert [Sun, 8 Nov 2020 18:19:34 +0000 (19:19 +0100)]
Merge branch '3.1' into 5.2
Alexander Ebert [Sun, 8 Nov 2020 18:19:17 +0000 (19:19 +0100)]
Obsolete exclusion of the old ACP catpcha
This route does not exist anymore since WoltLab Suite 3.0.
Matthias Schmidt [Sat, 7 Nov 2020 09:15:20 +0000 (10:15 +0100)]
Fix deleting obsolete nodes in form builder dependeny manager
Marcel Werk [Thu, 5 Nov 2020 22:05:15 +0000 (23:05 +0100)]
Use native click event if available
Marcel Werk [Tue, 3 Nov 2020 18:41:50 +0000 (19:41 +0100)]
Merge branch '3.1' into 5.2
Marcel Werk [Tue, 3 Nov 2020 18:41:31 +0000 (19:41 +0100)]
Block search keyword list if permissions for the search function are denied
Closes #3681
Matthias Schmidt [Tue, 3 Nov 2020 14:50:45 +0000 (15:50 +0100)]
Fix `Ui/Poll/Editor._reset()`
Tim Düsterhus [Tue, 3 Nov 2020 13:30:18 +0000 (14:30 +0100)]
Tim Düsterhus [Tue, 3 Nov 2020 13:26:13 +0000 (14:26 +0100)]
Fix typo in de.xml
Matthias Schmidt [Tue, 3 Nov 2020 10:14:08 +0000 (11:14 +0100)]
Fix polls in AJAX form builder forms
Matthias Schmidt [Tue, 3 Nov 2020 10:13:14 +0000 (11:13 +0100)]
Add data and options getters in poll editor js module
Matthias Schmidt [Tue, 3 Nov 2020 10:12:30 +0000 (11:12 +0100)]
Fire event if field is registered in form builder manager
Matthias Schmidt [Mon, 2 Nov 2020 17:56:03 +0000 (18:56 +0100)]
Merge branch '3.1' into 5.2
Matthias Schmidt [Mon, 2 Nov 2020 17:55:46 +0000 (18:55 +0100)]
Fix GDPR export if invalid user id is given
… and stop using deprecated method `UserProfile::getUserProfile()`.
Tim Düsterhus [Mon, 2 Nov 2020 09:40:18 +0000 (10:40 +0100)]
Whitelist `version_compare` in enterprise mode
Marcel Werk [Mon, 14 Sep 2020 12:31:34 +0000 (14:31 +0200)]
Expired session during 3rd party auth led to a SystemException
(cherry picked from commit
da8b0e89fa9da82fc7965955e7c0639a65d6ac00)