GitHub/WoltLab/WCF.git
2 years agoAvoid empty content interaction elements to avoid obsolete margin
Marcel Werk [Wed, 27 Apr 2022 13:19:06 +0000 (15:19 +0200)]
Avoid empty content interaction elements to avoid obsolete margin

2 years agoAdd explicit support for `*` in excludedPackages in `PackageUpdateAction`
joshuaruesweg [Wed, 27 Apr 2022 13:01:28 +0000 (15:01 +0200)]
Add explicit support for `*` in excludedPackages in `PackageUpdateAction`

Fixes #4736

2 years agoRevert "Unify the email validation of UserUtil::isValidEmail() and Mailbox::__constru...
Tim Düsterhus [Wed, 27 Apr 2022 12:56:56 +0000 (14:56 +0200)]
Revert "Unify the email validation of UserUtil::isValidEmail() and Mailbox::__construct()"

This change broke WCFSetup, because Mailboxes implicitly carry a language which
is not readily available in WCFSetup.

The validation of the email address should likely be moved into a dedicated
method in Mailbox and then UserUtil::isValidEmail() deprecated.

This reverts commit 395f9a6affffdd5381134d3f9d39b70de453b668.

2 years agoAdded standalone button for "mark as read"
Marcel Werk [Wed, 27 Apr 2022 11:33:46 +0000 (13:33 +0200)]
Added standalone button for "mark as read"

2 years agoRemoved useless RSS feed dialog for notifications
Marcel Werk [Wed, 27 Apr 2022 11:23:57 +0000 (13:23 +0200)]
Removed useless RSS feed dialog for notifications

The option for an anonymous RSS feed does not make sense at this point, as guests do not have access to notifications.

2 years agoRelease 5.5.0 Alpha 4 5.5.0_Alpha_4
Alexander Ebert [Tue, 26 Apr 2022 13:53:10 +0000 (15:53 +0200)]
Release 5.5.0 Alpha 4

2 years agoUpdating minified JavaScript files
WoltLab [Tue, 26 Apr 2022 13:42:57 +0000 (13:42 +0000)]
Updating minified JavaScript files

2 years agoMerge pull request #4757 from WoltLab/visit-tracker
Tim Düsterhus [Tue, 26 Apr 2022 13:25:55 +0000 (15:25 +0200)]
Merge pull request #4757 from WoltLab/visit-tracker

Improve VisitTracker behavior

2 years agoRemove support for object specific lifetimes in VisitTracker
Tim Düsterhus [Tue, 26 Apr 2022 13:21:10 +0000 (15:21 +0200)]
Remove support for object specific lifetimes in VisitTracker

2 years agoFix cleaning of tracked visits in DailyCleanUpCronjob
Tim Düsterhus [Tue, 26 Apr 2022 12:44:27 +0000 (14:44 +0200)]
Fix cleaning of tracked visits in DailyCleanUpCronjob

This part of the cronjob never was functional, because stored visitTime was
compared to the lifetime which could only ever match near the start of the unix
epoch.

Fix this by correctly subtracting the lifetime from the current timestamp. I've
opted to use 120 days as the cleanup lifetime, as this allows one to adjust the
DEFAULT_LIFETIME gracefully.

2 years agoSimplify VisitTracker::getVisitTime()
Tim Düsterhus [Tue, 26 Apr 2022 12:30:33 +0000 (14:30 +0200)]
Simplify VisitTracker::getVisitTime()

2 years agoRemove the intransparent doubling of the visit tracker lifetime if existing data...
Tim Düsterhus [Tue, 26 Apr 2022 12:23:17 +0000 (14:23 +0200)]
Remove the intransparent doubling of the visit tracker lifetime if existing data exists

In case of com.woltlab.wbb this only triggers if and only if a user *ever*
marked all boards as read. With the increase of the default lifetime in the
previous commit it becomes obsolete.

2 years agoIncrease VisitTracker::DEFAULT_LIFETIME to 31 days
Tim Düsterhus [Tue, 26 Apr 2022 12:22:24 +0000 (14:22 +0200)]
Increase VisitTracker::DEFAULT_LIFETIME to 31 days

see 0fb222af73eab6621c62c5bd4403bdf7330bfad8

2 years agoUse constant expression for VisitTracker::DEFAULT_LIFETIME
Tim Düsterhus [Tue, 26 Apr 2022 12:22:05 +0000 (14:22 +0200)]
Use constant expression for VisitTracker::DEFAULT_LIFETIME

2 years agoEnforce equal heights of all buttons
Alexander Ebert [Tue, 26 Apr 2022 11:19:52 +0000 (13:19 +0200)]
Enforce equal heights of all buttons

See https://www.woltlab.com/community/thread/295373-buttons-unterschiedlich-gro%C3%9F-wenn-pagination-aktiv/

2 years agoRephrased the button to set up notifications
Alexander Ebert [Tue, 26 Apr 2022 11:15:54 +0000 (13:15 +0200)]
Rephrased the button to set up notifications

See https://www.woltlab.com/community/thread/295368-desktop-benachrichtigungen-aktivieren-pr%C3%A4ferenzen-festlegen-falsch/

2 years agoMerge pull request #4756 from WoltLab/user-util-is-valid-email
Tim Düsterhus [Tue, 26 Apr 2022 08:51:02 +0000 (10:51 +0200)]
Merge pull request #4756 from WoltLab/user-util-is-valid-email

Unify the email validation of UserUtil::isValidEmail() and Mailbox::__construct()

2 years agoUnify the email validation of UserUtil::isValidEmail() and Mailbox::__construct()
Tim Düsterhus [Tue, 26 Apr 2022 07:08:09 +0000 (09:08 +0200)]
Unify the email validation of UserUtil::isValidEmail() and Mailbox::__construct()

2 years agoPasting code into a code box caused duplicates
Alexander Ebert [Mon, 25 Apr 2022 17:24:37 +0000 (19:24 +0200)]
Pasting code into a code box caused duplicates

2 years agoSuperfluous CSS for dialog alignment
Alexander Ebert [Mon, 25 Apr 2022 16:24:01 +0000 (18:24 +0200)]
Superfluous CSS for dialog alignment

This was supposed to be removed by 8fb8e05c07732280ff5fea3b926b71f35db9b0ff

2 years agoDisable the focus trap before hiding the dialog
Alexander Ebert [Mon, 25 Apr 2022 16:15:22 +0000 (18:15 +0200)]
Disable the focus trap before hiding the dialog

See https://www.woltlab.com/community/thread/295337-mobil-thema-bearbeiten-bug/

2 years agoDisable hiding of the user menu on Redactor focus
Alexander Ebert [Mon, 25 Apr 2022 16:12:27 +0000 (18:12 +0200)]
Disable hiding of the user menu on Redactor focus

This change was missing from 106207823daf1b1105afc918fa66718ae70707e2

2 years agoDisable hiding of the user menu on Redactor focus
Alexander Ebert [Mon, 25 Apr 2022 15:35:16 +0000 (17:35 +0200)]
Disable hiding of the user menu on Redactor focus

The behavior was intended to increase the available screen space when the editor is active. However, the height of smartphones has constantly increased, reducing the impact of a couple extra pixels.

The major downside was the focus behavior which is somewhat unintuitive on mobile and has repeatedly caused confusion among users, because the menu was seemingly “lost”.

2 years agoKeep the scrollbar visible while scrolling
Alexander Ebert [Mon, 25 Apr 2022 15:16:33 +0000 (17:16 +0200)]
Keep the scrollbar visible while scrolling

See https://www.woltlab.com/community/thread/295349-scrollbar-ohne-hover-nicht-sichtbar-selbst-beim-scrollen/

2 years agoSynchronize the unread indicator on menu close
Alexander Ebert [Mon, 25 Apr 2022 15:12:54 +0000 (17:12 +0200)]
Synchronize the unread indicator on menu close

See https://www.woltlab.com/community/thread/295340-mobiler-hinweis-verschwindet-nicht-direkt-nach-benachrichtigungen-als-gelesen-ma/

2 years agoUse the DOM attribute as notification counter
Alexander Ebert [Mon, 25 Apr 2022 15:10:46 +0000 (17:10 +0200)]
Use the DOM attribute as notification counter

2 years agoUser-friendly messages for network errors
Alexander Ebert [Mon, 25 Apr 2022 14:49:53 +0000 (16:49 +0200)]
User-friendly messages for network errors

See https://www.woltlab.com/community/thread/295356-load-failed-wenn-keine-netzwerkverbindung-beim-klick-auf-die-benachrichtigungen/

2 years agoMerge branch '5.4'
Tim Düsterhus [Mon, 25 Apr 2022 10:52:55 +0000 (12:52 +0200)]
Merge branch '5.4'

2 years agoSet explicit `referrerpolicy` for Vimeo embeds
Sascha Greuel [Mon, 25 Apr 2022 10:32:11 +0000 (12:32 +0200)]
Set explicit `referrerpolicy` for Vimeo embeds

see 936c0f6d5d3f5a811110f7add4fa688a3e9a8377
see https://www.woltlab.com/community/thread/295351/?postID=1891462#post1891462
Resolves #4755

2 years agoSet explicit `referrerpolicy` for YouTube embeds
Tim Düsterhus [Mon, 25 Apr 2022 10:49:48 +0000 (12:49 +0200)]
Set explicit `referrerpolicy` for YouTube embeds

YouTube requires the `Referer` header to be set for (some) embeds to work. By
using the attribute any `referrer-policy` header set on the top level document
is overridden (e.g. `same-origin`).

Co-authored-by: Sascha Greuel <github@1-2.dev>
2 years agoFix assertion in TMultiRecipientModerationQueueCommentUserNotificationObjectType
Tim Düsterhus [Mon, 25 Apr 2022 08:33:34 +0000 (10:33 +0200)]
Fix assertion in TMultiRecipientModerationQueueCommentUserNotificationObjectType

2 years agoRelease 5.5.0 Alpha 3 5.5.0_Alpha_3
Alexander Ebert [Sun, 24 Apr 2022 13:15:47 +0000 (15:15 +0200)]
Release 5.5.0 Alpha 3

2 years agoUpdating minified JavaScript files
WoltLab [Sun, 24 Apr 2022 13:04:47 +0000 (13:04 +0000)]
Updating minified JavaScript files

2 years agoAdded standalone button for "mark as read"
Marcel Werk [Sun, 24 Apr 2022 13:02:04 +0000 (15:02 +0200)]
Added standalone button for "mark as read"

2 years agoShow notification after "mark as read" is done
Marcel Werk [Sun, 24 Apr 2022 13:01:32 +0000 (15:01 +0200)]
Show notification after "mark as read" is done

2 years agoSkip the notification tab when in maintenance mode
Alexander Ebert [Sun, 24 Apr 2022 12:45:58 +0000 (14:45 +0200)]
Skip the notification tab when in maintenance mode

See https://www.woltlab.com/community/thread/295237-leeres-benutzermen%C3%BC-im-wartungsmodus/

2 years agoImproves visuals when marking user menu items read
Alexander Ebert [Sun, 24 Apr 2022 12:17:43 +0000 (14:17 +0200)]
Improves visuals when marking user menu items read

See https://www.woltlab.com/community/thread/295256-mobiles-als-gelesen-markieren-von-benachrichtigungen-schlecht-erkenntlich-und-nu/

2 years agoIncorrect selector target
Alexander Ebert [Sun, 24 Apr 2022 12:12:19 +0000 (14:12 +0200)]
Incorrect selector target

2 years agoMoved the page menu item counter to the text
Alexander Ebert [Sat, 23 Apr 2022 18:20:46 +0000 (20:20 +0200)]
Moved the page menu item counter to the text

2 years agoAdditional indicator for the active page menu
Alexander Ebert [Sat, 23 Apr 2022 18:15:28 +0000 (20:15 +0200)]
Additional indicator for the active page menu

2 years agoFixed code style
Marcel Werk [Sat, 23 Apr 2022 17:01:01 +0000 (19:01 +0200)]
Fixed code style

2 years agoUnused import
Alexander Ebert [Sat, 23 Apr 2022 16:08:39 +0000 (18:08 +0200)]
Unused import

2 years agoMerge branch 'master' of https://github.com/WoltLab/WCF
Marcel Werk [Sat, 23 Apr 2022 13:19:37 +0000 (15:19 +0200)]
Merge branch 'master' of https://github.com/WoltLab/WCF

2 years agoWrapping of the pagination prevented
Marcel Werk [Sat, 23 Apr 2022 13:19:35 +0000 (15:19 +0200)]
Wrapping of the pagination prevented

2 years agoFixed margins when pagination top was hidden
Marcel Werk [Sat, 23 Apr 2022 13:08:29 +0000 (15:08 +0200)]
Fixed margins when pagination top was hidden

2 years agoUnified code of content header / footer navigation
Marcel Werk [Sat, 23 Apr 2022 12:15:14 +0000 (14:15 +0200)]
Unified code of content header / footer navigation

2 years agoDo not focus the search suggestions automatically
Alexander Ebert [Sat, 23 Apr 2022 12:12:09 +0000 (14:12 +0200)]
Do not focus the search suggestions automatically

This interferes with the ability to enter a search term that is similar to a suggestion. Pressing enter would cause the suggestion to be filed in instead of submitting the value as-is.

2 years agoSelecting a search suggestion discarded the search
Alexander Ebert [Sat, 23 Apr 2022 12:08:54 +0000 (14:08 +0200)]
Selecting a search suggestion discarded the search

See https://www.woltlab.com/community/thread/295268-suchfunktion-teilweise-umst%C3%A4ndlich/

2 years agoSuperfluous whitespace
Alexander Ebert [Fri, 22 Apr 2022 16:11:11 +0000 (18:11 +0200)]
Superfluous whitespace

2 years agoRestore the user menu DOM on close
Alexander Ebert [Fri, 22 Apr 2022 16:01:37 +0000 (18:01 +0200)]
Restore the user menu DOM on close

See https://www.woltlab.com/community/thread/295304-kontrollzentrum-nicht-mehr-anklickbar-nach-wechsel-der-aufl%C3%B6sung/

2 years agoExclude the macOS emoji keyboard from keypresses
Alexander Ebert [Fri, 22 Apr 2022 15:16:55 +0000 (17:16 +0200)]
Exclude the macOS emoji keyboard from keypresses

See https://www.woltlab.com/community/thread/295207-hotkey-f%C3%BCr-emoji-men%C3%BC-funktioniert-im-editor-nicht/

2 years agoIncorrect selection when submitting editor dialogs
Alexander Ebert [Fri, 22 Apr 2022 15:10:25 +0000 (17:10 +0200)]
Incorrect selection when submitting editor dialogs

Fixes #4747

2 years agoUpdate fileDelete.xml to remove files where only the case changed
Tim Düsterhus [Fri, 22 Apr 2022 14:13:42 +0000 (16:13 +0200)]
Update fileDelete.xml to remove files where only the case changed

It is not guaranteed that new file case was successfully applied on case
insensitive file system, so these files might be deleted even with the
fileDelete PIP verifying the actual casing since
49c488354f3fd5b02a851a48d912d6aad3601161.

Remove those files from fileDelete.xml to be on the safe side. This is no
longer easily doable with bash only. The following PHP script was used to
generate fileDelete.xml:

    <?php
    \exec(<<<'EOT'
    git log --root --diff-filter=D --no-renames --summary |awk '/delete mode/{print $NF}' |grep wcfsetup/install/files/ |sort -u
    EOT, $delete);
    \exec(<<<'EOT'
    find wcfsetup/install/files/ |sort -u
    EOT, $preserve);
    $preserve = \array_map('strtolower', $preserve);

    $delete = \array_filter($delete, static function ($file) use ($preserve) {
     return !\in_array(\strtolower($file), $preserve);
    });

    echo <<<'EOT'
    <?xml version="1.0" encoding="UTF-8"?>
    <data xmlns="http://www.woltlab.com" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.woltlab.com http://www.woltlab.com/XSD/2019/fileDelete.xsd">
     <delete>
     <!-- Special files -->
     <file>acp/masterPassword.inc.php</file>
     <!-- /Special files -->
    EOT, "\n";

    echo \implode("\n", \array_map(static function ($file) {
     $file = \preg_replace('/^wcfsetup\\/install\\/files\\//', '', $file);

     return "\t\t<file>{$file}</file>";
    }, $delete))."\n";

    echo <<<'EOT'
     </delete>
    </data>
    EOT, "\n";

2 years agoMerge branch '5.4'
Tim Düsterhus [Fri, 22 Apr 2022 13:26:54 +0000 (15:26 +0200)]
Merge branch '5.4'

2 years agoRemove reference to CONTRIBUTING.md from README.md
Tim Düsterhus [Fri, 22 Apr 2022 13:26:13 +0000 (15:26 +0200)]
Remove reference to CONTRIBUTING.md from README.md

see 5d7b7d602e0f6efb077bffda4b3ecceed8534810

2 years agoAdded global language variable for "mark as read" buttons
Marcel Werk [Thu, 21 Apr 2022 15:28:08 +0000 (17:28 +0200)]
Added global language variable for "mark as read" buttons

2 years agoButton label optimized
Marcel Werk [Thu, 21 Apr 2022 13:26:24 +0000 (15:26 +0200)]
Button label optimized

2 years agoMerge branch '5.4'
Alexander Ebert [Thu, 21 Apr 2022 13:14:06 +0000 (15:14 +0200)]
Merge branch '5.4'

2 years agoDetect italic/underline text pasted from Google Docs
Alexander Ebert [Thu, 21 Apr 2022 13:12:48 +0000 (15:12 +0200)]
Detect italic/underline text pasted from Google Docs

2 years agoPagination of search results was not accessible for guests
Marcel Werk [Thu, 21 Apr 2022 09:33:12 +0000 (11:33 +0200)]
Pagination of search results was not accessible for guests

Closes #4749

2 years agoIndividual sorting of search results had no effect
Marcel Werk [Wed, 20 Apr 2022 20:19:21 +0000 (22:19 +0200)]
Individual sorting of search results had no effect

2 years agoRelease 5.5.0 Alpha 2 5.5.0_Alpha_2
Alexander Ebert [Wed, 20 Apr 2022 16:06:39 +0000 (18:06 +0200)]
Release 5.5.0 Alpha 2

2 years agoUpdating minified JavaScript files
WoltLab [Wed, 20 Apr 2022 16:05:32 +0000 (16:05 +0000)]
Updating minified JavaScript files

2 years agoIncorrect focus/scroll management on iOS
Alexander Ebert [Wed, 20 Apr 2022 15:28:12 +0000 (17:28 +0200)]
Incorrect focus/scroll management on iOS

See https://www.woltlab.com/community/thread/295245-antworten-button-springt-zum-footer/

2 years agoIncorrect DOM behavior of `dboAction`
Alexander Ebert [Wed, 20 Apr 2022 14:05:36 +0000 (16:05 +0200)]
Incorrect DOM behavior of `dboAction`

The invocation of the `DomChangeListener` does not make any sense any more, because the API is designed to be asynchronous. The caller must take care of this themselves.

2 years agoMerge pull request #4746 from WoltLab/55-user-menu-settings
Alexander Ebert [Wed, 20 Apr 2022 13:29:23 +0000 (15:29 +0200)]
Merge pull request #4746 from WoltLab/55-user-menu-settings

Cleaned up the user menu, extra profile link

2 years agoInconsistent layout of multiline text
Alexander Ebert [Wed, 20 Apr 2022 13:21:35 +0000 (15:21 +0200)]
Inconsistent layout of multiline text

2 years agoCleaned up the user menu, extra profile link
Alexander Ebert [Wed, 20 Apr 2022 13:05:51 +0000 (15:05 +0200)]
Cleaned up the user menu, extra profile link

2 years agoMerge pull request #4744 from WoltLab/deprecate-fetchRemoteAvatar
Alexander Ebert [Wed, 20 Apr 2022 12:21:34 +0000 (14:21 +0200)]
Merge pull request #4744 from WoltLab/deprecate-fetchRemoteAvatar

Deprecate UserAvatarAction::fetchRemoteAvatar()

2 years agoDeprecate UserAvatarAction::fetchRemoteAvatar()
Tim Düsterhus [Wed, 20 Apr 2022 10:56:56 +0000 (12:56 +0200)]
Deprecate UserAvatarAction::fetchRemoteAvatar()

2 years agoAdd `@since` to UserProfileAction::setAvatar()
Tim Düsterhus [Wed, 20 Apr 2022 10:53:58 +0000 (12:53 +0200)]
Add `@since` to UserProfileAction::setAvatar()

see 7448a453886e504eaa1d70e8a39bbb1fad14dd42
see #4583

2 years agoFetching a remote avatar didn't work if user doesn't have to permission to upload...
Marcel Werk [Wed, 20 Apr 2022 09:17:27 +0000 (11:17 +0200)]
Fetching a remote avatar didn't work if user doesn't have to permission to upload avatars

2 years agoProperly check permissions for the `systemIdMismatch` message in acp/index.tpl
Tim Düsterhus [Tue, 19 Apr 2022 13:49:35 +0000 (15:49 +0200)]
Properly check permissions for the `systemIdMismatch` message in acp/index.tpl

2 years agoMerge pull request #4739 from SoftCreatR/patch-4
Alexander Ebert [Tue, 19 Apr 2022 12:37:48 +0000 (14:37 +0200)]
Merge pull request #4739 from SoftCreatR/patch-4

Remove cursive font in quotes

2 years agoUpdating minified JavaScript files 5.5.0_Alpha_1
WoltLab [Tue, 19 Apr 2022 08:46:09 +0000 (08:46 +0000)]
Updating minified JavaScript files

2 years agoMerge branch '5.4'
joshuaruesweg [Tue, 19 Apr 2022 08:18:50 +0000 (10:18 +0200)]
Merge branch '5.4'

2 years agoFix fetching userID for multilanguage articles
joshuaruesweg [Tue, 19 Apr 2022 08:18:31 +0000 (10:18 +0200)]
Fix fetching userID for multilanguage articles

2 years agoMerge remote-tracking branch 'origin/master'
Tim Düsterhus [Tue, 19 Apr 2022 07:05:30 +0000 (09:05 +0200)]
Merge remote-tracking branch 'origin/master'

2 years agoMerge branch '5.4'
Tim Düsterhus [Tue, 19 Apr 2022 07:05:06 +0000 (09:05 +0200)]
Merge branch '5.4'

2 years agoUse spaces instead of tabs
joshuaruesweg [Mon, 18 Apr 2022 08:36:19 +0000 (10:36 +0200)]
Use spaces instead of tabs

2 years agoPrevent firing notifications for awarding own trophies
joshuaruesweg [Mon, 18 Apr 2022 08:31:40 +0000 (10:31 +0200)]
Prevent firing notifications for awarding own trophies

2 years agoRemoved cursive font in quotes
Sascha Greuel [Sun, 17 Apr 2022 13:27:45 +0000 (15:27 +0200)]
Removed cursive font in quotes

See https://www.woltlab.com/community/thread/295216-kursivschrift-in-zitaten-entfernen

2 years agoRelease 5.4.16 5.4.16
Alexander Ebert [Thu, 14 Apr 2022 14:57:41 +0000 (16:57 +0200)]
Release 5.4.16

2 years agoMerge branch '5.3' into 5.4
Alexander Ebert [Thu, 14 Apr 2022 14:47:23 +0000 (16:47 +0200)]
Merge branch '5.3' into 5.4

2 years agoRelease 5.3.22 5.3.22
Alexander Ebert [Thu, 14 Apr 2022 14:45:23 +0000 (16:45 +0200)]
Release 5.3.22

2 years agoMerge branch '5.4'
Alexander Ebert [Thu, 14 Apr 2022 14:25:09 +0000 (16:25 +0200)]
Merge branch '5.4'

2 years agoRemoved the outdated `CONTRIBUTING.md`
Alexander Ebert [Thu, 14 Apr 2022 14:25:02 +0000 (16:25 +0200)]
Removed the outdated `CONTRIBUTING.md`

The file is heavily outdated and badly presented on GitHub. With WoltLab Suite 5.4 we switched to PSR-12 and Prettier anyway, so there is no need to explain any special rules.

Closes #4600

2 years agoMerge branch '5.4'
Marcel Werk [Thu, 14 Apr 2022 12:26:35 +0000 (14:26 +0200)]
Merge branch '5.4'

2 years agoAttached images with mismatched proportions got mangled
Marcel Werk [Thu, 14 Apr 2022 12:26:23 +0000 (14:26 +0200)]
Attached images with mismatched proportions got mangled

2 years agoMerge pull request #4737 from WoltLab/exclusion-check-install
Tim Düsterhus [Thu, 14 Apr 2022 12:17:41 +0000 (14:17 +0200)]
Merge pull request #4737 from WoltLab/exclusion-check-install

Always check exclusions in PackageUpdateAction::createQueue()

2 years agoAlways check exclusions in PackageUpdateAction::createQueue()
Tim Düsterhus [Thu, 14 Apr 2022 10:23:15 +0000 (12:23 +0200)]
Always check exclusions in PackageUpdateAction::createQueue()

Ever since the method checked for package exclusions in
1d7f1d205ee64fd2723877c1f296c592518e516d it only applied the check to updates,
not to fresh installs. It's not clear why it did so, I assume this to be an
oversight.

Change this to always run the exclusion check, otherwise exclusions might be
circumvented using PackageUpdateAction::prepareInstallation() with a
package+version combination that would regularly be excluded.

2 years agoImprove types in Acp/Ui/Package/QuickInstallation.ts
Tim Düsterhus [Thu, 14 Apr 2022 10:20:33 +0000 (12:20 +0200)]
Improve types in Acp/Ui/Package/QuickInstallation.ts

2 years agoFix error handling in Acp/Ui/Package/QuickInstallation.ts
Tim Düsterhus [Thu, 14 Apr 2022 10:18:22 +0000 (12:18 +0200)]
Fix error handling in Acp/Ui/Package/QuickInstallation.ts

2 years agoMerge branch '5.4'
Tim Düsterhus [Thu, 14 Apr 2022 09:55:42 +0000 (11:55 +0200)]
Merge branch '5.4'

2 years agoAdd missing trailing comma in PackageUpdateDispatcher
Tim Düsterhus [Thu, 14 Apr 2022 09:54:49 +0000 (11:54 +0200)]
Add missing trailing comma in PackageUpdateDispatcher

see cdffd4c7fc6b55e7b131274b8050ddd6f8cb200b

2 years agoEnsure that the `version` array key is always set for excludes in package update...
Tim Düsterhus [Thu, 14 Apr 2022 09:50:18 +0000 (11:50 +0200)]
Ensure that the `version` array key is always set for excludes in package update XML processing

see 1996ec7a0df649b27bffbf150d8ddbc0131ce6db

2 years agoEmpty code boxes partially collapsed the layout
Alexander Ebert [Thu, 14 Apr 2022 09:47:35 +0000 (11:47 +0200)]
Empty code boxes partially collapsed the layout

See https://www.woltlab.com/community/thread/295182-leere-code-box-ist-kaputt/

2 years agoMerge pull request #4735 from WoltLab/rescue-mode-assets
Tim Düsterhus [Wed, 13 Apr 2022 08:55:41 +0000 (10:55 +0200)]
Merge pull request #4735 from WoltLab/rescue-mode-assets

Embed the assets as data URIs in rescueMode.tpl

2 years agoEmbed the assets as data URIs in rescueMode.tpl
Tim Düsterhus [Wed, 13 Apr 2022 08:06:35 +0000 (10:06 +0200)]
Embed the assets as data URIs in rescueMode.tpl

The same reasoning as for the change to WCFSetup in
600940bc4fe0cbc219ba6fd9a89444aefa07dda5 applies:

With this change the rescue mode is fully self-contained and does not rely on
external requests that need to be served using PHP, making it more resilient.

It also avoids the expensive rebuild of the compiled ACP CSS, because it now
uses the prebuilt WCFSetup.css which can be used as-is for this purpose.

2 years agoFix typo in en.xml
Tim Düsterhus [Wed, 13 Apr 2022 07:17:30 +0000 (09:17 +0200)]
Fix typo in en.xml