Tomas Winkler [Sat, 5 Mar 2011 22:55:20 +0000 (00:55 +0200)]
staging/easycap: wait_i2c should be static
wait_i2c is only used from easycap_low.c
so remove it from the easycap.h and mark it static
Cc: Mike Thomas <rmthomas@sciolus.org>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Xiaochen Wang [Sun, 6 Mar 2011 14:53:21 +0000 (22:53 +0800)]
staging: rtl8712: check _malloc return value
Description: The original check is wrong.
Signed-off-by: Xiaochen Wang <wangxiaochen0@gmail.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Xiaochen Wang [Sun, 6 Mar 2011 14:24:14 +0000 (22:24 +0800)]
staging: rtl8712: check copy_from_user return value
Description:return -EFAULT if copy_to_user() fails
Signed-off-by: Xiaochen Wang <wangxiaochen0@gmail.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Xiaochen Wang [Sun, 6 Mar 2011 14:04:15 +0000 (22:04 +0800)]
staging: rtl8192e use kmemdup and check its return value
use kmemdup instead of kmalloc and memcpy,
and check its return value
Signed-off-by: Xiaochen Wang <wangxiaochen0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Xiaochen Wang [Fri, 4 Mar 2011 05:09:00 +0000 (13:09 +0800)]
staging: rtl8187se: check kmalloc return value
check kmalloc return value
Signed-off-by: Xiaochen Wang <wangxiaochen0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dowan Kim [Sat, 5 Mar 2011 01:47:43 +0000 (17:47 -0800)]
staging: brcm80211: FIX for bug that prevents system from entering suspend state
The attempt to enter to suspend mode can be hindered when the network
interface is disabled.
When system enters the suspend mode with the network interface
disabled, network layer calls ifdown() followed by cfg80211 layer
calling wl_cfg80211_suspend() which is registered as suspend handler
for cfg80211 layer.
ifdown() call ultimately funnels down to __wl_cfg80211_down() call
where WL_STATUS_READY bit is cleared via call to
"clear_bit(WL_STATUS_READY, &wl->status)"
But CHECK_SYS_UP()checks WL_STATUS_READY bit thinking it's not ready
and returns -EIO from suspend handler which intern prevents entering
into system suspend state
CHECK_SYS_UP() is mainly used in the code path where upper layer would
request certain wifi related activity to be performed by the firmware,
where this calls helps to make sure our firmware would be in ready
state to respond to those requests
But in the case of wl_cfg80211_suspend() code path there is no need to
check for firmware status for any reason
Signed-off-by: Dowan Kim <dowan@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
wwang [Fri, 4 Mar 2011 02:56:36 +0000 (10:56 +0800)]
staging: rts_pstor: fix a bug that a greenhouse sd card can't be recognized
A greenhouse sd card can't be recognized using rts5209.
To fix this bug, these modifications are applied:
1, Move some codes which clear sd internal variables from sd_init_type to
sd_prepare_reset. So sd_init_type is useless any more and is removed
entirely;
2, If a sd card can't pass sd3.0 mode, the action of tunning phase should be
avoided when retrying sd2.0 mode.
Signed-off-by: wwang <wei_wang@realsil.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mark Allyn [Fri, 4 Mar 2011 00:38:28 +0000 (16:38 -0800)]
staging: sep: remove unused ioctls
Also remove associated functions, structures, and defines
Signed-off-by: Mark Allyn <mark.a.allyn@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
huajun li [Fri, 4 Mar 2011 02:56:18 +0000 (10:56 +0800)]
Staging: Merge ENE UB6250 SD card codes from keucr to drivers/usb/storage
The usb portion of this driver can now go into drivers/usb/storage.
This leaves the non-usb portion of the code still in staging.
Signed-off-by: Huajun Li <huajun.li.lee@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:47:41 +0000 (22:47 +0900)]
staging: rtl8192e: unused Remove dot11PowerSaveMode and RT_PS_MODE
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:47:29 +0000 (22:47 +0900)]
staging: rtl8192e: Move card specific structures out of ieee80211 library header
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:47:16 +0000 (22:47 +0900)]
staging: rtl8192e: Delete unused members from struct r8192_priv
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:46:42 +0000 (22:46 +0900)]
staging: rtl8192e: Delete non-existing function declarations
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:46:32 +0000 (22:46 +0900)]
staging: rtl8192e: Delete unused dm_change_dynamic_initgain_thresh
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:46:17 +0000 (22:46 +0900)]
staging: rtl8192e: Pass r8192_priv to MgntActSet_RF_State
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:46:04 +0000 (22:46 +0900)]
staging: rtl8192e: Pass r8192_priv around instead of net_device
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:45:54 +0000 (22:45 +0900)]
staging: rtl8192e: Remove redundant function declarations
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:45:42 +0000 (22:45 +0900)]
staging: rtl8192e: Pass r8192_priv around instead of net_device
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:45:24 +0000 (22:45 +0900)]
staging: rtl8192e: Convert more functions to use r8192_priv
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:45:08 +0000 (22:45 +0900)]
staging: rtl8192e: Pass r8192e_priv to phy functions
Phy functions shouldn't be associated with net_device.
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:44:58 +0000 (22:44 +0900)]
staging: rtl8192e: Pass r8192_priv to eprom_read
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:44:47 +0000 (22:44 +0900)]
staging: rtl8192e: Move PowerSaveControl to r8192e_priv
This variable is not used by the ieee80211 library, so
move it rtl8192e's private struct.
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:44:37 +0000 (22:44 +0900)]
staging: rtl8192e: Move variables to ieee80211 struct
Move variables only accessed by the RTL ieee80211 library into its
private struct.
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:44:28 +0000 (22:44 +0900)]
staging: rtl8192e: Move definition of RT_RF_CHANGE_SOURCE
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:41:53 +0000 (22:41 +0900)]
staging: rtl8192e: Move RfOffReason to r8192e_priv struct
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:41:35 +0000 (22:41 +0900)]
staging: rtl8192e: Move eRFPowerState to r8192e_priv struct
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:41:25 +0000 (22:41 +0900)]
staging: rtl8192e: Remove pointless hw_sleep_wq
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:41:12 +0000 (22:41 +0900)]
staging: rtl8192e: Remove unnecessary ps_lock
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:41:02 +0000 (22:41 +0900)]
staging: rtl8192e: Use single spinlock in MgntActSet_RF_State
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:40:52 +0000 (22:40 +0900)]
staging: rtl8192e: Remove SetRFPowerState
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:40:41 +0000 (22:40 +0900)]
staging: rtl8192e: Remove SetRFPowerStateInProgress
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike McCormack [Thu, 3 Mar 2011 13:40:30 +0000 (22:40 +0900)]
staging: rtl8192e: Add a spinlock around SetRFPowerState8190
Signed-off-by: Mike McCormack <mikem@ring3k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Marek Belisko [Thu, 3 Mar 2011 12:38:17 +0000 (12:38 +0000)]
staging: gma500: fix build errors
This patch will fix following compilation error:
drivers/staging/gma500/psb_drv.c:1635: error: unknown field ‘pci_driver’ specified in initializer
drivers/staging/gma500/psb_drv.c:1636: error: unknown field ‘name’ specified in initializer
drivers/staging/gma500/psb_drv.c:1636: warning: initialization from incompatible pointer type
drivers/staging/gma500/psb_drv.c:1637: error: unknown field ‘id_table’ specified in initializer
drivers/staging/gma500/psb_drv.c:1637: warning: excess elements in union initializer
drivers/staging/gma500/psb_drv.c:1637: warning: (near initialization for ‘driver.kdriver’)
drivers/staging/gma500/psb_drv.c:1638: error: unknown field ‘resume’ specified in initializer
drivers/staging/gma500/psb_drv.c:1638: warning: excess elements in union initializer
drivers/staging/gma500/psb_drv.c:1638: warning: (near initialization for ‘driver.kdriver’)
drivers/staging/gma500/psb_drv.c:1639: error: unknown field ‘suspend’ specified in initializer
drivers/staging/gma500/psb_drv.c:1639: warning: excess elements in union initializer
drivers/staging/gma500/psb_drv.c:1639: warning: (near initialization for ‘driver.kdriver’)
drivers/staging/gma500/psb_drv.c:1640: error: unknown field ‘probe’ specified in initializer
drivers/staging/gma500/psb_drv.c:1640: warning: excess elements in union initializer
drivers/staging/gma500/psb_drv.c:1640: warning: (near initialization for ‘driver.kdriver’)
drivers/staging/gma500/psb_drv.c:1641: error: unknown field ‘remove’ specified in initializer
drivers/staging/gma500/psb_drv.c:1641: warning: excess elements in union initializer
drivers/staging/gma500/psb_drv.c:1641: warning: (near initialization for ‘driver.kdriver’)
drivers/staging/gma500/psb_drv.c:1643: error: unknown field ‘driver’ specified in initializer
drivers/staging/gma500/psb_drv.c:1643: warning: excess elements in union initializer
drivers/staging/gma500/psb_drv.c:1643: warning: (near initialization for ‘driver.kdriver’)
drivers/staging/gma500/psb_drv.c: In function ‘psb_init’:
drivers/staging/gma500/psb_drv.c:1664: error: implicit declaration of function ‘drm_init’
drivers/staging/gma500/psb_drv.c: In function ‘psb_exit’:
drivers/staging/gma500/psb_drv.c:1669: error: implicit declaration of function ‘drm_exit’
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Alan Cox [Thu, 3 Mar 2011 12:38:04 +0000 (12:38 +0000)]
staging: gma500: Resync the patch queue with GregKH's space cleanup.
Remove all sorts of bits we can get rid of. We are now a very simple KMS
driver relying on the stolen memory for our framebuffer base (which is for
the moment hardcoded).
To support multiple frame buffers and some accel bits we will need some kind
of memory allocator, possibly a minimal use of GEM.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jonathan Neuschäfer [Thu, 3 Mar 2011 13:25:08 +0000 (14:25 +0100)]
staging: keucr: use kernel byteorder functions
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-by: Jack Stone <jwjstone@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jonathan Neuschäfer [Thu, 3 Mar 2011 13:25:07 +0000 (14:25 +0100)]
staging: keucr: remove unused typedef VOID
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Tomas Winkler [Wed, 2 Mar 2011 22:10:51 +0000 (00:10 +0200)]
staging/easycap: convert comparison to NULL into boolean
convert if (NULL != ptr) to if (ptr)
convert if (NULL == ptr) to if (!ptr)
Cc: Mike Thomas <rmthomas@sciolus.org>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Tomas Winkler [Wed, 2 Mar 2011 22:10:50 +0000 (00:10 +0200)]
staging/easycap: replace if(false == var) with if (!var)
's/(false == \([^ ]\+\))/(!\1)/g'
Cc: Mike Thomas <rmthomas@sciolus.org>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Tomas Winkler [Wed, 2 Mar 2011 22:10:49 +0000 (00:10 +0200)]
staging/easycap: replace if(true == var) with if (var)
's/(true == \([^ ]\+\))/(\1)/g'
Cc: Mike Thomas <rmthomas@sciolus.org>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Tomas Winkler [Wed, 2 Mar 2011 22:10:48 +0000 (00:10 +0200)]
staging/easycap: more style fixing in easycap_main.c
mostly indentation fixes and some line over 80 characters fixes
Cc: Mike Thomas <rmthomas@sciolus.org>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aaro Koskinen [Wed, 2 Mar 2011 22:26:35 +0000 (00:26 +0200)]
staging: xgifb: remove private ioctls
Drop the badly defined and broken private ioctl interface. Since the
driver is in staging, and some of the ioctls are clearly unsafe or not
even working, it's unlikely that there are any users.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Thomas Viehweger [Wed, 2 Mar 2011 22:00:20 +0000 (23:00 +0100)]
staging: lirc: fix for "lirc_dev: lirc_register_driver: driver pointer must be not NULL!"
Unable to load the module lirc_parallel without the attached patch.
Signed-off-by: Thomas Viehweger <patchesThomas.Vie@web.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:45:17 +0000 (19:45 -0800)]
Staging: hv: hv_mouse: remove unneeded function forward declaration
When the code moved around earlier, this function declaration should
have been removed but it wasn't. Resolve that.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:44:13 +0000 (19:44 -0800)]
Staging: hv: hv_mouse: fix up guid variable name
It wasn't a global either, yet it was called one for some reason...
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:42:19 +0000 (19:42 -0800)]
Staging: hv: hv_mouse: get rid of hungarian notation for name of the module
And, it's not even a global, so the original creator got the Hungarian
notation wrong! {sigh}
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:41:00 +0000 (19:41 -0800)]
Staging: hv: hv_mouse: fix up camelcase fields in struct mousevsc_prt_msg
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:39:48 +0000 (19:39 -0800)]
Staging: hv: hv_mouse: fix up camelcase usage in struct pipe_prt_msg
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:38:29 +0000 (19:38 -0800)]
Staging: hv: hv_mouse: fix up pipe size field name
Make it not camelcase.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:36:15 +0000 (19:36 -0800)]
Staging: hv: hv_mouse: fix up camelcase use for enum pipe_prot_msg_type in structures
It's a type, so call it that.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:33:17 +0000 (19:33 -0800)]
Staging: hv: hv_mouse: use an anonymous union for struct mousevsc_prt_msg
Much nicer than having an ugly 'u.' in the structure usage, welcome to
the 2000's...
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:31:39 +0000 (19:31 -0800)]
Staging: hv: hv_mouse: clean up camelcase in struct synthhid_input_report
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:29:42 +0000 (19:29 -0800)]
Staging: hv: hv_mouse: fix camelcase in struct synthhid_device_info_ack
Just one field to fix up, s/Reserved/reserved/g
Odd that we have to set the reserved field to 0 when we send the
message, that would imply that it really isn't "reserved"...
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:27:17 +0000 (19:27 -0800)]
Staging: hv: hv_mouse: use a real struct hid_descriptor
The data coming from the vmbus is really a hid descriptor, so use that
structure instead of having to mess around with a character array and
pointer fun.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:24:05 +0000 (19:24 -0800)]
Staging: hv: hv_mouse: clean up camelcase when using struct hv_input_dev_info
I think there's a callback we can remove that uses this variable in the
future as well, but that's for another patch...
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:19:58 +0000 (19:19 -0800)]
Staging: hv: hv_mouse: clean up camelcase in struct synthhid_protocol_response
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:18:34 +0000 (19:18 -0800)]
Staging: hv: hv_mouse: clean up version structure usage
Turns out no one uses the major or minor fields, but hey, we'll keep
them around just to make people feel happy...
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:11:49 +0000 (19:11 -0800)]
Staging: hv: hv_mouse: change camelcase for struct synthhid_msg
Turns out no one references the data field of this structure, so I
wonder if it's really even needed at all. All this is used for is the
type of the message here, so this structure might be able to be dropped
entirely in the future.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:08:05 +0000 (19:08 -0800)]
Staging: hv: hv_mouse: fix build warning
The trans_id variable (u64) was being incorrectly cast to a unsigned
long * when it should have just been unsigned long.
Fun with pointers, what a fricken mess, we need some real type safety
for these types of fields somehow...
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:04:09 +0000 (19:04 -0800)]
Staging: hv: hv_mouse: fix camelcase use of struct synthhid_msg_hdr
s/Header/header/g for this structure when it is used in the file.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 03:01:49 +0000 (19:01 -0800)]
Staging: hv: hv_mouse.c: clean up struct synthhid_msg_hdr
Use non-CamelCase names for this structure.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 02:58:35 +0000 (18:58 -0800)]
Staging: hv: hv_mouse: use proper input define for bus type
The code was so close, the bus type was in a comment, so go all the way
and actually use the define here. It's as if the original author was so
afraid of license issues if they referenced a define in the processed
code but they felt safe to keep it in a comment. Chicken.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 02:57:04 +0000 (18:57 -0800)]
Staging: hv: hv_mouse: fix up input device info structure
Make the name "hv_" specific as it's not an input layer structure we are
dealing with here. Also rename the fields to be not CamelCase.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 02:50:15 +0000 (18:50 -0800)]
Staging: hv: hv_mouse: reorder functions to remove forward declarations
This removes almost all forward declarations and makes all functions
static, as there should not be any global functions in this module at
all.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 02:40:16 +0000 (18:40 -0800)]
Staging: hv: hv_mouse: remove inline function markings
They are totally useless here, so remove them.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 02:38:31 +0000 (18:38 -0800)]
Staging: hv: hv_mouse.c: remove struct mousevsc_drv_obj function callbacks
They aren't needed at all either because they are never called (OnOpen,
OnClose), or because we can just call the real function instead as it's
never set to anything else.
Just another step in unwinding the callback mess...
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 02:28:52 +0000 (18:28 -0800)]
Staging: hv: hv_mouse: unwind the initialization process a bit
This unwinds the init call sequence a bit, as we don't need a callback
pointer for a function that is already in this file.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 02:21:01 +0000 (18:21 -0800)]
Staging: hv: hv_mouse: remove typedefs
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:57:51 +0000 (17:57 -0800)]
Staging: hv: delete mousevsc_api.h
This file is only used by one .c file (hv_mouse.c) so just move the
whole thing into that file.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:53:58 +0000 (17:53 -0800)]
Staging: hv: delete vmbus_hid_protocol.h
The .h file is not needed as only one .c file uses it, so just move
it into that file.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:49:30 +0000 (17:49 -0800)]
Staging: hv: hv_mouse: fix up copyright and license header
Use the proper license header from the other hv drivers and remove the
nonsense about derivative works, as it's rubbish.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:46:00 +0000 (17:46 -0800)]
Staging: hv: hv_mouse: rename hv_mouse_drv.c
As there's only one file for this driver, just name it the same
as the end module name, saving one build/link step and making it
simpler in the end.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:42:50 +0000 (17:42 -0800)]
Staging: hv: hv_mouse: delete mouse_vsc.c
Move the mouse_vsc.c file into hv_mouse_drv.c as it makes
no sense to have two files here, as we don't have to worry about the
"closed vs. open" split that this code was originally written for.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:33:26 +0000 (17:33 -0800)]
Staging: hv: mouse_vsc: fix comment coding style
Also mark this as a nice FIXME as we shouldn't ever
care about the value of an atomic variable, which makes me seriously
doubt the validity of this reference counting code. Odds are it can be
ripped out completly, or at the very least, converted to using a kref.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:31:05 +0000 (20:31 -0500)]
Staging: hv: mouse_vsc: fix space coding style issues
Lots of minor space cleanups to resolve coding style warnings and
errors.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:23:33 +0000 (20:23 -0500)]
Staging: hv: mouse_vsc.c: fix brace coding style issues
Minor brace coding style issue cleanups.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:19:05 +0000 (20:19 -0500)]
Staging: hv: hv_mouse_drv.c: minor coding style cleanups
Knock off some of the simple coding style issues in this file
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Thu, 3 Mar 2011 01:15:14 +0000 (20:15 -0500)]
Staging: hv: enable mouse driver to build
But we disable it from automatically loading as that would
be bad. This way people can build it easier and start cleaning
it up, as it needs it.
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:49 +0000 (21:18 +0100)]
staging: brcm80211: remove osl source files from driver
The whole need for the OSL concept has been removed from the driver. This
is the final commit removing the source file and include file from the
driver repository. All include statements of osl.h have been removed from
the other source files.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:48 +0000 (21:18 +0100)]
staging: brcm80211: remove struct osl_info from driver sources
The struct osl_info was being used only in attach functions but
previous changes make the entire usage of this structure obsolete.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:47 +0000 (21:18 +0100)]
staging: brcm80211: remove struct osl_info from function prototypes
A couple of functions with struct osl_info do not use this parameter
so it is removed from the function prototypes.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:46 +0000 (21:18 +0100)]
staging: brcm80211: remove counting of allocated sk_buff packets
The function pkt_buf_get_skb and pkt_buf_free_skb were using struct
osl_info field pktalloced to maintain counter of buffers in use in
the driver. It was decided to remove this facility. The prototypes
of these functions have been modified and the calling code adapted.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:45 +0000 (21:18 +0100)]
staging: brcm80211: remove of type definition osldma_t
The usage of variable of this type is not required so its use has
been removed from the driver.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:44 +0000 (21:18 +0100)]
staging: brcm80211: cleanup declaration in osl.h
Several declarations and macro definitions in osl.h are still needed
and therefore moved to bcmutils.h or hnddma.h. The osl_assert function
is moved to bcmutils.c accordingly.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:43 +0000 (21:18 +0100)]
staging: brcm80211: remove unused attributes from struct osl_info
Getting rid of the whole osl concept soon this removes most fields
in struct osl_info. Turned out hnddma.c was still using it so this
was fixed and now it gets pointer to bus device from si_info which
it only needs in the attach function for this purpose so reference
to it does not need to be kept. Two unused functions referencing
the removed fields in linux_osl.c also were removed.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:42 +0000 (21:18 +0100)]
staging: brcm80211: removed struct osl_info usage from fullmac driver
Several occurrences in fullmac using struct osl_info could be removed.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:41 +0000 (21:18 +0100)]
staging: brcm80211: remove function prototypes from wl_export.h
The include file wl_export.h contained several function prototypes
(and one macro defintion) that were not used or implemented within
the driver.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:40 +0000 (21:18 +0100)]
staging: brcm80211: move frameid initialization in wlc_d11hdrs_mac80211
Minor esthetical change to do initialization immediately at declaration.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:39 +0000 (21:18 +0100)]
staging: brcm80211: remove osl_info usage in wlc_main and wl_mac80211
Getting rid of osl concept taking small steps. This commit removes
it from wlc_main.c and wl_mac80211.c.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:38 +0000 (21:18 +0100)]
staging: brcm80211: remove struct osl_info usage from phy sources
Getting rid of osl concept taking small steps. This commit removes
it from source files in brcm80211/brcmsmac/phy directory.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 20:18:37 +0000 (21:18 +0100)]
staging: brcm80211: remove struct osl_info usage from wlc_bmac
Getting rid of osl concept taking small steps. This commit removes
it from wlc_bmac.c.
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Reviewed-by: Henry Ptasinski <henryp@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 16:01:37 +0000 (17:01 +0100)]
staging: brcm80211: replace simple_strtoul with strict_strtoul
By checkpatch recommendation using strict_strtoul now.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arend van Spriel [Wed, 2 Mar 2011 08:08:43 +0000 (09:08 +0100)]
staging: brcm80211: changed module wlc_mac80211 to wlc_main
The source and include file for the wlc_mac80211 module has been
renamed to wlc_main and subsequently the include statement in
other source files. This module provides the main interface towards
wl_mac80211 module.
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Brett Rudley <brudley@broadcom.com>
Signed-off-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jonathan Neuschäfer [Tue, 1 Mar 2011 22:58:54 +0000 (23:58 +0100)]
staging: echo: fix a typo ("overflow")
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arnd Bergmann [Tue, 1 Mar 2011 23:13:05 +0000 (00:13 +0100)]
staging/usbip: convert to kthread
usbip has its own infrastructure for managing kernel
threads, similar to kthread. By changing it to use
the standard functions, we can simplify the code
and get rid of one of the last BKL users at the
same time.
Includes changes suggested by Max Vozeler.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Takahiro Hirofuchi <hirofuchi@users.sourceforge.net>
Cc: Max Vozeler <max@vozeler.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Philip Worrall [Wed, 2 Mar 2011 14:34:45 +0000 (14:34 +0000)]
Staging: vt6656: Clean up switching to power saving mode.
When switching to power saving mode we only need to notify
the receiver when in infrastructure mode.
Signed-off-by: Philip Worrall <philip.worrall@googlemail.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Philip Worrall [Wed, 2 Mar 2011 17:36:35 +0000 (17:36 +0000)]
Staging: vt6656: Ensure power.c uses proper tabbing.
Simplify setting of power state in power.c when sending power
state notifications to the access point.
Signed-off-by: Philip Worrall <philip.worrall at googlemail.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Philip Worrall [Wed, 2 Mar 2011 14:34:43 +0000 (14:34 +0000)]
Staging: vt6656: Clean up spaces around parenthesized expressions
Clean up a number of places where unneeded spaces are used around
expressions.
Signed-off-by: Philip Worrall <philip.worrall@googlemail.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Philip Worrall [Wed, 2 Mar 2011 14:34:42 +0000 (14:34 +0000)]
Staging: vt6656: Clean up return from sending power state notifications
Clean up power.c so that unnecessary final return statements
are not used when sending power state notifications to
the access point.
Signed-off-by: Philip Worrall <philip.worrall@googlemail.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Philip Worrall [Wed, 2 Mar 2011 14:34:41 +0000 (14:34 +0000)]
Staging: vt6656: Clean up unneccessary braces in power.c
Clean up some unnecessary braces for conditional statements
where a single statement will do.
Signed-off-by: Philip Worrall <philip.worrall@googlemail.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Philip Worrall [Wed, 2 Mar 2011 14:34:40 +0000 (14:34 +0000)]
Staging: vt6656: Use C89 comments in power.c
Reformat the comments in power.c to use the C89 commenting
style instead of the C99 commenting style.
Signed-off-by: Philip Worrall <philip.worrall@googlemail.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>