GitHub/WoltLab/WCF.git
2 years agoCleaned up the user menu, extra profile link
Alexander Ebert [Wed, 20 Apr 2022 13:05:51 +0000 (15:05 +0200)]
Cleaned up the user menu, extra profile link

2 years agoMerge pull request #4744 from WoltLab/deprecate-fetchRemoteAvatar
Alexander Ebert [Wed, 20 Apr 2022 12:21:34 +0000 (14:21 +0200)]
Merge pull request #4744 from WoltLab/deprecate-fetchRemoteAvatar

Deprecate UserAvatarAction::fetchRemoteAvatar()

2 years agoDeprecate UserAvatarAction::fetchRemoteAvatar()
Tim Düsterhus [Wed, 20 Apr 2022 10:56:56 +0000 (12:56 +0200)]
Deprecate UserAvatarAction::fetchRemoteAvatar()

2 years agoAdd `@since` to UserProfileAction::setAvatar()
Tim Düsterhus [Wed, 20 Apr 2022 10:53:58 +0000 (12:53 +0200)]
Add `@since` to UserProfileAction::setAvatar()

see 7448a453886e504eaa1d70e8a39bbb1fad14dd42
see #4583

2 years agoProperly check permissions for the `systemIdMismatch` message in acp/index.tpl
Tim Düsterhus [Tue, 19 Apr 2022 13:49:35 +0000 (15:49 +0200)]
Properly check permissions for the `systemIdMismatch` message in acp/index.tpl

2 years agoMerge pull request #4739 from SoftCreatR/patch-4
Alexander Ebert [Tue, 19 Apr 2022 12:37:48 +0000 (14:37 +0200)]
Merge pull request #4739 from SoftCreatR/patch-4

Remove cursive font in quotes

2 years agoUpdating minified JavaScript files 5.5.0_Alpha_1
WoltLab [Tue, 19 Apr 2022 08:46:09 +0000 (08:46 +0000)]
Updating minified JavaScript files

2 years agoMerge branch '5.4'
joshuaruesweg [Tue, 19 Apr 2022 08:18:50 +0000 (10:18 +0200)]
Merge branch '5.4'

2 years agoFix fetching userID for multilanguage articles
joshuaruesweg [Tue, 19 Apr 2022 08:18:31 +0000 (10:18 +0200)]
Fix fetching userID for multilanguage articles

2 years agoMerge remote-tracking branch 'origin/master'
Tim Düsterhus [Tue, 19 Apr 2022 07:05:30 +0000 (09:05 +0200)]
Merge remote-tracking branch 'origin/master'

2 years agoMerge branch '5.4'
Tim Düsterhus [Tue, 19 Apr 2022 07:05:06 +0000 (09:05 +0200)]
Merge branch '5.4'

2 years agoUse spaces instead of tabs
joshuaruesweg [Mon, 18 Apr 2022 08:36:19 +0000 (10:36 +0200)]
Use spaces instead of tabs

2 years agoPrevent firing notifications for awarding own trophies
joshuaruesweg [Mon, 18 Apr 2022 08:31:40 +0000 (10:31 +0200)]
Prevent firing notifications for awarding own trophies

2 years agoRemoved cursive font in quotes
Sascha Greuel [Sun, 17 Apr 2022 13:27:45 +0000 (15:27 +0200)]
Removed cursive font in quotes

See https://www.woltlab.com/community/thread/295216-kursivschrift-in-zitaten-entfernen

2 years agoRelease 5.4.16 5.4.16
Alexander Ebert [Thu, 14 Apr 2022 14:57:41 +0000 (16:57 +0200)]
Release 5.4.16

2 years agoMerge branch '5.3' into 5.4
Alexander Ebert [Thu, 14 Apr 2022 14:47:23 +0000 (16:47 +0200)]
Merge branch '5.3' into 5.4

2 years agoRelease 5.3.22 5.3.22
Alexander Ebert [Thu, 14 Apr 2022 14:45:23 +0000 (16:45 +0200)]
Release 5.3.22

2 years agoMerge branch '5.4'
Alexander Ebert [Thu, 14 Apr 2022 14:25:09 +0000 (16:25 +0200)]
Merge branch '5.4'

2 years agoRemoved the outdated `CONTRIBUTING.md`
Alexander Ebert [Thu, 14 Apr 2022 14:25:02 +0000 (16:25 +0200)]
Removed the outdated `CONTRIBUTING.md`

The file is heavily outdated and badly presented on GitHub. With WoltLab Suite 5.4 we switched to PSR-12 and Prettier anyway, so there is no need to explain any special rules.

Closes #4600

2 years agoMerge branch '5.4'
Marcel Werk [Thu, 14 Apr 2022 12:26:35 +0000 (14:26 +0200)]
Merge branch '5.4'

2 years agoAttached images with mismatched proportions got mangled
Marcel Werk [Thu, 14 Apr 2022 12:26:23 +0000 (14:26 +0200)]
Attached images with mismatched proportions got mangled

2 years agoMerge pull request #4737 from WoltLab/exclusion-check-install
Tim Düsterhus [Thu, 14 Apr 2022 12:17:41 +0000 (14:17 +0200)]
Merge pull request #4737 from WoltLab/exclusion-check-install

Always check exclusions in PackageUpdateAction::createQueue()

2 years agoAlways check exclusions in PackageUpdateAction::createQueue()
Tim Düsterhus [Thu, 14 Apr 2022 10:23:15 +0000 (12:23 +0200)]
Always check exclusions in PackageUpdateAction::createQueue()

Ever since the method checked for package exclusions in
1d7f1d205ee64fd2723877c1f296c592518e516d it only applied the check to updates,
not to fresh installs. It's not clear why it did so, I assume this to be an
oversight.

Change this to always run the exclusion check, otherwise exclusions might be
circumvented using PackageUpdateAction::prepareInstallation() with a
package+version combination that would regularly be excluded.

2 years agoImprove types in Acp/Ui/Package/QuickInstallation.ts
Tim Düsterhus [Thu, 14 Apr 2022 10:20:33 +0000 (12:20 +0200)]
Improve types in Acp/Ui/Package/QuickInstallation.ts

2 years agoFix error handling in Acp/Ui/Package/QuickInstallation.ts
Tim Düsterhus [Thu, 14 Apr 2022 10:18:22 +0000 (12:18 +0200)]
Fix error handling in Acp/Ui/Package/QuickInstallation.ts

2 years agoMerge branch '5.4'
Tim Düsterhus [Thu, 14 Apr 2022 09:55:42 +0000 (11:55 +0200)]
Merge branch '5.4'

2 years agoAdd missing trailing comma in PackageUpdateDispatcher
Tim Düsterhus [Thu, 14 Apr 2022 09:54:49 +0000 (11:54 +0200)]
Add missing trailing comma in PackageUpdateDispatcher

see cdffd4c7fc6b55e7b131274b8050ddd6f8cb200b

2 years agoEnsure that the `version` array key is always set for excludes in package update...
Tim Düsterhus [Thu, 14 Apr 2022 09:50:18 +0000 (11:50 +0200)]
Ensure that the `version` array key is always set for excludes in package update XML processing

see 1996ec7a0df649b27bffbf150d8ddbc0131ce6db

2 years agoEmpty code boxes partially collapsed the layout
Alexander Ebert [Thu, 14 Apr 2022 09:47:35 +0000 (11:47 +0200)]
Empty code boxes partially collapsed the layout

See https://www.woltlab.com/community/thread/295182-leere-code-box-ist-kaputt/

2 years agoMerge pull request #4735 from WoltLab/rescue-mode-assets
Tim Düsterhus [Wed, 13 Apr 2022 08:55:41 +0000 (10:55 +0200)]
Merge pull request #4735 from WoltLab/rescue-mode-assets

Embed the assets as data URIs in rescueMode.tpl

2 years agoEmbed the assets as data URIs in rescueMode.tpl
Tim Düsterhus [Wed, 13 Apr 2022 08:06:35 +0000 (10:06 +0200)]
Embed the assets as data URIs in rescueMode.tpl

The same reasoning as for the change to WCFSetup in
600940bc4fe0cbc219ba6fd9a89444aefa07dda5 applies:

With this change the rescue mode is fully self-contained and does not rely on
external requests that need to be served using PHP, making it more resilient.

It also avoids the expensive rebuild of the compiled ACP CSS, because it now
uses the prebuilt WCFSetup.css which can be used as-is for this purpose.

2 years agoFix typo in en.xml
Tim Düsterhus [Wed, 13 Apr 2022 07:17:30 +0000 (09:17 +0200)]
Fix typo in en.xml

2 years agoMissing update of the compiled JavaScript files
Alexander Ebert [Tue, 12 Apr 2022 17:00:12 +0000 (19:00 +0200)]
Missing update of the compiled JavaScript files

2 years agoAllow out-of-band polling of notifications
Alexander Ebert [Tue, 12 Apr 2022 16:59:52 +0000 (18:59 +0200)]
Allow out-of-band polling of notifications

2 years agoRelease 5.4.16 dev 1 5.4.16_dev_1
Alexander Ebert [Tue, 12 Apr 2022 13:20:42 +0000 (15:20 +0200)]
Release 5.4.16 dev 1

2 years agoUpdating minified JavaScript files
WoltLab [Tue, 12 Apr 2022 12:39:44 +0000 (12:39 +0000)]
Updating minified JavaScript files

2 years agoRemoving an attachment did not purge copies
Alexander Ebert [Tue, 12 Apr 2022 12:32:56 +0000 (14:32 +0200)]
Removing an attachment did not purge copies

See https://www.woltlab.com/community/thread/295032-dateianh%C3%A4nge-aktualsieren-sich-nicht-beim-l%C3%B6schen/

2 years agoUpdating minified JavaScript files
WoltLab [Tue, 12 Apr 2022 09:53:44 +0000 (09:53 +0000)]
Updating minified JavaScript files

2 years agoMerge pull request #4734 from WoltLab/charset-title
Marcel Werk [Tue, 12 Apr 2022 09:38:45 +0000 (11:38 +0200)]
Merge pull request #4734 from WoltLab/charset-title

Move `<meta charset="utf-8">` from headInclude.tpl to header.tpl

2 years agoMove `<meta charset="utf-8">` from headInclude.tpl to header.tpl
Tim Düsterhus [Tue, 16 Feb 2021 13:22:28 +0000 (14:22 +0100)]
Move `<meta charset="utf-8">` from headInclude.tpl to header.tpl

see #3802
see #3998
see #4543

Co-authored-by: Sascha Moser <saschamoser1994@hotmail.de>
2 years agoMerge branch '5.4'
Tim Düsterhus [Mon, 11 Apr 2022 15:23:52 +0000 (17:23 +0200)]
Merge branch '5.4'

2 years agoOverlaying images discarded the transparency
Alexander Ebert [Mon, 11 Apr 2022 15:05:49 +0000 (17:05 +0200)]
Overlaying images discarded the transparency

See https://www.woltlab.com/community/thread/295124-imagickimageadapter-overlayen-zweier-bilder-mit-alpha-channel-entfernt-transpare/

2 years agoMark TUnsupportedDefaultValue as deprecated
Tim Düsterhus [Mon, 11 Apr 2022 14:04:13 +0000 (16:04 +0200)]
Mark TUnsupportedDefaultValue as deprecated

see #4733

2 years agoMerge pull request #4733 from WoltLab/php-ddl-default
Tim Düsterhus [Mon, 11 Apr 2022 14:01:58 +0000 (16:01 +0200)]
Merge pull request #4733 from WoltLab/php-ddl-default

Add IDefaultValueDatabaseTableColumn

2 years agoMerge branch '5.4'
Tim Düsterhus [Mon, 11 Apr 2022 14:01:29 +0000 (16:01 +0200)]
Merge branch '5.4'

2 years agoMerge pull request #4700 from WoltLab/54-disallow-default-value-for-blob-text
Alexander Ebert [Mon, 11 Apr 2022 14:00:58 +0000 (16:00 +0200)]
Merge pull request #4700 from WoltLab/54-disallow-default-value-for-blob-text

Disallow default values for BLOB and TEXT columns

2 years agoCheck for `IDefaultValueDatabaseTableColumn` in AbstractDatabaseTableColumn
Tim Düsterhus [Mon, 11 Apr 2022 12:14:48 +0000 (14:14 +0200)]
Check for `IDefaultValueDatabaseTableColumn` in AbstractDatabaseTableColumn

2 years agoExplicitly implement `IDefaultValueDatabaseTableColumn` in supported column types
Tim Düsterhus [Mon, 11 Apr 2022 12:14:19 +0000 (14:14 +0200)]
Explicitly implement `IDefaultValueDatabaseTableColumn` in supported column types

2 years agoImplement IDefaultValueDatabaseTableColumn by default in AbstractDatabaseTableColumn
Tim Düsterhus [Mon, 11 Apr 2022 12:13:28 +0000 (14:13 +0200)]
Implement IDefaultValueDatabaseTableColumn by default in AbstractDatabaseTableColumn

This is temporary to not break backwards compatibility.

2 years agoAdd IDefaultValueDatabaseTableColumn
Tim Düsterhus [Mon, 11 Apr 2022 12:11:50 +0000 (14:11 +0200)]
Add IDefaultValueDatabaseTableColumn

2 years agoAllow `null` in `TUnsupportedDefaultValue`
Tim Düsterhus [Mon, 11 Apr 2022 11:51:00 +0000 (13:51 +0200)]
Allow `null` in `TUnsupportedDefaultValue`

When fetching the column definition from the database MySQL will return `null`
as the default value for BLOB and TEXT column even if the column itself is
`NOT NULL`.

2 years agoIncorrect code formatting
Alexander Ebert [Mon, 11 Apr 2022 10:45:24 +0000 (12:45 +0200)]
Incorrect code formatting

2 years agoMissing cache reset after manually adding phrases
Alexander Ebert [Mon, 11 Apr 2022 10:41:36 +0000 (12:41 +0200)]
Missing cache reset after manually adding phrases

See https://www.woltlab.com/community/thread/295020-text-hinzuf%C3%BCgen-cache-wird-nicht-geleert/

2 years agoCreate/update page without box information resulted in error
Marcel Werk [Mon, 11 Apr 2022 09:01:36 +0000 (11:01 +0200)]
Create/update page without box information resulted in error

2 years agoMerge branch '5.4'
Tim Düsterhus [Fri, 8 Apr 2022 10:24:28 +0000 (12:24 +0200)]
Merge branch '5.4'

2 years agoRemove accidentally added space in MysqlSearchEngine
Tim Düsterhus [Fri, 8 Apr 2022 10:03:23 +0000 (12:03 +0200)]
Remove accidentally added space in MysqlSearchEngine

2 years agoDo not add the `+` prefix to search terms matching an InnoDB stop word
Tim Düsterhus [Fri, 8 Apr 2022 10:00:53 +0000 (12:00 +0200)]
Do not add the `+` prefix to search terms matching an InnoDB stop word

This is issue is effectively identical to the one fixed in commit
247d9cc51af9cd78395e2e7600bacbc2ffdf918b.

2 years agoUpdate composer dependencies
Tim Düsterhus [Thu, 7 Apr 2022 08:57:11 +0000 (10:57 +0200)]
Update composer dependencies

2 years agoMerge branch '5.4'
Tim Düsterhus [Thu, 7 Apr 2022 07:29:06 +0000 (09:29 +0200)]
Merge branch '5.4'

2 years agoFix code style in AbstractXMLPackageInstallationPlugin
Tim Düsterhus [Thu, 7 Apr 2022 07:28:30 +0000 (09:28 +0200)]
Fix code style in AbstractXMLPackageInstallationPlugin

2 years agoInstallation of nested elements (e.g. menu items) failed
Marcel Werk [Wed, 6 Apr 2022 15:50:17 +0000 (17:50 +0200)]
Installation of nested elements (e.g. menu items) failed

2 years agoUpdate update instructions for 5.5
Tim Düsterhus [Wed, 6 Apr 2022 13:29:26 +0000 (15:29 +0200)]
Update update instructions for 5.5

2 years agoDecouple HtmlInputProcessor::convertToHtml() from general-purpose HTML encoding ...
Tim Düsterhus [Wed, 6 Apr 2022 11:34:34 +0000 (13:34 +0200)]
Decouple HtmlInputProcessor::convertToHtml() from general-purpose HTML encoding (#4728)

Fixes #4717

Co-authored-by: Alexander Ebert <ebert@woltlab.com>
2 years agoIgnore prefixes that are not separated with a space in MysqlSearchEngine::splitIntoTe...
Tim Düsterhus [Wed, 6 Apr 2022 11:02:02 +0000 (13:02 +0200)]
Ignore prefixes that are not separated with a space in MysqlSearchEngine::splitIntoTerms()

2 years agoRemove unused import
joshuaruesweg [Wed, 6 Apr 2022 08:44:01 +0000 (10:44 +0200)]
Remove unused import

2 years agoUse internal class to mask IP addresses
joshuaruesweg [Wed, 6 Apr 2022 08:41:04 +0000 (10:41 +0200)]
Use internal class to mask IP addresses

2 years agoArticle teaser was incorrectly formatted when automatically generated from the articl...
Marcel Werk [Tue, 5 Apr 2022 14:06:13 +0000 (16:06 +0200)]
Article teaser was incorrectly formatted when automatically generated from the article content

2 years agoFixed wrong margin for content item images
Marcel Werk [Tue, 5 Apr 2022 13:59:00 +0000 (15:59 +0200)]
Fixed wrong margin for content item images

2 years agoBanning a user without entering an unbanning date leads to error message
Marcel Werk [Tue, 5 Apr 2022 09:20:31 +0000 (11:20 +0200)]
Banning a user without entering an unbanning date leads to error message

2 years agoDetect Firefox in Favico.js based on CSS
Alexander Ebert [Mon, 4 Apr 2022 17:08:41 +0000 (19:08 +0200)]
Detect Firefox in Favico.js based on CSS

See https://www.woltlab.com/community/thread/294994-verwendung-von-installtrigger-in-favico-js-vermeiden/

2 years agoVerify that the active dialog is closable
Alexander Ebert [Mon, 4 Apr 2022 17:01:12 +0000 (19:01 +0200)]
Verify that the active dialog is closable

See https://www.woltlab.com/community/thread/294867-verschachtelte-dialoge-verwerfen-optionen-des-1-dialogs/

2 years agoRemoved obsolete method calls of deprecated method
Alexander Ebert [Mon, 4 Apr 2022 13:47:47 +0000 (15:47 +0200)]
Removed obsolete method calls of deprecated method

See #4718

2 years agoRemoved unused code from WSC <3.0
Alexander Ebert [Mon, 4 Apr 2022 13:46:30 +0000 (15:46 +0200)]
Removed unused code from WSC <3.0

See #4718

2 years agoMerge pull request #4714 from WoltLab/5.5-fix-ci-file-delete
Joshua Rüsweg [Mon, 4 Apr 2022 13:16:56 +0000 (15:16 +0200)]
Merge pull request #4714 from WoltLab/5.5-fix-ci-file-delete

Make FileDeletePIP safe for ci file systems

2 years agoMake FileDeletePIP safe for ci file systems
joshuaruesweg [Wed, 30 Mar 2022 12:55:03 +0000 (14:55 +0200)]
Make FileDeletePIP safe for ci file systems

2 years agoAdded file archive for the upgrade
Alexander Ebert [Mon, 4 Apr 2022 12:47:00 +0000 (14:47 +0200)]
Added file archive for the upgrade

The current package builder does not handle dynamic files nicely.

2 years agoMerge pull request #4713 from WoltLab/content-language-filtering
Marcel Werk [Mon, 4 Apr 2022 11:22:43 +0000 (13:22 +0200)]
Merge pull request #4713 from WoltLab/content-language-filtering

Option to filter notifications by content language settings

2 years agoAdded parameter documentation
Marcel Werk [Mon, 4 Apr 2022 11:17:02 +0000 (13:17 +0200)]
Added parameter documentation

2 years agoApply suggestions from code review
Marcel Werk [Mon, 4 Apr 2022 11:14:42 +0000 (13:14 +0200)]
Apply suggestions from code review

Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
2 years agoMerge branch '5.4'
joshuaruesweg [Mon, 4 Apr 2022 07:09:43 +0000 (09:09 +0200)]
Merge branch '5.4'

2 years agoUpdate google console link
Sir-Will [Sun, 3 Apr 2022 01:19:51 +0000 (03:19 +0200)]
Update google console link

Closes #4716

2 years agoCheck permissions before redirecting to the canonical URL
Marcel Werk [Thu, 31 Mar 2022 12:11:15 +0000 (14:11 +0200)]
Check permissions before redirecting to the canonical URL

Redirecting to the Canonical URL can lead to information disclosure, for example, if the URL contains the title of the object. Therefore, it is important to check the permissions before redirecting.

2 years agoMerge branch '5.4'
Marcel Werk [Thu, 31 Mar 2022 12:06:21 +0000 (14:06 +0200)]
Merge branch '5.4'

2 years agoArticle system allowed access to titles of hidden articles
Marcel Werk [Thu, 31 Mar 2022 12:05:56 +0000 (14:05 +0200)]
Article system allowed access to titles of hidden articles

The problem was caused by a redirect to the Canonical URL before the permissions were checked.

2 years agoRemoved duplicate paragraph in privacy policy
Marcel Werk [Thu, 31 Mar 2022 09:10:36 +0000 (11:10 +0200)]
Removed duplicate paragraph in privacy policy

2 years agoUpdated privacy policy
Marcel Werk [Wed, 30 Mar 2022 14:41:02 +0000 (16:41 +0200)]
Updated privacy policy

* Renamed Facebook to Meta Platforms
* Add new sections about:
** Storage duration
** General information on the legal basis for the data processing
** Information on data transfer to the USA and other non-EU countries

2 years agoUse 'do not track' option for vimeo videos
Marcel Werk [Wed, 30 Mar 2022 13:48:56 +0000 (15:48 +0200)]
Use 'do not track' option for vimeo videos

2 years agoMerge pull request #4712 from WoltLab/5.5-eventlistener-validation
Joshua Rüsweg [Tue, 29 Mar 2022 15:21:53 +0000 (17:21 +0200)]
Merge pull request #4712 from WoltLab/5.5-eventlistener-validation

Enforce unique names for XML PIPs

2 years agoOption to filter notifications by content language settings
Marcel Werk [Tue, 29 Mar 2022 14:38:40 +0000 (16:38 +0200)]
Option to filter notifications by content language settings

2 years agoFloating of attachments in simplified HTML did not work properly
Marcel Werk [Tue, 29 Mar 2022 12:36:13 +0000 (14:36 +0200)]
Floating of attachments in simplified HTML did not work properly

2 years agoMerge branch '5.4'
Marcel Werk [Tue, 29 Mar 2022 12:11:49 +0000 (14:11 +0200)]
Merge branch '5.4'

2 years agoIncorrect handling of GIF cover photos when rebuilding users
Marcel Werk [Tue, 29 Mar 2022 12:01:36 +0000 (14:01 +0200)]
Incorrect handling of GIF cover photos when rebuilding users

2 years agoFix typo
joshuaruesweg [Mon, 28 Mar 2022 12:32:41 +0000 (14:32 +0200)]
Fix typo

2 years agoFix registration with local IPv6 address
joshuaruesweg [Mon, 28 Mar 2022 12:31:26 +0000 (14:31 +0200)]
Fix registration with local IPv6 address

Fixes #4689

2 years agoEnforce unique names for userprofilemenus
joshuaruesweg [Mon, 28 Mar 2022 09:02:24 +0000 (11:02 +0200)]
Enforce unique names for userprofilemenus

2 years agoEnforce unique names for smileys
joshuaruesweg [Mon, 28 Mar 2022 09:02:15 +0000 (11:02 +0200)]
Enforce unique names for smileys

2 years agoEnforce unique names for pages
joshuaruesweg [Mon, 28 Mar 2022 09:02:08 +0000 (11:02 +0200)]
Enforce unique names for pages

2 years agoEnforce unique names for objectTypeDefinitions
joshuaruesweg [Mon, 28 Mar 2022 09:02:00 +0000 (11:02 +0200)]
Enforce unique names for objectTypeDefinitions

2 years agoEnforce unique names for menu
joshuaruesweg [Mon, 28 Mar 2022 09:01:46 +0000 (11:01 +0200)]
Enforce unique names for menu

2 years agoEnforce unique names for menuitem
joshuaruesweg [Mon, 28 Mar 2022 09:01:40 +0000 (11:01 +0200)]
Enforce unique names for menuitem