GitHub/WoltLab/WCF.git
2 years agoAdd \wcf\http\Pipeline and \wcf\http\RequestHandlerMiddleware
Tim Düsterhus [Thu, 19 May 2022 14:01:42 +0000 (16:01 +0200)]
Add \wcf\http\Pipeline and \wcf\http\RequestHandlerMiddleware

2 years agoSupport `RequestHandlerInterface`-based controllers in `wcf\system\request\Request`
Tim Düsterhus [Thu, 19 May 2022 13:15:16 +0000 (15:15 +0200)]
Support `RequestHandlerInterface`-based controllers in `wcf\system\request\Request`

2 years agoImplement `Psr\Http\Message\ServerRequestInterface` in `wcf\system\request\Request`
Tim Düsterhus [Thu, 19 May 2022 13:13:48 +0000 (15:13 +0200)]
Implement `Psr\Http\Message\ServerRequestInterface` in `wcf\system\request\Request`

2 years agoMark `\wcf\system\request\Request` as final
Tim Düsterhus [Thu, 19 May 2022 13:10:21 +0000 (15:10 +0200)]
Mark `\wcf\system\request\Request` as final

2 years agoRemove obsolete check for `ResponseInterface` in RequestHandler::handle()
Tim Düsterhus [Thu, 19 May 2022 12:53:17 +0000 (14:53 +0200)]
Remove obsolete check for `ResponseInterface` in RequestHandler::handle()

2 years agoReturn LegacyPlaceholderResponse from `Request::execute()`
Tim Düsterhus [Thu, 19 May 2022 12:52:04 +0000 (14:52 +0200)]
Return LegacyPlaceholderResponse from `Request::execute()`

2 years agoHandle LegacyPlaceholderResponse in RequestHandler
Tim Düsterhus [Thu, 19 May 2022 12:50:40 +0000 (14:50 +0200)]
Handle LegacyPlaceholderResponse in RequestHandler

2 years agoAdd `\wcf\http\LegacyPlaceholderResponse`
Tim Düsterhus [Thu, 19 May 2022 12:49:33 +0000 (14:49 +0200)]
Add `\wcf\http\LegacyPlaceholderResponse`

2 years agoAdd `psr/http-server-middleware` composer dependency
Tim Düsterhus [Thu, 19 May 2022 12:23:05 +0000 (14:23 +0200)]
Add `psr/http-server-middleware` composer dependency

2 years agoExplicitly require `psr/http-message` composer dependency
Tim Düsterhus [Thu, 19 May 2022 12:22:39 +0000 (14:22 +0200)]
Explicitly require `psr/http-message` composer dependency

2 years agoExplicitly require `psr/http-server-handler` composer dependency
Tim Düsterhus [Thu, 19 May 2022 12:22:06 +0000 (14:22 +0200)]
Explicitly require `psr/http-server-handler` composer dependency

2 years agoAdd missing comma to headIncludeJavaScript.tpl
Tim Düsterhus [Thu, 19 May 2022 13:04:02 +0000 (15:04 +0200)]
Add missing comma to headIncludeJavaScript.tpl

see a5c441a61209584360c5917871536500ef7a12bd

2 years agoMerge branch '5.5'
Tim Düsterhus [Thu, 19 May 2022 12:54:57 +0000 (14:54 +0200)]
Merge branch '5.5'

2 years agoFix filename of the update scripts for 5.6
Tim Düsterhus [Thu, 19 May 2022 11:55:50 +0000 (13:55 +0200)]
Fix filename of the update scripts for 5.6

2 years agoAdd `x-frame-options` response header to PSR-7 responses in RequestHandler
Tim Düsterhus [Thu, 19 May 2022 08:36:22 +0000 (10:36 +0200)]
Add `x-frame-options` response header to PSR-7 responses in RequestHandler

2 years agoRemove obsolete checks for `!PACKAGE_ID` / `NO_IMPORTS`
Tim Düsterhus [Thu, 19 May 2022 08:33:50 +0000 (10:33 +0200)]
Remove obsolete checks for `!PACKAGE_ID` / `NO_IMPORTS`

see #4818

2 years agoMerge pull request #4818 from WoltLab/wcfsetup-psr-7
Tim Düsterhus [Thu, 19 May 2022 07:09:45 +0000 (09:09 +0200)]
Merge pull request #4818 from WoltLab/wcfsetup-psr-7

Migrate WCFSetup to PSR-7

2 years agoWork-around when closing a closing dialog
Alexander Ebert [Wed, 18 May 2022 16:38:36 +0000 (18:38 +0200)]
Work-around when closing a closing dialog

See https://www.woltlab.com/community/thread/295669-uidialog-cannot-read-properties-of-undefined-reading-closable/

2 years agoImage viewer broke during orientation change
Alexander Ebert [Wed, 18 May 2022 16:21:59 +0000 (18:21 +0200)]
Image viewer broke during orientation change

See https://www.woltlab.com/community/thread/295628-mobil-bildanzeige-skaliert-beim-drehen/

2 years agoMissing language variable
Marcel Werk [Wed, 18 May 2022 16:15:21 +0000 (18:15 +0200)]
Missing language variable

2 years agoInline WCFSetup::installFiles()
Tim Düsterhus [Wed, 18 May 2022 14:57:54 +0000 (16:57 +0200)]
Inline WCFSetup::installFiles()

`->unzipFiles()` basically consisted only of the call to `::installFiles()`,
simplify the control flow by putting those three lines of code inline to make
`->unzipFiles()` self-contained.

2 years agoMigrate WCFSetup to PSR-7
Tim Düsterhus [Wed, 18 May 2022 14:50:32 +0000 (16:50 +0200)]
Migrate WCFSetup to PSR-7

2 years agoMark WCFSetup as final
Tim Düsterhus [Wed, 18 May 2022 14:49:42 +0000 (16:49 +0200)]
Mark WCFSetup as final

2 years agoMerge pull request #4816 from WoltLab/template-engine-psr-7
Tim Düsterhus [Wed, 18 May 2022 15:52:03 +0000 (17:52 +0200)]
Merge pull request #4816 from WoltLab/template-engine-psr-7

Add TemplateEngine::fetchStream() to efficiently render a template as a PSR-7 StreamInterface

2 years agoFixed code style
Marcel Werk [Wed, 18 May 2022 15:46:22 +0000 (17:46 +0200)]
Fixed code style

2 years agoInconsistent sort order of the mobile ACP header
Alexander Ebert [Wed, 18 May 2022 15:39:43 +0000 (17:39 +0200)]
Inconsistent sort order of the mobile ACP header

See https://www.woltlab.com/community/thread/295662-mobiles-men%C3%BC-im-acp/

2 years agoAdd TemplateEngine::fetchStream() to efficiently render a template as a PSR-7 StreamI...
Tim Düsterhus [Wed, 18 May 2022 14:16:15 +0000 (16:16 +0200)]
Add TemplateEngine::fetchStream() to efficiently render a template as a PSR-7 StreamInterface

2 years agoMerge pull request #4815 from WoltLab/wcfsetup-relative-wcf-dir
Tim Düsterhus [Wed, 18 May 2022 14:13:42 +0000 (16:13 +0200)]
Merge pull request #4815 from WoltLab/wcfsetup-relative-wcf-dir

Remove the need for SetupTemplateCompiler

2 years agoRestrict access to `?action=WCFSetup` after successful installation
Tim Düsterhus [Wed, 18 May 2022 13:22:50 +0000 (15:22 +0200)]
Restrict access to `?action=WCFSetup` after successful installation

This action only exists to complete WCFSetup. It should be guarded by a check
an unfinished installation (`!PACKAGE_ID`) to prevent accesses in live
installation.

2 years agoImproved overflow behaviour of the contentInteractionButtons buttons on mobile
Marcel Werk [Wed, 18 May 2022 11:30:24 +0000 (13:30 +0200)]
Improved overflow behaviour of the contentInteractionButtons buttons on mobile

2 years agoMove the output generation in WCFSetup::installPackages() to a more appropriate location
Tim Düsterhus [Wed, 18 May 2022 13:11:49 +0000 (15:11 +0200)]
Move the output generation in WCFSetup::installPackages() to a more appropriate location

2 years agoRemove SetupTemplateCompiler
Tim Düsterhus [Wed, 18 May 2022 13:09:30 +0000 (15:09 +0200)]
Remove SetupTemplateCompiler

The implementation only differed from the TemplateCompiler /
TemplateScriptingCompiler by not rejecting the use of RELATIVE_WCF_DIR. As that
usage was removed in the previous commit the SetupTemplateCompiler is obsolete.

2 years agoDo not reference `RELATIVE_WCF_DIR` in stepInstallPackages.tpl
Tim Düsterhus [Wed, 18 May 2022 13:07:32 +0000 (15:07 +0200)]
Do not reference `RELATIVE_WCF_DIR` in stepInstallPackages.tpl

2 years agoMerge remote-tracking branch 'origin/5.5' into 5.5
Tim Düsterhus [Wed, 18 May 2022 11:00:28 +0000 (13:00 +0200)]
Merge remote-tracking branch 'origin/5.5' into 5.5

2 years agoMerge branch '5.4' into 5.5
Tim Düsterhus [Wed, 18 May 2022 11:00:17 +0000 (13:00 +0200)]
Merge branch '5.4' into 5.5

2 years agoMerge pull request #4814 from WoltLab/wcfsetup-tmp
Tim Düsterhus [Wed, 18 May 2022 10:48:56 +0000 (12:48 +0200)]
Merge pull request #4814 from WoltLab/wcfsetup-tmp

Clean up the handling of temporary files during WCFSetup

2 years agoImproved behaviour for contentHeaderNavigation buttons
Marcel Werk [Wed, 18 May 2022 10:45:06 +0000 (12:45 +0200)]
Improved behaviour for contentHeaderNavigation buttons

ref https://www.woltlab.com/community/thread/295238-%C3%A4nderung-der-reihenfolge-von-antworten-pagination-abonnieren-in-der-mobilen-ansi/?postID=1894039#post1894039

2 years agoAlways use install.php's __DIR__ as the temporary directory
Tim Düsterhus [Tue, 17 May 2022 15:23:55 +0000 (17:23 +0200)]
Always use install.php's __DIR__ as the temporary directory

The previous implementation of `BasicFileUtil::getTempFolder()` was unstable,
as it automatically detected `tmp/` directories in the document root. If
WoltLab Suite Core is installed into the document root, then the extraction of
the files will implicitly create a `tmp/` directory and thus change the temp
folder for the remaining installation.

2 years agoIncrease the randomness in `TMP_FILE_PREFIX` in install.php
Tim Düsterhus [Tue, 17 May 2022 15:15:09 +0000 (17:15 +0200)]
Increase the randomness in `TMP_FILE_PREFIX` in install.php

2 years agoRemove all extracted temporary files in WCFSetup::installPackages()
Tim Düsterhus [Wed, 18 May 2022 08:40:30 +0000 (10:40 +0200)]
Remove all extracted temporary files in WCFSetup::installPackages()

2 years agoMove the package archives into WCF_DIR/tmp in WCFSetup::installPackages()
Tim Düsterhus [Wed, 18 May 2022 08:38:32 +0000 (10:38 +0200)]
Move the package archives into WCF_DIR/tmp in WCFSetup::installPackages()

This allows for a complete cleanup of the temporary directory.

2 years agoRemove error handling for broken archives from WCFSetup
Tim Düsterhus [Wed, 18 May 2022 08:33:11 +0000 (10:33 +0200)]
Remove error handling for broken archives from WCFSetup

Any errors are generally not recoverable at this point, making the error
handling useless.

2 years agoSimplify calculation of `$processNo` in WCFSetup::installPackages()
Tim Düsterhus [Wed, 18 May 2022 08:10:30 +0000 (10:10 +0200)]
Simplify calculation of `$processNo` in WCFSetup::installPackages()

Similarly to the previous commit we know for sure that no process numbers are
taken yet, so we can hardcode this to 1.

2 years agoRemove useless check whether com.woltlab.wcf is already installed in WCFSetup::instal...
Tim Düsterhus [Wed, 18 May 2022 08:08:26 +0000 (10:08 +0200)]
Remove useless check whether com.woltlab.wcf is already installed in WCFSetup::installPackages()

The database structure was just created in WCFSetup, we know for sure that the
wcf1_package table is empty.

2 years agoRemove unneeded decompression of packages in WCFSetup::installPackages()
Tim Düsterhus [Wed, 18 May 2022 08:04:56 +0000 (10:04 +0200)]
Remove unneeded decompression of packages in WCFSetup::installPackages()

As indicated in the previous commit, the fact that this decompression did not
happen for Strato implies that it is not actually necessary in practice.

2 years agoRemove Strato workaround from WCFSetup
Tim Düsterhus [Wed, 18 May 2022 07:59:08 +0000 (09:59 +0200)]
Remove Strato workaround from WCFSetup

This workaround exists since the very first commit and it's not clear why that
was needed back then. It likely was related to the temporary directory not
being writable or files not being deletable in some cases, but with the change
of WCFSetup's temporary directory anything less than full writing permissions
to the directory mean that WoltLab Suite won't actually run after installation
anyway, making this workaround obsolete.

Also the fact that decompression of the archive does not happen in all cases
implies that the decompression is not actually necessary at this stage, making
that the next candidate for removal.

2 years agoUse the DOMContentLoaded event in WCFSetup
Tim Düsterhus [Wed, 18 May 2022 09:32:06 +0000 (11:32 +0200)]
Use the DOMContentLoaded event in WCFSetup

see 99e56d2929be14b1f5141e6a5136ff7c7de6f39d
see 0479cdecbc8788c5d980490af9c2fda00753cd6a

2 years agoRevert "Remove unneeded `window.onload` callbacks in WCFSetup JavaScript"
Tim Düsterhus [Wed, 18 May 2022 09:30:54 +0000 (11:30 +0200)]
Revert "Remove unneeded `window.onload` callbacks in WCFSetup JavaScript"

This change had the undesired effect that the footer did not show. Instead the
more appropriate `DOMContentLoaded` event should be used.

This reverts commit 99e56d2929be14b1f5141e6a5136ff7c7de6f39d.

2 years agoMerge pull request #4813 from WoltLab/wcfsetup-javascript
Tim Düsterhus [Wed, 18 May 2022 09:17:27 +0000 (11:17 +0200)]
Merge pull request #4813 from WoltLab/wcfsetup-javascript

Simplify JavaScript handling in WCFSetup

2 years agoMerge pull request #4812 from WoltLab/admin-panel-user-header
Alexander Ebert [Wed, 18 May 2022 09:14:49 +0000 (11:14 +0200)]
Merge pull request #4812 from WoltLab/admin-panel-user-header

Simplified the admin panel‘s user header

2 years agoRemove unneeded `window.onload` callbacks in WCFSetup JavaScript
Tim Düsterhus [Wed, 18 May 2022 09:06:57 +0000 (11:06 +0200)]
Remove unneeded `window.onload` callbacks in WCFSetup JavaScript

2 years agoDisable JavaScript relocation in WCFSetup
Tim Düsterhus [Wed, 18 May 2022 09:04:49 +0000 (11:04 +0200)]
Disable JavaScript relocation in WCFSetup

There is no benefit to this in WCFSetup, it just increases complexity.

2 years agoMerge branch '5.5'
Tim Düsterhus [Wed, 18 May 2022 09:07:42 +0000 (11:07 +0200)]
Merge branch '5.5'

2 years agoFix code style in WCFACP
Tim Düsterhus [Wed, 18 May 2022 07:28:58 +0000 (09:28 +0200)]
Fix code style in WCFACP

Apparently PSR-12 allows either brace placement, with PHP-CS-Fixer preferring
the brace on the same line and Intelephense preferring it on the next line. If
a multi-line interface definition would be used here, then the brace must be on
a dedicated line, making Intelephense slightly more right on this one.

However as WCFACP is expected to be touched seldomly, thus seldomly running the
Intelephense formatter, the pragmatic solution is to satisfy PHP-CS-Fixer.

see FriendsOfPHP/PHP-CS-Fixer#6396 for a related issue

2 years agoSimplified the link to access the frontend
Alexander Ebert [Tue, 17 May 2022 15:45:05 +0000 (17:45 +0200)]
Simplified the link to access the frontend

2 years agoRemove user links expect for the logout
Alexander Ebert [Tue, 17 May 2022 15:43:48 +0000 (17:43 +0200)]
Remove user links expect for the logout

This is still not ideal, the header might need a slight redesign to better represent the logged-in user and the logout button.

2 years agoFix typo in WCFSetup
Tim Düsterhus [Tue, 17 May 2022 14:59:10 +0000 (16:59 +0200)]
Fix typo in WCFSetup

2 years agoMerge pull request #4811 from WoltLab/wcfsetup-finalize
Tim Düsterhus [Tue, 17 May 2022 14:51:47 +0000 (16:51 +0200)]
Merge pull request #4811 from WoltLab/wcfsetup-finalize

Clean up finalization of WCFSetup

2 years agoRemove unneeded `file_exists` check for install files
Tim Düsterhus [Tue, 17 May 2022 14:27:07 +0000 (16:27 +0200)]
Remove unneeded `file_exists` check for install files

With the absolute path within the constants we know for sure that these files
must exist.

2 years agoUse appropriate constants to identify to-be-deleted install files
Tim Düsterhus [Tue, 17 May 2022 14:26:38 +0000 (16:26 +0200)]
Use appropriate constants to identify to-be-deleted install files

2 years agoDo not suppress errors during removal of setup files in WCFSetup::installPackages()
Tim Düsterhus [Tue, 17 May 2022 14:23:23 +0000 (16:23 +0200)]
Do not suppress errors during removal of setup files in WCFSetup::installPackages()

It is unsafe if these files remain. Also it is very likely that the system not
actually capable of reliably running WoltLab Suite if something as simple as
deleting a file fails.

2 years agoRemove `*Deleted' template variable assignment in WCFSetup::installPackages()
Tim Düsterhus [Tue, 17 May 2022 14:21:59 +0000 (16:21 +0200)]
Remove `*Deleted' template variable assignment in WCFSetup::installPackages()

These are not actually referenced in the template.

2 years agoMerge pull request #4810 from WoltLab/gzip-file-dynamic-dispatch
Tim Düsterhus [Tue, 17 May 2022 13:42:22 +0000 (15:42 +0200)]
Merge pull request #4810 from WoltLab/gzip-file-dynamic-dispatch

Remove dynamic dispatch of common cases from GZipFile

2 years agoRemove the `lang` prefilter from WCFSetup's template engine
Tim Düsterhus [Tue, 17 May 2022 13:41:00 +0000 (15:41 +0200)]
Remove the `lang` prefilter from WCFSetup's template engine

WCFSetup is not performance critical and the less logic that runs the better.

2 years agoRemove list of to-be-installed packages from WCFSetup
Tim Düsterhus [Tue, 17 May 2022 13:27:55 +0000 (15:27 +0200)]
Remove list of to-be-installed packages from WCFSetup

This is an incredible performance bottleneck, because it reparses all the
archives in every request.

2 years agoRemove GZipFile::$gzopen64
Tim Düsterhus [Tue, 17 May 2022 13:10:31 +0000 (15:10 +0200)]
Remove GZipFile::$gzopen64

This property is no longer accessible since GZipFile is `final`.

2 years agoMark GZipFile as `final`
Tim Düsterhus [Tue, 17 May 2022 13:09:12 +0000 (15:09 +0200)]
Mark GZipFile as `final`

There is no good reason to inherit from this class and the performance
optimization for the commonly used method calls might break derived classes
that rely on `->__call()` calling something else.

2 years agoRemove the need for dynamic dispatch for common GZipFile methods
Tim Düsterhus [Tue, 17 May 2022 13:05:56 +0000 (15:05 +0200)]
Remove the need for dynamic dispatch for common GZipFile methods

`->read()`, `->tell()` and `->seek()` are frequently used methods when parsing
Tar archives. We know for sure that these will be mapped to the corresponding
`gz*` function. Define them statically to avoid the need for repeated
`function_exists()` checks in `__call()`.

2 years agoReplace calls to `ord()` in checksum calculation of Tar::readHeader() with a table...
Tim Düsterhus [Tue, 17 May 2022 12:47:31 +0000 (14:47 +0200)]
Replace calls to `ord()` in checksum calculation of Tar::readHeader() with a table lookup

This makes Tar header processing much faster, due to the reduced number of function
calls (> 3.1 million calls to `ord()` in a WCFSetup with WoltLab Suite Forum
included).

see ec4be13babcd7e1579c08f1805412fcc9f3d65c5

2 years agoReduce the number of function calls in Tar::readHeader()
Tim Düsterhus [Tue, 17 May 2022 12:33:09 +0000 (14:33 +0200)]
Reduce the number of function calls in Tar::readHeader()

2 years agoMerge pull request #4785 from WoltLab/remove-multi-domain
Alexander Ebert [Tue, 17 May 2022 10:48:11 +0000 (12:48 +0200)]
Merge pull request #4785 from WoltLab/remove-multi-domain

Remove multi-domain support

2 years agoMerge branch '5.5'
Tim Düsterhus [Tue, 17 May 2022 09:08:10 +0000 (11:08 +0200)]
Merge branch '5.5'

2 years agoMerge branch '5.5'
Tim Düsterhus [Tue, 17 May 2022 09:07:15 +0000 (11:07 +0200)]
Merge branch '5.5'

2 years agoUnified phrases for deprecated options
Marcel Werk [Tue, 17 May 2022 08:59:25 +0000 (10:59 +0200)]
Unified phrases for deprecated options

2 years agoDeprecated AMP support
Marcel Werk [Fri, 13 May 2022 11:19:15 +0000 (13:19 +0200)]
Deprecated AMP support

PR #4803 accidentally had the wrong target branch.

(cherry picked from commit 8c97dca561b32b3c02f3cb30b32574a8f83b8bd5)

2 years agoFix code style
Tim Düsterhus [Tue, 17 May 2022 07:26:28 +0000 (09:26 +0200)]
Fix code style

2 years agoRevert "Use checkstyle output for php-cs-fixer"
Tim Düsterhus [Tue, 17 May 2022 07:03:36 +0000 (09:03 +0200)]
Revert "Use checkstyle output for php-cs-fixer"

This change was meant to improve the output, by properly annotating the files,
but instead it makes the output absolutely useless, as it does not include line
numbers.

This reverts commit 65a9247ac9566923cf89e4055c001833622996a6.

2 years agoSimplified checks against the domain name
Alexander Ebert [Mon, 16 May 2022 20:53:26 +0000 (22:53 +0200)]
Simplified checks against the domain name

2 years agoRedesigned the rescue mode, enforce shared domain
Alexander Ebert [Mon, 16 May 2022 20:36:09 +0000 (22:36 +0200)]
Redesigned the rescue mode, enforce shared domain

2 years agoAdded documentation of minvalue / maxvalue
Marcel Werk [Mon, 16 May 2022 19:47:11 +0000 (21:47 +0200)]
Added documentation of minvalue / maxvalue

2 years agoEmail address was not visible in listing of group members
Marcel Werk [Mon, 16 May 2022 14:54:01 +0000 (16:54 +0200)]
Email address was not visible in listing of group members

2 years agoRemove obsolete check for `->getAttributes()` method on ReflectionFunction/Reflection...
Tim Düsterhus [Mon, 16 May 2022 11:57:35 +0000 (13:57 +0200)]
Remove obsolete check for `->getAttributes()` method on ReflectionFunction/ReflectionMethod

2 years agoDeprecate the obsolete WCF::useDesktopNotifications()
Tim Düsterhus [Mon, 16 May 2022 09:46:17 +0000 (11:46 +0200)]
Deprecate the obsolete WCF::useDesktopNotifications()

2 years agoMerge branch 'master' into remove-multi-domain
Tim Düsterhus [Mon, 16 May 2022 09:42:53 +0000 (11:42 +0200)]
Merge branch 'master' into remove-multi-domain

2 years agoMerge branch '5.5'
Tim Düsterhus [Mon, 16 May 2022 09:41:07 +0000 (11:41 +0200)]
Merge branch '5.5'

2 years agoMerge remote-tracking branch 'origin/5.5' into 5.5
Tim Düsterhus [Mon, 16 May 2022 09:38:35 +0000 (11:38 +0200)]
Merge remote-tracking branch 'origin/5.5' into 5.5

2 years agoIncorrect handling of the return focus
Alexander Ebert [Sat, 14 May 2022 12:30:38 +0000 (14:30 +0200)]
Incorrect handling of the return focus

Related https://www.woltlab.com/community/thread/295562-inhalte-k%C3%B6nnen-doppelt-gemeldet-werden/

(cherry picked from commit e9ffefb4d0db61bf8e12b3824c6515ac16fe3812)

2 years agoRevert "Suppress errors when disabling the focus trap"
Tim Düsterhus [Mon, 16 May 2022 09:37:27 +0000 (11:37 +0200)]
Revert "Suppress errors when disabling the focus trap"

This commit duplicates commit e9ffefb4d0db61bf8e12b3824c6515ac16fe3812 which is
the cleaner fix, but was accidentally commited to `master` only. We revert this
one to allow for a clean cherry-picking of
e9ffefb4d0db61bf8e12b3824c6515ac16fe3812.

This reverts commit e7439c4f5fc7daf8d45d2de478c488798ddf463a.

2 years agoMerge pull request #4808 from WoltLab/55-incorrect-http-204-handling
Alexander Ebert [Mon, 16 May 2022 09:36:38 +0000 (11:36 +0200)]
Merge pull request #4808 from WoltLab/55-incorrect-http-204-handling

HTTP 204 does not carry a response type

2 years agoFix `wcf.user.register.error.blacklistMatches` language variable in RegisterForm
Tim Düsterhus [Mon, 16 May 2022 09:36:19 +0000 (11:36 +0200)]
Fix `wcf.user.register.error.blacklistMatches` language variable in RegisterForm

2 years agoInstall phpcs via `shivammathur/setup-php`
Tim Düsterhus [Fri, 13 May 2022 09:45:32 +0000 (11:45 +0200)]
Install phpcs via `shivammathur/setup-php`

Apparently the previously used actions uses an out of date phpcs.

(cherry picked from commit c5cd836751c3fb357b8ddce52a95a83f3ac46347)

2 years agoConsistent evaluation of the response content type
Alexander Ebert [Mon, 16 May 2022 09:31:40 +0000 (11:31 +0200)]
Consistent evaluation of the response content type

2 years agoProper handling of a 204 response
Alexander Ebert [Mon, 16 May 2022 09:25:55 +0000 (11:25 +0200)]
Proper handling of a 204 response

2 years agoHTTP 204 does not carry a `content-type`
Alexander Ebert [Mon, 16 May 2022 09:17:50 +0000 (11:17 +0200)]
HTTP 204 does not carry a `content-type`

See https://www.woltlab.com/community/thread/295631-importer-h%C3%A4ngt-bei-reaktionen-100/

2 years agoMerge pull request #4805 from WoltLab/package-xsd
Marcel Werk [Mon, 16 May 2022 07:51:10 +0000 (09:51 +0200)]
Merge pull request #4805 from WoltLab/package-xsd

Added documentation of the void element

2 years agoUse correct CodeMirror mode for SCSS inputs
Tim Düsterhus [Mon, 16 May 2022 07:42:33 +0000 (09:42 +0200)]
Use correct CodeMirror mode for SCSS inputs

`sass` is the indentation based SASS syntax.

2 years agoIncorrect markup in the authentication dialog
Alexander Ebert [Sun, 15 May 2022 11:20:40 +0000 (13:20 +0200)]
Incorrect markup in the authentication dialog

2 years agoSuppress errors when disabling the focus trap
Alexander Ebert [Sun, 15 May 2022 11:04:54 +0000 (13:04 +0200)]
Suppress errors when disabling the focus trap

2 years agoUse CSS variable to apply the dialog offset
Alexander Ebert [Sun, 15 May 2022 11:00:09 +0000 (13:00 +0200)]
Use CSS variable to apply the dialog offset

2 years agoRevert "Dynamic width of code box line numbers"
Alexander Ebert [Sun, 15 May 2022 10:38:59 +0000 (12:38 +0200)]
Revert "Dynamic width of code box line numbers"

This reverts commit d3853740d8304f9703876006db990c2e01642656.