H Hartley Sweeten [Wed, 28 May 2014 23:26:24 +0000 (16:26 -0700)]
staging: comedi: ni_mio_common: remove forward declaration 1
Move ni_8255_callback() to remove the need for the forward declaration.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sachin Kamat [Thu, 29 May 2014 11:35:20 +0000 (17:05 +0530)]
staging: bcm: Remove redundant casting in Bcmchar.c
Casting value returned by kzalloc is useless.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sachin Kamat [Thu, 29 May 2014 11:35:19 +0000 (17:05 +0530)]
staging: rtl8723au: Remove redundant casting in rtw_mlme.c
Casting value returned by kzalloc is useless.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sachin Kamat [Thu, 29 May 2014 11:35:18 +0000 (17:05 +0530)]
staging: rtl8723au: Remove redundant casting in rtw_mlme_ext.c
Casting value returned by kzalloc is useless.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alexey Tulia [Fri, 13 Jun 2014 08:35:13 +0000 (11:35 +0300)]
staging: usbip: fixed a coding-style warning
This fixes the following warning:
- WARNING: __constant_cpu_to_le32 should be cpu_to_le32
Signed-off-by: Alexey Tulia <alexey.tulia@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Geert Uytterhoeven [Wed, 11 Jun 2014 14:57:46 +0000 (16:57 +0200)]
staging: rtl8723au: Add compiler check for -Wtype-limits
Gcc versions before 4.3 do not support -Wtype-limits:
cc1: error: unrecognized command line option "-Wtype-limits"
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:17:08 +0000 (15:17 +0200)]
staging: rtl8723au: rtw_cfg80211_set_wpa_ie(): Avoid pointless memcpy
There is no point copying a buffer, just to scan it and then free it
again.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:17:07 +0000 (15:17 +0200)]
staging: rtl8723au: Move FillH2CCmd() prototype to rtl8723a_cmd.h where it really belongs
As an added bonus, remove the now obsolete rtw_ioctl_set.h
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:17:06 +0000 (15:17 +0200)]
staging: rtl8723au: Quiet unused variable warning when building with CONFIG_8723AU_AP_MODE=n
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:17:05 +0000 (15:17 +0200)]
staging: rtl8723au: Don't run regular scans in the driver, the stack handles that
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:17:04 +0000 (15:17 +0200)]
staging: rtl8723au: rtw_set_802_11_bssid23a_list_scan(): Use __func__ to print function name
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:17:03 +0000 (15:17 +0200)]
staging: rtl8723au: Move rtw_get_cur_max_rate23a() to ioctl_cfg80211.c
This function has only one caller, so move it home and declare it static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:17:02 +0000 (15:17 +0200)]
staging: rtl8723au: rtw_get_cur_max_rate23a(): We are in N mode if WLAN_EID_HT_CAPABILITY is present
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:17:01 +0000 (15:17 +0200)]
staging: rtl8723au: rtw_get_cur_max_rate23a(): Remove duplicate fwstate checks
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:17:00 +0000 (15:17 +0200)]
staging: rtl8723au: Move rtw_do_join23a() to rtw_mlme.c and declare it static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:59 +0000 (15:16 +0200)]
staging: rtl8723au: rtw_do_join23a(): Don't start scanning if network isn't found
Don't start running network scans if trying to connect to a network
not in our cache. Let the 802.11 stack do it's job instead.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:58 +0000 (15:16 +0200)]
staging: rtl8723au: rtw_set_ssid(): Use rtw_do_join_network()
We already have the wlan_network we wish to join, hence it's pointless
to go back to the scanned_queue and pull it out of there, before
running the join logic.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:57 +0000 (15:16 +0200)]
staging: rtl8723au: rtw_select_and_join_from_scanned_queue23a() never returns 2
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:56 +0000 (15:16 +0200)]
staging: rtl8723au: rtw_surveydone_event_callback23a(): We always set _FW_UNDER_LINKING
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:55 +0000 (15:16 +0200)]
staging: rtl8723au: to_join will no be true if _FW_LINKED is set
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:54 +0000 (15:16 +0200)]
staging: rtl8723au: Remove no-op rtw_get_encrypt_decrypt_from_registrypriv23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:53 +0000 (15:16 +0200)]
staging: rtl8723au: Consolidate duplicate adhoc joining code into rtw_do_join_adhoc()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:52 +0000 (15:16 +0200)]
staging: rtl8723au: rtw_surveydone_event_callback23a(): Remove superfluous memset()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:51 +0000 (15:16 +0200)]
staging: rtl8723au: rtw_do_join23a(): Use __func__ to get function name in debug messages
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:50 +0000 (15:16 +0200)]
staging: rtl8723au: Introduce rtw_do_join_network()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:49 +0000 (15:16 +0200)]
staging: rtl8723au: Introduce rtw_select_candidate_from_queue()
This splits a portion of rtw_select_and_join_from_scanned_queue23a()
into rtw_select_candidate_from_queue()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:48 +0000 (15:16 +0200)]
staging: rtl8723au: Don't prepend debug console messages with 'ERROR '
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:47 +0000 (15:16 +0200)]
staging: rtl8723au: Minor debug message fixup
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:46 +0000 (15:16 +0200)]
staging: rtl8723au: rtw_do_join23a(): Use correct error return values
Don't mix true/fail with _SUCCESS/_FAIL as return value
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:45 +0000 (15:16 +0200)]
staging: rtl8723au: rtw_cfg80211_add_wep(): Use WLAN_KEY_LEN_*
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:44 +0000 (15:16 +0200)]
staging: rtl8723au: rtw_set_ssid(): This is never called with _FW_UNDER_LINKING
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:43 +0000 (15:16 +0200)]
staging: rtl8723au: Pass a struct wlan_network to rtw_set_ssid()
There is no point copying the ssid out of struct wlan_network when we
can just pass on the whole struct.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:42 +0000 (15:16 +0200)]
staging: rtl8723au: cfg80211_rtw_connect(): Simplify ssid preparation
Since we just matched sme->{ssid,ssid_len} to
pnetwork->network.Ssid.{ssid,ssid_len} we can simplify the copy and
move it to just before the call to rtw_set_ssid().
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:41 +0000 (15:16 +0200)]
staging: rtl8723au: cfg80211_rtw_connect(): Remove obfuscating pointers
dst_ssid and dst_bssid were just obfuscating that we were in fact
looking at pnetwork.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:40 +0000 (15:16 +0200)]
staging: rtl8723au: cfg80211_rtw_connect(): Clean up various bits
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:39 +0000 (15:16 +0200)]
staging: rtl8723au: Move rtw_set_802_11_ssid23a() to ioctl_cfg80211.c
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:38 +0000 (15:16 +0200)]
staging: rtl8723au: Fold rtw_set_802_11_authentication_mode23a() into cfg80211_rtw_connect()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:37 +0000 (15:16 +0200)]
staging: rtl8723au: cfg80211_rtw_connect(): Check correct return value from rtw_set_802_11_ssid23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:36 +0000 (15:16 +0200)]
staging: rtl8723au: Make rtw_is_same_ibss23a() return bool
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:35 +0000 (15:16 +0200)]
staging: rtl8723au: Get rid of IW_ESSID_MAX_SIZE
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:34 +0000 (15:16 +0200)]
staging: rtl8723au: OnAuth23a(): Use ether_addr_copy()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:33 +0000 (15:16 +0200)]
staging: rtl8723au: rtw_stadel_event_callback23a(): Remove superfluous memset()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:32 +0000 (15:16 +0200)]
staging: rtl8723au: free_scanqueue(): Use _rtw_free_network23a()
Use _rtw_free_network23() so elements are freed in one place.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:31 +0000 (15:16 +0200)]
staging: rtl8723au: collect_bss_info(): Don't memset() what we just kzalloc()'d
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:30 +0000 (15:16 +0200)]
staging: rtl8723au: Allocate struct wlan_bssid_ex in collect_bss_info()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:29 +0000 (15:16 +0200)]
staging: rtl8723au: Do not embed struct wlan_bssid_ex in struct survey_event
Instead allocate it separately and reference it from survey_event.
This will allow for us to pass it on later without having to copy it.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:28 +0000 (15:16 +0200)]
staging: rtl8723au: rtw_survey_event_cb23a(): Use the correct types for the received arguments
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:27 +0000 (15:16 +0200)]
staging: rtl8723au: Declare rtw_update_scanned_network() static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:26 +0000 (15:16 +0200)]
staging: rtl8723au: rtw_check_bcn_info23a(): Don't search for WPA/WPA2 info twice
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:25 +0000 (15:16 +0200)]
staging: rtl8723au: rtw_check_bcn_info23a(): Don't make a local copy of beacon just to parse it
In addition be consistent with return values and parsing them.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:24 +0000 (15:16 +0200)]
staging: rtl8723au: rtw_check_bcn_info23a(): Use ether_addr_equal() to check BSSID
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:23 +0000 (15:16 +0200)]
staging: rtl8723au: Remove some unused 80211 header parsing macros
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:22 +0000 (15:16 +0200)]
staging: rtl8723au: Remove unused #defines WEP_KEY_LEN and MGMT_QUEUE_NUM
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:21 +0000 (15:16 +0200)]
staging: rtl8723au: Remove duplicate defines of IEEE80211_HT_PARAM_CHA_SEC_*
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:20 +0000 (15:16 +0200)]
staging: rtl8723au: Remove obsolete rtw_set_fixed_ie23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:19 +0000 (15:16 +0200)]
staging: rtl8723au: issue_action_BA23a(): Use struct ieee80211_mgmt to build action frames
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:18 +0000 (15:16 +0200)]
staging: rtl8723au: ioctl_cfg80211.c: Use struct ieee80211_mgmt to build mgmt frame
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:17 +0000 (15:16 +0200)]
staging: rtl8723au: Let cfg80211 handle public action management frames
The driver shouldn't be dealing with public action management frames.
Let these go directly to the cfg80211 layer which can defer them to
userland if needed.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:16 +0000 (15:16 +0200)]
staging: rtl8723au: Do not xmit BSS Coexistence management action frames
The driver should not be issuing BSS Coexistence management action
frames when scanning. This isn't required by the spec, and if needed,
these should come from wpa_s instead.
Recommended by Johannes Berg.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:15 +0000 (15:16 +0200)]
staging: rtl8723au: issue_action_BSSCoexistPacket(): Use struct ieee80211_mgmt
This gets rid of the rtw_set_fixed_ie23a() usage here. Note that this
abuses ieee80211_mgmt.u.action.u.chan_switch for now, since the
correct defines are currently missing, and this one matches.
Need to fix up the definitions in ieee80211.h and afterwards fix it up
here.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:14 +0000 (15:16 +0200)]
staging: rtl8723au: issue_action_spct_ch_switch23a(): Use struct ieee80211_mgmt
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:13 +0000 (15:16 +0200)]
staging: rtl8723au: _issue_deauth(): Use struct ieee80211_mgmt to build frame
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:10 +0000 (15:16 +0200)]
staging: rtl8723au: issue_assocrsp(): Use struct ieee80211_mgmt instead of rtw_set_fixed_ie23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:09 +0000 (15:16 +0200)]
staging: rtl8723au: issue_auth(): Convert to using struct ieee80211_mgmt
This reduces the dependency of rtw_set_fixed_ie23a() which is
scheduled to go away.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:08 +0000 (15:16 +0200)]
staging: rtl8723au: Make struct htpriv.ampdu_enable a bool
Be consistent in parsing it's value
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:07 +0000 (15:16 +0200)]
staging: rtl8723au: Be consistent in how htpriv.ht_option is checked
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:06 +0000 (15:16 +0200)]
staging: rtl8723au: Make struct ht_priv.ht_option a bool
Match the return type of rtw_restructure_ht_ie23a() accordingly
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:05 +0000 (15:16 +0200)]
staging: rtl8723au: Remove WMM_ defines
Only one is used, and only describes the size of an array defined in a
local function. Use sizeof() in the local function to deobfuscate it.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:04 +0000 (15:16 +0200)]
staging: rtl8723au: OnAssocRsp23a(): Use cfg80211_* to parse IEs
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:03 +0000 (15:16 +0200)]
staging: rtl8723au: Make WMM_param_handler23a() and HT_caps_handler23a() take a const u8 *
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:02 +0000 (15:16 +0200)]
staging: rtl8723au: Declare rtw_get_wpa{2, }_cipher_suite() static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:01 +0000 (15:16 +0200)]
staging: rtl8723au: Remove obsolete rtw_get_sec_ie23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:00 +0000 (15:16 +0200)]
staging: rtl8723au: rtw_wlan_util.c: Use cfg80211_* to determine crypto
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:15:59 +0000 (15:15 +0200)]
staging: rtl8723au: rtw_get_bcn_info23a(): Use cfg80211_* to obtain crypto info
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Tue, 3 Jun 2014 21:41:22 +0000 (23:41 +0200)]
staging: rtl8723au: rtw_update_ht_cap23a(): Use correct mask when determining 40MHz channel location
commit
4dc5f8bab2663b902b9cb0be29198dbbf38aa3fb
Author: Jes Sorensen <Jes.Sorensen@redhat.com>
Date: Tue May 27 13:43:12 2014 +0200
staging: rtl8723au: Eliminate struct HT_info_element
Yet another duplicate version of struct ieee80211_ht_operation
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
introduced a bad error, applying the wrong value as the mask when
determining the location of the 40MHz channel, effectively making it
always determining it as not present. This caused hangs and delays
when running in 40MHz channel mode.
This should get it right.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 31 May 2014 16:05:19 +0000 (18:05 +0200)]
staging: rtl8723au: collect_bss_info23a(): ieee80211_mgmt capab_info is little endian
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 31 May 2014 16:05:18 +0000 (18:05 +0200)]
staging: rtl8723au: collect_bss_info23a(): Collect beacon_interval correct
Only retrieve beacon_interval from frames where it is present. This
avoids setting BeaconPeriod to garbage for other frame types.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 31 May 2014 16:05:17 +0000 (18:05 +0200)]
staging: rtl8723au: Rewrite update_beacon23a_info() tto use cfg80211_find_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 31 May 2014 16:05:16 +0000 (18:05 +0200)]
staging: rtl8723au: Remmove buddy-adapter linking
This sort of stuff should be handled by the bonding driver
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 31 May 2014 16:05:15 +0000 (18:05 +0200)]
staging: rtl8723au: rtw_check_bcn_info23a(): Use capability bit define
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 31 May 2014 16:05:14 +0000 (18:05 +0200)]
staging: rtl8723au: Don't carry ht_cap_info and ht_param in struct wlan_bcn_info
These were just stored to check whether the beacon info had changed
and print a debug message in this case. If we ever need this again, we
can determine this change differently.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 31 May 2014 16:05:13 +0000 (18:05 +0200)]
staging: rtl8723au: Eliminate struct HT_info_element
Yet another duplicate version of struct ieee80211_ht_operation
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 31 May 2014 16:05:12 +0000 (18:05 +0200)]
staging: rtl8723au: Use correct struct for WLAN_EID_HT_CAPABILITY
WLAN_EID_HT_CAPABILITY carries a struct ieee80211_ht_operation - use
the right struct instead of a self invented one.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 31 May 2014 16:05:11 +0000 (18:05 +0200)]
staging: rtl8723au: Use struct ieee80211_ht_cap and associated #defines
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 31 May 2014 16:05:10 +0000 (18:05 +0200)]
staging: rtl8723au: Use struct ieee80211_mcs_info to describe MCS information
The original RTL code defined the MCS information as a 16 byte array
and blindly applied it's masking over the full array, ignoring the
fact that only the first 10 bytes describe the rx_mask and the rest
are different fields.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 31 May 2014 16:05:09 +0000 (18:05 +0200)]
staging: rtl8723au: rtw_mlme.c: Remove some tab and parenthesis abuse
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Sat, 31 May 2014 16:05:08 +0000 (18:05 +0200)]
staging: rtl8723au: rtw_mlme_ext.c: Fix up some of the bad formatting
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wahib Faizi [Thu, 12 Jun 2014 19:40:19 +0000 (23:40 +0400)]
staging: usbip: usbip_host_driver.c: fix line over 80 characters
Fix coding style issue "line over 80 characters"
detected by checkpatch.pl in usbip_host_driver.c.
Signed-off-by: Wahib Faizi <wahibfaizi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wahib Faizi [Thu, 12 Jun 2014 19:40:18 +0000 (23:40 +0400)]
staging: usbip: usbip_host_driver.c: avoid assignment in if
Fix coding style issue "do not use assignment in if condition"
detected by checkpatch.pl in usbip_host_driver.c.
Signed-off-by: Wahib Faizi <wahibfaizi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:12 +0000 (15:16 +0200)]
staging: rtl8723au: Reference correct firmwarefiles with MODULE_FIRMWARE()
Add missing firmware references, and request the correct one.
Reported-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:16:11 +0000 (15:16 +0200)]
staging: rtl8723au: Request correct firmware file for A-cut parts
The filename requested by the driver didn't match what we had sitting
in /lib/firmware/
Reported-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:15:58 +0000 (15:15 +0200)]
staging: rtl8723au: Remove obsolete rtw_get_wps_ie23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:15:57 +0000 (15:15 +0200)]
staging: rtl8723au: rtw_ap.c: Convert from rtw_get_wps_ie23a() to cfg80211_find_vendor_ie()
Some of this is hackish, but so was the original code. This needs to
be cleaned up eventually.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:15:56 +0000 (15:15 +0200)]
staging: rtl8723au: ioctl_cfg80211.c: Convert rtw_get_wps_ie23a() to cfg80211_find_vendor_ie()
Given that the IE len is stored in a u8, there is no point having a
512 buffer to store it, nor check if the size exceeds this size.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:15:55 +0000 (15:15 +0200)]
staging: rtl8723au: rtw_mlme.c: Convert rtw_get_wps_ie23a() to cfg80211_find_vendor_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:15:54 +0000 (15:15 +0200)]
staging: rtl8723au: rtw_mlme_ext.c: Convert rtw_get_wps_ie23a() to cfg80211_find_vendor_ie()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 9 Jun 2014 13:15:53 +0000 (15:15 +0200)]
staging: rtl8723au: rtw_get_wps_ie23a(): Remove unused dest pointer wps_ie
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Linus Torvalds [Mon, 16 Jun 2014 03:45:28 +0000 (17:45 -1000)]
Linux 3.16-rc1
Linus Torvalds [Mon, 16 Jun 2014 02:37:03 +0000 (16:37 -1000)]
Merge git://git./linux/kernel/git/davem/net
Pull networking fixes from David Miller:
1) Fix checksumming regressions, from Tom Herbert.
2) Undo unintentional permissions changes for SCTP rto_alpha and
rto_beta sysfs knobs, from Denial Borkmann.
3) VXLAN, like other IP tunnels, should advertize it's encapsulation
size using dev->needed_headroom instead of dev->hard_header_len.
From Cong Wang.
* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net:
net: sctp: fix permissions for rto_alpha and rto_beta knobs
vxlan: Checksum fixes
net: add skb_pop_rcv_encapsulation
udp: call __skb_checksum_complete when doing full checksum
net: Fix save software checksum complete
net: Fix GSO constants to match NETIF flags
udp: ipv4: do not waste time in __udp4_lib_mcast_demux_lookup
vxlan: use dev->needed_headroom instead of dev->hard_header_len
MAINTAINERS: update cxgb4 maintainer
Linus Torvalds [Mon, 16 Jun 2014 02:02:20 +0000 (16:02 -1000)]
Merge tag 'clk-for-linus-3.16-part2' of git://git.linaro.org/people/mike.turquette/linux
Pull more clock framework updates from Mike Turquette:
"This contains the second half the of the clk changes for 3.16.
They are simply fixes and code refactoring for the OMAP clock drivers.
The sunxi clock driver changes include splitting out the one
mega-driver into several smaller pieces and adding support for the A31
SoC clocks"
* tag 'clk-for-linus-3.16-part2' of git://git.linaro.org/people/mike.turquette/linux: (25 commits)
clk: sunxi: document PRCM clock compatible strings
clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support
clk: sun6i: Protect SDRAM gating bit
clk: sun6i: Protect CPU clock
clk: sunxi: Rework clock protection code
clk: sunxi: Move the GMAC clock to a file of its own
clk: sunxi: Move the 24M oscillator to a file of its own
clk: sunxi: Remove calls to clk_put
clk: sunxi: document new A31 USB clock compatible
clk: sunxi: Implement A31 USB clock
ARM: dts: OMAP5/DRA7: use omap5-mpu-dpll-clock capable of dealing with higher frequencies
CLK: TI: dpll: support OMAP5 MPU DPLL that need special handling for higher frequencies
ARM: OMAP5+: dpll: support Duty Cycle Correction(DCC)
CLK: TI: clk-54xx: Set the rate for dpll_abe_m2x2_ck
CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)
dt:/bindings: DRA7 ATL (Audio Tracking Logic) clock bindings
ARM: dts: dra7xx-clocks: Correct name for atl clkin3 clock
CLK: TI: gate: add composite interface clock to OMAP2 only build
ARM: OMAP2: clock: add DT boot support for cpufreq_ck
CLK: TI: OMAP2: add clock init support
...