GitHub/WoltLab/WCF.git
3 years agoRelease 5.4.1
Alexander Ebert [Thu, 15 Jul 2021 11:58:44 +0000 (13:58 +0200)]
Release 5.4.1

3 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Thu, 15 Jul 2021 11:56:01 +0000 (13:56 +0200)]
Merge branch '5.3' into 5.4

3 years agoMerge pull request #4404 from WoltLab/imagick-webp-optional
Alexander Ebert [Thu, 15 Jul 2021 11:05:26 +0000 (13:05 +0200)]
Merge pull request #4404 from WoltLab/imagick-webp-optional

Permit the upgrade if only GD with WebP support is present

3 years agoRebuild the pre-update file archive
Alexander Ebert [Thu, 15 Jul 2021 11:00:55 +0000 (13:00 +0200)]
Rebuild the pre-update file archive

3 years agoMerge branch '5.4' into imagick-webp-optional
Alexander Ebert [Thu, 15 Jul 2021 11:00:14 +0000 (13:00 +0200)]
Merge branch '5.4' into imagick-webp-optional

3 years agoMerge pull request #4403 from WoltLab/5.4-sqlLog
Alexander Ebert [Thu, 15 Jul 2021 10:57:46 +0000 (12:57 +0200)]
Merge pull request #4403 from WoltLab/5.4-sqlLog

Add missing SQL log entry for `wcf1_acp_session_virtual` during upgrade to 5.4

3 years agoUpdated the pre-update file archive
Alexander Ebert [Thu, 15 Jul 2021 10:52:39 +0000 (12:52 +0200)]
Updated the pre-update file archive

3 years agoAllow bypass of a broken imagick extension, improved error messages
Alexander Ebert [Thu, 15 Jul 2021 10:50:51 +0000 (12:50 +0200)]
Allow bypass of a broken imagick extension, improved error messages

3 years agoImproved the explanation for missing system requirements
Alexander Ebert [Thu, 15 Jul 2021 10:45:36 +0000 (12:45 +0200)]
Improved the explanation for missing system requirements

3 years agoAdd missing SQL log entry for `wcf1_acp_session_virtual` during upgrade to 5.4
Tim Düsterhus [Thu, 15 Jul 2021 09:57:39 +0000 (11:57 +0200)]
Add missing SQL log entry for `wcf1_acp_session_virtual` during upgrade to 5.4

This entry is required to be able to delete this table later in the process.

3 years agoCheck for WebP support in the selected adapter
Alexander Ebert [Thu, 15 Jul 2021 09:22:06 +0000 (11:22 +0200)]
Check for WebP support in the selected adapter

3 years agoFix typo in de.xml
Tim Düsterhus [Thu, 15 Jul 2021 07:19:22 +0000 (09:19 +0200)]
Fix typo in de.xml

3 years agoRelease 5.4.0 5.4.0
Alexander Ebert [Wed, 14 Jul 2021 15:38:49 +0000 (17:38 +0200)]
Release 5.4.0

3 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Wed, 14 Jul 2021 13:34:06 +0000 (15:34 +0200)]
Merge branch '5.3' into 5.4

3 years agoRelease 5.3.11 5.3.11
Alexander Ebert [Wed, 14 Jul 2021 13:14:25 +0000 (15:14 +0200)]
Release 5.3.11

3 years agoRemoved reference to earlier evaluation versions
Alexander Ebert [Wed, 14 Jul 2021 12:27:04 +0000 (14:27 +0200)]
Removed reference to earlier evaluation versions

3 years agoEnable the upgrade notice for 5.4 by default
Alexander Ebert [Wed, 14 Jul 2021 12:08:06 +0000 (14:08 +0200)]
Enable the upgrade notice for 5.4 by default

3 years agoRemoved a legacy condition used in the old session system
Alexander Ebert [Tue, 13 Jul 2021 15:32:34 +0000 (17:32 +0200)]
Removed a legacy condition used in the old session system

This is an old condition that dates back to the early days of the keep alive system. The condition does not work with the new session system anymore, because `lastActivityTime` is always mapped to `TIME_NOW`.

3 years agoMerge pull request #4383 from WoltLab/article_embedded
Marcel Werk [Tue, 13 Jul 2021 15:15:06 +0000 (17:15 +0200)]
Merge pull request #4383 from WoltLab/article_embedded

Fix recursively loading embedded objects in articles

3 years agoMerge pull request #4346 from mutec/currencydecimals
Alexander Ebert [Tue, 13 Jul 2021 14:43:03 +0000 (16:43 +0200)]
Merge pull request #4346 from mutec/currencydecimals

support custom number of decimals in currency modifier

3 years agoSaving WebP images in GD requires a True Color palette
Alexander Ebert [Tue, 13 Jul 2021 14:31:03 +0000 (16:31 +0200)]
Saving WebP images in GD requires a True Color palette

https://stackoverflow.com/questions/39292617/fatal-error-paletter-image-not-supported-by-webp/47469726#47469726

3 years agoMerge branch '5.3'
joshuaruesweg [Tue, 13 Jul 2021 08:39:27 +0000 (10:39 +0200)]
Merge branch '5.3'

3 years agoUse `emailConfirmed` status to exclude unconfirmed emails
joshuaruesweg [Tue, 13 Jul 2021 08:31:43 +0000 (10:31 +0200)]
Use `emailConfirmed` status to exclude unconfirmed emails

With 5.3 we introduced the new `emailConfirmed` status to separate the status of the email and the activation status of the user. Therefore, we want to send emails to users, which emails are enabled. The user activation status is not relevant anymore for sending emails.

3 years agoMerge pull request #4397 from WoltLab/favicon-is-processed
Tim Düsterhus [Tue, 13 Jul 2021 07:32:08 +0000 (09:32 +0200)]
Merge pull request #4397 from WoltLab/favicon-is-processed

Improve Favicon handling in StyleAction

3 years agoDevtools did not work correctly under Windows
Marcel Werk [Mon, 12 Jul 2021 18:07:22 +0000 (20:07 +0200)]
Devtools did not work correctly under Windows

3 years agoIncorrect keystroke
Alexander Ebert [Mon, 12 Jul 2021 14:52:32 +0000 (16:52 +0200)]
Incorrect keystroke

3 years agoMissing `px` units for the image dimensions
Alexander Ebert [Mon, 12 Jul 2021 14:50:47 +0000 (16:50 +0200)]
Missing `px` units for the image dimensions

3 years agoMerge branch '5.4' of https://github.com/WoltLab/WCF into 5.4
Alexander Ebert [Mon, 12 Jul 2021 14:40:03 +0000 (16:40 +0200)]
Merge branch '5.4' of https://github.com/WoltLab/WCF into 5.4

3 years agoMissing cover photo in the list of articles in a footer box
Alexander Ebert [Mon, 12 Jul 2021 14:39:56 +0000 (16:39 +0200)]
Missing cover photo in the list of articles in a footer box

Replaces #4378

3 years agoUpgrade the default STARTTLS level to `encrypt`
Tim Düsterhus [Mon, 12 Jul 2021 14:27:34 +0000 (16:27 +0200)]
Upgrade the default STARTTLS level to `encrypt`

see #4246

3 years agoUpdate the default SMTP port to 587
Tim Düsterhus [Mon, 12 Jul 2021 13:55:57 +0000 (15:55 +0200)]
Update the default SMTP port to 587

25 is not meant for submission.

3 years agoExplicitly mark styles for 5.2+ as compatible with 5.4
Alexander Ebert [Mon, 12 Jul 2021 13:40:28 +0000 (15:40 +0200)]
Explicitly mark styles for 5.2+ as compatible with 5.4

3 years agoRegenerate Favicon images only when the template changes
Tim Düsterhus [Mon, 12 Jul 2021 12:55:31 +0000 (14:55 +0200)]
Regenerate Favicon images only when the template changes

3 years agoDelete manifest.json and browserconfig.xml when deleting a favicon
Tim Düsterhus [Mon, 12 Jul 2021 12:53:05 +0000 (14:53 +0200)]
Delete manifest.json and browserconfig.xml when deleting a favicon

3 years agoMerge pull request #4392 from WoltLab/rename-totp-field
Joshua Rüsweg [Sun, 11 Jul 2021 16:02:54 +0000 (18:02 +0200)]
Merge pull request #4392 from WoltLab/rename-totp-field

Rename TOTP code form field to `onetimecode`

3 years agosupport custom number of decimals in currency modifier
mutec [Sat, 26 Jun 2021 17:17:46 +0000 (19:17 +0200)]
support custom number of decimals in currency modifier

3 years agoRename TOTP code form field to `onetimecode`
joshuaruesweg [Sun, 11 Jul 2021 09:28:07 +0000 (11:28 +0200)]
Rename TOTP code form field to `onetimecode`

The name `code` for the form field is too generic and should be specified. `onetimecode` is a more fitting identifier for the input name. In addition, 1password fills the totp code automatically, if the field is named `onetimecode` (See https://1password.community/discussion/comment/604200/#Comment_604200).

3 years agoConvert tabs to spaces
joshuaruesweg [Sun, 11 Jul 2021 08:50:15 +0000 (10:50 +0200)]
Convert tabs to spaces

3 years agoMerge branch '5.3'
joshuaruesweg [Sun, 11 Jul 2021 08:48:21 +0000 (10:48 +0200)]
Merge branch '5.3'

3 years agoMerge branch '5.2'
joshuaruesweg [Sun, 11 Jul 2021 08:34:16 +0000 (10:34 +0200)]
Merge branch '5.2'

3 years agoMerge branch '3.1'
joshuaruesweg [Sun, 11 Jul 2021 08:31:21 +0000 (10:31 +0200)]
Merge branch '3.1'

3 years agoDon't leak an account's activation status (#4365)
Sascha Greuel [Sun, 11 Jul 2021 08:24:24 +0000 (10:24 +0200)]
Don't leak an account's activation status (#4365)

* Don't leak an account's activation status

* Update wcfsetup/install/files/lib/form/RegisterNewActivationCodeForm.class.php

Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
3 years agoMerge branch '5.3'
joshuaruesweg [Sat, 10 Jul 2021 09:44:09 +0000 (11:44 +0200)]
Merge branch '5.3'

3 years agoSet new activation code on rerequesting them
joshuaruesweg [Sat, 10 Jul 2021 09:39:33 +0000 (11:39 +0200)]
Set new activation code on rerequesting them

3 years agoRelease 5.4.0 RC 2 5.4.0_RC_2
Alexander Ebert [Thu, 8 Jul 2021 13:38:43 +0000 (15:38 +0200)]
Release 5.4.0 RC 2

3 years agoFix recursively loading embedded objects in articles
Matthias Schmidt [Thu, 8 Jul 2021 07:36:37 +0000 (09:36 +0200)]
Fix recursively loading embedded objects in articles

Close #4382
See 3af7b77d40ed93c95cebb22004ab745bf69683e2

3 years agoAdd update_com.woltlab.wcf_5.4_styleCoverPhoto.php to package.xml
Tim Düsterhus [Thu, 8 Jul 2021 07:25:39 +0000 (09:25 +0200)]
Add update_com.woltlab.wcf_5.4_styleCoverPhoto.php to package.xml

3 years agoDo not use the cache in update_com.woltlab.wcf_5.4_styleCoverPhoto.php
Tim Düsterhus [Thu, 8 Jul 2021 07:25:20 +0000 (09:25 +0200)]
Do not use the cache in update_com.woltlab.wcf_5.4_styleCoverPhoto.php

3 years agoFix variable name in `ViewableArticleContentList::readObjects()`
Matthias Schmidt [Thu, 8 Jul 2021 06:50:43 +0000 (08:50 +0200)]
Fix variable name in `ViewableArticleContentList::readObjects()`

3 years agoDo not block matching abbreviation if the package is the same
Alexander Ebert [Wed, 7 Jul 2021 16:16:32 +0000 (18:16 +0200)]
Do not block matching abbreviation if the package is the same

The previous code would block the installation of an update of the same package.

Fix for #4357

3 years agoRelease 5.4.0 RC 2
Alexander Ebert [Wed, 7 Jul 2021 15:58:23 +0000 (17:58 +0200)]
Release 5.4.0 RC 2

3 years agoUpdating minified JavaScript files
WoltLab [Wed, 7 Jul 2021 15:41:36 +0000 (15:41 +0000)]
Updating minified JavaScript files

3 years agoImproved the visuals of the list of MFA options
Alexander Ebert [Wed, 7 Jul 2021 15:14:55 +0000 (17:14 +0200)]
Improved the visuals of the list of MFA options

The content is now vertically centered and the somewhat tiny smartphone icon is enlarged to better match the other icons.

3 years agoUse `<small>` instead of `<p class="small">`
Alexander Ebert [Wed, 7 Jul 2021 15:08:28 +0000 (17:08 +0200)]
Use `<small>` instead of `<p class="small">`

3 years agoFix `this` value for `Core.enableLegacyInheritance()` (#4380)
Matthias Schmidt [Wed, 7 Jul 2021 10:48:12 +0000 (12:48 +0200)]
Fix `this` value for `Core.enableLegacyInheritance()` (#4380)

Without explicitly binding `this` to `thisValue`, it will be `constructed` resulting in missing data only present in `thisValue`.

3 years agoExplicitly show error message if import queue is empty
Matthias Schmidt [Wed, 7 Jul 2021 08:25:33 +0000 (10:25 +0200)]
Explicitly show error message if import queue is empty

Close #3804
See #4379

3 years agoMerge branch '5.3' into 5.4
Matthias Schmidt [Wed, 7 Jul 2021 07:05:42 +0000 (09:05 +0200)]
Merge branch '5.3' into 5.4

3 years agoFix reading value of `CheckboxFormField`
Matthias Schmidt [Wed, 7 Jul 2021 07:01:14 +0000 (09:01 +0200)]
Fix reading value of `CheckboxFormField`

In contrast to `BooleanFormField` for which an explicit "no" input field exists, a normal checkbox does not submit any data if no checked.

3 years agoMerge branch '5.4' of https://github.com/WoltLab/WCF into 5.4
Alexander Ebert [Tue, 6 Jul 2021 12:47:11 +0000 (14:47 +0200)]
Merge branch '5.4' of https://github.com/WoltLab/WCF into 5.4

3 years agoIncorrect type cast to `number`
Alexander Ebert [Tue, 6 Jul 2021 12:47:03 +0000 (14:47 +0200)]
Incorrect type cast to `number`

3 years agoFix conversion of `Dictionary` to `Map` in `Acp/Ui/Menu/Item/Handler`
Matthias Schmidt [Tue, 6 Jul 2021 12:34:01 +0000 (14:34 +0200)]
Fix conversion of `Dictionary` to `Map` in `Acp/Ui/Menu/Item/Handler`

See 2727575fbe8a2ca2fe4a19288c7a982969170882

3 years agoSearch for articles toggled the incorrect container
Alexander Ebert [Tue, 6 Jul 2021 12:33:14 +0000 (14:33 +0200)]
Search for articles toggled the incorrect container

3 years agoMerge branch '5.3' into 5.4
Matthias Schmidt [Tue, 6 Jul 2021 12:24:10 +0000 (14:24 +0200)]
Merge branch '5.3' into 5.4

3 years agoRemove obsolete style logo upload field descriptions
Matthias Schmidt [Tue, 6 Jul 2021 12:23:51 +0000 (14:23 +0200)]
Remove obsolete style logo upload field descriptions

See #3456

3 years agoFixed missing language version for embedded articles
Marcel Werk [Tue, 6 Jul 2021 11:08:46 +0000 (13:08 +0200)]
Fixed missing language version for embedded articles

3 years agoMerge remote-tracking branch 'origin/5.4' into 5.4
Tim Düsterhus [Tue, 6 Jul 2021 10:48:04 +0000 (12:48 +0200)]
Merge remote-tracking branch 'origin/5.4' into 5.4

3 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Tue, 6 Jul 2021 10:47:52 +0000 (12:47 +0200)]
Merge branch '5.3' into 5.4

3 years agoAdd missing encoding of `$family` in font download requests
Tim Düsterhus [Tue, 6 Jul 2021 10:46:01 +0000 (12:46 +0200)]
Add missing encoding of `$family` in font download requests

3 years agoAdd missing since tag for `User::requiresMultifactor()`
Matthias Schmidt [Tue, 6 Jul 2021 09:42:35 +0000 (11:42 +0200)]
Add missing since tag for `User::requiresMultifactor()`

3 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Tue, 6 Jul 2021 08:23:25 +0000 (10:23 +0200)]
Merge branch '5.3' into 5.4

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Tue, 6 Jul 2021 07:34:53 +0000 (09:34 +0200)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Tue, 6 Jul 2021 07:34:26 +0000 (09:34 +0200)]
Merge branch '3.1' into 5.2

3 years agoRemove duplicate `class` attribute in cacheList.tpl
Tim Düsterhus [Tue, 6 Jul 2021 07:32:45 +0000 (09:32 +0200)]
Remove duplicate `class` attribute in cacheList.tpl

3 years agoCheck for WebP support in update_com.woltlab.wcf_5.4_checkSystemRequirements.php
Tim Düsterhus [Mon, 5 Jul 2021 12:18:15 +0000 (14:18 +0200)]
Check for WebP support in update_com.woltlab.wcf_5.4_checkSystemRequirements.php

3 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Mon, 5 Jul 2021 12:17:29 +0000 (14:17 +0200)]
Merge branch '5.3' into 5.4

3 years agoMerge pull request #4368 from WoltLab/upgrade-check-webp
Tim Düsterhus [Mon, 5 Jul 2021 12:09:42 +0000 (14:09 +0200)]
Merge pull request #4368 from WoltLab/upgrade-check-webp

Add check for GD support to PackageEnableUpgradeOverrideForm

3 years agoAdd check for GD support to PackageEnableUpgradeOverrideForm
Tim Düsterhus [Mon, 5 Jul 2021 11:57:40 +0000 (13:57 +0200)]
Add check for GD support to PackageEnableUpgradeOverrideForm

3 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Mon, 5 Jul 2021 10:45:33 +0000 (12:45 +0200)]
Merge branch '5.3' into 5.4

3 years agoValidate the `actionName` in MessageQuoteAction
Tim Düsterhus [Mon, 5 Jul 2021 10:39:50 +0000 (12:39 +0200)]
Validate the `actionName` in MessageQuoteAction

3 years agoFix adding pages if only one language is available
Matthias Schmidt [Mon, 5 Jul 2021 09:53:05 +0000 (11:53 +0200)]
Fix adding pages if only one language is available

See 128dbea9130f7decfb255d0d6e04f83e291021e6

3 years agoFix code formatting issue
Matthias Schmidt [Mon, 5 Jul 2021 09:32:03 +0000 (11:32 +0200)]
Fix code formatting issue

3 years agoEnsure that app abbreviation is unique before app installation
Matthias Schmidt [Fri, 2 Jul 2021 11:23:40 +0000 (13:23 +0200)]
Ensure that app abbreviation is unique before app installation

Close #4344

3 years agoFix path of database PIP file located in `files_wcf/` for DevTools syncs
Matthias Schmidt [Mon, 5 Jul 2021 09:25:37 +0000 (11:25 +0200)]
Fix path of database PIP file located in `files_wcf/` for DevTools syncs

Close #4359

3 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Mon, 5 Jul 2021 07:56:34 +0000 (09:56 +0200)]
Merge branch '5.3' into 5.4

Also applied the second change from #4366.

Co-authored-by: Sascha Greuel <sascha@softcreatr.de>
3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Mon, 5 Jul 2021 07:54:22 +0000 (09:54 +0200)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Mon, 5 Jul 2021 07:54:10 +0000 (09:54 +0200)]
Merge branch '3.1' into 5.2

3 years agoFix typo in de.xml
Tim Düsterhus [Mon, 5 Jul 2021 07:53:22 +0000 (09:53 +0200)]
Fix typo in de.xml

Closes #4366

Co-authored-by: Sascha Greuel <sascha@softcreatr.de>
3 years agoAdd missing `@since` to AbstractOauth2Action
Tim Düsterhus [Mon, 5 Jul 2021 07:01:02 +0000 (09:01 +0200)]
Add missing `@since` to AbstractOauth2Action

3 years agoMake AbstractOauth2Action::getHttpClient() non-final
Tim Düsterhus [Sun, 4 Jul 2021 13:35:07 +0000 (15:35 +0200)]
Make AbstractOauth2Action::getHttpClient() non-final

It might be desirable to be able to add custom headers, specifically a custom
`user-agent`, for non-stock IDPs.

3 years agoFix TOTP QR code in dark styles
Tim Düsterhus [Thu, 1 Jul 2021 13:49:00 +0000 (15:49 +0200)]
Fix TOTP QR code in dark styles

3 years agoRelease 5.3.10 5.3.10
Alexander Ebert [Thu, 1 Jul 2021 12:13:27 +0000 (14:13 +0200)]
Release 5.3.10

3 years agoMerge branch '5.3' into 5.4
Tim Düsterhus [Thu, 1 Jul 2021 09:48:22 +0000 (11:48 +0200)]
Merge branch '5.3' into 5.4

3 years agoMerge pull request #4354 from WoltLab/systemcheck-performance
Tim Düsterhus [Thu, 1 Jul 2021 09:41:48 +0000 (11:41 +0200)]
Merge pull request #4354 from WoltLab/systemcheck-performance

Improve performance of SystemCheckPage::validateWritableDirectories()

3 years agoImprove performance of SystemCheckPage::validateWritableDirectories()
Tim Düsterhus [Thu, 1 Jul 2021 09:21:08 +0000 (11:21 +0200)]
Improve performance of SystemCheckPage::validateWritableDirectories()

The previous implementation resulted in a syscall hell for large attachment or
image directories. RecursiveDirectoryIterator requires two syscalls for
directory entry just for iteration and that does not yet include any custom
logic.

Replace the implementation by a simple `glob()`. This is a small behavior
change, as a `*` will only check the files immediately below the directory in
question instead of recursing all the way down. However this likely is what was
intended anyway.

3 years agoUpdating minified JavaScript files
WoltLab [Thu, 1 Jul 2021 08:32:22 +0000 (08:32 +0000)]
Updating minified JavaScript files

3 years agoModified update instructions 5.4.0_RC_1
Alexander Ebert [Wed, 30 Jun 2021 13:15:45 +0000 (15:15 +0200)]
Modified update instructions

3 years agoHandle Facebook not providing an email address
Tim Düsterhus [Wed, 30 Jun 2021 10:57:11 +0000 (12:57 +0200)]
Handle Facebook not providing an email address

Fixes #4241

3 years agoRegister reauthentication after MFA in ACP only
Tim Düsterhus [Tue, 29 Jun 2021 07:51:13 +0000 (09:51 +0200)]
Register reauthentication after MFA in ACP only

It was not desired that a login within the frontend also registers a
reauthentication, as the actions requiring a reauthentication are very rarely
used and can benefit from this additional password check. In the ACP however
each request requires a reauthentication, thus it makes sense to register it
during login.

see 4624ceeda0e19109245d19e883dc6fd388e95519

3 years agoMerge pull request #4350 from WoltLab/update-server-db
Tim Düsterhus [Mon, 28 Jun 2021 15:39:00 +0000 (17:39 +0200)]
Merge pull request #4350 from WoltLab/update-server-db

Adjust the URL of the update servers in install.sql

3 years agoMerge branch '5.3' into 5.4
Marcel Werk [Mon, 28 Jun 2021 15:27:17 +0000 (17:27 +0200)]
Merge branch '5.3' into 5.4