GitHub/WoltLab/WCF.git
3 years agoMerge pull request #4009 from WoltLab/check-system-requirements
Tim Düsterhus [Tue, 23 Feb 2021 11:00:52 +0000 (12:00 +0100)]
Merge pull request #4009 from WoltLab/check-system-requirements

Check system requirements before starting the upgrade

3 years agoMerge pull request #4001 from WoltLab/avatars
Alexander Ebert [Tue, 23 Feb 2021 10:53:53 +0000 (11:53 +0100)]
Merge pull request #4001 from WoltLab/avatars

Add interface to request safe avatar formats

3 years agoSimplify object type sorting in RebuildDataPage
Tim Düsterhus [Tue, 23 Feb 2021 10:16:33 +0000 (11:16 +0100)]
Simplify object type sorting in RebuildDataPage

3 years agoRemove database encoding check from RebuildDataPage
Tim Düsterhus [Tue, 23 Feb 2021 10:06:44 +0000 (11:06 +0100)]
Remove database encoding check from RebuildDataPage

see 1238dfad4af8f94ea1c7aad09872fdf3d580cff5
see #3570

3 years agoCorrectly handle `null` in benchmark parameter insertion
Tim Düsterhus [Tue, 23 Feb 2021 09:26:33 +0000 (10:26 +0100)]
Correctly handle `null` in benchmark parameter insertion

see 048aaf0c318f01d11da4f6b8c01b6fdd1acbcb7a

3 years agoMerge branch '5.3'
Tim Düsterhus [Tue, 23 Feb 2021 08:50:03 +0000 (09:50 +0100)]
Merge branch '5.3'

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Tue, 23 Feb 2021 08:48:09 +0000 (09:48 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Tue, 23 Feb 2021 08:47:42 +0000 (09:47 +0100)]
Merge branch '3.1' into 5.2

3 years agoMatch all prefixes for store.woltlab.com in PackageAction::validateSearchForPurchased...
Tim Düsterhus [Tue, 23 Feb 2021 08:46:31 +0000 (09:46 +0100)]
Match all prefixes for store.woltlab.com in PackageAction::validateSearchForPurchasedItems()

see #3910

3 years agoMerge branch '5.3'
Tim Düsterhus [Tue, 23 Feb 2021 08:16:34 +0000 (09:16 +0100)]
Merge branch '5.3'

3 years agoRemove return types from ContactRecipient for 5.3
Tim Düsterhus [Tue, 23 Feb 2021 08:13:05 +0000 (09:13 +0100)]
Remove return types from ContactRecipient for 5.3

3 years agoGeneric error messages for failed text option validation
Alexander Ebert [Mon, 22 Feb 2021 23:15:17 +0000 (00:15 +0100)]
Generic error messages for failed text option validation

3 years agoUploading too many attachments yields an incorrect error type
Alexander Ebert [Mon, 22 Feb 2021 23:05:56 +0000 (00:05 +0100)]
Uploading too many attachments yields an incorrect error type

3 years agoRestrict the maximum length of menu items
Alexander Ebert [Mon, 22 Feb 2021 23:01:26 +0000 (00:01 +0100)]
Restrict the maximum length of menu items

3 years agoClicking on notifications did not close the user menu overlay
Alexander Ebert [Mon, 22 Feb 2021 22:56:14 +0000 (23:56 +0100)]
Clicking on notifications did not close the user menu overlay

3 years agoMerge branch '5.3'
Alexander Ebert [Mon, 22 Feb 2021 22:42:13 +0000 (23:42 +0100)]
Merge branch '5.3'

3 years agoRemove inaccessible search results
Alexander Ebert [Mon, 22 Feb 2021 22:39:56 +0000 (23:39 +0100)]
Remove inaccessible search results

3 years agoRequesting the preview caused Firefox to submit the form
Alexander Ebert [Mon, 22 Feb 2021 22:23:29 +0000 (23:23 +0100)]
Requesting the preview caused Firefox to submit the form

3 years agoKeyboard support for drop-down menus with deferred initialization
Alexander Ebert [Mon, 22 Feb 2021 16:10:23 +0000 (17:10 +0100)]
Keyboard support for drop-down menus with deferred initialization

Fixes #3704

3 years agoCheck system requirements before starting the upgrade
Tim Düsterhus [Mon, 22 Feb 2021 11:27:17 +0000 (12:27 +0100)]
Check system requirements before starting the upgrade

Resolves #4008

3 years agoDelete .github/typescript-tsc.json
Tim Düsterhus [Mon, 22 Feb 2021 15:33:20 +0000 (16:33 +0100)]
Delete .github/typescript-tsc.json

Obsolete as of actions/setup-node#125

3 years agoImplement ISafeFormatAvatar in DefaultAvatar
Tim Düsterhus [Mon, 22 Feb 2021 12:50:46 +0000 (13:50 +0100)]
Implement ISafeFormatAvatar in DefaultAvatar

3 years agoMerge pull request #4006 from WoltLab/log_sitemaps_file_log
Joshua Rüsweg [Mon, 22 Feb 2021 10:24:42 +0000 (11:24 +0100)]
Merge pull request #4006 from WoltLab/log_sitemaps_file_log

Log sitemap files for packages to delete them on uninstallation

3 years agoKeyboard support for reactions
Alexander Ebert [Mon, 22 Feb 2021 09:55:22 +0000 (10:55 +0100)]
Keyboard support for reactions

Fixes #3703

3 years agoImproved the accessibility for code listings and quotes
Alexander Ebert [Sun, 21 Feb 2021 12:20:04 +0000 (13:20 +0100)]
Improved the accessibility for code listings and quotes

Fixes #3702

3 years agoClear a dialog callback on runtime
Alexander Ebert [Sun, 21 Feb 2021 11:20:48 +0000 (12:20 +0100)]
Clear a dialog callback on runtime

See #3932

3 years agoLog sitemap files for packages to delete them on uninstallation
joshuaruesweg [Sat, 20 Feb 2021 14:51:08 +0000 (15:51 +0100)]
Log sitemap files for packages to delete them on uninstallation

3 years agoClear the abort callback on worker completion
Alexander Ebert [Sun, 21 Feb 2021 11:02:58 +0000 (12:02 +0100)]
Clear the abort callback on worker completion

Fixes #3932

3 years agoMerge pull request #3995 from WoltLab/email-log
Tim Düsterhus [Thu, 18 Feb 2021 15:31:09 +0000 (16:31 +0100)]
Merge pull request #3995 from WoltLab/email-log

Add Email Log

3 years agoUse stable Message-ID in MailWorker
Tim Düsterhus [Mon, 15 Feb 2021 14:04:57 +0000 (15:04 +0100)]
Use stable Message-ID in MailWorker

3 years agoSet fallback Message-ID in UserNotificationHandler::sendInstantMailNotification()
Tim Düsterhus [Mon, 15 Feb 2021 11:32:40 +0000 (12:32 +0100)]
Set fallback Message-ID in UserNotificationHandler::sendInstantMailNotification()

3 years agoSet explicit Message-ID in UserAction::enable()
Tim Düsterhus [Mon, 15 Feb 2021 11:31:11 +0000 (12:31 +0100)]
Set explicit Message-ID in UserAction::enable()

3 years agoSet explicit Message-ID in SendNewPasswordWorker
Tim Düsterhus [Mon, 15 Feb 2021 11:27:17 +0000 (12:27 +0100)]
Set explicit Message-ID in SendNewPasswordWorker

3 years agoSet explicit Message-ID in ExceptionMailerCronjob
Tim Düsterhus [Mon, 15 Feb 2021 11:25:01 +0000 (12:25 +0100)]
Set explicit Message-ID in ExceptionMailerCronjob

3 years agoAdd filter to EmailLogListPage
Tim Düsterhus [Thu, 18 Feb 2021 13:04:18 +0000 (14:04 +0100)]
Add filter to EmailLogListPage

3 years agoShorten the logged email subject to 20 characters
Tim Düsterhus [Thu, 18 Feb 2021 11:44:48 +0000 (12:44 +0100)]
Shorten the logged email subject to 20 characters

Co-authored-by: Alexander Ebert <ebert@woltlab.com>
3 years agoAdd subject to email log
Tim Düsterhus [Mon, 15 Feb 2021 13:58:50 +0000 (14:58 +0100)]
Add subject to email log

3 years agoRemove `final` from private methods in EmailDeliveryBackgroundJob
Tim Düsterhus [Mon, 15 Feb 2021 13:37:44 +0000 (14:37 +0100)]
Remove `final` from private methods in EmailDeliveryBackgroundJob

3 years agoPrune email log entries
Tim Düsterhus [Mon, 15 Feb 2021 13:27:05 +0000 (14:27 +0100)]
Prune email log entries

3 years agoAdd EmailLogListPage
Tim Düsterhus [Mon, 15 Feb 2021 13:21:27 +0000 (14:21 +0100)]
Add EmailLogListPage

3 years agoReturn status message in SmtpEmailTransport::deliver()
Tim Düsterhus [Mon, 15 Feb 2021 11:15:54 +0000 (12:15 +0100)]
Return status message in SmtpEmailTransport::deliver()

3 years agoUpdate the email log entry when delivery succeeds or fails
Tim Düsterhus [Mon, 15 Feb 2021 11:09:16 +0000 (12:09 +0100)]
Update the email log entry when delivery succeeds or fails

3 years agoCreate email log entry when creating a delivery job
Tim Düsterhus [Mon, 15 Feb 2021 10:44:32 +0000 (11:44 +0100)]
Create email log entry when creating a delivery job

3 years agoCall ->onFinalFailure() when encountering a PermanentFailure during email delivery
Tim Düsterhus [Mon, 15 Feb 2021 10:43:16 +0000 (11:43 +0100)]
Call ->onFinalFailure() when encountering a PermanentFailure during email delivery

3 years agoAdd wcf1_email_log_entry
Tim Düsterhus [Mon, 15 Feb 2021 10:15:39 +0000 (11:15 +0100)]
Add wcf1_email_log_entry

3 years agoUse 'php' diff driver for PHP files
Tim Düsterhus [Thu, 18 Feb 2021 13:56:10 +0000 (14:56 +0100)]
Use 'php' diff driver for PHP files

3 years agoMerge pull request #4003 from WoltLab/contact-form-disable-admin
Tim Düsterhus [Thu, 18 Feb 2021 12:38:24 +0000 (13:38 +0100)]
Merge pull request #4003 from WoltLab/contact-form-disable-admin

Allow disabling the admin contact in ContactForm

3 years agoReturn AvatarDecorator in UserProfile::getAvatar()
Tim Düsterhus [Wed, 17 Feb 2021 15:05:54 +0000 (16:05 +0100)]
Return AvatarDecorator in UserProfile::getAvatar()

3 years agoImplement ISafeFormatAvatar in UserAvatar
Tim Düsterhus [Wed, 17 Feb 2021 14:49:39 +0000 (15:49 +0100)]
Implement ISafeFormatAvatar in UserAvatar

3 years agoAdd AvatarDecorator
Tim Düsterhus [Wed, 17 Feb 2021 14:49:23 +0000 (15:49 +0100)]
Add AvatarDecorator

3 years agoAdd ISafeFormatAvatar
Tim Düsterhus [Wed, 17 Feb 2021 14:49:05 +0000 (15:49 +0100)]
Add ISafeFormatAvatar

3 years agoRemove deprecated methods from IUserAvatar interface
Tim Düsterhus [Wed, 17 Feb 2021 14:36:00 +0000 (15:36 +0100)]
Remove deprecated methods from IUserAvatar interface

3 years agoAllow disabling the admin contact in ContactForm
Tim Düsterhus [Thu, 18 Feb 2021 11:23:23 +0000 (12:23 +0100)]
Allow disabling the admin contact in ContactForm

Resolves #3967

3 years agoMerge pull request #4002 from WoltLab/box-content-loading
Tim Düsterhus [Thu, 18 Feb 2021 10:40:24 +0000 (11:40 +0100)]
Merge pull request #4002 from WoltLab/box-content-loading

Preload box content even for system boxes

3 years agoPreload box content even for system boxes
Tim Düsterhus [Thu, 18 Feb 2021 10:30:33 +0000 (11:30 +0100)]
Preload box content even for system boxes

Box::getBoxContentTitle() unconditionally loads the box contents for all box
types, because even system boxes might fall back to the box title that is
configured within the ACP.

This might result on O(n) queries when a page has several system boxes.

Fix this issue by preloading the box contents for all boxes.

3 years agoAdd 'name' to the contact form's `Reply-To` Mailbox
Tim Düsterhus [Thu, 18 Feb 2021 10:14:57 +0000 (11:14 +0100)]
Add 'name' to the contact form's `Reply-To` Mailbox

3 years agoMerge branch '5.3'
Tim Düsterhus [Thu, 18 Feb 2021 10:12:38 +0000 (11:12 +0100)]
Merge branch '5.3'

3 years agoFix use of localized recipient email addresses in contact form
Tim Düsterhus [Thu, 18 Feb 2021 10:08:05 +0000 (11:08 +0100)]
Fix use of localized recipient email addresses in contact form

3 years agoUpdate to setup-node@v2
Tim Düsterhus [Thu, 18 Feb 2021 09:57:55 +0000 (10:57 +0100)]
Update to setup-node@v2

3 years agoMerge pull request #3991 from WoltLab/settings-section-anchors
Tim Düsterhus [Thu, 18 Feb 2021 08:06:42 +0000 (09:06 +0100)]
Merge pull request #3991 from WoltLab/settings-section-anchors

Add anchors to account settings

3 years agoReturn the SystemException's description in extra information only if not empty
Tim Düsterhus [Wed, 17 Feb 2021 10:54:27 +0000 (11:54 +0100)]
Return the SystemException's description in extra information only if not empty

see 72ae641557703c600de12c07a04346ba16001251

3 years agoFix the visual marking of the markAll checkbox for Controller/Clipboard.ts
Tim Düsterhus [Tue, 16 Feb 2021 15:26:35 +0000 (16:26 +0100)]
Fix the visual marking of the markAll checkbox for Controller/Clipboard.ts

During the refactoring to TypeScript it was missed that after matching the
`.columnMark` class another access to `.parentNode` happens:

https://github.com/WoltLab/WCF/blob/6a623551e6d7a08ffdf7a623aa174e644af7a0d5/wcfsetup/install/files/js/WoltLabSuite/Core/Controller/Clipboard.js#L691

Fixes #3999

3 years agoFix calling UserAction::update() for 'counters' only
Tim Düsterhus [Tue, 16 Feb 2021 14:11:30 +0000 (15:11 +0100)]
Fix calling UserAction::update() for 'counters' only

This fixes:
> Undefined array key "data"

see 21dd1c3dafe4cfdc31748da4aae3027d63316d70

3 years agoMove `<meta charset="utf-8">` before `<title>` in WCFSetup
Tim Düsterhus [Tue, 16 Feb 2021 13:20:32 +0000 (14:20 +0100)]
Move `<meta charset="utf-8">` before `<title>` in WCFSetup

see #3802

3 years agoMove `<meta charset="utf-8">` before `<title>` in exception handler
Tim Düsterhus [Tue, 16 Feb 2021 13:20:08 +0000 (14:20 +0100)]
Move `<meta charset="utf-8">` before `<title>` in exception handler

see #3802

3 years agoMove `<meta charset="utf-8">` before `<title>` in install.php
Tim Düsterhus [Tue, 16 Feb 2021 13:19:07 +0000 (14:19 +0100)]
Move `<meta charset="utf-8">` before `<title>` in install.php

see #3802

3 years agoMerge branch '5.3'
Tim Düsterhus [Tue, 16 Feb 2021 11:54:29 +0000 (12:54 +0100)]
Merge branch '5.3'

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Tue, 16 Feb 2021 11:40:15 +0000 (12:40 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Tue, 16 Feb 2021 11:40:03 +0000 (12:40 +0100)]
Merge branch '3.1' into 5.2

3 years agoMerge branch '3.0' into 3.1
Tim Düsterhus [Tue, 16 Feb 2021 11:38:24 +0000 (12:38 +0100)]
Merge branch '3.0' into 3.1

3 years agoMerge pull request #3997 from WoltLab/major-upgrade-no-upload
Tim Düsterhus [Tue, 16 Feb 2021 11:37:59 +0000 (12:37 +0100)]
Merge pull request #3997 from WoltLab/major-upgrade-no-upload

Reject major com.woltlab.wcf upgrades via package upload

3 years agoReject major com.woltlab.wcf upgrades via package upload
Tim Düsterhus [Tue, 16 Feb 2021 11:11:21 +0000 (12:11 +0100)]
Reject major com.woltlab.wcf upgrades via package upload

3 years agoMerge branch 'master' of https://github.com/WoltLab/WCF
Marcel Werk [Tue, 16 Feb 2021 10:51:40 +0000 (11:51 +0100)]
Merge branch 'master' of https://github.com/WoltLab/WCF

3 years agoAdded missing literal tag
Marcel Werk [Tue, 16 Feb 2021 10:51:37 +0000 (11:51 +0100)]
Added missing literal tag

3 years agoFix typo in comment in PackageInstallationConfirmPage
Tim Düsterhus [Tue, 16 Feb 2021 10:20:17 +0000 (11:20 +0100)]
Fix typo in comment in PackageInstallationConfirmPage

3 years agoAdd prefix to accountSecurity / settings section `id`s
Tim Düsterhus [Tue, 16 Feb 2021 09:03:50 +0000 (10:03 +0100)]
Add prefix to accountSecurity / settings section `id`s

3 years agoMerge branch '5.3'
Tim Düsterhus [Tue, 16 Feb 2021 08:29:57 +0000 (09:29 +0100)]
Merge branch '5.3'

3 years agoStream the response in ImageProxyAction
Tim Düsterhus [Tue, 16 Feb 2021 08:23:58 +0000 (09:23 +0100)]
Stream the response in ImageProxyAction

see 5fc80baf9a348a63baaaa6fa150b1732adfc9f3c

3 years agoMerge branch 'master' of github.com:WoltLab/WCF
Tim Düsterhus [Tue, 16 Feb 2021 08:20:54 +0000 (09:20 +0100)]
Merge branch 'master' of github.com:WoltLab/WCF

3 years agoMerge branch '5.3'
Tim Düsterhus [Tue, 16 Feb 2021 08:20:38 +0000 (09:20 +0100)]
Merge branch '5.3'

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Tue, 16 Feb 2021 08:18:58 +0000 (09:18 +0100)]
Merge branch '5.2' into 5.3

3 years agoFixes twitch clips which contain a dash char
Sir-Will [Mon, 15 Feb 2021 18:48:20 +0000 (19:48 +0100)]
Fixes twitch clips which contain a dash char

Twitch clips can contain a dash (´-`).
Example: https://clips.twitch.tv/NeighborlyManlyBaconMikeHogu-_9zfXbRK47vik1WO

Resolves #3996

3 years agoThe mail notification type was unselectable
Alexander Ebert [Mon, 15 Feb 2021 19:05:54 +0000 (20:05 +0100)]
The mail notification type was unselectable

3 years agoMerge pull request #3994 from WoltLab/simplify-notification-phrases
Alexander Ebert [Sun, 14 Feb 2021 16:11:32 +0000 (17:11 +0100)]
Merge pull request #3994 from WoltLab/simplify-notification-phrases

Simplify phrases for notifications

3 years agoUpdated privacy policy regarding profile information of third-party logins
Marcel Werk [Sun, 14 Feb 2021 12:58:08 +0000 (13:58 +0100)]
Updated privacy policy regarding profile information of third-party logins

Closes #3925

3 years agoMerge branch '5.2' into 5.3
joshuaruesweg [Sun, 14 Feb 2021 12:37:54 +0000 (13:37 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix deleting an empty list of objects
joshuaruesweg [Sun, 14 Feb 2021 12:35:03 +0000 (13:35 +0100)]
Fix deleting an empty list of objects

It can happen that content that was previously counted no longer exists and therefore fewer runs are required than initially assumed. This can happen if, for example, a user's posts and threads are deleted and the user has only written posts in his or her own threads (the posts are then deleted along with the threads). This may have led to errors before because an empty list of objects was passed.

3 years agoAdjusted/unified html attributes for avatars
Marcel Werk [Sun, 14 Feb 2021 12:29:58 +0000 (13:29 +0100)]
Adjusted/unified html attributes for avatars

3 years agoUse guest support of UserFunctionTemplatePlugin
Marcel Werk [Sun, 14 Feb 2021 11:44:39 +0000 (12:44 +0100)]
Use guest support of UserFunctionTemplatePlugin

See #3989

3 years agoSimplify phrases for notifications
Marcel Werk [Sat, 13 Feb 2021 20:36:58 +0000 (21:36 +0100)]
Simplify phrases for notifications

See #3958

3 years agoMerge branch '5.3'
Tim Düsterhus [Fri, 12 Feb 2021 15:39:16 +0000 (16:39 +0100)]
Merge branch '5.3'

3 years agoMerge pull request #3992 from WoltLab/export-mail-address-permission
Tim Düsterhus [Fri, 12 Feb 2021 14:55:58 +0000 (15:55 +0100)]
Merge pull request #3992 from WoltLab/export-mail-address-permission

Bind exportMailAddress bulk process to `canEditMailAddress` instead of `canMailUser`

3 years agoBind exportMailAddress bulk process to `canEditMailAddress` instead of `canMailUser`
Tim Düsterhus [Fri, 12 Feb 2021 14:46:44 +0000 (15:46 +0100)]
Bind exportMailAddress bulk process to `canEditMailAddress` instead of `canMailUser`

Unfortunately the `permissions` form a logical disjunction, not a conjunction,
thus we can't check both permissions. The `canEditMailAddress` is more fitting,
because even without `canMailUser` the admin could simply look up all users
manually if they are allowed to edit (and thus see) mail addresses. It's just a
larger effort.

Resolves #3963

3 years agoMake SystemException implement IExtraInformationException
Tim Düsterhus [Fri, 12 Feb 2021 13:59:02 +0000 (14:59 +0100)]
Make SystemException implement IExtraInformationException

This allows logging the `$description`.

Resolves #3944

3 years agoMake use of anchors when linking to AccountSecurityPage
Tim Düsterhus [Fri, 12 Feb 2021 13:42:08 +0000 (14:42 +0100)]
Make use of anchors when linking to AccountSecurityPage

3 years agoAdd `id`s to sections in AccountSecurityPage
Tim Düsterhus [Fri, 12 Feb 2021 13:37:11 +0000 (14:37 +0100)]
Add `id`s to sections in AccountSecurityPage

3 years agoAdd `id`s to sections in SettingsForm
Tim Düsterhus [Fri, 12 Feb 2021 13:36:32 +0000 (14:36 +0100)]
Add `id`s to sections in SettingsForm

Resolves #3972

3 years agoMerge pull request #3990 from WoltLab/guest-user-function-template-plugin
Marcel Werk [Fri, 12 Feb 2021 12:51:09 +0000 (13:51 +0100)]
Merge pull request #3990 from WoltLab/guest-user-function-template-plugin

Support guest users in UserFunctionTemplatePlugin

3 years agoMerge pull request #3987 from WoltLab/visit-tracker-after-registration
Tim Düsterhus [Fri, 12 Feb 2021 12:47:29 +0000 (13:47 +0100)]
Merge pull request #3987 from WoltLab/visit-tracker-after-registration

Mark contents created before user registration as read

3 years agoMerge pull request #3986 from WoltLab/wcfsetup-all-languages
Tim Düsterhus [Fri, 12 Feb 2021 12:46:49 +0000 (13:46 +0100)]
Merge pull request #3986 from WoltLab/wcfsetup-all-languages

Remove language selection from WCFSetup