GitHub/WoltLab/WCF.git
5 years agoMerge branch '3.0'
Tim Düsterhus [Thu, 13 Sep 2018 18:37:49 +0000 (20:37 +0200)]
Merge branch '3.0'

5 years agoPrevent GravatarDownloadAction from downloading if module is off
Tim Düsterhus [Thu, 13 Sep 2018 18:36:12 +0000 (20:36 +0200)]
Prevent GravatarDownloadAction from downloading if module is off

5 years agoShow proper error messages for XHR without responseText
Tim Düsterhus [Thu, 13 Sep 2018 13:56:52 +0000 (15:56 +0200)]
Show proper error messages for XHR without responseText

This can happen if the domain name cannot be resolved or if
the request is blocked because of CORS.

5 years agoMerge branch '3.0'
Tim Düsterhus [Thu, 13 Sep 2018 13:56:27 +0000 (15:56 +0200)]
Merge branch '3.0'

5 years agoImprove error message if Dialog._createDialog receives invalid `html`
Tim Düsterhus [Thu, 13 Sep 2018 13:42:41 +0000 (15:42 +0200)]
Improve error message if Dialog._createDialog receives invalid `html`

5 years agoMerge branch '3.0'
Marcel Werk [Fri, 7 Sep 2018 14:26:22 +0000 (16:26 +0200)]
Merge branch '3.0'

5 years agoUpdated outdated links in the cookie policy
Marcel Werk [Fri, 7 Sep 2018 14:07:33 +0000 (16:07 +0200)]
Updated outdated links in the cookie policy

5 years agoMerge branch '3.0'
Marcel Werk [Fri, 7 Sep 2018 11:23:11 +0000 (13:23 +0200)]
Merge branch '3.0'

5 years agoFixed sorting in member list
Marcel Werk [Fri, 7 Sep 2018 11:21:33 +0000 (13:21 +0200)]
Fixed sorting in member list

5 years agoMerge branch '3.0'
Marcel Werk [Thu, 6 Sep 2018 09:36:17 +0000 (11:36 +0200)]
Merge branch '3.0'

5 years agoFixed missing css classes in avatar edit form
Marcel Werk [Thu, 6 Sep 2018 09:35:31 +0000 (11:35 +0200)]
Fixed missing css classes in avatar edit form

5 years agoMerge branch 'master' of https://github.com/WoltLab/WCF
Marcel Werk [Thu, 6 Sep 2018 09:30:27 +0000 (11:30 +0200)]
Merge branch 'master' of https://github.com/WoltLab/WCF

5 years agoMerge pull request #2747 from jens1o/patch-1
Marcel Werk [Tue, 4 Sep 2018 15:36:11 +0000 (17:36 +0200)]
Merge pull request #2747 from jens1o/patch-1

fix typo

5 years agofix typo
Jens Hausdorf [Tue, 4 Sep 2018 15:27:35 +0000 (17:27 +0200)]
fix typo

5 years agoUnified phrases
Marcel Werk [Tue, 4 Sep 2018 13:30:54 +0000 (15:30 +0200)]
Unified phrases

5 years agoUnified phrases
Marcel Werk [Tue, 4 Sep 2018 13:24:30 +0000 (15:24 +0200)]
Unified phrases

5 years agoMerge branch '3.0'
Marcel Werk [Tue, 4 Sep 2018 13:21:30 +0000 (15:21 +0200)]
Merge branch '3.0'

5 years agoFixed typo
Marcel Werk [Tue, 4 Sep 2018 13:21:11 +0000 (15:21 +0200)]
Fixed typo

5 years agoFixed typo
Marcel Werk [Tue, 4 Sep 2018 13:18:07 +0000 (15:18 +0200)]
Fixed typo

5 years agoMerge branch '3.0'
Marcel Werk [Tue, 4 Sep 2018 13:00:41 +0000 (15:00 +0200)]
Merge branch '3.0'

5 years agoFixed typo
Marcel Werk [Tue, 4 Sep 2018 13:00:12 +0000 (15:00 +0200)]
Fixed typo

5 years agoUnified phrases
Marcel Werk [Tue, 4 Sep 2018 12:52:36 +0000 (14:52 +0200)]
Unified phrases

5 years agoMerge branch '3.0'
Matthias Schmidt [Sun, 2 Sep 2018 15:00:59 +0000 (17:00 +0200)]
Merge branch '3.0'

5 years agoFix circular dependency issue in Language module
Matthias Schmidt [Sun, 2 Sep 2018 15:00:26 +0000 (17:00 +0200)]
Fix circular dependency issue in Language module

5 years agoMerge branch '3.0'
Matthias Schmidt [Sun, 2 Sep 2018 11:22:43 +0000 (13:22 +0200)]
Merge branch '3.0'

5 years agoAdd missing `content` child for boxes' `content` element in `box.xsd`
Matthias Schmidt [Sun, 2 Sep 2018 11:22:15 +0000 (13:22 +0200)]
Add missing `content` child for boxes' `content` element in `box.xsd`

Fixes #2717

5 years agoMerge branch 'master' of https://github.com/WoltLab/WCF
Marcel Werk [Thu, 30 Aug 2018 17:39:07 +0000 (19:39 +0200)]
Merge branch 'master' of https://github.com/WoltLab/WCF

5 years agoFixed undersized og images in articles
Marcel Werk [Thu, 30 Aug 2018 17:39:02 +0000 (19:39 +0200)]
Fixed undersized og images in articles

5 years agoRemove spurious `continue` from InstallPackageAction
Tim Düsterhus [Tue, 28 Aug 2018 16:11:24 +0000 (18:11 +0200)]
Remove spurious `continue` from InstallPackageAction

see 2b6889512694c9e2fecec840733beb9426e106aa

5 years agoRemove spurious `continue` from UninstallPackageAction
Tim Düsterhus [Tue, 28 Aug 2018 16:07:03 +0000 (18:07 +0200)]
Remove spurious `continue` from UninstallPackageAction

This complains as of PHP 7.3 [1] and there is no loop to be found. The git
history does not provide any insight either: It exists since the initial
import.

[1] "continue" targeting switch is equivalent to "break". Did you mean to
    use "continue 2"?

5 years agoMerge branch '3.0'
Marcel Werk [Mon, 27 Aug 2018 10:57:57 +0000 (12:57 +0200)]
Merge branch '3.0'

5 years agoFixed broken media images in the editor
Marcel Werk [Mon, 27 Aug 2018 10:54:10 +0000 (12:54 +0200)]
Fixed broken media images in the editor

5 years agoAdd `insteadOfReadObjects@MultipleLinkPage` event
Matthias Schmidt [Sun, 26 Aug 2018 14:48:04 +0000 (16:48 +0200)]
Add `insteadOfReadObjects@MultipleLinkPage` event

5 years agoMerge branch '3.0'
Joshua Rüsweg [Thu, 23 Aug 2018 15:00:32 +0000 (17:00 +0200)]
Merge branch '3.0'

5 years agoFix setting monolingual i18n items with js
Joshua Rüsweg [Thu, 23 Aug 2018 14:58:44 +0000 (16:58 +0200)]
Fix setting monolingual i18n items with js

5 years agoTrim spaces from host, username and password in SmtpEmailTransport
Tim Düsterhus [Thu, 23 Aug 2018 13:57:59 +0000 (15:57 +0200)]
Trim spaces from host, username and password in SmtpEmailTransport

Fixes #2703

5 years agoFix position of bottom pagination in exceptionLogView
Tim Düsterhus [Thu, 23 Aug 2018 13:34:20 +0000 (15:34 +0200)]
Fix position of bottom pagination in exceptionLogView

see 537cac2ef50e410b4ee622f478d66c78dd15b673

5 years agoMerge branch '3.0'
Joshua Rüsweg [Sun, 19 Aug 2018 13:40:40 +0000 (15:40 +0200)]
Merge branch '3.0'

5 years agoMerge branch 'Fabii547-patch-55' into 3.0
Joshua Rüsweg [Sun, 19 Aug 2018 13:33:03 +0000 (15:33 +0200)]
Merge branch 'Fabii547-patch-55' into 3.0

5 years agoFix UserProfileCommentResponseOwnerUserNotificationEvent::getLink()
Fabii547 [Sat, 18 Aug 2018 09:13:52 +0000 (11:13 +0200)]
Fix UserProfileCommentResponseOwnerUserNotificationEvent::getLink()

UserProfileCommentResponseOwnerUserNotificationEvent::getLink() now returns the correct link when using an event listener on fireEvent@wcf\system\user\notification\UserNotificationHandler

Fix usage of the RuntimeCacheBuilder

5 years agoPreparing the release 3.1.5 pl 1 3.1.5_pl_1
Alexander Ebert [Sat, 18 Aug 2018 17:48:30 +0000 (19:48 +0200)]
Preparing the release 3.1.5 pl 1

5 years agoMerge branch '3.0'
Alexander Ebert [Sat, 18 Aug 2018 17:48:21 +0000 (19:48 +0200)]
Merge branch '3.0'

5 years agoPreparing the release 3.0.17 pl 1 3.0.17_pl_1
Alexander Ebert [Sat, 18 Aug 2018 17:44:59 +0000 (19:44 +0200)]
Preparing the release 3.0.17 pl 1

5 years agoForce-reset all cronjobs to their default state
Alexander Ebert [Sat, 18 Aug 2018 17:39:31 +0000 (19:39 +0200)]
Force-reset all cronjobs to their default state

5 years agoMerge pull request #2741 from WoltLab/cronjobs
Alexander Ebert [Sat, 18 Aug 2018 17:35:49 +0000 (19:35 +0200)]
Merge pull request #2741 from WoltLab/cronjobs

Fix logic in CronjobScheduler

5 years agoUpdating minified JavaScript files
woltlab.com [Sat, 18 Aug 2018 17:24:09 +0000 (17:24 +0000)]
Updating minified JavaScript files

5 years agoMerge branch '3.0'
Alexander Ebert [Sat, 18 Aug 2018 17:16:48 +0000 (19:16 +0200)]
Merge branch '3.0'

5 years agoRemove failCount condition from CronjobScheduler::resetFailedCronjobs()
Tim Düsterhus [Sat, 18 Aug 2018 16:37:05 +0000 (18:37 +0200)]
Remove failCount condition from CronjobScheduler::resetFailedCronjobs()

It is redundant with the isDisabled condition and might cause issues.

5 years agoAdd logging when Cronjobs are being reset to READY
Tim Düsterhus [Sat, 18 Aug 2018 16:31:25 +0000 (18:31 +0200)]
Add logging when Cronjobs are being reset to READY

5 years agoFix logic in CronjobScheduler::resetFailedCronjobs()
Tim Düsterhus [Sat, 18 Aug 2018 16:16:19 +0000 (18:16 +0200)]
Fix logic in CronjobScheduler::resetFailedCronjobs()

This adds the missing check for `state <> READY` to the query.

Consider the following situation in a low traffic community. The
cronjob is assumed to be executed every five minutes.

0000 Cronjob is executed regularly (next = 0005, afterNext = 0010).
0012 A visitor triggers the cronjobs, afterNext is in the past, thus
     the cronjob is assumed to have failed (next = 0015,
                                            afterNext = 0020).
0027 A visitor triggers the cronjobs, afterNext is in the past, thus
     the cronjob is assumed to have failed (next = 0030,
                                            afterNext = 0035).
0039 A visitor triggers the cronjobs, afterNext is in the past, thus
     the cronjob is assumed to have failed (next = 0040,
                                            afterNext = 0045).
0100 A visitor triggers the cronjobs, afterNext is in the past, thus
     the cronjob is assumed to have failed. The cronjob now missed
     it's execution window for 3 times and is being disabled.

With this change the state is checked to not be READY, in this case
it should have been already processed in another request when
afterNextExec lies in the past:

If the state is EXECUTING then the cronjob is the actual cause of
failure, if the state is PENDING then the cronjob is innocent and
just happens to be a bystander.

5 years agoCatch any type of Exception in CronjobScheduler
Tim Düsterhus [Sat, 18 Aug 2018 16:05:58 +0000 (18:05 +0200)]
Catch any type of Exception in CronjobScheduler

5 years agoUpdating minified JavaScript files
woltlab.com [Sat, 18 Aug 2018 16:13:55 +0000 (16:13 +0000)]
Updating minified JavaScript files

5 years agoAvoid writing to `arguments` directly, strange optimization result
Alexander Ebert [Sat, 18 Aug 2018 16:11:34 +0000 (18:11 +0200)]
Avoid writing to `arguments` directly, strange optimization result

5 years agoFix calculation of afterNextExec in CronjobScheduler::resetFailedCronjobs()
Tim Düsterhus [Sat, 18 Aug 2018 16:04:37 +0000 (18:04 +0200)]
Fix calculation of afterNextExec in CronjobScheduler::resetFailedCronjobs()

see 7dabbb18927ec523716a2a874d4de116383d1f87

5 years agoFix some typos (#2740)
Jens Hausdorf [Sat, 18 Aug 2018 13:09:27 +0000 (15:09 +0200)]
Fix some typos (#2740)

5 years agofix typo (#2738)
Jens Hausdorf [Sat, 18 Aug 2018 07:47:49 +0000 (09:47 +0200)]
fix typo (#2738)

* fix typo

* fix typos

5 years agoUpdated the release date 3.1.5
Alexander Ebert [Fri, 17 Aug 2018 11:19:04 +0000 (13:19 +0200)]
Updated the release date

5 years agoMerge branch '3.0'
Alexander Ebert [Fri, 17 Aug 2018 10:51:11 +0000 (12:51 +0200)]
Merge branch '3.0'

5 years agoPreparing the release 3.0.17 3.0.17
Alexander Ebert [Fri, 17 Aug 2018 09:52:11 +0000 (11:52 +0200)]
Preparing the release 3.0.17

5 years agoSoft-limit for the length of the open/close HTML tags
Alexander Ebert [Fri, 17 Aug 2018 09:14:41 +0000 (11:14 +0200)]
Soft-limit for the length of the open/close HTML tags

5 years agoTypos
Alexander Ebert [Fri, 17 Aug 2018 09:08:16 +0000 (11:08 +0200)]
Typos

5 years agoFixed typo
Marcel Werk [Mon, 13 Aug 2018 14:11:17 +0000 (16:11 +0200)]
Fixed typo

5 years agoMerge branch '3.0'
Joshua Rüsweg [Sun, 12 Aug 2018 12:24:56 +0000 (14:24 +0200)]
Merge branch '3.0'

# Conflicts:
# wcfsetup/install/files/lib/data/page/PageAction.class.php

5 years agoDelete page comments after deleting the page
Joshua Rüsweg [Sun, 12 Aug 2018 12:21:15 +0000 (14:21 +0200)]
Delete page comments after deleting the page

5 years agoMerge branch '3.0'
Matthias Schmidt [Sat, 11 Aug 2018 13:53:13 +0000 (15:53 +0200)]
Merge branch '3.0'

5 years agoFix user option condition forms ignoring set default values
Matthias Schmidt [Sat, 11 Aug 2018 13:52:33 +0000 (15:52 +0200)]
Fix user option condition forms ignoring set default values

5 years agoPreparing the release 3.1.5
Alexander Ebert [Fri, 10 Aug 2018 14:22:56 +0000 (16:22 +0200)]
Preparing the release 3.1.5

5 years agoUpdating minified JavaScript files
woltlab.com [Fri, 10 Aug 2018 13:26:05 +0000 (13:26 +0000)]
Updating minified JavaScript files

5 years agoMerge branch '3.0'
Alexander Ebert [Fri, 10 Aug 2018 11:29:45 +0000 (13:29 +0200)]
Merge branch '3.0'

5 years agoUpdate the image when rotating by 180deg
Alexander Ebert [Fri, 10 Aug 2018 11:29:20 +0000 (13:29 +0200)]
Update the image when rotating by 180deg

Replaces 329f42e09c06cb7b69fb26cfc92beb6d3b435b74

5 years agoMerge branch '3.0'
Alexander Ebert [Fri, 10 Aug 2018 11:05:39 +0000 (13:05 +0200)]
Merge branch '3.0'

5 years agoUpdate the image when rotating by 180deg
Alexander Ebert [Fri, 10 Aug 2018 11:04:10 +0000 (13:04 +0200)]
Update the image when rotating by 180deg

5 years agoMinor phrasing improvements
Alexander Ebert [Fri, 10 Aug 2018 11:00:10 +0000 (13:00 +0200)]
Minor phrasing improvements

5 years agoMerge branch '3.0'
Alexander Ebert [Fri, 10 Aug 2018 10:56:05 +0000 (12:56 +0200)]
Merge branch '3.0'

5 years agoProper HTML processing for page rebuilds
Alexander Ebert [Fri, 10 Aug 2018 10:52:55 +0000 (12:52 +0200)]
Proper HTML processing for page rebuilds

5 years agoUpdating minified JavaScript files
woltlab.com [Fri, 10 Aug 2018 09:47:39 +0000 (09:47 +0000)]
Updating minified JavaScript files

5 years agoPrevent concurrent message submit requests
Alexander Ebert [Fri, 10 Aug 2018 09:40:12 +0000 (11:40 +0200)]
Prevent concurrent message submit requests

5 years agoUpdating minified JavaScript files
woltlab.com [Thu, 9 Aug 2018 11:22:11 +0000 (11:22 +0000)]
Updating minified JavaScript files

5 years agoUpdating minified JavaScript files
woltlab.com [Thu, 9 Aug 2018 11:15:37 +0000 (11:15 +0000)]
Updating minified JavaScript files

5 years agoMerge branch '3.0'
Marcel Werk [Thu, 9 Aug 2018 10:22:14 +0000 (12:22 +0200)]
Merge branch '3.0'

5 years agoFixed broken indentation in multi-category condition
Marcel Werk [Thu, 9 Aug 2018 10:20:44 +0000 (12:20 +0200)]
Fixed broken indentation in multi-category condition

5 years agoFix trophies are not shown, if the user option is not set
Joshua Rüsweg [Thu, 9 Aug 2018 08:07:08 +0000 (10:07 +0200)]
Fix trophies are not shown, if the user option is not set

5 years agoMerge branch '3.0'
Alexander Ebert [Mon, 6 Aug 2018 15:26:47 +0000 (17:26 +0200)]
Merge branch '3.0'

5 years agoUse height/width attributes for compatibility
Alexander Ebert [Mon, 6 Aug 2018 15:26:18 +0000 (17:26 +0200)]
Use height/width attributes for compatibility

See #2555

5 years agoAdd width/height properties for default avatars (#2555)
Sascha Greuel [Sat, 19 May 2018 18:47:44 +0000 (20:47 +0200)]
Add width/height properties for default avatars (#2555)

* Added width/height properties for default avatars

Under certain circumstances, it is possible, that a browser strips the style tag on SVG images. This leads to a display of very tiny avatar images as shown below:

Since `width` and `height` are valid properties and respected by every browser, it's not the worst idea to include them.

* Removed redundant style attribute

5 years agoIncorrect usage of `continue`
Alexander Ebert [Mon, 6 Aug 2018 15:14:38 +0000 (17:14 +0200)]
Incorrect usage of `continue`

Fixes #2730

5 years agoMerge branch '3.0'
Alexander Ebert [Mon, 6 Aug 2018 11:50:40 +0000 (13:50 +0200)]
Merge branch '3.0'

5 years agoConvert <br> inside <pre> into plain newline characters
Alexander Ebert [Mon, 6 Aug 2018 11:38:25 +0000 (13:38 +0200)]
Convert <br> inside <pre> into plain newline characters

5 years agoLogo was 1px too wide
Alexander Ebert [Mon, 6 Aug 2018 11:25:15 +0000 (13:25 +0200)]
Logo was 1px too wide

5 years agoConverting multiple code blocks let to discarded newlines
Alexander Ebert [Wed, 13 Jun 2018 10:23:46 +0000 (12:23 +0200)]
Converting multiple code blocks let to discarded newlines

The XPath expression matched the global scope, eventually removing the newlines inside previously converted code blocks.

5 years agoMerge branch '3.0'
Marcel Werk [Mon, 6 Aug 2018 09:09:40 +0000 (11:09 +0200)]
Merge branch '3.0'

5 years agoDisallow search for updates when benchmark is enabled
Marcel Werk [Mon, 6 Aug 2018 09:08:11 +0000 (11:08 +0200)]
Disallow search for updates when benchmark is enabled

5 years agoFixed typo
Marcel Werk [Mon, 6 Aug 2018 08:12:30 +0000 (10:12 +0200)]
Fixed typo

5 years agoFixed typo
Marcel Werk [Mon, 6 Aug 2018 08:05:18 +0000 (10:05 +0200)]
Fixed typo

5 years agoMerge branch '3.0'
Marcel Werk [Wed, 1 Aug 2018 14:30:53 +0000 (16:30 +0200)]
Merge branch '3.0'

5 years agoFixed missing permission check
Marcel Werk [Wed, 1 Aug 2018 14:29:42 +0000 (16:29 +0200)]
Fixed missing permission check

5 years agoMerge branch '3.0'
Tim Düsterhus [Mon, 30 Jul 2018 21:39:30 +0000 (23:39 +0200)]
Merge branch '3.0'

5 years agoAdd support for infinite memory limit in ExceptionLogViewPage
Tim Düsterhus [Mon, 30 Jul 2018 21:38:35 +0000 (23:38 +0200)]
Add support for infinite memory limit in ExceptionLogViewPage

5 years agoReset previously failed cronjobs before executing them (#2726)
Alexander Ebert [Mon, 30 Jul 2018 13:34:36 +0000 (15:34 +0200)]
Reset previously failed cronjobs before executing them (#2726)

* Reset previously failed cronjobs before executing them

* Missing method call to reset the failed cronjobs

5 years agoFixed typo
Marcel Werk [Mon, 30 Jul 2018 08:55:41 +0000 (10:55 +0200)]
Fixed typo