GitHub/WoltLab/WCF.git
2 years agoReduce the number of function calls in Tar::readHeader()
Tim Düsterhus [Tue, 17 May 2022 12:33:09 +0000 (14:33 +0200)]
Reduce the number of function calls in Tar::readHeader()

2 years agoMerge pull request #4785 from WoltLab/remove-multi-domain
Alexander Ebert [Tue, 17 May 2022 10:48:11 +0000 (12:48 +0200)]
Merge pull request #4785 from WoltLab/remove-multi-domain

Remove multi-domain support

2 years agoMerge branch '5.5'
Tim Düsterhus [Tue, 17 May 2022 09:08:10 +0000 (11:08 +0200)]
Merge branch '5.5'

2 years agoMerge branch '5.5'
Tim Düsterhus [Tue, 17 May 2022 09:07:15 +0000 (11:07 +0200)]
Merge branch '5.5'

2 years agoUnified phrases for deprecated options
Marcel Werk [Tue, 17 May 2022 08:59:25 +0000 (10:59 +0200)]
Unified phrases for deprecated options

2 years agoDeprecated AMP support
Marcel Werk [Fri, 13 May 2022 11:19:15 +0000 (13:19 +0200)]
Deprecated AMP support

PR #4803 accidentally had the wrong target branch.

(cherry picked from commit 8c97dca561b32b3c02f3cb30b32574a8f83b8bd5)

2 years agoFix code style
Tim Düsterhus [Tue, 17 May 2022 07:26:28 +0000 (09:26 +0200)]
Fix code style

2 years agoRevert "Use checkstyle output for php-cs-fixer"
Tim Düsterhus [Tue, 17 May 2022 07:03:36 +0000 (09:03 +0200)]
Revert "Use checkstyle output for php-cs-fixer"

This change was meant to improve the output, by properly annotating the files,
but instead it makes the output absolutely useless, as it does not include line
numbers.

This reverts commit 65a9247ac9566923cf89e4055c001833622996a6.

2 years agoSimplified checks against the domain name
Alexander Ebert [Mon, 16 May 2022 20:53:26 +0000 (22:53 +0200)]
Simplified checks against the domain name

2 years agoRedesigned the rescue mode, enforce shared domain
Alexander Ebert [Mon, 16 May 2022 20:36:09 +0000 (22:36 +0200)]
Redesigned the rescue mode, enforce shared domain

2 years agoAdded documentation of minvalue / maxvalue
Marcel Werk [Mon, 16 May 2022 19:47:11 +0000 (21:47 +0200)]
Added documentation of minvalue / maxvalue

2 years agoEmail address was not visible in listing of group members
Marcel Werk [Mon, 16 May 2022 14:54:01 +0000 (16:54 +0200)]
Email address was not visible in listing of group members

2 years agoRemove obsolete check for `->getAttributes()` method on ReflectionFunction/Reflection...
Tim Düsterhus [Mon, 16 May 2022 11:57:35 +0000 (13:57 +0200)]
Remove obsolete check for `->getAttributes()` method on ReflectionFunction/ReflectionMethod

2 years agoDeprecate the obsolete WCF::useDesktopNotifications()
Tim Düsterhus [Mon, 16 May 2022 09:46:17 +0000 (11:46 +0200)]
Deprecate the obsolete WCF::useDesktopNotifications()

2 years agoMerge branch 'master' into remove-multi-domain
Tim Düsterhus [Mon, 16 May 2022 09:42:53 +0000 (11:42 +0200)]
Merge branch 'master' into remove-multi-domain

2 years agoMerge branch '5.5'
Tim Düsterhus [Mon, 16 May 2022 09:41:07 +0000 (11:41 +0200)]
Merge branch '5.5'

2 years agoMerge remote-tracking branch 'origin/5.5' into 5.5
Tim Düsterhus [Mon, 16 May 2022 09:38:35 +0000 (11:38 +0200)]
Merge remote-tracking branch 'origin/5.5' into 5.5

2 years agoIncorrect handling of the return focus
Alexander Ebert [Sat, 14 May 2022 12:30:38 +0000 (14:30 +0200)]
Incorrect handling of the return focus

Related https://www.woltlab.com/community/thread/295562-inhalte-k%C3%B6nnen-doppelt-gemeldet-werden/

(cherry picked from commit e9ffefb4d0db61bf8e12b3824c6515ac16fe3812)

2 years agoRevert "Suppress errors when disabling the focus trap"
Tim Düsterhus [Mon, 16 May 2022 09:37:27 +0000 (11:37 +0200)]
Revert "Suppress errors when disabling the focus trap"

This commit duplicates commit e9ffefb4d0db61bf8e12b3824c6515ac16fe3812 which is
the cleaner fix, but was accidentally commited to `master` only. We revert this
one to allow for a clean cherry-picking of
e9ffefb4d0db61bf8e12b3824c6515ac16fe3812.

This reverts commit e7439c4f5fc7daf8d45d2de478c488798ddf463a.

2 years agoMerge pull request #4808 from WoltLab/55-incorrect-http-204-handling
Alexander Ebert [Mon, 16 May 2022 09:36:38 +0000 (11:36 +0200)]
Merge pull request #4808 from WoltLab/55-incorrect-http-204-handling

HTTP 204 does not carry a response type

2 years agoInstall phpcs via `shivammathur/setup-php`
Tim Düsterhus [Fri, 13 May 2022 09:45:32 +0000 (11:45 +0200)]
Install phpcs via `shivammathur/setup-php`

Apparently the previously used actions uses an out of date phpcs.

(cherry picked from commit c5cd836751c3fb357b8ddce52a95a83f3ac46347)

2 years agoConsistent evaluation of the response content type
Alexander Ebert [Mon, 16 May 2022 09:31:40 +0000 (11:31 +0200)]
Consistent evaluation of the response content type

2 years agoProper handling of a 204 response
Alexander Ebert [Mon, 16 May 2022 09:25:55 +0000 (11:25 +0200)]
Proper handling of a 204 response

2 years agoHTTP 204 does not carry a `content-type`
Alexander Ebert [Mon, 16 May 2022 09:17:50 +0000 (11:17 +0200)]
HTTP 204 does not carry a `content-type`

See https://www.woltlab.com/community/thread/295631-importer-h%C3%A4ngt-bei-reaktionen-100/

2 years agoMerge pull request #4805 from WoltLab/package-xsd
Marcel Werk [Mon, 16 May 2022 07:51:10 +0000 (09:51 +0200)]
Merge pull request #4805 from WoltLab/package-xsd

Added documentation of the void element

2 years agoUse correct CodeMirror mode for SCSS inputs
Tim Düsterhus [Mon, 16 May 2022 07:42:33 +0000 (09:42 +0200)]
Use correct CodeMirror mode for SCSS inputs

`sass` is the indentation based SASS syntax.

2 years agoIncorrect markup in the authentication dialog
Alexander Ebert [Sun, 15 May 2022 11:20:40 +0000 (13:20 +0200)]
Incorrect markup in the authentication dialog

2 years agoSuppress errors when disabling the focus trap
Alexander Ebert [Sun, 15 May 2022 11:04:54 +0000 (13:04 +0200)]
Suppress errors when disabling the focus trap

2 years agoUse CSS variable to apply the dialog offset
Alexander Ebert [Sun, 15 May 2022 11:00:09 +0000 (13:00 +0200)]
Use CSS variable to apply the dialog offset

2 years agoRevert "Dynamic width of code box line numbers"
Alexander Ebert [Sun, 15 May 2022 10:38:59 +0000 (12:38 +0200)]
Revert "Dynamic width of code box line numbers"

This reverts commit d3853740d8304f9703876006db990c2e01642656.

2 years agoDynamic width of code box line numbers
Alexander Ebert [Sun, 15 May 2022 10:37:51 +0000 (12:37 +0200)]
Dynamic width of code box line numbers

This avoids indenting short code listings too much, especially on screens with limited space.

2 years agoDo not wrap code boxes on mobile
Alexander Ebert [Sun, 15 May 2022 09:17:08 +0000 (11:17 +0200)]
Do not wrap code boxes on mobile

Having long lines wrap multiple times is horrible, overflow scrolling is much better and also quite natural on touch devices.

2 years agoBetter accessibility of code box buttons
Alexander Ebert [Sun, 15 May 2022 09:16:26 +0000 (11:16 +0200)]
Better accessibility of code box buttons

2 years agoNewer iOS versions permit a click near the bottom
Alexander Ebert [Sun, 15 May 2022 09:04:40 +0000 (11:04 +0200)]
Newer iOS versions permit a click near the bottom

2 years agoPrevent the "external url" indicator to wrap
Alexander Ebert [Sat, 14 May 2022 17:13:45 +0000 (19:13 +0200)]
Prevent the "external url" indicator to wrap

See https://www.woltlab.com/community/thread/295487-einzelnes-umbrechen-des-externalurl-icons-verhindern/

2 years agoExpand the active menu item by default
Alexander Ebert [Sat, 14 May 2022 17:01:48 +0000 (19:01 +0200)]
Expand the active menu item by default

2 years agoMerge pull request #4807 from WoltLab/55-desktop-notifications
Alexander Ebert [Sat, 14 May 2022 16:12:55 +0000 (18:12 +0200)]
Merge pull request #4807 from WoltLab/55-desktop-notifications

Remove the option to disable desktop notifications

2 years agoAlign the mobile main menu to the right
Alexander Ebert [Sat, 14 May 2022 15:10:15 +0000 (17:10 +0200)]
Align the mobile main menu to the right

See https://www.woltlab.com/community/thread/295627-mobil-men%C3%BC-links/

2 years agoSuppress error messages when aborting `fetch()`
Alexander Ebert [Sat, 14 May 2022 14:32:17 +0000 (16:32 +0200)]
Suppress error messages when aborting `fetch()`

See https://www.woltlab.com/community/thread/295566-fetch-is-aborted-bei-suchergebnissen/

2 years agoRemove the option to disable desktop notifications
Alexander Ebert [Sat, 14 May 2022 14:07:03 +0000 (16:07 +0200)]
Remove the option to disable desktop notifications

Fixes #4806

2 years agoAdded documentation of the void element
Marcel Werk [Sat, 14 May 2022 14:03:45 +0000 (16:03 +0200)]
Added documentation of the void element

2 years agoIncorrect handling of the return focus
Alexander Ebert [Sat, 14 May 2022 12:30:38 +0000 (14:30 +0200)]
Incorrect handling of the return focus

Related https://www.woltlab.com/community/thread/295562-inhalte-k%C3%B6nnen-doppelt-gemeldet-werden/

2 years agoMerge pull request #4801 from WoltLab/template-event-javascript-head-include
Tim Düsterhus [Sat, 14 May 2022 12:02:40 +0000 (14:02 +0200)]
Merge pull request #4801 from WoltLab/template-event-javascript-head-include

Remove long-deprecated JavaScript template events from `headInclude.tpl`

2 years agoMerge pull request #4800 from WoltLab/convert-encoding
Tim Düsterhus [Sat, 14 May 2022 12:02:30 +0000 (14:02 +0200)]
Merge pull request #4800 from WoltLab/convert-encoding

Deprecate StringUtil::convertEncoding()

2 years agoMerge pull request #4802 from WoltLab/sensitive-parameter
Tim Düsterhus [Sat, 14 May 2022 12:02:19 +0000 (14:02 +0200)]
Merge pull request #4802 from WoltLab/sensitive-parameter

Use PHP 8.2's SensitiveParameter argument

2 years agoMerge branch '5.4' into 5.5
Marcel Werk [Sat, 14 May 2022 11:46:27 +0000 (13:46 +0200)]
Merge branch '5.4' into 5.5

2 years agoTruncate error message in cronjob log if necessary
Marcel Werk [Sat, 14 May 2022 11:46:05 +0000 (13:46 +0200)]
Truncate error message in cronjob log if necessary

2 years agoSupport for meta tags during article import
Marcel Werk [Sat, 14 May 2022 10:59:48 +0000 (12:59 +0200)]
Support for meta tags during article import

2 years agoTypo
Marcel Werk [Sat, 14 May 2022 10:35:35 +0000 (12:35 +0200)]
Typo

2 years agoMerge branch 'master' into remove-multi-domain
Tim Düsterhus [Fri, 13 May 2022 16:13:53 +0000 (18:13 +0200)]
Merge branch 'master' into remove-multi-domain

2 years agoRemove accidentally commited bootstrap.php
Tim Düsterhus [Fri, 13 May 2022 14:05:24 +0000 (16:05 +0200)]
Remove accidentally commited bootstrap.php

see 4f33a332b8aaf66e6c2fb1c9919063146c328c56

2 years agoUse Guzzle in PackageAction::searchForPurchasedItems()
Tim Düsterhus [Fri, 13 May 2022 14:01:16 +0000 (16:01 +0200)]
Use Guzzle in PackageAction::searchForPurchasedItems()

see #4281

2 years agoUse Guzzle in PackageUpdateDispatcher::getPurchasedVersions()
Tim Düsterhus [Fri, 13 May 2022 13:52:49 +0000 (15:52 +0200)]
Use Guzzle in PackageUpdateDispatcher::getPurchasedVersions()

see #4281

2 years agoMerge pull request #4803 from WoltLab/deprecate-amp
Marcel Werk [Fri, 13 May 2022 11:31:01 +0000 (13:31 +0200)]
Merge pull request #4803 from WoltLab/deprecate-amp

Deprecated AMP support

2 years agoDeprecated AMP support
Marcel Werk [Fri, 13 May 2022 11:19:15 +0000 (13:19 +0200)]
Deprecated AMP support

2 years agoReplace `\wcf\SensitiveArgument` by `\SensitiveParameter`
Tim Düsterhus [Fri, 13 May 2022 10:08:13 +0000 (12:08 +0200)]
Replace `\wcf\SensitiveArgument` by `\SensitiveParameter`

2 years agoDeprecate `\wcf\SensitiveArgument`
Tim Düsterhus [Fri, 13 May 2022 10:07:06 +0000 (12:07 +0200)]
Deprecate `\wcf\SensitiveArgument`

2 years agoAdd support for PHP 8.2's native SensitiveParameter attribute
Tim Düsterhus [Fri, 13 May 2022 10:06:03 +0000 (12:06 +0200)]
Add support for PHP 8.2's native SensitiveParameter attribute

2 years agoUse checkstyle output for php-cs-fixer
Tim Düsterhus [Fri, 13 May 2022 09:50:59 +0000 (11:50 +0200)]
Use checkstyle output for php-cs-fixer

2 years agoInstall phpcs via `shivammathur/setup-php`
Tim Düsterhus [Fri, 13 May 2022 09:45:32 +0000 (11:45 +0200)]
Install phpcs via `shivammathur/setup-php`

Apparently the previously used actions uses an out of date phpcs.

2 years agoMerge branch '5.5'
Tim Düsterhus [Fri, 13 May 2022 09:39:09 +0000 (11:39 +0200)]
Merge branch '5.5'

2 years agoRemove obsolete workaround for PHP_CodeSniffer bug
Tim Düsterhus [Fri, 13 May 2022 09:38:41 +0000 (11:38 +0200)]
Remove obsolete workaround for PHP_CodeSniffer bug

2 years agoRemove long-deprecated JavaScript template events from `headInclude.tpl`
Tim Düsterhus [Fri, 13 May 2022 09:17:27 +0000 (11:17 +0200)]
Remove long-deprecated JavaScript template events from `headInclude.tpl`

2 years agoUse a `?` placeholder for the `USER_SESSION_LIMIT` in SessionHandler
Tim Düsterhus [Fri, 13 May 2022 09:14:19 +0000 (11:14 +0200)]
Use a `?` placeholder for the `USER_SESSION_LIMIT` in SessionHandler

MySQL supports placeholders within the `LIMIT`, make use of this to avoid the
string concatenation that breaks syntax highlighting of the SQL query within
the IDE.

2 years agoStop using StringUtil::convertEncoding()
Tim Düsterhus [Fri, 13 May 2022 08:52:17 +0000 (10:52 +0200)]
Stop using StringUtil::convertEncoding()

2 years agoDeprecate StringUtil::convertEncoding()
Tim Düsterhus [Fri, 13 May 2022 08:50:44 +0000 (10:50 +0200)]
Deprecate StringUtil::convertEncoding()

This method is a simple wrapper around `mb_convert_encoding()`, so that one can
simply be called directly.

2 years agoRemove use of `utf8_encode` / `utf8_decode`
Tim Düsterhus [Fri, 13 May 2022 08:49:52 +0000 (10:49 +0200)]
Remove use of `utf8_encode` / `utf8_decode`

These functions will be deprecated with PHP 8.2.

2 years agoMerge pull request #4790 from WoltLab/package-server-tls
Tim Düsterhus [Fri, 13 May 2022 07:29:30 +0000 (09:29 +0200)]
Merge pull request #4790 from WoltLab/package-server-tls

Enforce TLS for package servers

2 years agoMerge branch 'master' into package-server-tls
Tim Düsterhus [Fri, 13 May 2022 07:22:56 +0000 (09:22 +0200)]
Merge branch 'master' into package-server-tls

2 years agoMerge branch '5.5'
Tim Düsterhus [Fri, 13 May 2022 07:20:20 +0000 (09:20 +0200)]
Merge branch '5.5'

2 years agoMerge pull request #4799 from WoltLab/wcf-force-logout
Tim Düsterhus [Fri, 13 May 2022 07:18:52 +0000 (09:18 +0200)]
Merge pull request #4799 from WoltLab/wcf-force-logout

Immediately destroy the session for banned users

2 years agoMerge pull request #4795 from WoltLab/mb-strpos
Tim Düsterhus [Fri, 13 May 2022 07:17:25 +0000 (09:17 +0200)]
Merge pull request #4795 from WoltLab/mb-strpos

Remove unneeded usage of `mb_strpos`

2 years agoMerge pull request #4786 from WoltLab/remove-x-frame-options
Tim Düsterhus [Fri, 13 May 2022 07:17:06 +0000 (09:17 +0200)]
Merge pull request #4786 from WoltLab/remove-x-frame-options

Always send `x-frame-options`

2 years agoMerge pull request #4793 from WoltLab/error-500
Tim Düsterhus [Fri, 13 May 2022 07:16:43 +0000 (09:16 +0200)]
Merge pull request #4793 from WoltLab/error-500

Use HTTP 500 in error conditions

2 years agoMerge pull request #4794 from WoltLab/wcfacp-initPackage
Tim Düsterhus [Fri, 13 May 2022 07:16:25 +0000 (09:16 +0200)]
Merge pull request #4794 from WoltLab/wcfacp-initPackage

Remove obsolete WCFACP::initPackage()

2 years agoMerge pull request #4796 from WoltLab/canonical-url-s-parameter
Tim Düsterhus [Fri, 13 May 2022 07:16:14 +0000 (09:16 +0200)]
Merge pull request #4796 from WoltLab/canonical-url-s-parameter

Remove the obsolete stripping of the `s=<sessionID>` when handling the canonical URL

2 years agoMerge pull request #4788 from WoltLab/template-modifier-allowlist
Tim Düsterhus [Fri, 13 May 2022 07:16:00 +0000 (09:16 +0200)]
Merge pull request #4788 from WoltLab/template-modifier-allowlist

Always restrict valid template modifiers to an allow list

2 years agoImmediately destroy the session for banned users
Tim Düsterhus [Thu, 12 May 2022 15:16:54 +0000 (17:16 +0200)]
Immediately destroy the session for banned users

The forced logout for banned users was introduced in
ab84d9cab2f864c23f0b18dbeb67e7ea79b1fe9f and only destroyed the session during
shutdown.

At the point where this check runs the request effectively is fully booted up
and in any case the NamedUserException would abort any further booting, thus it
is safe to simply destroy the session immediately to keep all the necessary
logic in a single location.

2 years agoUse `->prepare()` instead of `->prepareStatement()` in SessionHandler
Tim Düsterhus [Thu, 12 May 2022 15:13:13 +0000 (17:13 +0200)]
Use `->prepare()` instead of `->prepareStatement()` in SessionHandler

2 years agoMerge branch '5.4' into 5.5
Tim Düsterhus [Thu, 12 May 2022 14:08:05 +0000 (16:08 +0200)]
Merge branch '5.4' into 5.5

2 years agoMerge pull request #4798 from pehbeh/patch-1
Tim Düsterhus [Thu, 12 May 2022 13:38:20 +0000 (15:38 +0200)]
Merge pull request #4798 from pehbeh/patch-1

Update URL to WoltLab Community and Plugin-Store in acp/pageHeaderUser.tpl

2 years agoMerge pull request #4797 from WoltLab/mysql-requirements
Tim Düsterhus [Thu, 12 May 2022 13:38:04 +0000 (15:38 +0200)]
Merge pull request #4797 from WoltLab/mysql-requirements

Increase minimum MySQL version to 8.0.29 / MariaDB 10.5.12

2 years agoIncrease minimum MySQL version to 8.0.29 / MariaDB 10.5.12
Tim Düsterhus [Thu, 12 May 2022 13:31:52 +0000 (15:31 +0200)]
Increase minimum MySQL version to 8.0.29 / MariaDB 10.5.12

2 years agoUpdate URL to WoltLab Community and Plugin-Store in acp/pageHeaderUser.tpl
pehbeh [Thu, 12 May 2022 13:31:54 +0000 (15:31 +0200)]
Update URL to WoltLab Community and Plugin-Store in acp/pageHeaderUser.tpl

2 years agoRemove the obsolete stripping of the `s=<sessionID>` when handling the canonical URL
Tim Düsterhus [Thu, 12 May 2022 13:19:14 +0000 (15:19 +0200)]
Remove the obsolete stripping of the `s=<sessionID>` when handling the canonical URL

2 years agoRemove unneeded usage of `mb_strpos`
Tim Düsterhus [Thu, 12 May 2022 12:39:24 +0000 (14:39 +0200)]
Remove unneeded usage of `mb_strpos`

If the return value of `mb_strpos` is only compared to `false` then there is no
need to use the multibyte engine, instead `str_contains()` does example the
same and is clearer.

The same applies if the return value is compared to `0`, in this case the size
of multibyte characters cannot have affected the offset. `str_starts_with()`
can be used instead.

2 years agoMerge branch '5.5'
Tim Düsterhus [Thu, 12 May 2022 12:50:09 +0000 (14:50 +0200)]
Merge branch '5.5'

2 years agoFix incorrect use of `mb_strpos` in MysqlSearchEngine
Tim Düsterhus [Thu, 12 May 2022 12:48:06 +0000 (14:48 +0200)]
Fix incorrect use of `mb_strpos` in MysqlSearchEngine

The return value of `mb_strpos` needs to be checked type-safely, as both `0`
and `false` are falsy. In this case this likely was safe, as the inner join may
not appear at the start of the query, it was a questionable nonetheless.

Fix this by using `str_contains()` which makes the intent even clearer.

2 years agoSimplify PackageUpdateServer::isTrustedServer()
Tim Düsterhus [Thu, 12 May 2022 12:33:40 +0000 (14:33 +0200)]
Simplify PackageUpdateServer::isTrustedServer()

2 years agoRemove `UPDATE_SERVER_TRUSTED_MIRROR`
Tim Düsterhus [Thu, 12 May 2022 12:32:23 +0000 (14:32 +0200)]
Remove `UPDATE_SERVER_TRUSTED_MIRROR`

2 years agoMerge remote-tracking branch 'origin/master'
Tim Düsterhus [Thu, 12 May 2022 11:49:18 +0000 (13:49 +0200)]
Merge remote-tracking branch 'origin/master'

2 years agoMerge branch '5.5'
Tim Düsterhus [Thu, 12 May 2022 11:48:47 +0000 (13:48 +0200)]
Merge branch '5.5'

2 years agoMerge branch '5.4' into 5.5
Tim Düsterhus [Thu, 12 May 2022 11:48:37 +0000 (13:48 +0200)]
Merge branch '5.4' into 5.5

2 years agoUpdate URL to WoltLab Ticket Support in acp/pageHeaderUser.tpl
Tim Düsterhus [Thu, 12 May 2022 11:48:13 +0000 (13:48 +0200)]
Update URL to WoltLab Ticket Support in acp/pageHeaderUser.tpl

2 years agoMerge pull request #4792 from WoltLab/styleID-parameter
Tim Düsterhus [Thu, 12 May 2022 10:47:07 +0000 (12:47 +0200)]
Merge pull request #4792 from WoltLab/styleID-parameter

Remove the `$_REQUEST['styleID']` handling

2 years agoRemove obsolete WCFACP::initPackage()
Tim Düsterhus [Thu, 12 May 2022 10:39:18 +0000 (12:39 +0200)]
Remove obsolete WCFACP::initPackage()

Ever since WoltLab Suite Core got its own frontend the PACKAGE_ID constant
should be defined at all times, making this method obsolete.

2 years agoRemove the `$_REQUEST['styleID']` handling
Tim Düsterhus [Thu, 12 May 2022 10:29:34 +0000 (12:29 +0200)]
Remove the `$_REQUEST['styleID']` handling

Resolves #4533

2 years agoUse HTTP 500 in error conditions
Tim Düsterhus [Thu, 12 May 2022 10:32:41 +0000 (12:32 +0200)]
Use HTTP 500 in error conditions

Sending a 500 Internal Server Error for unplanned errors is more appropriate
than a 503 Service Unavailable, as the latter is defined:

RFC 7231#6.6.4:

> The 503 (Service Unavailable) status code indicates that the server
> is currently unable to handle the request due to a temporary overload
> or scheduled maintenance, which will likely be alleviated after some
> delay.

It's not likely that the exception will resolve itself after some delay.

2 years agoSimplify generation of random cookie prefix in WCFSetup
Tim Düsterhus [Thu, 12 May 2022 10:02:31 +0000 (12:02 +0200)]
Simplify generation of random cookie prefix in WCFSetup

2 years agoDrop unused constant `URL_TO_LOWERCASE` from default options.inc.php
Tim Düsterhus [Thu, 12 May 2022 09:26:11 +0000 (11:26 +0200)]
Drop unused constant `URL_TO_LOWERCASE` from default options.inc.php

The option was removed in f3aa502157efa11ac3c76e8471d69d0ac9f69f1f.