Tim Düsterhus [Tue, 6 Jul 2021 10:04:55 +0000 (12:04 +0200)]
Simplify extraction of abbreviation for active application check
Matthias Schmidt [Tue, 6 Jul 2021 09:42:44 +0000 (11:42 +0200)]
Merge branch '5.4'
Matthias Schmidt [Tue, 6 Jul 2021 09:42:35 +0000 (11:42 +0200)]
Add missing since tag for `User::requiresMultifactor()`
Tim Düsterhus [Tue, 6 Jul 2021 09:34:17 +0000 (11:34 +0200)]
Move call to `checkAppEvaluation()` into `handle()`
It fits better here to cleanly separate the handling from the building. No
behavioral change was found.
Tim Düsterhus [Tue, 6 Jul 2021 09:32:06 +0000 (11:32 +0200)]
Move the check for expired app evaluations into a dedicated method
Tim Düsterhus [Tue, 6 Jul 2021 09:30:33 +0000 (11:30 +0200)]
Make the evaluation check independent of local variables
Tim Düsterhus [Tue, 6 Jul 2021 09:29:44 +0000 (11:29 +0200)]
Simplify extraction of abbreviation for evaluation check
Tim Düsterhus [Tue, 6 Jul 2021 09:29:14 +0000 (11:29 +0200)]
Add `@since` to RequestHandler::checkOfflineMode()
see
60fff547e76067211270f9f5eb7da9f257f847fc
Tim Düsterhus [Tue, 6 Jul 2021 09:19:37 +0000 (11:19 +0200)]
Move the check for offline mode into a dedicated method
Tim Düsterhus [Tue, 6 Jul 2021 09:21:54 +0000 (11:21 +0200)]
Use `getActiveRequest()` method in favor of directly accessing the class property
Tim Düsterhus [Tue, 6 Jul 2021 09:04:44 +0000 (11:04 +0200)]
Use `isACPRequest()` method in favor of a local variable in RequestHandler::handle()
Tim Düsterhus [Tue, 6 Jul 2021 08:58:18 +0000 (10:58 +0200)]
Remove unused local variable `$appendSession` in LinkHandler::getLink()
Tim Düsterhus [Tue, 6 Jul 2021 08:23:46 +0000 (10:23 +0200)]
Merge branch '5.4'
Tim Düsterhus [Tue, 6 Jul 2021 08:23:25 +0000 (10:23 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Tue, 6 Jul 2021 07:34:53 +0000 (09:34 +0200)]
Merge branch '5.2' into 5.3
Tim Düsterhus [Tue, 6 Jul 2021 07:34:26 +0000 (09:34 +0200)]
Merge branch '3.1' into 5.2
Tim Düsterhus [Tue, 6 Jul 2021 07:32:45 +0000 (09:32 +0200)]
Remove duplicate `class` attribute in cacheList.tpl
Matthias Schmidt [Tue, 6 Jul 2021 07:12:34 +0000 (09:12 +0200)]
Support sorting users in `UserOnlineListBoxController` (#4372)
Close #4182
Tim Düsterhus [Mon, 5 Jul 2021 14:21:52 +0000 (16:21 +0200)]
Remove obsolete import
Tim Düsterhus [Mon, 5 Jul 2021 14:00:08 +0000 (16:00 +0200)]
Remove cleanup of `userID` and `password` cookies
They are no longer used as of WoltLab Suite 5.4, however the removal remained
in the code to clean up the browser's cookie store on logout. Remove it, the
cookies will naturally expire in the future.
Tim Düsterhus [Mon, 5 Jul 2021 13:08:13 +0000 (15:08 +0200)]
Set `optimize-autoloader: true` in composer.json
Tim Düsterhus [Mon, 5 Jul 2021 13:03:53 +0000 (15:03 +0200)]
Merge pull request #4369 from WoltLab/composer
Update composer dependencies
Tim Düsterhus [Mon, 5 Jul 2021 13:00:35 +0000 (15:00 +0200)]
Update fileDelete.xml for composer updates
Tim Düsterhus [Mon, 5 Jul 2021 12:49:15 +0000 (14:49 +0200)]
Update composer dependencies
Tim Düsterhus [Mon, 5 Jul 2021 12:19:01 +0000 (14:19 +0200)]
Merge branch '5.4'
Tim Düsterhus [Mon, 5 Jul 2021 12:18:15 +0000 (14:18 +0200)]
Check for WebP support in update_com.woltlab.wcf_5.4_checkSystemRequirements.php
Tim Düsterhus [Mon, 5 Jul 2021 12:17:29 +0000 (14:17 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Mon, 5 Jul 2021 12:09:42 +0000 (14:09 +0200)]
Merge pull request #4368 from WoltLab/upgrade-check-webp
Add check for GD support to PackageEnableUpgradeOverrideForm
Tim Düsterhus [Mon, 5 Jul 2021 11:57:40 +0000 (13:57 +0200)]
Add check for GD support to PackageEnableUpgradeOverrideForm
Matthias Schmidt [Mon, 5 Jul 2021 10:51:46 +0000 (12:51 +0200)]
Export `WCFMessageQuoteManager` interface in `Ui/Message/Quote`
See #3876
Tim Düsterhus [Mon, 5 Jul 2021 10:45:51 +0000 (12:45 +0200)]
Merge branch '5.4'
Tim Düsterhus [Mon, 5 Jul 2021 10:45:33 +0000 (12:45 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Mon, 5 Jul 2021 10:39:50 +0000 (12:39 +0200)]
Validate the `actionName` in MessageQuoteAction
Matthias Schmidt [Mon, 5 Jul 2021 09:54:20 +0000 (11:54 +0200)]
Merge branch '5.4'
Matthias Schmidt [Mon, 5 Jul 2021 09:53:05 +0000 (11:53 +0200)]
Fix adding pages if only one language is available
See
128dbea9130f7decfb255d0d6e04f83e291021e6
Matthias Schmidt [Mon, 5 Jul 2021 09:32:16 +0000 (11:32 +0200)]
Merge branch '5.4'
Matthias Schmidt [Mon, 5 Jul 2021 09:32:03 +0000 (11:32 +0200)]
Fix code formatting issue
Matthias Schmidt [Mon, 5 Jul 2021 09:27:25 +0000 (11:27 +0200)]
Merge branch '5.4'
Matthias Schmidt [Fri, 2 Jul 2021 11:23:40 +0000 (13:23 +0200)]
Ensure that app abbreviation is unique before app installation
Close #4344
Matthias Schmidt [Mon, 5 Jul 2021 09:25:37 +0000 (11:25 +0200)]
Fix path of database PIP file located in `files_wcf/` for DevTools syncs
Close #4359
Matthias Schmidt [Mon, 5 Jul 2021 09:15:20 +0000 (11:15 +0200)]
Make renaming columns with PHP DB API idempotent (#4367)
An error message should only be shown if the neither a column with the old name, nor with the name name exists so that after the rename, a second rename is a no-op.
Close #4362
See #3765
Tim Düsterhus [Mon, 5 Jul 2021 07:57:17 +0000 (09:57 +0200)]
Merge branch '5.4'
Tim Düsterhus [Mon, 5 Jul 2021 07:56:34 +0000 (09:56 +0200)]
Merge branch '5.3' into 5.4
Also applied the second change from #4366.
Co-authored-by: Sascha Greuel <sascha@softcreatr.de>
Tim Düsterhus [Mon, 5 Jul 2021 07:54:22 +0000 (09:54 +0200)]
Merge branch '5.2' into 5.3
Tim Düsterhus [Mon, 5 Jul 2021 07:54:10 +0000 (09:54 +0200)]
Merge branch '3.1' into 5.2
Tim Düsterhus [Mon, 5 Jul 2021 07:53:22 +0000 (09:53 +0200)]
Fix typo in de.xml
Closes #4366
Co-authored-by: Sascha Greuel <sascha@softcreatr.de>
Tim Düsterhus [Mon, 5 Jul 2021 07:01:02 +0000 (09:01 +0200)]
Add missing `@since` to AbstractOauth2Action
Tim Düsterhus [Sun, 4 Jul 2021 13:35:07 +0000 (15:35 +0200)]
Make AbstractOauth2Action::getHttpClient() non-final
It might be desirable to be able to add custom headers, specifically a custom
`user-agent`, for non-stock IDPs.
Matthias Schmidt [Fri, 2 Jul 2021 11:37:38 +0000 (13:37 +0200)]
Replace use of `WCF.Clipboard` with `Controller/Clipboard`
See #3876
Tim Düsterhus [Fri, 2 Jul 2021 10:52:43 +0000 (12:52 +0200)]
Merge branch '5.4'
Tim Düsterhus [Fri, 2 Jul 2021 09:28:01 +0000 (11:28 +0200)]
Merge pull request #4356 from WoltLab/user-logged-in
Add UserLoggedIn event and cancel lost password requests upon login
Tim Düsterhus [Fri, 2 Jul 2021 08:36:18 +0000 (10:36 +0200)]
Add cancelLostPasswordRequest to UserAction
Tim Düsterhus [Thu, 1 Jul 2021 12:59:02 +0000 (14:59 +0200)]
Cancel lost password requests when the user logs in
Resolves #3922
Tim Düsterhus [Thu, 1 Jul 2021 12:49:34 +0000 (14:49 +0200)]
Implement the UserLoggedIn event
Tim Düsterhus [Thu, 1 Jul 2021 12:44:02 +0000 (14:44 +0200)]
Add a UserLoggedIn event
Matthias Schmidt [Fri, 2 Jul 2021 09:04:28 +0000 (11:04 +0200)]
Merge pull request #4353 from WoltLab/ColorFormField
Modernize color picker and add `ColorFormField`
Matthias Schmidt [Fri, 2 Jul 2021 08:37:30 +0000 (10:37 +0200)]
Support wildcard for category name in `AclFormField` (#4355)
Tim Düsterhus [Thu, 1 Jul 2021 13:49:00 +0000 (15:49 +0200)]
Fix TOTP QR code in dark styles
Alexander Ebert [Thu, 1 Jul 2021 12:13:27 +0000 (14:13 +0200)]
Release 5.3.10
Tim Düsterhus [Thu, 1 Jul 2021 09:48:32 +0000 (11:48 +0200)]
Merge branch '5.4'
Tim Düsterhus [Thu, 1 Jul 2021 09:48:22 +0000 (11:48 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Thu, 1 Jul 2021 09:41:48 +0000 (11:41 +0200)]
Merge pull request #4354 from WoltLab/systemcheck-performance
Improve performance of SystemCheckPage::validateWritableDirectories()
Tim Düsterhus [Thu, 1 Jul 2021 09:21:08 +0000 (11:21 +0200)]
Improve performance of SystemCheckPage::validateWritableDirectories()
The previous implementation resulted in a syscall hell for large attachment or
image directories. RecursiveDirectoryIterator requires two syscalls for
directory entry just for iteration and that does not yet include any custom
logic.
Replace the implementation by a simple `glob()`. This is a small behavior
change, as a `*` will only check the files immediately below the directory in
question instead of recursing all the way down. However this likely is what was
intended anyway.
WoltLab [Thu, 1 Jul 2021 08:32:22 +0000 (08:32 +0000)]
Updating minified JavaScript files
Matthias Schmidt [Thu, 1 Jul 2021 08:06:15 +0000 (10:06 +0200)]
Add `ColorFormField`
Matthias Schmidt [Thu, 1 Jul 2021 08:05:10 +0000 (10:05 +0200)]
Add new phrases to JavaScript for existing uses of color pickers
Matthias Schmidt [Thu, 1 Jul 2021 07:59:25 +0000 (09:59 +0200)]
Deprecate `WCF.ColorPicker` in favor of `Ui/Color/Picker`
Matthias Schmidt [Thu, 1 Jul 2021 07:58:43 +0000 (09:58 +0200)]
Update `Ui/Color/Picker` to use native TypeScript-based implementation
Instead of having to implement a color picker ourselves, we delegate the task to the browser by using a `input[type=color]` element. Because this color input does not support transparency, there is an additional `input[type=range]` element for transparency.
Alexander Ebert [Wed, 30 Jun 2021 13:15:45 +0000 (15:15 +0200)]
Modified update instructions
Matthias Schmidt [Wed, 30 Jun 2021 12:02:14 +0000 (14:02 +0200)]
Add `ColorUtil.stringToRgba()`
Matthias Schmidt [Wed, 30 Jun 2021 12:00:23 +0000 (14:00 +0200)]
Add `ColorUtil.isValidColor()`
Matthias Schmidt [Wed, 30 Jun 2021 11:53:10 +0000 (13:53 +0200)]
Add `ColorUtil.rgbaToString()`
Matthias Schmidt [Wed, 30 Jun 2021 11:51:02 +0000 (13:51 +0200)]
Add `ColorUtil.rgbaToHex()`
Matthias Schmidt [Wed, 30 Jun 2021 11:48:45 +0000 (13:48 +0200)]
Use `.toString(16)` for `ColorUtil.rgbToHex()`
Matthias Schmidt [Wed, 30 Jun 2021 11:45:56 +0000 (13:45 +0200)]
Export color interfaces from `ColorUtil`
Joshua Rüsweg [Wed, 30 Jun 2021 11:00:16 +0000 (13:00 +0200)]
Merge pull request #4352 from WoltLab/twitter-auth
Modernize Twitter Auth
Tim Düsterhus [Wed, 30 Jun 2021 10:57:53 +0000 (12:57 +0200)]
Merge branch '5.4'
Tim Düsterhus [Wed, 30 Jun 2021 10:57:11 +0000 (12:57 +0200)]
Handle Facebook not providing an email address
Fixes #4241
Tim Düsterhus [Wed, 30 Jun 2021 10:55:57 +0000 (12:55 +0200)]
Correctly handle Twitter not providing an email address
Tim Düsterhus [Tue, 29 Jun 2021 14:26:12 +0000 (16:26 +0200)]
Migrate Twitter authentication to Guzzle
Tim Düsterhus [Tue, 29 Jun 2021 13:44:36 +0000 (15:44 +0200)]
Improve readability of OAuth header generation in TwitterAuthAction
Tim Düsterhus [Tue, 29 Jun 2021 13:36:30 +0000 (15:36 +0200)]
Use `getControllerLink()` to generate TwitterAuth callback URL
Tim Düsterhus [Tue, 29 Jun 2021 13:35:47 +0000 (15:35 +0200)]
Use constant time b64 encoder in TwitterAuthAction
Tim Düsterhus [Tue, 29 Jun 2021 13:34:31 +0000 (15:34 +0200)]
Use `\hash_equals()` for token validation in TwitterAuthAction
Tim Düsterhus [Tue, 29 Jun 2021 14:20:06 +0000 (16:20 +0200)]
Fix use of unused parameter in `AbstractOauth2Action::codeToAccessToken()`
Matthias Schmidt [Tue, 29 Jun 2021 08:00:44 +0000 (10:00 +0200)]
Make `failure` parameter of `Popover.ajaxApi()` optional
There is no reason to make the custom failure callback a required parameter here because in most cases, there is no need fur such a custom handler.
Tim Düsterhus [Tue, 29 Jun 2021 07:57:03 +0000 (09:57 +0200)]
Merge remote-tracking branch 'origin/master'
Tim Düsterhus [Tue, 29 Jun 2021 07:56:52 +0000 (09:56 +0200)]
Merge branch '5.4'
Matthias Schmidt [Tue, 29 Jun 2021 07:52:21 +0000 (09:52 +0200)]
Improve speed of PIPs to delete files
… by fetching all existing database records at once and deleting obsolete records in one transaction.
See #4269
See #4289
Tim Düsterhus [Tue, 29 Jun 2021 07:51:13 +0000 (09:51 +0200)]
Register reauthentication after MFA in ACP only
It was not desired that a login within the frontend also registers a
reauthentication, as the actions requiring a reauthentication are very rarely
used and can benefit from this additional password check. In the ACP however
each request requires a reauthentication, thus it makes sense to register it
during login.
see
4624ceeda0e19109245d19e883dc6fd388e95519
Tim Düsterhus [Tue, 29 Jun 2021 07:24:54 +0000 (09:24 +0200)]
Merge branch '5.4'
Tim Düsterhus [Mon, 28 Jun 2021 15:39:00 +0000 (17:39 +0200)]
Merge pull request #4350 from WoltLab/update-server-db
Adjust the URL of the update servers in install.sql
Marcel Werk [Mon, 28 Jun 2021 15:27:31 +0000 (17:27 +0200)]
Merge branch '5.4'
Marcel Werk [Mon, 28 Jun 2021 15:27:17 +0000 (17:27 +0200)]
Merge branch '5.3' into 5.4
Marcel Werk [Mon, 28 Jun 2021 15:25:12 +0000 (17:25 +0200)]
Sorting in article category had no effect
Tim Düsterhus [Mon, 28 Jun 2021 15:22:25 +0000 (17:22 +0200)]
Adjust the URL of the update servers in install.sql
This is technically unnecessary as the proper URLs will be inserted during
runtime, but might improve debugging, as it is clear which version was used to
install the software.
Tim Düsterhus [Mon, 28 Jun 2021 15:05:43 +0000 (17:05 +0200)]
Merge branch '5.4'
Tim Düsterhus [Mon, 28 Jun 2021 15:01:25 +0000 (17:01 +0200)]
Add acpTemplate PIP to update instructions from 5.4.0 Beta 2
Tim Düsterhus [Mon, 28 Jun 2021 15:00:08 +0000 (17:00 +0200)]
Use RejectEverythingFormField in PackageEnableUpgradeOverrideForm
Tim Düsterhus [Mon, 28 Jun 2021 14:59:04 +0000 (16:59 +0200)]
Clear WCF::AVAILABLE_UPGRADE_VERSION