GitHub/exynos8895/android_kernel_samsung_universal8895.git
12 years agostaging: gdm72xx: use list_move_tail instead of list_del/list_add_tail
Wei Yongjun [Wed, 5 Sep 2012 06:49:15 +0000 (14:49 +0800)]
staging: gdm72xx: use list_move_tail instead of list_del/list_add_tail

Using list_move_tail() instead of list_del() + list_add_tail().

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: ozwpan: use list_move_tail instead of list_del/list_add_tail
Wei Yongjun [Wed, 5 Sep 2012 06:48:48 +0000 (14:48 +0800)]
staging: ozwpan: use list_move_tail instead of list_del/list_add_tail

Using list_move_tail() instead of list_del() + list_add_tail().

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: ipack: fix build failure in powerpc allyesconfig
Samuel Iglesias Gonsálvez [Wed, 5 Sep 2012 07:08:17 +0000 (09:08 +0200)]
Staging: ipack: fix build failure in powerpc allyesconfig

Caused by commit 187e47824013 ("Staging: ipack: Read the ID space during
device registration").

drivers/staging/ipack/ipack.c: In function 'ipack_device_read_id':
drivers/staging/ipack/ipack.c:291:2: error: implicit declaration of function
'ioread8' [-Werror=implicit-function-declaration]
drivers/staging/ipack/ipack.c:309:3: error: implicit declaration of function
'ioread16be' [-Werror=implicit-function-declaration]

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: comedi: das08: Use struct comedi_device hw_dev for PCI
Ian Abbott [Wed, 5 Sep 2012 10:02:40 +0000 (11:02 +0100)]
staging: comedi: das08: Use struct comedi_device hw_dev for PCI

Remove the pointer to the PCI device from the private data `struct
das08_private_struct`.  Use `comedi_set_hw_dev()` to save a pointer to
the PCI device (actually, its embedded `struct device`) and
`comedi_to_pci_dev()` to retrieve it.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: comedi: das08: No need to manipulate PCI ref count
Ian Abbott [Wed, 5 Sep 2012 10:02:39 +0000 (11:02 +0100)]
staging: comedi: das08: No need to manipulate PCI ref count

Now that this driver no longer supports "manual" attachment of PCI
devices in its `attach` hook (`das08_attach()`), it no longer has code
that searches for a suitable PCI device and increments its reference
count.  Since the driver no longer has any reason for incrementing and
decrementing the PCI device's reference count, the calls to
`pci_dev_get()` and `pci_dev_put()` can be removed.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: comedi: addi_amcc_S5920.[ch]: remove unnecessary files
H Hartley Sweeten [Tue, 4 Sep 2012 22:29:28 +0000 (15:29 -0700)]
staging: comedi: addi_amcc_S5920.[ch]: remove unnecessary files

The addi_amcc_S5920.c file only has the function i_AddiHeaderRW_ReadEeprom()
in it. The addi_amcc_S5920.h file has a prototype for this function and a
couple defines for the magic numbers used when accessing the eeprom.

The .c file is not actually built by any .config selection, or by an

The .h file is only #include'd by the hwdrv_apci3200.c file. That file
actually has a local version of the i_AddiHeaderRW_ReadEeprom() function
that is identical to the one in the .c file.

Just move the #define's from the .h file into hwdrv_apci3200.c and remove
the addi_amcc_S5920.[ch] files.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: comedi: amcc_s5933_58.h: remove unused file
H Hartley Sweeten [Tue, 4 Sep 2012 22:28:54 +0000 (15:28 -0700)]
staging: comedi: amcc_s5933_58.h: remove unused file

Nothing in the comedi subsystem references this header file. It's
actually almost a straight copy of the addi_amcc_s5933.h file anyway.
Just remove the file.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: comedi: addi_apci_all.c: remove unused file
H Hartley Sweeten [Tue, 4 Sep 2012 22:28:26 +0000 (15:28 -0700)]
staging: comedi: addi_apci_all.c: remove unused file

The Makefile for the comedi subsystem does not compile this file
for any .config selection. This file would allow building one big
driver to support all the addi-data cards.

The addi-data drivers are a big enough mess as-is. Just remove this
file.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Iam Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: ipack: Provide ID Prom through sysfs.
Jens Taprogge [Tue, 4 Sep 2012 15:01:21 +0000 (17:01 +0200)]
Staging: ipack: Provide ID Prom through sysfs.

Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: ipack: Expose modalias through sysfs.
Jens Taprogge [Tue, 4 Sep 2012 15:01:20 +0000 (17:01 +0200)]
Staging: ipack: Expose modalias through sysfs.

Also include it in the hotplug event so that udev can
provide the respective driver.

Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: ipack: Implement device matching on the bus level.
Jens Taprogge [Tue, 4 Sep 2012 15:01:19 +0000 (17:01 +0200)]
Staging: ipack: Implement device matching on the bus level.

Devices are match based upon their vendor and device ids.  Since
the individual drivers provide a list of supported ids they do not
need to implement the matching themselves.

Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: ipack/devices/ipoctal: Expose DEVICE_TABLE for ipoctal.
Jens Taprogge [Tue, 4 Sep 2012 15:01:18 +0000 (17:01 +0200)]
Staging: ipack/devices/ipoctal: Expose DEVICE_TABLE for ipoctal.

The modalias entries for the module are now created.

Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: ipack: Make ipack_driver_ops const.
Jens Taprogge [Tue, 4 Sep 2012 15:01:17 +0000 (17:01 +0200)]
Staging: ipack: Make ipack_driver_ops const.

Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: ipack: Move device ids from ipoctal.c to ipack_ids.h.
Jens Taprogge [Tue, 4 Sep 2012 15:01:16 +0000 (17:01 +0200)]
Staging: ipack: Move device ids from ipoctal.c to ipack_ids.h.

Rename them in the process.

Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: ipack: Parse vendor and device id.
Jens Taprogge [Tue, 4 Sep 2012 15:01:15 +0000 (17:01 +0200)]
Staging: ipack: Parse vendor and device id.

Also expose the values through sysfs.

Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: ipack: Read the ID space during device registration.
Jens Taprogge [Tue, 4 Sep 2012 15:01:14 +0000 (17:01 +0200)]
Staging: ipack: Read the ID space during device registration.

We keep a copy of the ID space for later use.

Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: ipack: implement ipack device table.
Jens Taprogge [Tue, 4 Sep 2012 15:01:13 +0000 (17:01 +0200)]
Staging: ipack: implement ipack device table.

The modaliases look like ipack:fXvNdM, where X is the format version (8
bit) and N and M are the vendor and device ID represented as 32 bit
hexadecimal numbers each. Using 32 bits allows us to define IPACK_ANY_ID
as (~0) without interfering with the valid ids.

The resulting modalias string for ipoctal.ko looks like this (once
ipoctal provides a device table):
alias:          ipack:f01v000000F0d00000048*
alias:          ipack:f01v000000F0d0000002A*
alias:          ipack:f01v000000F0d00000022*
(output from modinfo)

Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: ipack/devices/ipoctal: Tidy up ipoctal some more.
Jens Taprogge [Tue, 4 Sep 2012 15:01:12 +0000 (17:01 +0200)]
Staging: ipack/devices/ipoctal: Tidy up ipoctal some more.

No need to have a struct when it has only one field.

Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: ipack/devices/ipoctal: ipoctal cleanups.
Jens Taprogge [Tue, 4 Sep 2012 15:01:11 +0000 (17:01 +0200)]
Staging: ipack/devices/ipoctal: ipoctal cleanups.

Define memory address space, fix sparse warnings and mark the structs
reflecting hardware memory layout "packed" to be on the safe side.

Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: ipack: remove read/write operations from ipack_bus_ops
Samuel Iglesias Gonsálvez [Tue, 4 Sep 2012 15:01:10 +0000 (17:01 +0200)]
Staging: ipack: remove read/write operations from ipack_bus_ops

They are not used any longer.

Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: ipack/bridges/tpci200: Remove the read/write functions from ipack_bus_ops.
Jens Taprogge [Tue, 4 Sep 2012 15:01:09 +0000 (17:01 +0200)]
Staging: ipack/bridges/tpci200: Remove the read/write functions from ipack_bus_ops.

They are not used any longer.

Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: ipack/devices/ipoctal: Convert ipoctal to directly use ioread/write functions.
Jens Taprogge [Tue, 4 Sep 2012 15:01:08 +0000 (17:01 +0200)]
Staging: ipack/devices/ipoctal: Convert ipoctal to directly use ioread/write functions.

Before it was using the functions in ipack_bus_ops.

Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: ipack/bridges/tpci200: Use the TPCI200 in big endian mode.
Jens Taprogge [Tue, 4 Sep 2012 15:01:07 +0000 (17:01 +0200)]
Staging: ipack/bridges/tpci200: Use the TPCI200 in big endian mode.

During initialization we configure the TPCI200 so it does not swap data
lanes on IndustryPack module access.  The read and write functions are
changed accordingly.

We are taking this approach in the hope that all IP Carriers are able to
present the Module memory layout unchanged.  We can thus directly access
the memory and registers of IP Modules without having to rely on the
read and write wrappers currently exposed in ipack_bus_opts.  A later
patch will convert the existing driver and remove the wrappers.

Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: ipack/bridges/tpci200: Reorganize tpci200_probe in preparation for functiona...
Jens Taprogge [Tue, 4 Sep 2012 15:01:06 +0000 (17:01 +0200)]
Staging: ipack/bridges/tpci200: Reorganize tpci200_probe in preparation for functional changes.

These changes make it easier to add more initialization steps later on.

Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: csr: replace calls to kmalloc and memset with kzalloc
Devendra Naga [Tue, 4 Sep 2012 19:26:44 +0000 (00:56 +0530)]
staging: csr: replace calls to kmalloc and memset with kzalloc

the kzalloc does allocates memory and sets the data at the memory
which is allocated to 0,

The driver does uses the kmalloc and memset at some points in the code
replace them with a single call to kzalloc

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Acked-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: csr: remove casting of return value from kmalloc
Devendra Naga [Tue, 4 Sep 2012 19:26:43 +0000 (00:56 +0530)]
staging: csr: remove casting of return value from kmalloc

as per Documentation/CodingStyle, casting of void pointer to
any other pointer is not needed

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Acked-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: csr: Remove all leftover kernel version checks \o/
Priit Laes [Sat, 1 Sep 2012 09:06:10 +0000 (12:06 +0300)]
staging: csr: Remove all leftover kernel version checks \o/

Signed-off-by: Priit Laes <plaes@plaes.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: csr: Remove unneeded UF_NETIF_TX_* macros
Priit Laes [Sat, 1 Sep 2012 09:06:09 +0000 (12:06 +0300)]
staging: csr: Remove unneeded UF_NETIF_TX_* macros

Signed-off-by: Priit Laes <plaes@plaes.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: csr: unifi_priv.h: Remove KERNEL_VERSION checks
Priit Laes [Sat, 1 Sep 2012 09:06:08 +0000 (12:06 +0300)]
staging: csr: unifi_priv.h: Remove KERNEL_VERSION checks

Signed-off-by: Priit Laes <plaes@plaes.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: csr: unifi_wext.h: Remove KERNEL_VERSION checks
Priit Laes [Sat, 1 Sep 2012 09:06:07 +0000 (12:06 +0300)]
staging: csr: unifi_wext.h: Remove KERNEL_VERSION checks

Signed-off-by: Priit Laes <plaes@plaes.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: csr: drv.c: Remove KERNEL_VERSION checks and associated defines
Priit Laes [Sat, 1 Sep 2012 09:06:06 +0000 (12:06 +0300)]
staging: csr: drv.c: Remove KERNEL_VERSION checks and associated defines

Signed-off-by: Priit Laes <plaes@plaes.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: csr: Drop unused UNIFI_NET_NAME configuration option
Priit Laes [Sat, 1 Sep 2012 09:06:05 +0000 (12:06 +0300)]
staging: csr: Drop unused UNIFI_NET_NAME configuration option

Signed-off-by: Priit Laes <plaes@plaes.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: csr: remove unused define ALLOW_Q_PAUSE
Priit Laes [Sat, 1 Sep 2012 09:06:04 +0000 (12:06 +0300)]
staging: csr: remove unused define ALLOW_Q_PAUSE

Signed-off-by: Priit Laes <plaes@plaes.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: csr: netdev.c: Clean up KERNEL_VERSION checks: 2.6.37
Priit Laes [Sat, 1 Sep 2012 09:06:03 +0000 (12:06 +0300)]
staging: csr: netdev.c: Clean up KERNEL_VERSION checks: 2.6.37

Signed-off-by: Priit Laes <plaes@plaes.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: csr: netdev.c: Clean up KERNEL_VERSION checks: 2.6.34
Priit Laes [Sat, 1 Sep 2012 09:06:02 +0000 (12:06 +0300)]
staging: csr: netdev.c: Clean up KERNEL_VERSION checks: 2.6.34

Signed-off-by: Priit Laes <plaes@plaes.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: csr: netdev.c: Clean up KERNEL_VERSION checks: 2.6.32
Priit Laes [Sat, 1 Sep 2012 09:06:01 +0000 (12:06 +0300)]
staging: csr: netdev.c: Clean up KERNEL_VERSION checks: 2.6.32

Signed-off-by: Priit Laes <plaes@plaes.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: csr: netdev.c: Clean up KERNEL_VERSION checks: 2.6.29
Priit Laes [Sat, 1 Sep 2012 09:06:00 +0000 (12:06 +0300)]
staging: csr: netdev.c: Clean up KERNEL_VERSION checks: 2.6.29

Signed-off-by: Priit Laes <plaes@plaes.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: csr: netdev.c: Clean up KERNEL_VERSION checks: 2.6.28
Priit Laes [Sat, 1 Sep 2012 09:05:59 +0000 (12:05 +0300)]
staging: csr: netdev.c: Clean up KERNEL_VERSION checks: 2.6.28

Signed-off-by: Priit Laes <plaes@plaes.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: csr: netdev.c: Clean up KERNEL_VERSION checks: 2.6.27
Priit Laes [Sat, 1 Sep 2012 09:05:58 +0000 (12:05 +0300)]
staging: csr: netdev.c: Clean up KERNEL_VERSION checks: 2.6.27

Signed-off-by: Priit Laes <plaes@plaes.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: csr: netdev.c: Clean up KERNEL_VERSION checks: <=2.6.25
Priit Laes [Sat, 1 Sep 2012 09:05:57 +0000 (12:05 +0300)]
staging: csr: netdev.c: Clean up KERNEL_VERSION checks: <=2.6.25

Signed-off-by: Priit Laes <plaes@plaes.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: bcm: use pr_info and pr_err rather than printk
Alexey Khoroshilov [Sun, 2 Sep 2012 19:30:14 +0000 (23:30 +0400)]
staging: bcm: use pr_info and pr_err rather than printk

Convert printk(KERN_INFO to pr_info( and printk(KERN_ERR to pr_err(.

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: bcm: fix error handling in bcm_init()
Alexey Khoroshilov [Sun, 2 Sep 2012 19:30:13 +0000 (23:30 +0400)]
staging: bcm: fix error handling in bcm_init()

bcm_init() does not have proper error handling of usb_register().
The patch implements one.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Acked-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: bcm: Convert INT to int in InterfaceInit.h
Kevin McKinney [Sun, 2 Sep 2012 17:55:55 +0000 (13:55 -0400)]
Staging: bcm: Convert INT to int in InterfaceInit.h

This patch converts INT to int in InterfaceInit.h

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: bcm: Fix white space issues in InterfaceInit.h
Kevin McKinney [Sun, 2 Sep 2012 17:55:54 +0000 (13:55 -0400)]
Staging: bcm: Fix white space issues in InterfaceInit.h

This patch fixes white space issue in InterfaceInit.h
as reported by checkpatch.pl.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: "winbond" Fix typos.
Justin P. Mattock [Mon, 3 Sep 2012 15:06:02 +0000 (08:06 -0700)]
staging: "winbond" Fix typos.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: cxt1e1: solve coding style problem
Devendra Naga [Sat, 1 Sep 2012 20:59:51 +0000 (02:29 +0530)]
staging: cxt1e1: solve coding style problem

remove the spaces and replace with tabs at the beginning of a line
and also remove space between function call and its open paranthesis

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: cxt1e1: use kernel's way of returning error codes
Devendra Naga [Sat, 1 Sep 2012 20:59:50 +0000 (02:29 +0530)]
staging: cxt1e1: use kernel's way of returning error codes

The error codes the kernel functions return are -ve numbers, convert this
function to follow the other kernel functions

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: sep: Correct misspelled "remap_page_range" -> "remap_pfn_range"
Robert P. J. Day [Wed, 29 Aug 2012 22:48:30 +0000 (18:48 -0400)]
Staging: sep: Correct misspelled "remap_page_range" -> "remap_pfn_range"

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: sm7xxfb: copy device name before we pass to the smtc_alloc_fb_info
Devendra Naga [Sun, 26 Aug 2012 06:27:16 +0000 (11:57 +0530)]
staging: sm7xxfb: copy device name before we pass to the smtc_alloc_fb_info

the name is not initialised and passed to the function smtc_alloc_fb_info
and copies the name into a member of fb structure.

copy the name before calling alloc_fb_info.

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Acked-by: Javier Muñoz <jmunhoz@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: android: Alarm driver cleanups
Dae S. Kim [Wed, 29 Aug 2012 15:08:33 +0000 (17:08 +0200)]
Staging: android: Alarm driver cleanups

Little cleanups. Enum value ANDROID_ALARM_TYPE_COUNT was treated as
an alarm type within a switch statement. That condition was unreachable
though.

Signed-off-by: Dae S. Kim <dae@velatum.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: slicoss: release firmware before returning
Devendra Naga [Sun, 26 Aug 2012 07:12:50 +0000 (12:42 +0530)]
staging: slicoss: release firmware before returning

we request_firmware in slic_card_download_gbrcv and we return out
with out calling release_firmware, where we compare against a
firmware lengths of certain device ids.

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: slicoss: return early before calling request_firmware with empty firmware...
Devendra Naga [Sun, 26 Aug 2012 07:06:56 +0000 (12:36 +0530)]
staging: slicoss: return early before calling request_firmware with empty firmware filename

when the device id doesn't match in slic_card_download_gbrcv the filename is "",
i.e an empty name, and we try calling request_firmware with that name,
actually we can just fail out at default case before even calling request_firmware

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: serqt_usb2: fix dbg print when kzalloc failed to allocate qt_port
Devendra Naga [Sun, 26 Aug 2012 05:42:33 +0000 (11:12 +0530)]
staging: serqt_usb2: fix dbg print when kzalloc failed to allocate qt_port

the port was kzalloced but the print statement says that its kmalloc.

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: cptm1217: use module_i2c_driver macro
Devendra Naga [Sat, 25 Aug 2012 21:05:47 +0000 (02:35 +0530)]
staging: cptm1217: use module_i2c_driver macro

use the module_i2c_driver and remove the reimplementation of module_i2c_driver

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: sbe-2t3e3: fix sparse warnings
Devendra Naga [Sat, 25 Aug 2012 17:40:47 +0000 (23:10 +0530)]
staging: sbe-2t3e3: fix sparse warnings

warnings:
drivers/staging/sbe-2t3e3/netdev.c:24:5: warning: symbol 't3e3_ioctl' was not declared. Should it be static?
drivers/staging/sbe-2t3e3/netdev.c:85:5: warning: symbol 't3e3_open' was not declared. Should it be static?
drivers/staging/sbe-2t3e3/netdev.c:100:5: warning: symbol 't3e3_close' was not declared. Should it be static?

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: sbe-2t3e3: fix sparse warnings
Devendra Naga [Sat, 25 Aug 2012 17:41:43 +0000 (23:11 +0530)]
staging: sbe-2t3e3: fix sparse warnings

warnings:

drivers/staging/sbe-2t3e3/netdev.c:30:56: warning: incorrect type in initializer (different address spaces)
drivers/staging/sbe-2t3e3/netdev.c:30:56:    expected void *data
drivers/staging/sbe-2t3e3/netdev.c:30:56:    got void [noderef] <asn:1>*
drivers/staging/sbe-2t3e3/netdev.c:48:44: warning: incorrect type in argument 2 (different address spaces)
drivers/staging/sbe-2t3e3/netdev.c:48:44:    expected void const [noderef] <asn:1>*from
drivers/staging/sbe-2t3e3/netdev.c:48:44:    got void *data
drivers/staging/sbe-2t3e3/netdev.c:54:34: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/sbe-2t3e3/netdev.c:54:34:    expected void [noderef] <asn:1>*dst
drivers/staging/sbe-2t3e3/netdev.c:54:34:    got void *data

type must be __user.

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agodrivers/staging/crystalhd/crystalhd_lnx.c: adjust inconsistent IS_ERR and PTR_ERR
Julia Lawall [Sat, 25 Aug 2012 19:57:08 +0000 (21:57 +0200)]
drivers/staging/crystalhd/crystalhd_lnx.c: adjust inconsistent IS_ERR and PTR_ERR

Change the call to PTR_ERR to access the value just tested by IS_ERR.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e,e1;
@@

(
if (IS_ERR(e)) { ... PTR_ERR(e) ... }
|
if (IS_ERR(e=e1)) { ... PTR_ERR(e) ... }
|
*if (IS_ERR(e))
 { ...
*  PTR_ERR(e1)
   ... }
)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: bcm: fix possible memory leak in bcm_char_ioctl()
Wei Yongjun [Mon, 3 Sep 2012 10:02:23 +0000 (18:02 +0800)]
staging: bcm: fix possible memory leak in bcm_char_ioctl()

psFwInfo has been allocated in this function and should be
freed before leaving from the error handling cases.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: et131x: using is_zero_ether_addr() to simplify the code
Wei Yongjun [Sun, 26 Aug 2012 00:55:15 +0000 (08:55 +0800)]
staging: et131x: using is_zero_ether_addr() to simplify the code

Using is_zero_ether_addr() to simplify the code

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: r8712u: use is_zero_ether_addr() instead of memcmp()
Wei Yongjun [Thu, 23 Aug 2012 06:40:28 +0000 (14:40 +0800)]
staging: r8712u: use is_zero_ether_addr() instead of memcmp()

Using is_zero_ether_addr() instead of directly use
memcmp(addr, "\x00\x00\x00\x00\x00\x00", ETH_ALEN)
to determine if the ethernet address is all zeros.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: r8712u: Remove defines that are not used
Larry Finger [Wed, 29 Aug 2012 20:59:59 +0000 (15:59 -0500)]
staging: r8712u: Remove defines that are not used

This driver has a number of defines, etc. that are not used.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: r8712u: Fix allocations not checked for failure
Larry Finger [Tue, 28 Aug 2012 16:59:04 +0000 (11:59 -0500)]
staging: r8712u: Fix allocations not checked for failure

The driver has a dev_alloc_skb() and an skb_clone() call that are not
checked for failure.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: csr: use is_zero_ether_addr() instead of memcmp()
Wei Yongjun [Sat, 25 Aug 2012 01:39:15 +0000 (09:39 +0800)]
staging: csr: use is_zero_ether_addr() instead of memcmp()

Using is_zero_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is all
zeros.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: csr: fix possible memory leak in do_patch_convert_download()
Wei Yongjun [Mon, 3 Sep 2012 10:15:26 +0000 (18:15 +0800)]
staging: csr: fix possible memory leak in do_patch_convert_download()

pfw has been allocated in function xbv_to_patch() and should be
freed before leaving from the error handling cases.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: rtl8192u: using random_ether_addr() to generate random MAC
Wei Yongjun [Tue, 21 Aug 2012 08:39:04 +0000 (16:39 +0800)]
Staging: rtl8192u: using random_ether_addr() to generate random MAC

Using random_ether_addr() to generate a random Ethernet
address (MAC) that is not multicast and has the local
assigned bit set. Not need to duplicating its implementation.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: rtl8192e: using random_ether_addr() to generate random MAC
Wei Yongjun [Tue, 21 Aug 2012 08:38:45 +0000 (16:38 +0800)]
staging: rtl8192e: using random_ether_addr() to generate random MAC

Using random_ether_addr() to generate a random Ethernet
address (MAC) that is not multicast and has the local
assigned bit set. Not need to duplicating its implementation.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: rtl8187se: using random_ether_addr() to generate random MAC
Wei Yongjun [Tue, 21 Aug 2012 08:36:28 +0000 (16:36 +0800)]
staging: rtl8187se: using random_ether_addr() to generate random MAC

Using random_ether_addr() to generate a random Ethernet
address (MAC) that is not multicast and has the local
assigned bit set. Not need to duplicating its implementation.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: rtl8192e: remove casting of returned pointer from kmalloc
Devendra Naga [Tue, 4 Sep 2012 19:24:41 +0000 (00:54 +0530)]
staging: rtl8192e: remove casting of returned pointer from kmalloc

as per Documentation/CodingStyle we dont need to cast the return of
kmalloc

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: rtl8192e: remove pointless conditional before kfree_skb()
Wei Yongjun [Tue, 28 Aug 2012 13:10:35 +0000 (21:10 +0800)]
staging: rtl8192e: remove pointless conditional before kfree_skb()

Remove pointless conditional before kfree_skb().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: rtl8192u: use kzalloc to allocate firmware pointer
Devendra Naga [Sun, 26 Aug 2012 05:36:33 +0000 (11:06 +0530)]
staging: rtl8192u: use kzalloc to allocate firmware pointer

the firmware pointer is allocated with kmalloc and memset,
instead we can just do a kzalloc which will return a memory that
has been memset.

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: r8712u: rtl871x_mlme.c: use is_zero_ether_addr() instead of memcmp()
Wei Yongjun [Fri, 24 Aug 2012 05:29:09 +0000 (13:29 +0800)]
staging: r8712u: rtl871x_mlme.c: use is_zero_ether_addr() instead of memcmp()

Using is_zero_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is
all zeros.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: rtl8192e: use is_zero_ether_addr() instead of memcmp()
Wei Yongjun [Thu, 23 Aug 2012 08:50:12 +0000 (16:50 +0800)]
staging: rtl8192e: use is_zero_ether_addr() instead of memcmp()

Using is_zero_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is all
zeros.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: rtl8192u: use is_zero_ether_addr() instead of memcmp()
Wei Yongjun [Thu, 23 Aug 2012 07:19:37 +0000 (15:19 +0800)]
Staging: rtl8192u: use is_zero_ether_addr() instead of memcmp()

Using is_zero_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is all
zeros.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: rtl8187se: use is_zero_ether_addr() instead of memcmp()
Wei Yongjun [Thu, 23 Aug 2012 07:18:28 +0000 (15:18 +0800)]
Staging: rtl8187se: use is_zero_ether_addr() instead of memcmp()

Using is_zero_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is all
zeros.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agospeakup: lower default software speech rate
Samuel Thibault [Sun, 26 Aug 2012 21:35:17 +0000 (23:35 +0200)]
speakup: lower default software speech rate

Speech synthesis beginners need a low speech rate, and trained people
want a high speech rate.  A medium speech rate is thus actually not a
good default for neither.  Since trained people will typically know how
to change the rate, better default for a low speech rate, which
beginners can grasp and learn how to increase it afterwards

This was agreed with users on the speakup mailing list.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: r8712u: use is_broadcast_ether_addr() to simplify the code
Wei Yongjun [Sun, 26 Aug 2012 01:22:33 +0000 (09:22 +0800)]
staging: r8712u: use is_broadcast_ether_addr() to simplify the code

Using is_broadcast_ether_addr() to simplify the code.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: rtl8187se: use is_broadcast_ether_addr() instead of memcmp()
Wei Yongjun [Sun, 26 Aug 2012 00:59:58 +0000 (08:59 +0800)]
staging: rtl8187se: use is_broadcast_ether_addr() instead of memcmp()

Using is_broadcast_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is broadcast
address.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: rtl8192u: use is_broadcast_ether_addr() instead of memcmp()
Wei Yongjun [Sun, 26 Aug 2012 01:00:30 +0000 (09:00 +0800)]
Staging: rtl8192u: use is_broadcast_ether_addr() instead of memcmp()

Using is_broadcast_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is broadcast
address.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: rtl8192e: use is_broadcast_ether_addr() instead of memcmp()
Wei Yongjun [Sun, 26 Aug 2012 01:04:23 +0000 (09:04 +0800)]
staging: rtl8192e: use is_broadcast_ether_addr() instead of memcmp()

Using is_broadcast_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is broadcast
address.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: vt6655: using is_broadcast_ether_addr() to simplify the code
Wei Yongjun [Sun, 26 Aug 2012 01:02:16 +0000 (09:02 +0800)]
Staging: vt6655: using is_broadcast_ether_addr() to simplify the code

Using is_broadcast_ether_addr() to simplify the code.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: vt6656: using is_broadcast_ether_addr() to simplify the code
Wei Yongjun [Sun, 26 Aug 2012 01:03:04 +0000 (09:03 +0800)]
Staging: vt6656: using is_broadcast_ether_addr() to simplify the code

Using is_broadcast_ether_addr() to simplify the code.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging "vt6656" Typo rename Embeded to Embedded.
Justin P. Mattock [Sun, 26 Aug 2012 15:16:45 +0000 (08:16 -0700)]
staging "vt6656" Typo rename Embeded to Embedded.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging "vt6656" Typo rename Caculate to Calculate.
Justin P. Mattock [Sun, 26 Aug 2012 15:16:44 +0000 (08:16 -0700)]
staging "vt6656" Typo rename Caculate to Calculate.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging "vt6656" Fix typos in comments, and in a printk message.
Justin P. Mattock [Sun, 26 Aug 2012 15:16:43 +0000 (08:16 -0700)]
staging "vt6656" Fix typos in comments, and in a printk message.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: "vt6655" Typo change *Caculate to *Calculate.
Justin P. Mattock [Mon, 20 Aug 2012 15:43:15 +0000 (08:43 -0700)]
staging: "vt6655" Typo change *Caculate to *Calculate.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: "vt6655" Typo change *Embeded to *Embedded.
Justin P. Mattock [Mon, 20 Aug 2012 15:43:14 +0000 (08:43 -0700)]
staging: "vt6655" Typo change *Embeded to *Embedded.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: "vt6655" Fix typos in comments.
Justin P. Mattock [Mon, 20 Aug 2012 15:43:13 +0000 (08:43 -0700)]
staging: "vt6655" Fix typos in comments.

Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging/vme: Use pr_ printks in vme_pio2_core.c
Toshiaki Yamane [Tue, 21 Aug 2012 11:13:09 +0000 (20:13 +0900)]
staging/vme: Use pr_ printks in vme_pio2_core.c

The below checkpatch warnings was fixed,

-WARNING: Prefer pr_err(... to printk(KERN_ERR, ...

and added pr_fmt.

Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agoStaging: vme: Fix a white space issue
Toshiaki Yamane [Tue, 21 Aug 2012 11:12:33 +0000 (20:12 +0900)]
Staging: vme: Fix a white space issue

The below checkpatch error was fixed.

-ERROR: trailing whitespace

Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: nvec: use system_nrt_wq instead of custom one
Tejun Heo [Wed, 22 Aug 2012 22:32:38 +0000 (15:32 -0700)]
staging: nvec: use system_nrt_wq instead of custom one

There isn't much reason to use custom workqueue in nvec.  It can use
system_nrt_wq instead and cancel the two work items on removal.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: nvec: do not depend on MACH_PAZ00
Marc Dietrich [Sun, 19 Aug 2012 17:03:08 +0000 (19:03 +0200)]
staging: nvec: do not depend on MACH_PAZ00

With the removal of board files on the tegra arch, drivers can now only
be instantiated via device tree. Consequently, all MACH_<board> config
variables are removed. As a temporary solution always enable building
for the (up to now) only supported paz00 board until nvec is full ported
to device tree.

Signed-off-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: nvec: release sync write lock in error case
Marc Dietrich [Sun, 19 Aug 2012 17:03:07 +0000 (19:03 +0200)]
staging: nvec: release sync write lock in error case

We forgot to release the sync write lock in case the async write
fails. Found by rpiloose on IRC.

Signed-off-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: nvec: fix clock setup
Marc Dietrich [Sun, 19 Aug 2012 17:03:06 +0000 (19:03 +0200)]
staging: nvec: fix clock setup

commit 30b68231 "ARM: tegra: clock: add i2c fast clock entry in clock table"
added a new clock for the i2c controllers, so clock requests are no longer
conclusive. Fix this by specifying "div-clk" explicitly.

Signed-off-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: wlags49_h2: use is_broadcast_ether_addr() instead of memcmp()
Wei Yongjun [Sun, 26 Aug 2012 00:52:48 +0000 (08:52 +0800)]
staging: wlags49_h2: use is_broadcast_ether_addr() instead of memcmp()

Using is_broadcast_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is broadcast
address.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: wlags49_h2: Fix typo in staging/wlags49_h2 driver
Masanari Iida [Mon, 27 Aug 2012 14:21:13 +0000 (23:21 +0900)]
staging: wlags49_h2: Fix typo in staging/wlags49_h2 driver

Correct spelling typo in staging/wlags49_h2

Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: wlagn49_h2: move open brace of if from below to beside of if statement
Devendra Naga [Sat, 18 Aug 2012 18:54:12 +0000 (00:24 +0530)]
staging: wlagn49_h2: move open brace of if from below to beside of if statement

the opening brace of the if statement should be beside to it, not below to it.

Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: wlags49_h2: remove return statements at the end of all void functions
Devendra Naga [Sat, 18 Aug 2012 18:54:11 +0000 (00:24 +0530)]
staging: wlags49_h2: remove return statements at the end of all void functions

this patch removes the return statement at the end of all void functions,
since the function returning void no need to have a return at the end of the
function.

Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: wlagn49_h2: fix the checkpatch warning about the space after the open parant...
Devendra Naga [Sat, 18 Aug 2012 18:54:10 +0000 (00:24 +0530)]
staging: wlagn49_h2: fix the checkpatch warning about the space after the open paranthesis

the following fix is done in the wl_wds_netif_carrier_off function:

wl_netdev.c:1764: ERROR: space prohibited after that open parenthesis '('
wl_netdev.c:1764: ERROR: space prohibited before that close parenthesis ')'
wl_netdev.c:1768: ERROR: space prohibited after that open parenthesis '('
wl_netdev.c:1768: ERROR: space prohibited before that close parenthesis ')'
wl_netdev.c:1768: ERROR: space required before the open parenthesis '('
wl_netdev.c:1769: ERROR: space prohibited after that open parenthesis '('
wl_netdev.c:1769: ERROR: space prohibited before that close parenthesis ')'
wl_netdev.c:1769: ERROR: space required before the open parenthesis '('
wl_netdev.c:1770: ERROR: space prohibited after that open parenthesis '('
wl_netdev.c:1770: ERROR: space prohibited before that close parenthesis ')'
wl_netdev.c:1770: ERROR: space required before the open parenthesis '('
wl_netdev.c:1771: ERROR: space prohibited after that open parenthesis '('
wl_netdev.c:1771: ERROR: space prohibited before that close parenthesis ')'

Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: wlags49_h2: style fix in w1_wds_netif_carrier_off
Devendra Naga [Sat, 18 Aug 2012 18:54:09 +0000 (00:24 +0530)]
staging: wlags49_h2: style fix in w1_wds_netif_carrier_off

whitespaces at beginning of the line are removed and are replaced
with the tabs

Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
12 years agostaging: wlags49_h2: remove unneded return in wl_wds_netif_carrier_off
Devendra Naga [Sat, 18 Aug 2012 18:54:08 +0000 (00:24 +0530)]
staging: wlags49_h2: remove unneded return in wl_wds_netif_carrier_off

the return is at the end of void function, which is not needed as this
function returns void.

Signed-off-by: Devendra Naga <develkernel412222@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>