Cathal Mullaney [Sun, 18 Sep 2016 19:08:45 +0000 (20:08 +0100)]
Staging: rts5208: rtsx_card.c: Fixed brace style issues
Fixed several minor brace coding style issues.
Signed-off-by: Cathal Mullaney <chuckleberryfinn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Tue, 20 Sep 2016 07:41:39 +0000 (13:11 +0530)]
Staging: ks7010: michael_mic: Use "foo *bar" instead of "foo * bar".
This issue was found by checkpatch.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Tue, 20 Sep 2016 07:39:58 +0000 (13:09 +0530)]
Staging: ks7010: Use "foo *bar" instead of "foo * bar".
This issue was found by checkpatch.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Tue, 20 Sep 2016 06:45:15 +0000 (12:15 +0530)]
Staging: ks7010: Use "foo *bar" instead of "foo * bar"
This patch was found by checkpatch.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Tue, 20 Sep 2016 06:25:47 +0000 (11:55 +0530)]
Staging: ks7010: Use sizeof structure *pointer over sizeof structure in kzalloc()
This issue was found by checkpatch.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sayli karnik [Sun, 18 Sep 2016 20:16:34 +0000 (01:46 +0530)]
staging: ks7010: Remove unnecessary variable used to store return value
This patch removes an unnecessary variable used to store return values in order
to reduce memory usage.
Done using coccinelle:
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
return
- ret
+ C
;
Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Hariharan R [Mon, 19 Sep 2016 00:16:03 +0000 (20:16 -0400)]
staging: ks7010: fixes typo in ks_hostif.c
Fixes typo,
FAILUER -> FAILURE
Recieve -> Receive
Signed-off-by: Hariharan R <hariharanrangasamy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sat, 17 Sep 2016 23:37:21 +0000 (05:07 +0530)]
Staging: fsl-mc: Use !x instead of x == NULL.
Use !x instead of x == NULL. This issue was found by checkpatch.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sun, 18 Sep 2016 17:32:33 +0000 (23:02 +0530)]
Staging: octeon: Add missing of_node_put after calling of_parse_phandle.
of_node_put needs to be called when the device node which is got
from of_parse_phandle is no longer used.
This patch is found by below coccinelle script:
@@
expression e,e1,e2;
@@
*e = of_parse_phandle(...)
... when != of_node_put(e)
when != true e == NULL
when != e2 = e
e = e1
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sayli karnik [Mon, 19 Sep 2016 14:32:40 +0000 (20:02 +0530)]
staging: i4l: act2000: Move assignment out of if statement
This patch places assignments which are inside the if condition, above it.
Done using coccinelle:
@@
statement s;
expression e;
identifier id;
@@
- if ((id = e))
+ id = e;
+ if (id)
s
Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sun, 18 Sep 2016 19:01:12 +0000 (00:31 +0530)]
Staging: i4l: Remove unused variable
Remove unused variable.
This change is made by below coccinelle script:
@@
type T;
identifier i;
constant C;
@@
(
extern T i;
|
- T i;
<+... when != i
- i = C;
...+>
)
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sun, 18 Sep 2016 00:08:34 +0000 (05:38 +0530)]
Staging: i4l: Use !x instead of x == NULL.
Use !x instead of x == NULL. This issue was found by checkpatch.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sat, 17 Sep 2016 23:59:03 +0000 (05:29 +0530)]
Staging: i4l: Do not initialise statics to 0.
Do not initialise statics to 0. Static variable by default initialise to 0,
so no need to explicit initialisation. This issue was found by checkpatch.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sat, 17 Sep 2016 23:46:44 +0000 (05:16 +0530)]
Staging: i4l: Remove NULL comparison.
This patch removes the explicit NULL comparison. This issue was found by
checkpatch.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Brian Masney [Tue, 20 Sep 2016 09:38:56 +0000 (05:38 -0400)]
staging: iio: isl29018: remove the FSF's mailing address
Address warning from checkpatch:
CHECK: Do not include the paragraph about writing to the Free Software
Foundation's mailing address from the sample GPL notice. The FSF has
changed addresses in the past, and may do so again. Linux already
includes a copy of the GPL.
Signed-off-by: Brian Masney <masneyb@onstation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Georgiana Rodica Chelu [Mon, 19 Sep 2016 16:35:09 +0000 (19:35 +0300)]
staging: iio: meter:
ade7754: Match alignment with open parenthesis
Reorganize the parameters to improve the readability of the code in
two manners:
- parameters of distinctive variable types on different lines
- parameters of similar variable types on the same line
Also, take advantage of the horizontal space available and place
all the parameters on a single line.
Issues found by checkpatch.pl script.
Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Georgiana Rodica Chelu [Mon, 19 Sep 2016 15:41:56 +0000 (18:41 +0300)]
staging: iio: meter: ade7758_ring: Match alignment with open parenthesis
Organize the parameters on a single line to improve the readability of
the code. Also, indent the line to match alignment with the open
parenthesis. Ensure that the modifications do not break the rule
of 80 characters per line.
Issues found by checkpatch.pl script.
Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rehas Sachdeva [Tue, 20 Sep 2016 07:46:37 +0000 (13:16 +0530)]
staging: dgnc: Merge assignment with return
Instead of storing the return value of a function call into a variable and
then returning it, we can club the two into a single return statement. This
change was made using the following semantic patch by Coccinelle:
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Georgiana Rodica Chelu [Tue, 20 Sep 2016 09:13:06 +0000 (12:13 +0300)]
staging: rtl8188eu: core: rtw_xmit: Remove extra braces
Remove the braces {} in the following cases:
- when there is a single branch with a single statement.
- when both branches have a single statement
The modifications improve the coding style.
Issues found by checkpatch.pl script.
Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Tue, 20 Sep 2016 09:07:43 +0000 (14:37 +0530)]
Staging: rtl8712: rtl871x_cmd: Use !x instead of x == NULL.
Use !x instead of x == NULL. This patch was found by checkpatch.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Tue, 20 Sep 2016 09:06:17 +0000 (14:36 +0530)]
Staging: rtl8712: rtl8712_xmit: Use !x instead of x == NULL
Use !x instead of x == NULL. This patch was found by checkpatch.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Tue, 20 Sep 2016 09:04:36 +0000 (14:34 +0530)]
Staging: rtl8712: rtl8712_recv: Use !x instead of x == NULL
Use !x instead of x == NULL. This patch was found by checkpatch.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Tue, 20 Sep 2016 09:01:50 +0000 (14:31 +0530)]
Staging: rtl8712: rtl8712_efuse: Use !x instead of x == NULL.
Use !x instead of x == NULL. This patch was found by checkpatch.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Namrata A Shettar [Mon, 19 Sep 2016 14:57:56 +0000 (20:27 +0530)]
staging: rtl8192e: Insert blank line after function declaration
Insert blank line after function declaration to resolve checkpatch
issue.
Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Namrata A Shettar [Mon, 19 Sep 2016 14:57:46 +0000 (20:27 +0530)]
staging: rtl8192e: Add space around binary operator '+'
Add space around binary operator '+' to resolve checkpatch issue.
Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Namrata A Shettar [Mon, 19 Sep 2016 14:57:37 +0000 (20:27 +0530)]
staging: rtl8192e: Remove unnecessary blank lines
Remove unneccessary blank lines to resolve checkpatch issue.
Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Namrata A Shettar [Mon, 19 Sep 2016 14:57:26 +0000 (20:27 +0530)]
staging: rtl8192e: Add space around '+'
Add space around '+' to resolve checkpatch issue.
Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhumika Goyal [Sun, 18 Sep 2016 12:26:24 +0000 (17:56 +0530)]
Staging: rtl8192u: Remove useless type conversion
Some type conversions like casting a pointer to a pointer of same type,
casting to the original type using addressof(&) operator etc. are not
needed. Therefore, remove them. Done using coccinelle:
@@
type t;
t *p;
t a;
@@
(
- (t)(a)
+ a
|
- (t *)(p)
+ p
|
- (t *)(&a)
+ &a
)
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Xavier Roumegue [Mon, 19 Sep 2016 12:49:24 +0000 (14:49 +0200)]
staging: rtl8192u: r8192U_core: fix checkpatch permission warnings
Fix the following warnings:
Symbolic permissions are not preferred. Consider using octal permissions.
Signed-off-by: Xavier Roumegue <xroumegue@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sun, 18 Sep 2016 17:28:06 +0000 (00:28 +0700)]
staging: r8188eu: remove GET_HAL_DATA macro
GET_HAL_DATA replaced by its definition.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sun, 18 Sep 2016 17:27:43 +0000 (00:27 +0700)]
staging: r8188eu: remove GET_RF_TYPE macro
This macro does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sun, 18 Sep 2016 17:27:32 +0000 (00:27 +0700)]
staging: r8188eu: set correct type for HalData member of adapter structure
To avoid unnecessary typecast.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sun, 18 Sep 2016 17:27:16 +0000 (00:27 +0700)]
staging: r8188eu: remove HW_VAR_DM_FLAG member of hw_variables enumeration
rtw_hal_set_hwreg and rtw_hal_get_hwreg does not used
with HW_VAR_DM_FLAG parameter.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sun, 18 Sep 2016 17:26:29 +0000 (00:26 +0700)]
staging: r8188eu: remove usb_hal.h
usb_hal.h is empty.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sun, 18 Sep 2016 17:26:16 +0000 (00:26 +0700)]
staging: r8188eu: remove rtl8188eu_set_hal_ops function
rtl8188eu_set_hal_ops only allocates
HalData member of adapter structure.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sun, 18 Sep 2016 17:25:40 +0000 (00:25 +0700)]
staging: r8188eu: replace N_BYTE_ALIGMENT macro with PTR_ALIGN
PTR_ALIGN is a bit shorter than N_BYTE_ALIGMENT.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sun, 18 Sep 2016 17:25:25 +0000 (00:25 +0700)]
staging: r8188eu: delete rtw_usb_bulk_size_boundary function
This function does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sun, 18 Sep 2016 17:24:54 +0000 (00:24 +0700)]
staging: r8188eu: remove pkt_hdrlen member of pkt_attrib structure
pkt_hdrlen has a constant value.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sun, 18 Sep 2016 17:24:01 +0000 (00:24 +0700)]
staging: r8188eu: remove xmitframe_direct function
xmitframe_direct is a simple wrapper around
rtw_xmitframe_coalesce and rtw_dump_xframe functions.
Many wrappers complicates code reading.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Sun, 18 Sep 2016 17:23:42 +0000 (00:23 +0700)]
staging: r8188eu: change last argument type of the usb_write_port function
usb_write_port writes only xmit_buf object data to device.
In addition, an appropriate name for this argument is used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rehas Sachdeva [Tue, 20 Sep 2016 07:48:40 +0000 (13:18 +0530)]
staging: wilc1000: Merge assignment with return
Instead of storing the return value into a variable and then returning it, we
can club the two into a single return statement. This change was made using
the following semantic patch by Coccinelle:
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Mon, 19 Sep 2016 21:09:37 +0000 (17:09 -0400)]
staging: unisys: visorbus: move parahotplug_request_list and related lock
parahotplug_request_list and parahotplug_request_list_lock should be
defined closer to where we are actually using them.
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Mon, 19 Sep 2016 21:09:36 +0000 (17:09 -0400)]
staging: unisys: visorbus: remove fix_vbus_dev_info prototype
Move the visordriver_probe_device and visorbus_register_visor_driver
functions lower in the file to get rid of the function prototype
fix_vbus_dev_info.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Mon, 19 Sep 2016 21:09:35 +0000 (17:09 -0400)]
staging: unisys: visorbus move visorbus_type to remove prototypes
Move the struct visorbus_type down in the file to get rid of
the function prototypes visorbus_uevent and visorbus_match.
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Mon, 19 Sep 2016 21:09:34 +0000 (17:09 -0400)]
staging: unisys: visorbus: move deviceenabled/disabled store functions
Move the deviceenabled/devicedisabled store functions so that
function prototypes can be removed.
This caused us to move several of the structures farther
down in the file as well.
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Mon, 19 Sep 2016 21:09:33 +0000 (17:09 -0400)]
staging: unisys: visorbus: move the remaining_steps_show/store functions
Moving the remaining_steps functions allows us to get rid of an unneeded
prototype.
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Mon, 19 Sep 2016 21:09:32 +0000 (17:09 -0400)]
staging: unisys: visorbus: move textid store and show functions
The textid store and show functions were moved to allow us to remove
the function prototypes.
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Mon, 19 Sep 2016 21:09:31 +0000 (17:09 -0400)]
staging: unisys: visorbus: move error store/show functions
Move the show and store functions for the error DEV_ATTR_RW so that the
function prototypes can be removed.
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Mon, 19 Sep 2016 21:09:28 +0000 (17:09 -0400)]
staging: unisys: visorbus: remove parser_done prototype
Remove the unneeded prototype parser_done.
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Mon, 19 Sep 2016 21:09:27 +0000 (17:09 -0400)]
staging: unisys: visorbus: remove controlvm_respond_physdev_changestate
Remove the unneeded prototype declaration for function
controlvm_respond_physdev_changestate.
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Mon, 19 Sep 2016 21:09:22 +0000 (17:09 -0400)]
staging: unisys: visorbus: move parser_init_byte_stream
The function parser_init_byte_stream needs to be moved lower in the file to
avoid extraneous function prototypes.
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Mon, 19 Sep 2016 21:09:30 +0000 (17:09 -0400)]
staging: unisys: visorbus: move boottotool
Move the boottotool show and store functions so the function
prototypes can be removed.
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Mon, 19 Sep 2016 21:09:29 +0000 (17:09 -0400)]
staging: unisys: visorbus: move toolaction functions to remove prototypes
The toolchain functions show and store needed to be moved so the prototypes
were no longer needed.
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Mon, 19 Sep 2016 21:09:26 +0000 (17:09 -0400)]
staging: unisys: visorbus: remove controlvm_respond_chipset_init prototype
Remove the unneeded controlvm_respond_chipset_init prototype by
moving the functions controlvm_init_response and
controlvm_respond_chipset_init up in the file.
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Mon, 19 Sep 2016 21:09:25 +0000 (17:09 -0400)]
staging: unisys: visorbus: remove prototype controlvm_respond
Remove the unneeded prototype for controlvm_respond.
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Mon, 19 Sep 2016 21:09:24 +0000 (17:09 -0400)]
staging: unisys: visorbus: move parahotplug_process_list
The function parahotplug_process_list needs to be moved lower in the file
to avoid extraneous function prototypes.
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Mon, 19 Sep 2016 21:09:23 +0000 (17:09 -0400)]
staging: unisys: visorbus: move read_controlvm_event
The function read_controlvm_event needs to be moved lower in the file
to avoid extraneous function prototypes.
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Mon, 19 Sep 2016 21:09:21 +0000 (17:09 -0400)]
staging: unisys: visorbus: move handle_command
Handle_command gets moved lower in the file to avoid the need for
extraneous function prototypes.
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Mon, 19 Sep 2016 21:09:20 +0000 (17:09 -0400)]
staging: unisys: visorbus: reorder controlvm_periodic_work
Move controlvm_periodic_work lower in the file to avoid having
to create function prototypes.
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jon Frisch [Mon, 19 Sep 2016 21:09:19 +0000 (17:09 -0400)]
staging: unisys: visorbus: move controlvm_payload_bytes_buffered
This patch moves the unsigned long controlvm_payload_bytes_buffered
from the module parameters location to a more appropriate location
below the controlvm_payload_info.
Signed-off-by: Jon Frisch <jon.frisch@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jon Frisch [Mon, 19 Sep 2016 21:09:18 +0000 (17:09 -0400)]
staging: unisys: visorbus: remove unused dump_vhba_bus
This patch removes the unused u32 dump_vhba_bus.
Signed-off-by: Jon Frisch <jon.frisch@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jon Frisch [Mon, 19 Sep 2016 21:09:17 +0000 (17:09 -0400)]
staging: unisys: visorbus: remove unused long long bus_count
This patch removes the unused long long bus_count.
Signed-off-by: Jon Frisch <jon.frisch@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jon Frisch [Mon, 19 Sep 2016 21:09:16 +0000 (17:09 -0400)]
staging: unisys: visorbus remove unused module parameter
This patch removes the unused module parameter
visorchipset_visorbusregwait
Signed-off-by: Jon Frisch <jon.frisch@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 20 Sep 2016 00:47:30 +0000 (09:47 +0900)]
staging: greybus: use preferred kernel type u16
As suggested by checkpatch.pl:
CHECK: Prefer kernel type 'u16' over 'uint16_t'
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Tue, 20 Sep 2016 00:47:29 +0000 (09:47 +0900)]
staging: greybus: use preferred kernel type u8
As suggested by checkpatch.pl:
CHECK: Prefer kernel type 'u8' over 'uint8_t'
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anchal Jain [Sun, 18 Sep 2016 15:54:12 +0000 (21:24 +0530)]
staging: lustre: lnet: klnds: socklnd: Remove unnecessary line continuations
Fixes checkpatch warning:
WARNING: Avoid unnecessary line continuations
Signed-off-by: Anchal Jain <anchalj109@gmail.com>
Acked-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nayeemahmed Badebade [Sun, 18 Sep 2016 21:18:19 +0000 (02:48 +0530)]
staging: lustre: lustre/ldlm: Fixed sparse warnings
Added __acquires / __releases sparse locking annotations
to lock_res_and_lock() and unlock_res_and_lock() functions
in l_lock.c, to fix below sparse warnings:
l_lock.c:47:22: warning: context imbalance in 'lock_res_and_lock' - wrong count at exit
l_lock.c:61:6: warning: context imbalance in 'unlock_res_and_lock' - unexpected unlock
Signed-off-by: Nayeemahmed Badebade <itachi.opsrc@gmail.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Mon, 19 Sep 2016 18:29:36 +0000 (23:59 +0530)]
Staging: lustre: lmv_obd: Remove redundant test.
filp != NULL is already checked, so no need to check it again.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sat, 17 Sep 2016 23:53:49 +0000 (05:23 +0530)]
Staging: lustre: Convert array index from the loop bound to the loop index.
Convert array index from the loop bound to the loop index.
The structure cl_env_percpu[NR_CPUS] has been initializing for each possible
cpu (i.e 0 to i). During initialization if any error will occurred, the error
handling code should uninitialize cl_env_percpu upto i. But currently
unitialization is repeatedly done for the same cl_env_percpu[i] element.
This does not seems to be correct.
Used below semantic patch to identify this issue:
@@
expression e1,e2,ar;
@@
for(e1 = 0; e1 < e2; e1++) { <...
ar[
- e2
+ e1
]
...> }
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bryan O'Donoghue [Mon, 19 Sep 2016 17:41:46 +0000 (18:41 +0100)]
staging: greybus: MAINTAINERS: add greybus protocol drivers maintainers
Add bod to some Greybus protocol drivers maintainers, loopback and
timesync.
Signed-off-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 19 Sep 2016 15:40:25 +0000 (17:40 +0200)]
staging: most: hdm-usb: rename channel related spinlock
To increase comprehension this patch renames the channel related
spinlock with a more fitting name.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 19 Sep 2016 15:40:24 +0000 (17:40 +0200)]
staging: most: hdm-usb: remove calls to usb_unachor_urb
This patch removes the calls to usb_unanchor_urb() from the completion
routines, since disassociation of the URBs is already handles by the
USB subsystem.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 19 Sep 2016 15:40:23 +0000 (17:40 +0200)]
staging: most: hdm-usb: remove redundant spinlocks
This patch removes the spinlocks when accessing the usb_anchor list,
because the struct usb_anchor is using its own lock.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Christian Gromm [Mon, 19 Sep 2016 15:40:22 +0000 (17:40 +0200)]
staging: most: hdm-usb: remove proprietary urb anchoring
This patch removes the propietary tracking of URBs. Instead the structure
usb_anchor of the USB subsystem is used.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Tue, 20 Sep 2016 06:36:04 +0000 (08:36 +0200)]
Merge tag 'iio-for-4.9c' of git://git./linux/kernel/git/jic23/iio into staging-next
Jonathan writes:
Third set of new device support, functionality and cleanups for IIO in the 4.9 cycle.
Given Linus is hinting (strongly!) at an rc8 this last set is hopefully in
time for the 4.9 merge window. The zpa2326 and si1145 drivers provide
fine illustrations that devices aren't getting any simpler!
I'm also particularly pleased Linus Walliej did such a thorough job of cleaning
up one of my old drivers.
New device support
* mCube MC3230 accelerometer
- new fairly minimal driver.
* Murata zpa2326
- extensive new driver supporting the rather 'novel' buffering of data this
device provides and handling both it's own data ready trigger and other
triggers rather elegantly.
* si1141, si1142, si1143, si1145, si1146 and si1147 proximity, UV, visible and
IR sensors.
- another extensive new driver supporting all the key bits of what this
set of devices supplies including dataready triggers, buffers and all the
various data channels.
Functionality
* kxsd9 - Linus brought this scratch driver I wrote in one afternoon years ago
up to date adding lots of good stuff along the way.
- SPI support after extensive rework of the driver.
- Triggered buffer capture support.
- Runtime PM.
- Regulator handling.
- Mounting matrix support.
* mma7660
- Add MODULE_DEVICE_TABLE to support autoprobing.
Cleanups
* ad5933
- Align some function arguements nicely.
* med_z188
- Constify iio_info structure.
* sca3000
- Implement IIO_CHAN_INFO_SAMP_FREQ rather than a hand rolled attr.
There are still quite a few drivers that would benefit from similar updates.
* ssp_sensors
- Constify iio_info structures in accel and gyro drivers.
Greg Kroah-Hartman [Mon, 19 Sep 2016 17:34:33 +0000 (19:34 +0200)]
Merge branch 'greybus' into staging-testing
This merges the greybus branch into staging-testing. It contains the
drivers/staging/greybus/ subsystem and related drivers and has passed
the 0-day bot tests so no builds should break.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rui Miguel Silva [Mon, 19 Sep 2016 16:07:59 +0000 (17:07 +0100)]
staging: greybus: MAINTAINERS: add greybus protocol drivers maintainers
Add me to some Greybus protocol drivers maintainers, spi, sdio, power
supply, light and gpio.
Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Mon, 19 Sep 2016 16:23:19 +0000 (18:23 +0200)]
staging: greybus: add some MAINTAINERS
Johan and Alex and I are going to maintain the greybus code, so add it
to MAINTAINERS so we get cc:ed on patches.
Acked-by: Johan Hovold <johan@kernel.org>
Acked-by: Alex Elder <elder@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Fri, 9 Sep 2016 07:47:01 +0000 (09:47 +0200)]
staging: greybus: remove CONFIG_PM_RUNTIME from kernel_ver.h
The last thing remaining in kernel_ver.h was the setting of
CONFIG_PM_RUNTIME, which isn't needed in a in-tree implementation. So
remove the setting of this value, and the .h file entirely as that was
the last thing left in it.
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Rui Miguel Silva [Thu, 8 Sep 2016 16:17:52 +0000 (17:17 +0100)]
staging: greybus: Kconfig: enable possibility to select light driver
Remove BROKEN keyword to allow the light driver to be select now that
we fixed the kernel version dependencies. Also fix the module name in
the help section.
Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Rui Miguel Silva [Thu, 8 Sep 2016 16:17:51 +0000 (17:17 +0100)]
staging: greybus: makefile: fix dependency of spi to spilib
Greybus SPI driver depends on gb-spilib and we need to state that at
makefile to make it link correctly.
Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Rui Miguel Silva [Thu, 8 Sep 2016 16:17:50 +0000 (17:17 +0100)]
staging: greybus: power_supply: remove KERNEL_VERSION checks
No need to support older kernel versions in the Greybus Power Supply
driver, so remove the checks as needed, we can now rely on all of the
correct Power Supply core apis being present. Also move some properties
definitions to the power supply greybus code.
Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Rui Miguel Silva [Thu, 8 Sep 2016 16:17:49 +0000 (17:17 +0100)]
staging: greybus: sdio: remove KERNEL_VERSION checks
No need to support older kernel versions in the Greybus SDIO driver, so
remove the checks as needed, we can now rely on all of the correct SDIO
core apis being present.
Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Rui Miguel Silva [Thu, 8 Sep 2016 16:17:48 +0000 (17:17 +0100)]
staging: greybus: light: remove KERNEL_VERSION checks
No need to support older kernel versions in the Greybus Light driver, so
remove the checks as needed, we can now rely on all of the correct LED
core apis being present. And compile only if flash and v4l2 flash is
reachable.
Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Greg Kroah-Hartman [Thu, 8 Sep 2016 14:10:50 +0000 (16:10 +0200)]
staging: greybus: sdio: fix min() type check
The 0-day bot pointed out a type difference in one min() call, so fix it
up by being explicit about the type being compared.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Greg Kroah-Hartman [Thu, 8 Sep 2016 14:06:27 +0000 (16:06 +0200)]
staging: greybus: spi: remove KERNEL_VERSION checks
No need to support older kernel versions in the Greybus SPI and spilib
driver, so remove the checks as needed, we can now rely on all of the
correct SPI core apis being present.
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Greg Kroah-Hartman [Mon, 19 Sep 2016 14:41:54 +0000 (16:41 +0200)]
staging: greybus: gpio: it's CONFIG_GPIOLIB, not CONFIG_GPIO
The GPIO dependancy is CONFIG_GPIOLIB, not CONFIG_GPIO, no wonder it
wasn't building properly...
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Greg Kroah-Hartman [Thu, 8 Sep 2016 13:52:06 +0000 (15:52 +0200)]
staging: greybus: gpio: remove KERNEL_VERSION checks
No need to support older kernel versions in the Greybus GPIO driver, so
remove the checks as needed, we can now rely on all of the correct
GPIO core apis being present.
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Greg Kroah-Hartman [Thu, 8 Sep 2016 13:47:30 +0000 (15:47 +0200)]
staging: greybus: vibrator: remove KERNEL_VERSION checks
No need to support older kernel versions in the Greybus Vibrator driver,
so remove the checks as needed, we can now rely on all of the correct
driver core apis being present.
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Greg Kroah-Hartman [Thu, 8 Sep 2016 13:46:38 +0000 (15:46 +0200)]
staging: greybus: hid: remove KERNEL_VERSION checks
No need to support older kernel versions in the Greybus HID driver, so
remove the checks as needed, we can now rely on all of the "new" apis
being present.
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Greg Kroah-Hartman [Thu, 8 Sep 2016 09:51:33 +0000 (11:51 +0200)]
staging: greybus: kernel_ver.h: remove lots of stuff
Now that we do not care about the kernel version we are building
against, we can strip out lots of backward compatibilty that was added
to kernel_ver.h in order to write semi-portable driver code.
To start with, remove the functions and #defines that are now in the
kernel tree, no need to have duplicate copies of them all.
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Greg Kroah-Hartman [Mon, 19 Sep 2016 13:46:40 +0000 (15:46 +0200)]
staging: greybus: Add drivers/staging/greybus to the build
This adds a proper Kconfig file for drivers/staging/greybus and fixes up
the Makefile to work correctly within the kernel build system (modules
depend on the .config options, etc.)
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Greg Kroah-Hartman [Mon, 19 Sep 2016 10:40:33 +0000 (12:40 +0200)]
staging: greybus: remove old es1 endpoint description
The Toshiba ES1 chip is no longer around, so remove the USB descriptor
documentation for it as no one cares anymore.
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Greg Kroah-Hartman [Thu, 8 Sep 2016 13:01:23 +0000 (15:01 +0200)]
staging: greybus: remove .gitignore file
Only the tools subdirectory needs a .gitignore entry, so move it there
and fix it up to only list the needed file.
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Greg Kroah-Hartman [Thu, 8 Sep 2016 09:58:46 +0000 (11:58 +0200)]
staging: greybus: remove README and LICENSE
We don't need yet-another-copy of the GPLv2 in the tree, and the README
is now pointless, so remove both of these files.
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Greg Kroah-Hartman [Mon, 19 Sep 2016 10:35:16 +0000 (12:35 +0200)]
staging: greybus: Documentation: remove sysfs tree
We do not need an example of the sysfs tree in the kernel code itself,
so remove these files, as they are now pointless.
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Greg Kroah-Hartman [Thu, 8 Sep 2016 09:44:34 +0000 (11:44 +0200)]
greybus: remove local checkpatch.pl copy
When the greybus tree was external, it contained a copy of checkpatch.pl
to keep everyone "in line". This is no longer needed and can now be
removed.
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Greg Kroah-Hartman [Mon, 19 Sep 2016 10:29:33 +0000 (12:29 +0200)]
Merge greybus driver tree into 4.8-rc6
This pulls the external greybus driver tree into 4.8-rc6 as it should be
part of the main kernel tree and not live outside in some lonely github
repo, never to be reunited with it's true love...
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Sun, 18 Sep 2016 20:39:03 +0000 (16:39 -0400)]
staging: lustre: update version to 2.6.99
With all of the the missing patches from the
lustre 2.7 version merged upstream its time to update
the upstream clients version.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Doug Oucharek [Sun, 18 Sep 2016 20:39:02 +0000 (16:39 -0400)]
staging: lustre: o2iblnd: Put back work queue check previously removed
The previous patch, http://review.whamcloud.com/21304/, removed
a check needed until LU-5718 is properly addressed. With
the check, LU-5718 results in an error message and a lost
RDMA operation. Without it, we have memory corruption and
a crash (much harder to debug).
Putting the check back in case LU-5718 is not fixed soon.
Signed-off-by: Doug Oucharek <doug.s.oucharek@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-7650
Reviewed-on: http://review.whamcloud.com/22281
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Olaf Weber <olaf@sgi.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / GitHub / LineageOS / android_kernel_motorola_exynos9610.git / log