GitHub/WoltLab/WCF.git
3 years agoDisconnect SMTP session for all types of Exception during connect / auth
Tim Düsterhus [Mon, 11 Jan 2021 10:51:23 +0000 (11:51 +0100)]
Disconnect SMTP session for all types of Exception during connect / auth

3 years agoFail SMTP auth if credentials are configured but all mechanisms fail
Tim Düsterhus [Mon, 11 Jan 2021 10:49:20 +0000 (11:49 +0100)]
Fail SMTP auth if credentials are configured but all mechanisms fail

3 years agoMerge branch '5.2' into 5.3 5.3.2
joshuaruesweg [Wed, 6 Jan 2021 15:40:00 +0000 (16:40 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
joshuaruesweg [Wed, 6 Jan 2021 15:39:26 +0000 (16:39 +0100)]
Merge branch '3.1' into 5.2

3 years agoMerge pull request #3844 from WoltLab/fix-failing-cronjobs
Joshua Rüsweg [Wed, 6 Jan 2021 15:38:31 +0000 (16:38 +0100)]
Merge pull request #3844 from WoltLab/fix-failing-cronjobs

Fix failing cronjobs

3 years agoIncorrect year
Alexander Ebert [Wed, 6 Jan 2021 14:59:23 +0000 (15:59 +0100)]
Incorrect year

Old habits die hard…

3 years agoRelease 5.3.2
Alexander Ebert [Wed, 6 Jan 2021 14:57:01 +0000 (15:57 +0100)]
Release 5.3.2

3 years agoUpdating minified JavaScript files
WoltLab [Wed, 6 Jan 2021 14:44:19 +0000 (14:44 +0000)]
Updating minified JavaScript files

3 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Wed, 6 Jan 2021 11:19:16 +0000 (12:19 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix VarbinaryDatabaseTableColumn
Tim Düsterhus [Wed, 6 Jan 2021 11:18:29 +0000 (12:18 +0100)]
Fix VarbinaryDatabaseTableColumn

> Call to undefined method wcf\system\database\table\column\VarbinaryDatabaseTableColumn::traitGetLength()

see 4a65b1e27cc85fc9fb9bbcdf6a6d7a5f9cc76187

3 years agoHide article-related notification events if articles are disabled
Matthias Schmidt [Sun, 3 Jan 2021 16:23:09 +0000 (17:23 +0100)]
Hide article-related notification events if articles are disabled

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Sun, 3 Jan 2021 16:20:22 +0000 (17:20 +0100)]
Merge branch '5.2' into 5.3

3 years agoHide article-related notification events if articles are disabled
Matthias Schmidt [Sun, 3 Jan 2021 16:20:06 +0000 (17:20 +0100)]
Hide article-related notification events if articles are disabled

Close #3845

3 years agofixup! Disable disabling of failed system cronjobs Fixes #3841
joshuaruesweg [Sun, 3 Jan 2021 16:10:32 +0000 (17:10 +0100)]
fixup! Disable disabling of failed system cronjobs Fixes #3841

3 years agoDisable disabling of failed system cronjobs
joshuaruesweg [Sat, 2 Jan 2021 15:10:37 +0000 (16:10 +0100)]
Disable disabling of failed system cronjobs
Fixes #3841

3 years agoPrevent failing cronjobs from blocking other cronjobs by executing them last
joshuaruesweg [Sat, 2 Jan 2021 15:06:56 +0000 (16:06 +0100)]
Prevent failing cronjobs from blocking other cronjobs by executing them last

3 years agoFix missing informal language variable
Peter Lohse [Sat, 2 Jan 2021 13:37:43 +0000 (14:37 +0100)]
Fix missing informal language variable

Closes #3843

3 years agoPrevent sentences in the search result list from being "glued" together
Alexander Ebert [Thu, 31 Dec 2020 12:43:19 +0000 (13:43 +0100)]
Prevent sentences in the search result list from being "glued" together

3 years agoProperly remove formatting in nested elements
Alexander Ebert [Mon, 28 Dec 2020 19:08:32 +0000 (20:08 +0100)]
Properly remove formatting in nested elements

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Mon, 28 Dec 2020 15:30:06 +0000 (16:30 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix validation of required single media form fields
Matthias Schmidt [Mon, 28 Dec 2020 15:29:17 +0000 (16:29 +0100)]
Fix validation of required single media form fields

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Sun, 27 Dec 2020 13:12:50 +0000 (14:12 +0100)]
Merge branch '5.2' into 5.3

3 years agoImprove readability of form field template code
Matthias Schmidt [Sun, 27 Dec 2020 13:11:32 +0000 (14:11 +0100)]
Improve readability of form field template code

3 years agoFix validation of form builder node attributes
Matthias Schmidt [Sun, 27 Dec 2020 13:10:31 +0000 (14:10 +0100)]
Fix validation of form builder node attributes

Close #3827

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Sun, 27 Dec 2020 12:55:45 +0000 (13:55 +0100)]
Merge branch '5.2' into 5.3

3 years agoThrow exception for VARBINARY columns without length
Matthias Schmidt [Sun, 27 Dec 2020 12:54:55 +0000 (13:54 +0100)]
Throw exception for VARBINARY columns without length

Close #3827

3 years agoMerge pull request #3824 from WoltLab/53-upgrade-preserve-credentials
Alexander Ebert [Wed, 23 Dec 2020 18:16:53 +0000 (19:16 +0100)]
Merge pull request #3824 from WoltLab/53-upgrade-preserve-credentials

Preserve package server credentials during the upgrade from 5.2 to 5.3.

3 years agoEnable the media page in offline mode
Alexander Ebert [Wed, 23 Dec 2020 17:30:50 +0000 (18:30 +0100)]
Enable the media page in offline mode

This is consistent with the existing exception from the forced login (`AbstractPage::forceLogin()`).

Fixes #3836

3 years agoPrevent the removal of the package servers for `5.3` to preserve the credentials
Alexander Ebert [Wed, 23 Dec 2020 17:12:16 +0000 (18:12 +0100)]
Prevent the removal of the package servers for `5.3` to preserve the credentials

3 years agoPermit `wsm` to be placed inside `<li>`
Alexander Ebert [Wed, 23 Dec 2020 16:15:43 +0000 (17:15 +0100)]
Permit `wsm` to be placed inside `<li>`

3 years agoRemoved the extra margin for `<em>`
Alexander Ebert [Wed, 23 Dec 2020 12:00:44 +0000 (13:00 +0100)]
Removed the extra margin for `<em>`

This margin was required in previous versions that used incomplete fonts with lack for true italic versions. All system fonts have support for italic variants and the new WebFont support utilizes fonts with the same capabilities, creating a weird gap after italic words.

3 years agoDisplay a somewhat meaningful message when the package list inaccessible
Alexander Ebert [Tue, 22 Dec 2020 17:48:21 +0000 (18:48 +0100)]
Display a somewhat meaningful message when the package list inaccessible

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Tue, 22 Dec 2020 13:08:09 +0000 (14:08 +0100)]
Merge branch '5.2' into 5.3

3 years agoValidate column names in indices when using PHP DB API (#3832)
Matthias Schmidt [Tue, 22 Dec 2020 13:07:39 +0000 (14:07 +0100)]
Validate column names in indices when using PHP DB API (#3832)

Close  #3828

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Tue, 22 Dec 2020 12:20:34 +0000 (13:20 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix case of non-existing table in DatabaseTableChangeProcessor::getColumnByName()
Matthias Schmidt [Tue, 22 Dec 2020 12:04:22 +0000 (13:04 +0100)]
Fix case of non-existing table in DatabaseTableChangeProcessor::getColumnByName()

Close #3829

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Tue, 22 Dec 2020 11:59:56 +0000 (12:59 +0100)]
Merge branch '5.2' into 5.3

3 years agoConsider package during event listeners' name validation in PIP GUI
Matthias Schmidt [Tue, 22 Dec 2020 11:59:18 +0000 (12:59 +0100)]
Consider package during event listeners' name validation in PIP GUI

Close #3831

3 years agoIncorrect usage of `<div>` inside `<code>`
Alexander Ebert [Mon, 21 Dec 2020 17:01:45 +0000 (18:01 +0100)]
Incorrect usage of `<div>` inside `<code>`

Fixes #3720

3 years agoPreserve the package server credentials when upgrading from 5.2 -> 5.3
Alexander Ebert [Mon, 21 Dec 2020 16:41:54 +0000 (17:41 +0100)]
Preserve the package server credentials when upgrading from 5.2 -> 5.3

Fixes #3805

3 years agoUpdating minified JavaScript files
WoltLab [Mon, 21 Dec 2020 13:54:52 +0000 (13:54 +0000)]
Updating minified JavaScript files

3 years ago`const` trips the requirejs compiler
Alexander Ebert [Mon, 21 Dec 2020 13:53:34 +0000 (14:53 +0100)]
`const` trips the requirejs compiler

3 years agoprevented unnecessary duplicate generation of the option tree
Marcel Werk [Mon, 21 Dec 2020 10:29:55 +0000 (11:29 +0100)]
prevented unnecessary duplicate generation of the option tree

3 years agoFix copy and paste error in error output in styleAdd.tpl
Tim Düsterhus [Mon, 21 Dec 2020 10:13:36 +0000 (11:13 +0100)]
Fix copy and paste error in error output in styleAdd.tpl

3 years agoFix copy and paste error in image size validation in StyleAddForm
Tim Düsterhus [Mon, 21 Dec 2020 10:10:49 +0000 (11:10 +0100)]
Fix copy and paste error in image size validation in StyleAddForm

3 years agoUpdating minified JavaScript files
WoltLab [Sun, 20 Dec 2020 13:16:33 +0000 (13:16 +0000)]
Updating minified JavaScript files

3 years ago`const` trips the requirejs compiler
Alexander Ebert [Sun, 20 Dec 2020 13:15:12 +0000 (14:15 +0100)]
`const` trips the requirejs compiler

3 years agoUpdating minified JavaScript files
WoltLab [Sun, 20 Dec 2020 12:02:41 +0000 (12:02 +0000)]
Updating minified JavaScript files

3 years agoRequire label for `CheckboxFormField`
Matthias Schmidt [Sun, 20 Dec 2020 10:05:19 +0000 (11:05 +0100)]
Require label for `CheckboxFormField`

3 years agoImproved the scroll behavior on mobile devices
Alexander Ebert [Sat, 19 Dec 2020 22:55:32 +0000 (23:55 +0100)]
Improved the scroll behavior on mobile devices

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Fri, 18 Dec 2020 18:33:51 +0000 (19:33 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix DatabaseTableChangeProcessor::getColumnByName() for WSC < 5.4
Matthias Schmidt [Fri, 18 Dec 2020 18:33:23 +0000 (19:33 +0100)]
Fix DatabaseTableChangeProcessor::getColumnByName() for WSC < 5.4

See #3792

3 years agoFix missing variable error in DatabaseTableChangeProcessor
Matthias Schmidt [Fri, 18 Dec 2020 18:32:51 +0000 (19:32 +0100)]
Fix missing variable error in DatabaseTableChangeProcessor

See #3792

3 years agoFix updating action of foreign key
Matthias Schmidt [Fri, 18 Dec 2020 18:26:29 +0000 (19:26 +0100)]
Fix updating action of foreign key

See c64a33b40a7e601a6005f7ca247f7d2ecb52a393

3 years agoAdd CheckboxFormField (#3812)
Peter Lohse [Fri, 18 Dec 2020 18:17:12 +0000 (19:17 +0100)]
Add CheckboxFormField (#3812)

* added implementation of a checkbox form field for boolen values

* fixed indentation

* added __checkboxFormField to syncTemplates.json

* added missing comma

3 years agoRTL fix for code boxes
Marcel Werk [Fri, 18 Dec 2020 14:47:22 +0000 (15:47 +0100)]
RTL fix for code boxes

3 years agoMerge pull request #3818 from WoltLab/empty-style-preview
Tim Düsterhus [Fri, 18 Dec 2020 12:53:16 +0000 (13:53 +0100)]
Merge pull request #3818 from WoltLab/empty-style-preview

Fix style previews pointing to the style's asset folder

3 years agoFix style previews pointing to the style's asset folder
Tim Düsterhus [Fri, 18 Dec 2020 12:44:57 +0000 (13:44 +0100)]
Fix style previews pointing to the style's asset folder

update_com.woltlab.wcf_5.3.1_style.php created this situation when the style
did not have a preview image, due to a missing check for a non-empty `image` /
`image2x` property.

3 years agoMerge pull request #3817 from WoltLab/count-category-options
Marcel Werk [Fri, 18 Dec 2020 11:16:38 +0000 (12:16 +0100)]
Merge pull request #3817 from WoltLab/count-category-options

Improved detection of empty option categories

3 years agoRemoved obsolete parameter
Marcel Werk [Thu, 17 Dec 2020 18:20:09 +0000 (19:20 +0100)]
Removed obsolete parameter

3 years agoPermit the use of `is_null` in templates when running in the enterprise mode
Alexander Ebert [Thu, 17 Dec 2020 16:57:43 +0000 (17:57 +0100)]
Permit the use of `is_null` in templates when running in the enterprise mode

3 years agoImproved detection of empty option categories
Marcel Werk [Thu, 17 Dec 2020 15:20:13 +0000 (16:20 +0100)]
Improved detection of empty option categories

3 years agoFix typo in de.xml
Tim Düsterhus [Thu, 17 Dec 2020 08:14:29 +0000 (09:14 +0100)]
Fix typo in de.xml

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Tue, 15 Dec 2020 17:19:37 +0000 (18:19 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix hiding/showing tab menu entries due to form builder dependencies
Matthias Schmidt [Tue, 15 Dec 2020 17:19:21 +0000 (18:19 +0100)]
Fix hiding/showing tab menu entries due to form builder dependencies

3 years agoMerge pull request #3810 from WoltLab/user-group-option-limited-removal
Alexander Ebert [Tue, 15 Dec 2020 10:42:36 +0000 (11:42 +0100)]
Merge pull request #3810 from WoltLab/user-group-option-limited-removal

Prevent the unintentional removal of values for groups that are not being edited

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Mon, 14 Dec 2020 19:13:35 +0000 (20:13 +0100)]
Merge branch '5.2' into 5.3

3 years agoExcempt the admin panel from application overrides
Alexander Ebert [Mon, 14 Dec 2020 19:13:04 +0000 (20:13 +0100)]
Excempt the admin panel from application overrides

Fixes #3762

3 years agoPrevent the unintentional removal of values for groups that are not being edited
Alexander Ebert [Mon, 14 Dec 2020 17:44:41 +0000 (18:44 +0100)]
Prevent the unintentional removal of values for groups that are not being edited

3 years agoMerge pull request #3807 from WoltLab/imagick-quantize-images
Alexander Ebert [Mon, 14 Dec 2020 13:13:27 +0000 (14:13 +0100)]
Merge pull request #3807 from WoltLab/imagick-quantize-images

Greatly improve the performance of GIF processing with ImageMagick

3 years agoRemoved the legacy workaround for ancient ImageMagick versions
Alexander Ebert [Mon, 14 Dec 2020 12:43:18 +0000 (13:43 +0100)]
Removed the legacy workaround for ancient ImageMagick versions

3 years agoTypo
Alexander Ebert [Sun, 13 Dec 2020 19:05:13 +0000 (20:05 +0100)]
Typo

3 years agoPrevent the trophy content being squished together
Alexander Ebert [Sat, 12 Dec 2020 18:11:39 +0000 (19:11 +0100)]
Prevent the trophy content being squished together

3 years agoGreatly improve the performance of GIF processing with ImageMagick
Alexander Ebert [Sat, 12 Dec 2020 17:41:36 +0000 (18:41 +0100)]
Greatly improve the performance of GIF processing with ImageMagick

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Sat, 12 Dec 2020 14:01:52 +0000 (15:01 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge pull request #3799 from WoltLab/nonnull_in_primary_key
Matthias Schmidt [Sat, 12 Dec 2020 14:00:52 +0000 (15:00 +0100)]
Merge pull request #3799 from WoltLab/nonnull_in_primary_key

Validate primary indices with null columns in PHP DB API

3 years agoReload styleEditor after updating image path
joshuaruesweg [Fri, 11 Dec 2020 10:48:22 +0000 (11:48 +0100)]
Reload styleEditor after updating image path
Because the style is compiled after the variables have been set, we have to reload the style object once with the correct `imagePath` so that it can be used correctly in the initial compilation.

3 years agoRemove obsolete PACKAGE_ID check in ImportCLICommand
Tim Düsterhus [Thu, 10 Dec 2020 13:21:03 +0000 (14:21 +0100)]
Remove obsolete PACKAGE_ID check in ImportCLICommand

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Wed, 9 Dec 2020 17:43:05 +0000 (18:43 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix doubled validation errors for CaptchaFormField
Matthias Schmidt [Wed, 9 Dec 2020 17:42:41 +0000 (18:42 +0100)]
Fix doubled validation errors for CaptchaFormField

3 years agoValidate primary indices with null columns in PHP DB API
Matthias Schmidt [Wed, 9 Dec 2020 16:13:59 +0000 (17:13 +0100)]
Validate primary indices with null columns in PHP DB API

Close #3792

3 years agoRestored the user online location for profiles
Alexander Ebert [Wed, 9 Dec 2020 00:23:31 +0000 (01:23 +0100)]
Restored the user online location for profiles

There has been a change in 5.3 that introduced the `$userOnline` value, however this is the target user itself and not the user's content they are viewing. The `$user` variable is useless, because it is a plain `User` object that is not compatible with `{$user}`.

3 years agoFix `wcf.user.register.needEmailConfirmation`
joshuaruesweg [Tue, 8 Dec 2020 12:56:41 +0000 (13:56 +0100)]
Fix `wcf.user.register.needEmailConfirmation`

3 years agoFix `wcf.user.register.needEmailConfirmation`
joshuaruesweg [Tue, 8 Dec 2020 12:54:49 +0000 (13:54 +0100)]
Fix `wcf.user.register.needEmailConfirmation`

3 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Mon, 7 Dec 2020 20:00:31 +0000 (21:00 +0100)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Mon, 7 Dec 2020 20:00:11 +0000 (21:00 +0100)]
Merge branch '3.1' into 5.2

3 years agoForce the use of the attachment thumbnail if the original is inaccessible
Alexander Ebert [Mon, 7 Dec 2020 19:58:02 +0000 (20:58 +0100)]
Force the use of the attachment thumbnail if the original is inaccessible

3 years agoWorkaround for the misaligned caret in Safari caused by 0x200B
Alexander Ebert [Mon, 7 Dec 2020 19:02:58 +0000 (20:02 +0100)]
Workaround for the misaligned caret in Safari caused by 0x200B

3 years agoImproved the iOS WebKit click detection inside the editor margin
Alexander Ebert [Mon, 7 Dec 2020 17:16:08 +0000 (18:16 +0100)]
Improved the iOS WebKit click detection inside the editor margin

3 years agoForce a whitespace before and after inserted smileys
Alexander Ebert [Mon, 7 Dec 2020 16:27:54 +0000 (17:27 +0100)]
Force a whitespace before and after inserted smileys

3 years agoMerge pull request #3793 from WoltLab/style-import-permissions
Tim Düsterhus [Mon, 7 Dec 2020 15:52:12 +0000 (16:52 +0100)]
Merge pull request #3793 from WoltLab/style-import-permissions

Validate package installation permissions in StyleImportForm

3 years agoValidate package installation permissions in StyleImportForm
Tim Düsterhus [Mon, 7 Dec 2020 14:56:53 +0000 (15:56 +0100)]
Validate package installation permissions in StyleImportForm

3 years agoMerge pull request #3786 from WoltLab/like-rebuild
Joshua Rüsweg [Mon, 7 Dec 2020 12:59:44 +0000 (13:59 +0100)]
Merge pull request #3786 from WoltLab/like-rebuild

Optimize LikeRebuildDataWorker performance

3 years agoOnly close the user panel drop-downs if no key modifier was pressed
Alexander Ebert [Sun, 6 Dec 2020 21:48:54 +0000 (22:48 +0100)]
Only close the user panel drop-downs if no key modifier was pressed

3 years agoDiscard the current selection when saving a quote
Alexander Ebert [Sun, 6 Dec 2020 20:16:16 +0000 (21:16 +0100)]
Discard the current selection when saving a quote

3 years agoPrevent the tooltip being selectable while the user changes the selection
Alexander Ebert [Sun, 6 Dec 2020 20:10:59 +0000 (21:10 +0100)]
Prevent the tooltip being selectable while the user changes the selection

3 years agoUnified behavior of the notification list and the corresponding menu drop-down
Alexander Ebert [Sun, 6 Dec 2020 19:35:08 +0000 (20:35 +0100)]
Unified behavior of the notification list and the corresponding menu drop-down

3 years agoConsistent width of menus in the mobile menu
Alexander Ebert [Sun, 6 Dec 2020 19:19:58 +0000 (20:19 +0100)]
Consistent width of menus in the mobile menu

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Sun, 6 Dec 2020 14:09:45 +0000 (15:09 +0100)]
Merge branch '5.2' into 5.3

3 years agoFix dependencies for single media form field
Matthias Schmidt [Sun, 6 Dec 2020 14:09:17 +0000 (15:09 +0100)]
Fix dependencies for single media form field