joshuaruesweg [Tue, 9 Nov 2021 14:59:02 +0000 (15:59 +0100)]
Use `UserProfileAction::setAvatar()` in AvatarUploadFileSaveStrategy
joshuaruesweg [Tue, 9 Nov 2021 14:43:12 +0000 (15:43 +0100)]
Add method to set an avatar for an user
Tim Düsterhus [Fri, 5 Nov 2021 12:33:13 +0000 (13:33 +0100)]
Merge branch '5.4'
Tim Düsterhus [Fri, 5 Nov 2021 11:33:05 +0000 (12:33 +0100)]
Tim Düsterhus [Fri, 5 Nov 2021 11:16:27 +0000 (12:16 +0100)]
Tim Düsterhus [Fri, 5 Nov 2021 10:56:08 +0000 (11:56 +0100)]
Update to WoltLab/zxcvbn@
ade1e45a9a744600124f760243535b366ce76483
Resolves #4578
Tim Düsterhus [Fri, 5 Nov 2021 08:35:23 +0000 (09:35 +0100)]
Merge branch '5.4'
mutec [Thu, 4 Nov 2021 18:03:19 +0000 (19:03 +0100)]
Fix typo in TS comment
see #4577
Tim Düsterhus [Thu, 4 Nov 2021 14:54:19 +0000 (15:54 +0100)]
Clean up attachment tmpHash handling in WYSIWYG autosave (#4576)
The previous `.splice()` call was erroneous because it might remove more
entries in case the to-be-removed entry is not the last within the array for
whatever reason.
Replace the whole logic with a modern `.filter()`, cleanly filtering out all
existing entries for the current `tmpHash` and then readding it, if it still is
required.
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
Tim Düsterhus [Thu, 4 Nov 2021 14:38:16 +0000 (15:38 +0100)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Thu, 4 Nov 2021 14:35:33 +0000 (15:35 +0100)]
Merge branch '5.2' into 5.3
Tim Düsterhus [Thu, 4 Nov 2021 14:34:47 +0000 (15:34 +0100)]
Fix error message for `foreignColumnChange` in PHP DDL API
Tim Düsterhus [Wed, 3 Nov 2021 09:23:58 +0000 (10:23 +0100)]
Do not require implementation of AbstractSearchEngine::getFulltextMinimumWordLength()
This method is deprecated since 5.4, do not require an implementation in a specific
search engine by making it abstract.
Tim Düsterhus [Tue, 2 Nov 2021 12:38:23 +0000 (13:38 +0100)]
Merge branch '5.4'
Tim Düsterhus [Tue, 2 Nov 2021 12:38:13 +0000 (13:38 +0100)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Tue, 2 Nov 2021 12:36:47 +0000 (13:36 +0100)]
Merge branch '5.2' into 5.3
Tim Düsterhus [Tue, 2 Nov 2021 12:34:12 +0000 (13:34 +0100)]
Merge branch '3.1' into 5.2
Tim Düsterhus [Tue, 2 Nov 2021 12:31:07 +0000 (13:31 +0100)]
Merge pull request #4574 from WoltLab/supportexpiry-31
Notify users of the expiring support
Tim Düsterhus [Tue, 2 Nov 2021 11:11:50 +0000 (12:11 +0100)]
joshuaruesweg [Tue, 2 Nov 2021 10:00:58 +0000 (11:00 +0100)]
Hide edit button w/o actions
joshuaruesweg [Tue, 2 Nov 2021 09:58:42 +0000 (10:58 +0100)]
Use typeunsafe comparsion
joshuaruesweg [Tue, 2 Nov 2021 09:57:05 +0000 (10:57 +0100)]
Prevent showing deleting own user button
Fixes #4573
Joshua Rüsweg [Tue, 2 Nov 2021 09:31:33 +0000 (10:31 +0100)]
Merge pull request #4570 from WoltLab/5.5-simple-acl-inverted
Add support for inverted permissions in simple acl form field
Tim Düsterhus [Tue, 2 Nov 2021 09:25:28 +0000 (10:25 +0100)]
Fix code style in UserFormField
Tim Düsterhus [Tue, 2 Nov 2021 09:25:06 +0000 (10:25 +0100)]
Merge branch '5.4'
Tim Düsterhus [Tue, 2 Nov 2021 09:24:50 +0000 (10:24 +0100)]
Fix code style in UserFormField
Tim Düsterhus [Tue, 2 Nov 2021 09:17:57 +0000 (10:17 +0100)]
Make `UserFormField::$users` a list
This is a small compatibility break, but even previously one could not rely on
a specific value used for indexing. Users passed via `->value()` would be indexed
by userID, whereas users fetched during validation would be indexed by username.
Make this a regular 0-indexed list for consistency.
While doing so, filter out any `null` values, as they are completely useless
within a list where one cannot derive any information from the array key.
Tim Düsterhus [Tue, 2 Nov 2021 09:14:02 +0000 (10:14 +0100)]
Merge branch '5.4'
Tim Düsterhus [Tue, 2 Nov 2021 09:10:20 +0000 (10:10 +0100)]
Ignore values referring to non-existent users in UserFormField::value()
This is required when reloading database values for a UserFormField that is not
required. The column either contains a `0` or `null` which previously failed to
reload.
Fix this by filtering out `null` values from `$this->users` and gracefully
handling an empty `$this->users` array.
joshuaruesweg [Thu, 28 Oct 2021 06:54:40 +0000 (08:54 +0200)]
Add support for inverted permissions
Tim Düsterhus [Tue, 2 Nov 2021 08:57:01 +0000 (09:57 +0100)]
Merge branch '5.4'
Tim Düsterhus [Tue, 2 Nov 2021 08:42:36 +0000 (09:42 +0100)]
Disallow calls to UserFormField::getSaveValue() if multiple values may be entered
Tim Düsterhus [Tue, 2 Nov 2021 08:39:23 +0000 (09:39 +0100)]
Fix UserProfile::getUserProfilesByUsername() if `null` is cached
Tim Düsterhus [Tue, 2 Nov 2021 08:24:41 +0000 (09:24 +0100)]
Fix type of `UserFormField::$users`
Tim Düsterhus [Tue, 2 Nov 2021 08:22:41 +0000 (09:22 +0100)]
Use `\array_column()` in UserFormField::value()
Tim Düsterhus [Mon, 1 Nov 2021 14:55:56 +0000 (15:55 +0100)]
Merge pull request #4572 from WoltLab/systemcheck-id
Suggest performing a system check when key system information change
Tim Düsterhus [Mon, 1 Nov 2021 14:47:10 +0000 (15:47 +0100)]
Improve readability in `Environment::getSystemId()`
Tim Düsterhus [Mon, 1 Nov 2021 13:34:30 +0000 (14:34 +0100)]
Show an info message on IndexPage if the system ID has changed
Tim Düsterhus [Mon, 1 Nov 2021 13:24:39 +0000 (14:24 +0100)]
Store the system ID after WCFSetup
Tim Düsterhus [Mon, 1 Nov 2021 13:22:58 +0000 (14:22 +0100)]
Store the system ID on successful system checks
Tim Düsterhus [Mon, 1 Nov 2021 13:18:58 +0000 (14:18 +0100)]
Add \wcf\system\Environment
Tim Düsterhus [Mon, 1 Nov 2021 13:33:25 +0000 (14:33 +0100)]
Merge branch '5.4'
Tim Düsterhus [Mon, 1 Nov 2021 13:32:52 +0000 (14:32 +0100)]
Revert "Make PHP status in SystemCheckPage resilient against method reordering"
This change was buggy and it's not worth the effort to do this cleanly.
This reverts commit
ba725407cd3e7ee83961e355252841153493face.
Tim Düsterhus [Mon, 1 Nov 2021 10:30:19 +0000 (11:30 +0100)]
Merge branch '5.4'
Tim Düsterhus [Mon, 1 Nov 2021 10:21:05 +0000 (11:21 +0100)]
Wrap overly long line in SystemCheckPage
Tim Düsterhus [Mon, 1 Nov 2021 10:19:53 +0000 (11:19 +0100)]
Make PHP status in SystemCheckPage resilient against method reordering
Tim Düsterhus [Mon, 1 Nov 2021 10:16:37 +0000 (11:16 +0100)]
Fix indentation in systemCheck.tpl
Marcel Werk [Sun, 31 Oct 2021 17:26:19 +0000 (18:26 +0100)]
Improve error handling in GDImageAdapter::loadFile()
Closes #4413
Tim Düsterhus [Fri, 29 Oct 2021 14:07:17 +0000 (16:07 +0200)]
Merge branch '5.4'
Tim Düsterhus [Fri, 29 Oct 2021 14:06:44 +0000 (16:06 +0200)]
Tim Düsterhus [Fri, 29 Oct 2021 12:54:51 +0000 (14:54 +0200)]
Move php-css-parser to the WoltLab fork
This is for PHP 8.1 compatibility.
Marcel Werk [Wed, 27 Oct 2021 16:46:51 +0000 (18:46 +0200)]
Deal with commented-out code in ZipWriter
Closes #4391
Marcel Werk [Wed, 27 Oct 2021 16:22:42 +0000 (18:22 +0200)]
Merge branch 'master' of https://github.com/WoltLab/WCF
Marcel Werk [Wed, 27 Oct 2021 16:22:35 +0000 (18:22 +0200)]
Deal with commented-out code in StyleUtil
Closes #4390#
Marcel Werk [Wed, 27 Oct 2021 16:15:43 +0000 (18:15 +0200)]
Merge pull request #4569 from WoltLab/cleanup-paypal-callback
Clean up PaypalCallbackAction
Marcel Werk [Wed, 27 Oct 2021 16:10:12 +0000 (18:10 +0200)]
Improved code style
Tim Düsterhus [Wed, 27 Oct 2021 09:16:11 +0000 (11:16 +0200)]
Stop using SystemException in PaypalCallbackAction
Marcel Werk [Wed, 27 Oct 2021 08:38:34 +0000 (10:38 +0200)]
Fixed request
Marcel Werk [Wed, 27 Oct 2021 08:27:16 +0000 (10:27 +0200)]
Fixed code style
Marcel Werk [Wed, 27 Oct 2021 08:25:48 +0000 (10:25 +0200)]
Apply suggestions from code review
Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
Marcel Werk [Tue, 26 Oct 2021 16:52:04 +0000 (18:52 +0200)]
Clean up PaypalCallbackAction
Closes #4351
Marcel Werk [Tue, 26 Oct 2021 14:44:39 +0000 (16:44 +0200)]
Show online status indicator in user management
Closes #4568
Marcel Werk [Tue, 26 Oct 2021 14:09:20 +0000 (16:09 +0200)]
Do not increase article view counter for unpublished articles
Closes #4374
Tim Düsterhus [Tue, 26 Oct 2021 12:57:31 +0000 (14:57 +0200)]
Merge branch '5.4'
Tim Düsterhus [Tue, 26 Oct 2021 12:57:19 +0000 (14:57 +0200)]
Merge branch '5.3' into 5.4
Tim Düsterhus [Tue, 26 Oct 2021 12:56:26 +0000 (14:56 +0200)]
Regenerate composer autoloader
Tim Düsterhus [Mon, 25 Oct 2021 11:45:41 +0000 (13:45 +0200)]
Update composer dependencies
Tim Düsterhus [Mon, 25 Oct 2021 09:19:11 +0000 (11:19 +0200)]
Merge branch '5.4'
joshuaruesweg [Mon, 25 Oct 2021 09:08:44 +0000 (11:08 +0200)]
Sync `aclSimple.tpl`
joshuaruesweg [Mon, 25 Oct 2021 09:02:52 +0000 (11:02 +0200)]
Alexander Ebert [Sun, 24 Oct 2021 12:57:39 +0000 (14:57 +0200)]
Workaround for multiple quote handlers on one page
joshuaruesweg [Mon, 25 Oct 2021 09:08:44 +0000 (11:08 +0200)]
Sync `aclSimple.tpl`
Tim Düsterhus [Mon, 25 Oct 2021 09:03:27 +0000 (11:03 +0200)]
Merge pull request #4567 from WoltLab/censorship
Clean up Censorship
joshuaruesweg [Mon, 25 Oct 2021 09:02:52 +0000 (11:02 +0200)]
Alexander Ebert [Sun, 24 Oct 2021 12:57:39 +0000 (14:57 +0200)]
Workaround for multiple quote handlers on one page
Tim Düsterhus [Fri, 22 Oct 2021 09:28:16 +0000 (11:28 +0200)]
Stop checking the `enable_censorship` option
Tim Düsterhus [Fri, 22 Oct 2021 09:25:30 +0000 (11:25 +0200)]
Remove the `enable_censorship` option
Resolves #4566
Tim Düsterhus [Fri, 22 Oct 2021 09:17:48 +0000 (11:17 +0200)]
Make Censorship::$matches a local variable
There is no good reason why this should be a class property.
Tim Düsterhus [Fri, 22 Oct 2021 09:14:07 +0000 (11:14 +0200)]
Clean up initialization in `Censorship`
- Use a regular foreach loop.
- Use `ArrayUtil::trim()` which also removes empty elements by itself.
Tim Düsterhus [Fri, 22 Oct 2021 09:15:54 +0000 (11:15 +0200)]
Add early check if censored words are configured in `Censorship::test()`
Tim Düsterhus [Fri, 22 Oct 2021 09:20:14 +0000 (11:20 +0200)]
Fix the use of `preg_quote()` in `Censorship`
Specify the correct `$delimiter`.
Tim Düsterhus [Fri, 22 Oct 2021 08:50:21 +0000 (10:50 +0200)]
Merge branch '5.4'
Tim Düsterhus [Fri, 22 Oct 2021 08:48:20 +0000 (10:48 +0200)]
Specify a default value for `register_disabled`
see
83a6038eea6da6608c5363be7b9f88080f3dadb1
see #4565
Tim Düsterhus [Fri, 22 Oct 2021 08:49:36 +0000 (10:49 +0200)]
Specify a default value for `force_login`
see
83a6038eea6da6608c5363be7b9f88080f3dadb1
see #4565
Tim Düsterhus [Fri, 22 Oct 2021 08:47:17 +0000 (10:47 +0200)]
Specify a default value for `module_paid_subscription` / `paid_subscription_enable_tos_confirmation`
see
83a6038eea6da6608c5363be7b9f88080f3dadb1
see #4565
Tim Düsterhus [Fri, 22 Oct 2021 08:45:01 +0000 (10:45 +0200)]
Specify a default value for `offline` / `offline_message_allow_html`
see
83a6038eea6da6608c5363be7b9f88080f3dadb1
see #4565
Tim Düsterhus [Fri, 22 Oct 2021 08:43:23 +0000 (10:43 +0200)]
Merge branch '5.4'
Tim Düsterhus [Fri, 22 Oct 2021 08:41:52 +0000 (10:41 +0200)]
Specify a default value for `enable_censorship`
This did not cause issues in practice, as `options.inc.php` reliably contained
a `0` as the option’s value.
Fixes #4565
Tim Düsterhus [Thu, 21 Oct 2021 13:37:51 +0000 (15:37 +0200)]
Merge pull request #4564 from WoltLab/table-column-factory-inheritance
Prevent object creation for the DatabaseTableColumn factory classes
Tim Düsterhus [Thu, 21 Oct 2021 13:32:01 +0000 (15:32 +0200)]
Merge branch '5.4'
Tim Düsterhus [Thu, 21 Oct 2021 13:18:44 +0000 (15:18 +0200)]
Fix doc comment for ACPSessionAccessLog::hasProtectedURI()
This should read `deprecated`, not `since`.
see
c1586ab667e1b6e075538516b21fe8a31855c19e
Tim Düsterhus [Thu, 21 Oct 2021 13:17:06 +0000 (15:17 +0200)]
Merge pull request #4557 from WoltLab/acp-session-log-link
Remove link from requestURI in acpSessionLog
Tim Düsterhus [Thu, 21 Oct 2021 13:05:46 +0000 (15:05 +0200)]
Merge pull request #4556 from WoltLab/password-toggle-submit
Hide all passwords upon form submission in Core/Ui/Password.ts
Tim Düsterhus [Thu, 21 Oct 2021 12:19:52 +0000 (14:19 +0200)]
Merge pull request #4555 from WoltLab/style-delete
Move all of the style deletion logic into StyleEditor
Tim Düsterhus [Thu, 21 Oct 2021 12:00:23 +0000 (14:00 +0200)]
Merge branch '5.4'
Tim Düsterhus [Thu, 21 Oct 2021 11:59:28 +0000 (13:59 +0200)]
Fix PHPDoc return type for IDatabaseTableColumn::getDefaultValue()
Tim Düsterhus [Thu, 21 Oct 2021 11:54:38 +0000 (13:54 +0200)]
Prevent object creation for the DatabaseTableColumn factory classes
Resolves #4563
Tim Düsterhus [Thu, 21 Oct 2021 08:49:43 +0000 (10:49 +0200)]
Remove explicit include of class-php-ico.php in StyleAction
This class can be loaded using composer's autoloader.
Tim Düsterhus [Thu, 21 Oct 2021 08:46:55 +0000 (10:46 +0200)]
Merge branch '5.4'
Tim Düsterhus [Thu, 21 Oct 2021 08:46:36 +0000 (10:46 +0200)]
Remove include of deprecated scss.inc.php in StyleCompiler