GitHub/WoltLab/WCF.git
4 years agoMerge branch 'master' into next
Tim Düsterhus [Thu, 6 Feb 2020 17:16:18 +0000 (18:16 +0100)]
Merge branch 'master' into next

4 years agoMerge branch '3.0'
Tim Düsterhus [Thu, 6 Feb 2020 17:15:47 +0000 (18:15 +0100)]
Merge branch '3.0'

4 years agoMerge pull request #3150 from Krymonota/fix-github-primary-email
Tim Düsterhus [Thu, 6 Feb 2020 17:14:51 +0000 (18:14 +0100)]
Merge pull request #3150 from Krymonota/fix-github-primary-email

Fix GitHub primary email not correctly being detected

4 years agoUpdating minified JavaScript files
woltlab.com [Thu, 6 Feb 2020 17:06:30 +0000 (17:06 +0000)]
Updating minified JavaScript files

4 years agoFix GitHub primary email not correctly being detected
Niklas (Krymonota) [Thu, 6 Feb 2020 17:01:13 +0000 (18:01 +0100)]
Fix GitHub primary email not correctly being detected

4 years agoMerge branch 'master' into next
Tim Düsterhus [Thu, 6 Feb 2020 16:44:45 +0000 (17:44 +0100)]
Merge branch 'master' into next

4 years agoMerge branch '3.0'
Tim Düsterhus [Thu, 6 Feb 2020 16:43:19 +0000 (17:43 +0100)]
Merge branch '3.0'

4 years agoMerge pull request #3149 from Krymonota/update-github-auth
Tim Düsterhus [Thu, 6 Feb 2020 16:41:48 +0000 (17:41 +0100)]
Merge pull request #3149 from Krymonota/update-github-auth

Update GitHub authorization to use headers instead of query parameters

4 years agoUpdate GitHub authorization to use headers instead of query parameters
Niklas (Krymonota) [Thu, 6 Feb 2020 16:36:13 +0000 (17:36 +0100)]
Update GitHub authorization to use headers instead of query parameters

Using query parameters for access_token has been deprecated.

For further information, check out:
- https://community.woltlab.com/thread/281366-github-api-deprecation-notice-for-authentication-via-url-query-parameters/
- https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters

4 years agoImproved scripting access
Alexander Ebert [Wed, 5 Feb 2020 17:16:18 +0000 (18:16 +0100)]
Improved scripting access

4 years agoImproved usability of the rewrite rules dialog
Marcel Werk [Wed, 5 Feb 2020 15:31:22 +0000 (16:31 +0100)]
Improved usability of the rewrite rules dialog

4 years agoFix active ACP menu item of BBCode media provider edit form
Matthias Schmidt [Tue, 4 Feb 2020 18:01:39 +0000 (19:01 +0100)]
Fix active ACP menu item of BBCode media provider edit form

4 years agoRequire length before setting decimals of DecimalDatabaseTableColumn
Matthias Schmidt [Tue, 4 Feb 2020 17:57:02 +0000 (18:57 +0100)]
Require length before setting decimals of DecimalDatabaseTableColumn

4 years agoDistinct class name for the "Search for Updates" button
Alexander Ebert [Mon, 3 Feb 2020 19:06:10 +0000 (20:06 +0100)]
Distinct class name for the "Search for Updates" button

4 years agoRevert "Add &display=swap to Google Font request"
Alexander Ebert [Mon, 3 Feb 2020 19:01:32 +0000 (20:01 +0100)]
Revert "Add &display=swap to Google Font request"

This reverts commit f869569107955803acf4625daab2f4e080f00f80.

The `font-display: swap` behaves quite different from the previous approach and causes a FOUT even on fast connections.
Changing the default behavior in a bugfix release doesn't feel right at this time, we should revisit this with 5.3.

4 years agoMerge pull request #3147 from WoltLab/request-sql-query-comment
Alexander Ebert [Sun, 2 Feb 2020 15:59:48 +0000 (16:59 +0100)]
Merge pull request #3147 from WoltLab/request-sql-query-comment

Add \wcf\getRequestId() to request information in SQL queries

4 years agoClean up generation of request information for SQL queries
Tim Düsterhus [Sun, 2 Feb 2020 15:03:59 +0000 (16:03 +0100)]
Clean up generation of request information for SQL queries

4 years agoCache request information for SQL queries
Tim Düsterhus [Sun, 2 Feb 2020 14:59:10 +0000 (15:59 +0100)]
Cache request information for SQL queries

4 years agoAdd \wcf\getRequestId() to request information in SQL queries
Tim Düsterhus [Sun, 2 Feb 2020 14:57:27 +0000 (15:57 +0100)]
Add \wcf\getRequestId() to request information in SQL queries

4 years agoFix UserFormField value for empty fields
Matthias Schmidt [Sat, 1 Feb 2020 09:03:54 +0000 (10:03 +0100)]
Fix UserFormField value for empty fields

4 years agoUse function_exists to check for disabled functions
Marcel Werk [Fri, 31 Jan 2020 17:26:35 +0000 (18:26 +0100)]
Use function_exists to check for disabled functions

4 years agouse global namespace for opcache functions to improve the usefulness of error messages
Marcel Werk [Fri, 31 Jan 2020 17:26:18 +0000 (18:26 +0100)]
use global namespace for opcache functions to improve the usefulness of error messages

4 years agoAdded check for disabled opcache functions
Marcel Werk [Fri, 31 Jan 2020 17:14:02 +0000 (18:14 +0100)]
Added check for disabled opcache functions

4 years agoPreparing the release 5.2.2
Alexander Ebert [Thu, 30 Jan 2020 19:54:26 +0000 (20:54 +0100)]
Preparing the release 5.2.2

4 years agoUpdating minified JavaScript files
woltlab.com [Thu, 30 Jan 2020 17:32:24 +0000 (17:32 +0000)]
Updating minified JavaScript files

4 years agoMerge branch 'master' into next
Alexander Ebert [Thu, 30 Jan 2020 16:39:05 +0000 (17:39 +0100)]
Merge branch 'master' into next

4 years agoIncorrect update path calculation if the only available version is not an exact match
Alexander Ebert [Thu, 30 Jan 2020 16:37:24 +0000 (17:37 +0100)]
Incorrect update path calculation if the only available version is not an exact match

4 years agoChanged layout of amp images to responsive
Marcel Werk [Thu, 30 Jan 2020 14:10:54 +0000 (15:10 +0100)]
Changed layout of amp images to responsive

4 years agoFixed typo
Marcel Werk [Thu, 30 Jan 2020 13:50:03 +0000 (14:50 +0100)]
Fixed typo

4 years agoMerge branch 'next' of https://github.com/WoltLab/WCF into next
Marcel Werk [Thu, 30 Jan 2020 13:37:14 +0000 (14:37 +0100)]
Merge branch 'next' of https://github.com/WoltLab/WCF into next

4 years agoMerge pull request #3138 from netzhuffle/patch-2
Alexander Ebert [Thu, 30 Jan 2020 13:37:11 +0000 (14:37 +0100)]
Merge pull request #3138 from netzhuffle/patch-2

Add &display=swap to Google Font request

4 years agoremoved embedded videos from the dashboard to avoid truncated js code
Marcel Werk [Thu, 30 Jan 2020 13:37:06 +0000 (14:37 +0100)]
removed embedded videos from the dashboard to avoid truncated js code

4 years agoDisable the user edit button if there are no accessible actions
Alexander Ebert [Thu, 30 Jan 2020 13:30:13 +0000 (14:30 +0100)]
Disable the user edit button if there are no accessible actions

4 years agoMerge branch 'next' of https://github.com/WoltLab/WCF into next
Marcel Werk [Thu, 30 Jan 2020 13:27:40 +0000 (14:27 +0100)]
Merge branch 'next' of https://github.com/WoltLab/WCF into next

4 years agoFixed broken hover state of the share buttons
Marcel Werk [Thu, 30 Jan 2020 13:27:38 +0000 (14:27 +0100)]
Fixed broken hover state of the share buttons

4 years agoDisable `transform: translate` when entering fullscreen mode in the editor
Alexander Ebert [Thu, 30 Jan 2020 12:41:40 +0000 (13:41 +0100)]
Disable `transform: translate` when entering fullscreen mode in the editor

The transform of `.anchorFixedHeader` introduces a new stacking context which will cause `position: fixed` inside to be relative to the container, instead of the document.

4 years agoDesktop notifications could not be turned off in multi-domain setup
Marcel Werk [Wed, 29 Jan 2020 21:57:23 +0000 (22:57 +0100)]
Desktop notifications could not be turned off in multi-domain setup

4 years agoMerge branch 'next' of https://github.com/WoltLab/WCF into next
Marcel Werk [Wed, 29 Jan 2020 21:49:43 +0000 (22:49 +0100)]
Merge branch 'next' of https://github.com/WoltLab/WCF into next

4 years agoFixed inconsistent button labeling
Marcel Werk [Wed, 29 Jan 2020 21:49:33 +0000 (22:49 +0100)]
Fixed inconsistent button labeling

4 years agoInclude the overlaying page header in position calculations
Alexander Ebert [Wed, 29 Jan 2020 21:49:08 +0000 (22:49 +0100)]
Include the overlaying page header in position calculations

4 years agoMerge branch 'next' of https://github.com/WoltLab/WCF into next
Marcel Werk [Wed, 29 Jan 2020 21:46:46 +0000 (22:46 +0100)]
Merge branch 'next' of https://github.com/WoltLab/WCF into next

4 years agoremoved potentially unreachable link
Marcel Werk [Wed, 29 Jan 2020 21:46:43 +0000 (22:46 +0100)]
removed potentially unreachable link

4 years agoPrevent changes to the visibility settings of system boxes during an update/upgrade
Alexander Ebert [Wed, 29 Jan 2020 13:38:56 +0000 (14:38 +0100)]
Prevent changes to the visibility settings of system boxes during an update/upgrade

4 years agoMerge branch 'master' into next
Marcel Werk [Tue, 28 Jan 2020 12:00:48 +0000 (13:00 +0100)]
Merge branch 'master' into next

4 years agoMerge branch '3.0'
Marcel Werk [Tue, 28 Jan 2020 12:00:34 +0000 (13:00 +0100)]
Merge branch '3.0'

4 years agofixed issue that embedded videos were not aligned to the left
Marcel Werk [Tue, 28 Jan 2020 12:00:11 +0000 (13:00 +0100)]
fixed issue that embedded videos were not aligned to the left

4 years agoDeprecated string offset in Net_IDNA2 (PHP 7.4)
Alexander Ebert [Mon, 27 Jan 2020 15:32:16 +0000 (16:32 +0100)]
Deprecated string offset in Net_IDNA2 (PHP 7.4)

4 years agoIgnore validation errors for existing int columns with larger lengths
Matthias Schmidt [Sun, 26 Jan 2020 11:02:20 +0000 (12:02 +0100)]
Ignore validation errors for existing int columns with larger lengths

Close #3139

4 years agoFix smilies in wysiwyg form container for multiple smiley categories
Matthias Schmidt [Sun, 26 Jan 2020 09:21:39 +0000 (10:21 +0100)]
Fix smilies in wysiwyg form container for multiple smiley categories

4 years agoUse UTC instead of server timezone in DateFormField
Matthias Schmidt [Sun, 26 Jan 2020 08:17:23 +0000 (09:17 +0100)]
Use UTC instead of server timezone in DateFormField

4 years agoUse constants instead of hardcoded strings in DateFormField
Matthias Schmidt [Sun, 26 Jan 2020 08:16:51 +0000 (09:16 +0100)]
Use constants instead of hardcoded strings in DateFormField

4 years agoFix validation of earliest and latest date in DateFormField
Matthias Schmidt [Sun, 26 Jan 2020 08:14:23 +0000 (09:14 +0100)]
Fix validation of earliest and latest date in DateFormField

4 years agoUpdate documentation of DateFormField::supportsTime()
Matthias Schmidt [Sun, 26 Jan 2020 08:11:23 +0000 (09:11 +0100)]
Update documentation of DateFormField::supportsTime()

4 years agoFix reading existing poll's data in form builder
Matthias Schmidt [Sat, 25 Jan 2020 18:54:13 +0000 (19:54 +0100)]
Fix reading existing poll's data in form builder

4 years agoFix handling and validation of PollOptionsFormField's value
Matthias Schmidt [Sat, 25 Jan 2020 18:53:43 +0000 (19:53 +0100)]
Fix handling and validation of PollOptionsFormField's value

4 years agoMerge branch 'master' into next
Tim Düsterhus [Wed, 22 Jan 2020 18:00:31 +0000 (19:00 +0100)]
Merge branch 'master' into next

4 years agoFix retryAfter for EmailDeliveryBackgroundJob
Olaf Braun [Sun, 19 Jan 2020 13:48:06 +0000 (14:48 +0100)]
Fix retryAfter for EmailDeliveryBackgroundJob

The array contained a duplicate entry `11`.

Closes #3140

4 years agoOptional select fields were not optional because of a property mismatch
Alexander Ebert [Tue, 21 Jan 2020 16:49:42 +0000 (17:49 +0100)]
Optional select fields were not optional because of a property mismatch

4 years agoExperimental adjustment of selections in the editor on triple click
Alexander Ebert [Tue, 21 Jan 2020 16:05:46 +0000 (17:05 +0100)]
Experimental adjustment of selections in the editor on triple click

4 years agoMisaligned caret in Safari 13+ using the invisible space
Alexander Ebert [Mon, 20 Jan 2020 18:36:19 +0000 (19:36 +0100)]
Misaligned caret in Safari 13+ using the invisible space

4 years agoFix revoking of user trophies
Joshua Rüsweg [Mon, 20 Jan 2020 16:37:41 +0000 (17:37 +0100)]
Fix revoking of user trophies

4 years agoSelected text hidden in an element's overflow should not trigger the quote tooltip
Alexander Ebert [Mon, 20 Jan 2020 12:36:42 +0000 (13:36 +0100)]
Selected text hidden in an element's overflow should not trigger the quote tooltip

4 years agoThe space key should not collapse drop-downs attached to `<input>`
Alexander Ebert [Sun, 19 Jan 2020 18:12:56 +0000 (19:12 +0100)]
The space key should not collapse drop-downs attached to `<input>`

4 years agoSuppress pointer events for hidden dialogs
Alexander Ebert [Sun, 19 Jan 2020 17:58:45 +0000 (18:58 +0100)]
Suppress pointer events for hidden dialogs

4 years agoIncorrect link to the version history of articles
Alexander Ebert [Thu, 16 Jan 2020 18:22:54 +0000 (19:22 +0100)]
Incorrect link to the version history of articles

4 years agoMerge branch 'master' into next
Alexander Ebert [Thu, 16 Jan 2020 17:53:19 +0000 (18:53 +0100)]
Merge branch 'master' into next

4 years agoMerge branch '3.0'
Alexander Ebert [Thu, 16 Jan 2020 17:52:58 +0000 (18:52 +0100)]
Merge branch '3.0'

4 years agoAttempting to access an element that is not always present
Alexander Ebert [Thu, 16 Jan 2020 17:52:17 +0000 (18:52 +0100)]
Attempting to access an element that is not always present

4 years agoMerge branch 'master' into next
Alexander Ebert [Thu, 16 Jan 2020 17:32:14 +0000 (18:32 +0100)]
Merge branch 'master' into next

4 years agoMerge branch '3.0'
Alexander Ebert [Thu, 16 Jan 2020 17:31:44 +0000 (18:31 +0100)]
Merge branch '3.0'

4 years ago`WCF::getAnchor()` already encodes HTML entities
Alexander Ebert [Thu, 16 Jan 2020 17:30:51 +0000 (18:30 +0100)]
`WCF::getAnchor()` already encodes HTML entities

4 years agoTrim the usernames reported by `Ui/ItemList`.
Alexander Ebert [Thu, 16 Jan 2020 17:23:58 +0000 (18:23 +0100)]
Trim the usernames reported by `Ui/ItemList`.

4 years agoAdd &display=swap to Google Font request
Jannis Grimm [Thu, 16 Jan 2020 16:47:00 +0000 (17:47 +0100)]
Add &display=swap to Google Font request

This requests Google Fonts to deliver fonts with the `font-display: swap;` CSS option, reducing time until meaningful display epecially on slow connections. Including this option is suggested by default now from Google Fonts.

4 years agoValidate the access token using a strict regex pattern
Alexander Ebert [Thu, 16 Jan 2020 16:08:06 +0000 (17:08 +0100)]
Validate the access token using a strict regex pattern

4 years agoProperly suppress links in the AttachmentBBCode when requested by the parser
Alexander Ebert [Thu, 16 Jan 2020 15:10:34 +0000 (16:10 +0100)]
Properly suppress links in the AttachmentBBCode when requested by the parser

4 years agoImproved detection of WebP files in PHP 7.0
Alexander Ebert [Wed, 15 Jan 2020 18:14:36 +0000 (19:14 +0100)]
Improved detection of WebP files in PHP 7.0

Closes #3136

4 years ago`IMAGETYPE_WEBP` is available since PHP 7.1 only
Alexander Ebert [Tue, 14 Jan 2020 16:12:07 +0000 (17:12 +0100)]
`IMAGETYPE_WEBP` is available since PHP 7.1 only

4 years agoDo not use html variables in AbstractFormField::getHtml()
Matthias Schmidt [Sun, 12 Jan 2020 16:11:14 +0000 (17:11 +0100)]
Do not use html variables in AbstractFormField::getHtml()

The additional template variables are only relevant for the actual form field which is generated by `AbstractFormField::getFieldHtml()`.

4 years agoSuppress the option for i18n articles when there is only a single language
Alexander Ebert [Sat, 11 Jan 2020 22:27:39 +0000 (23:27 +0100)]
Suppress the option for i18n articles when there is only a single language

4 years agoAdd missing bracket in German phrase
Matthias Schmidt [Sat, 11 Jan 2020 17:22:54 +0000 (18:22 +0100)]
Add missing bracket in German phrase

4 years agoAdd missing foreign keys for 3.1 updates
Matthias Schmidt [Sat, 11 Jan 2020 14:20:13 +0000 (15:20 +0100)]
Add missing foreign keys for 3.1 updates

4 years agoFix adding reactions with multilingual title fields
Joshua Rüsweg [Fri, 10 Jan 2020 19:24:30 +0000 (20:24 +0100)]
Fix adding reactions with multilingual title fields

4 years agofixed missing consideration of the box name in menu pip
Marcel Werk [Fri, 10 Jan 2020 17:00:35 +0000 (18:00 +0100)]
fixed missing consideration of the box name in menu pip

4 years agobuttons in article view were too large
Marcel Werk [Fri, 10 Jan 2020 16:28:24 +0000 (17:28 +0100)]
buttons in article view were too large

4 years agoIncorrect version comparison
Alexander Ebert [Thu, 9 Jan 2020 22:35:54 +0000 (23:35 +0100)]
Incorrect version comparison

4 years agoFix codestyle
Joshua Rüsweg [Thu, 9 Jan 2020 22:17:51 +0000 (23:17 +0100)]
Fix codestyle

4 years agoPrevent duplicates in special trophy assignment
Joshua Rüsweg [Thu, 9 Jan 2020 22:12:36 +0000 (23:12 +0100)]
Prevent duplicates in special trophy assignment
If a trophy is taken away and added again shortly afterwards, the error may occur that the trophy can be marked twice as "Special". In this case, this leads to an error. We prevent this by making the whole thing clear.

4 years agoAdd helper method to add missing foreign keys for 3.1 updates 5.2.1
Matthias Schmidt [Wed, 8 Jan 2020 19:00:26 +0000 (20:00 +0100)]
Add helper method to add missing foreign keys for 3.1 updates

4 years agoAdd missing foreign keys logs during table creation via PHP API
Matthias Schmidt [Wed, 8 Jan 2020 17:53:59 +0000 (18:53 +0100)]
Add missing foreign keys logs during table creation via PHP API

4 years agoMissing file omitted by .gitignore
Alexander Ebert [Wed, 8 Jan 2020 17:50:59 +0000 (18:50 +0100)]
Missing file omitted by .gitignore

4 years agoPreparing the release 5.2.1
Alexander Ebert [Wed, 8 Jan 2020 15:27:05 +0000 (16:27 +0100)]
Preparing the release 5.2.1

4 years agoUpdating minified JavaScript files
woltlab.com [Wed, 8 Jan 2020 14:47:45 +0000 (14:47 +0000)]
Updating minified JavaScript files

4 years agoThe owner group has always access to all groups
Alexander Ebert [Wed, 8 Jan 2020 14:04:11 +0000 (15:04 +0100)]
The owner group has always access to all groups

4 years agoReject MySQL 8 < 8.0.14 due to a serious bug
Alexander Ebert [Mon, 6 Jan 2020 17:48:40 +0000 (18:48 +0100)]
Reject MySQL 8 < 8.0.14 due to a serious bug

See #3133

4 years agoMerge branch 'next' of github.com:WoltLab/WCF into next
Alexander Ebert [Mon, 6 Jan 2020 17:24:28 +0000 (18:24 +0100)]
Merge branch 'next' of github.com:WoltLab/WCF into next

4 years agoDeploy the RoutingCacheBuilder at a later point during the upgrade
Alexander Ebert [Mon, 6 Jan 2020 17:24:09 +0000 (18:24 +0100)]
Deploy the RoutingCacheBuilder at a later point during the upgrade

Fixes #3124

4 years agoFix incorrect usage of classList
Joshua Rüsweg [Mon, 6 Jan 2020 17:07:46 +0000 (18:07 +0100)]
Fix incorrect usage of classList

4 years agoIdempotent modification of the database
Alexander Ebert [Mon, 6 Jan 2020 15:29:32 +0000 (16:29 +0100)]
Idempotent modification of the database

Fixes #3125

4 years agoMerge branch 'master' into next
Alexander Ebert [Mon, 6 Jan 2020 14:13:39 +0000 (15:13 +0100)]
Merge branch 'master' into next

4 years agoDeclare implicitly used property
Alexander Ebert [Mon, 6 Jan 2020 14:12:44 +0000 (15:12 +0100)]
Declare implicitly used property

Fixes #3121