GitHub/WoltLab/WCF.git
4 years agoAdd missing trailing commas
Tim Düsterhus [Fri, 17 Jul 2020 14:49:14 +0000 (16:49 +0200)]
Add missing trailing commas

Co-authored-by: Matthias Schmidt <gravatronics@live.com>
4 years agoSet default user-agent for Guzzle
Tim Düsterhus [Wed, 15 Jul 2020 10:06:32 +0000 (12:06 +0200)]
Set default user-agent for Guzzle

4 years agoMake HttpFactory::$defaultClient static
Tim Düsterhus [Tue, 14 Jul 2020 14:31:30 +0000 (16:31 +0200)]
Make HttpFactory::$defaultClient static

4 years agoReimplement \wcf\util\HTTPRequest using Guzzle
Tim Düsterhus [Tue, 14 Jul 2020 13:09:45 +0000 (15:09 +0200)]
Reimplement \wcf\util\HTTPRequest using Guzzle

4 years agoAdd HttpFactory
Tim Düsterhus [Tue, 14 Jul 2020 13:09:11 +0000 (15:09 +0200)]
Add HttpFactory

4 years agoAdd guzzlehttp/guzzle as requirement
Tim Düsterhus [Tue, 14 Jul 2020 10:32:05 +0000 (12:32 +0200)]
Add guzzlehttp/guzzle as requirement

4 years agoMake Travis run PHP 7.4 + 7.0
Tim Düsterhus [Tue, 14 Jul 2020 13:56:32 +0000 (15:56 +0200)]
Make Travis run PHP 7.4 + 7.0

4 years agoMerge branch '5.2'
Matthias Schmidt [Tue, 14 Jul 2020 13:33:23 +0000 (15:33 +0200)]
Merge branch '5.2'

4 years agoFix VoidFormDataProcessor for `null` values
Matthias Schmidt [Tue, 14 Jul 2020 13:31:19 +0000 (15:31 +0200)]
Fix VoidFormDataProcessor for `null` values

4 years agoRelease 5.2.8 5.2.8
Alexander Ebert [Mon, 13 Jul 2020 11:14:17 +0000 (13:14 +0200)]
Release 5.2.8

4 years agoUpdating minified JavaScript files
woltlab.com [Mon, 13 Jul 2020 11:06:11 +0000 (11:06 +0000)]
Updating minified JavaScript files

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Mon, 13 Jul 2020 10:59:40 +0000 (12:59 +0200)]
Merge branch '3.1' into 5.2

4 years agoRelease 3.1.16 3.1.16
Alexander Ebert [Mon, 13 Jul 2020 10:59:02 +0000 (12:59 +0200)]
Release 3.1.16

4 years agoMerge pull request #3437 from WoltLab/paid-subscription-permission
Alexander Ebert [Sat, 11 Jul 2020 18:39:40 +0000 (20:39 +0200)]
Merge pull request #3437 from WoltLab/paid-subscription-permission

Add user.profile.payment.canBuyPaidSubscription permission

4 years agoMerge pull request #3442 from WoltLab/tar-performance
Alexander Ebert [Sat, 11 Jul 2020 17:59:51 +0000 (19:59 +0200)]
Merge pull request #3442 from WoltLab/tar-performance

Make Tar::extractToString() much faster

4 years agoMerge pull request #3444 from WoltLab/attachment-sync-instances
Alexander Ebert [Sat, 11 Jul 2020 17:22:33 +0000 (19:22 +0200)]
Merge pull request #3444 from WoltLab/attachment-sync-instances

Synchronize attachments across instances

4 years agoSuperfluous whitespace
Alexander Ebert [Sat, 11 Jul 2020 17:22:01 +0000 (19:22 +0200)]
Superfluous whitespace

4 years agoSimplify code by not checking for the "enable thunbnails" option
Alexander Ebert [Fri, 10 Jul 2020 20:53:04 +0000 (22:53 +0200)]
Simplify code by not checking for the "enable thunbnails" option

4 years agoForce enable `ATTACHMENT_ENABLE_THUMBNAILS`
Alexander Ebert [Fri, 10 Jul 2020 20:47:40 +0000 (22:47 +0200)]
Force enable `ATTACHMENT_ENABLE_THUMBNAILS`

4 years agoRebuild interface elements on upload
Alexander Ebert [Fri, 10 Jul 2020 18:49:36 +0000 (20:49 +0200)]
Rebuild interface elements on upload

4 years agoMerge branch '5.2'
Matthias Schmidt [Fri, 10 Jul 2020 16:05:54 +0000 (18:05 +0200)]
Merge branch '5.2'

4 years agoAdd close callback to form builder dialog
Matthias Schmidt [Fri, 10 Jul 2020 16:04:47 +0000 (18:04 +0200)]
Add close callback to form builder dialog

4 years agoSynchronizes multiple attachment instances for the same tmpHash
Alexander Ebert [Fri, 10 Jul 2020 15:10:37 +0000 (17:10 +0200)]
Synchronizes multiple attachment instances for the same tmpHash

4 years agoUpdating minified JavaScript files
woltlab.com [Thu, 9 Jul 2020 19:11:02 +0000 (19:11 +0000)]
Updating minified JavaScript files

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Thu, 9 Jul 2020 19:09:02 +0000 (21:09 +0200)]
Merge branch '3.1' into 5.2

4 years agoPrevent Chromium browser form injecting base64 encoded images
Alexander Ebert [Thu, 9 Jul 2020 19:08:44 +0000 (21:08 +0200)]
Prevent Chromium browser form injecting base64 encoded images

4 years agoMerge pull request #3427 from WoltLab/dbo-empty
Tim Düsterhus [Wed, 8 Jul 2020 14:01:29 +0000 (16:01 +0200)]
Merge pull request #3427 from WoltLab/dbo-empty

Check strings against '' instead of using empty when validating in DBO actions

4 years agoFix button class for single media form field
Matthias Schmidt [Wed, 8 Jul 2020 12:24:07 +0000 (14:24 +0200)]
Fix button class for single media form field

4 years agoMerge branch '5.2'
Matthias Schmidt [Wed, 8 Jul 2020 12:08:55 +0000 (14:08 +0200)]
Merge branch '5.2'

4 years agoFix duplicate data handler registration for captcha form fields
Matthias Schmidt [Wed, 8 Jul 2020 12:08:30 +0000 (14:08 +0200)]
Fix duplicate data handler registration for captcha form fields

Close #3441

4 years agoFixed error message in Form Builder
Peter Frühwirt [Wed, 8 Jul 2020 06:39:53 +0000 (08:39 +0200)]
Fixed error message in Form Builder

4 years agoAdjust install.php for Tar changes
Tim Düsterhus [Wed, 8 Jul 2020 10:55:11 +0000 (12:55 +0200)]
Adjust install.php for Tar changes

4 years agoCheck the length of the resulting string in Tar::extractToString()
Tim Düsterhus [Wed, 8 Jul 2020 10:49:01 +0000 (12:49 +0200)]
Check the length of the resulting string in Tar::extractToString()

4 years agoMake Tar::extractToString() much faster
Tim Düsterhus [Wed, 8 Jul 2020 10:46:07 +0000 (12:46 +0200)]
Make Tar::extractToString() much faster

We are building a full in memory string instead of streaming, so let
PHP perform the heavy lifting of building the string in C instead of
doing it manually in 512 Byte chunks.

4 years agoMerge pull request #3438 from WoltLab/style-editor-relative
Tim Düsterhus [Wed, 8 Jul 2020 07:59:26 +0000 (09:59 +0200)]
Merge pull request #3438 from WoltLab/style-editor-relative

Return relative paths for logos uploaded in style editor

4 years agoWhitelist `unserialize()` when running in enterprise mode
Alexander Ebert [Tue, 7 Jul 2020 16:26:16 +0000 (18:26 +0200)]
Whitelist `unserialize()` when running in enterprise mode

4 years agoMerge branch '5.2'
Tim Düsterhus [Tue, 7 Jul 2020 13:11:31 +0000 (15:11 +0200)]
Merge branch '5.2'

4 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Tue, 7 Jul 2020 13:09:04 +0000 (15:09 +0200)]
Merge branch '3.1' into 5.2

4 years agoMerge pull request #3439 from WoltLab/cronjob-fix2
Tim Düsterhus [Tue, 7 Jul 2020 13:07:09 +0000 (15:07 +0200)]
Merge pull request #3439 from WoltLab/cronjob-fix2

Fix calculation of nextExec of cronjobs

4 years agoFix calculation of nextExec of cronjobs
Tim Düsterhus [Tue, 7 Jul 2020 12:26:20 +0000 (14:26 +0200)]
Fix calculation of nextExec of cronjobs

To properly calculate nextExec we must not specify the TIME_NOW parameter,
because if the cronjob is run on the scheduled time the nextExec() will
return the current time.

Not passing the TIME_NOW parameter adds at least 120 seconds of delay to
prevent this issue.

This bug was introduced in commit 485f8e1888824b862823de983e019afcb9bca7ce.
When moving the update of the execution time the calls were not correctly
moved and the explicit passing of TIME_NOW was added.

4 years agoMerge pull request #3415 from WoltLab/scssphp
Tim Düsterhus [Tue, 7 Jul 2020 09:04:32 +0000 (11:04 +0200)]
Merge pull request #3415 from WoltLab/scssphp

Upgrade leafo/scssphp to scssphp/scssphp

4 years agoMerge pull request #3403 from WoltLab/media_file_replacement
Matthias Schmidt [Mon, 6 Jul 2020 16:01:06 +0000 (18:01 +0200)]
Merge pull request #3403 from WoltLab/media_file_replacement

Support replacing existing media files

4 years agoRelease 5.2.8
Alexander Ebert [Mon, 6 Jul 2020 15:53:12 +0000 (17:53 +0200)]
Release 5.2.8

4 years agoMerge branch '5.2'
Tim Düsterhus [Mon, 6 Jul 2020 15:21:50 +0000 (17:21 +0200)]
Merge branch '5.2'

4 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Mon, 6 Jul 2020 15:21:01 +0000 (17:21 +0200)]
Merge branch '3.1' into 5.2

4 years agoMerge pull request #3428 from WoltLab/url-is
Tim Düsterhus [Mon, 6 Jul 2020 15:20:12 +0000 (17:20 +0200)]
Merge pull request #3428 from WoltLab/url-is

Fix Url::is()

4 years agoFix duplicate semicolon
Tim Düsterhus [Mon, 6 Jul 2020 15:10:31 +0000 (17:10 +0200)]
Fix duplicate semicolon

4 years agoReturn relative paths for logos uploaded in style editor
Tim Düsterhus [Mon, 6 Jul 2020 15:01:34 +0000 (17:01 +0200)]
Return relative paths for logos uploaded in style editor

Resolves #3283

4 years agoMerge branch '5.2'
Marcel Werk [Mon, 6 Jul 2020 12:16:46 +0000 (14:16 +0200)]
Merge branch '5.2'

4 years agoCaptcha setting was not considered
Marcel Werk [Mon, 6 Jul 2020 12:16:33 +0000 (14:16 +0200)]
Captcha setting was not considered

4 years agoUpdating minified JavaScript files
woltlab.com [Mon, 6 Jul 2020 11:25:05 +0000 (11:25 +0000)]
Updating minified JavaScript files

4 years agoAdd user.profile.payment.canBuyPaidSubscription permission
Tim Düsterhus [Mon, 6 Jul 2020 10:26:52 +0000 (12:26 +0200)]
Add user.profile.payment.canBuyPaidSubscription permission

Resolves #3253

4 years agoMerge branch '5.2'
Marcel Werk [Mon, 6 Jul 2020 09:58:26 +0000 (11:58 +0200)]
Merge branch '5.2'

4 years agoRemoved misleading description
Marcel Werk [Mon, 6 Jul 2020 09:57:40 +0000 (11:57 +0200)]
Removed misleading description

4 years agoMissing module setting check
Marcel Werk [Mon, 6 Jul 2020 09:57:14 +0000 (11:57 +0200)]
Missing module setting check

4 years agoFixed parameter validation
Marcel Werk [Mon, 6 Jul 2020 09:56:56 +0000 (11:56 +0200)]
Fixed parameter validation

4 years agoRemove version-specific information in README file
Matthias Schmidt [Sun, 5 Jul 2020 15:27:54 +0000 (17:27 +0200)]
Remove version-specific information in README file

4 years agoRemove TODO and fix code style issue
Matthias Schmidt [Sun, 5 Jul 2020 15:19:41 +0000 (17:19 +0200)]
Remove TODO and fix code style issue

4 years agoAdd third gender option (#3436)
Matthias Schmidt [Sun, 5 Jul 2020 14:45:12 +0000 (16:45 +0200)]
Add third gender option (#3436)

Close #3389

4 years agoAlways confirm email on confirmEmail action
joshuaruesweg [Sun, 5 Jul 2020 08:42:10 +0000 (10:42 +0200)]
Always confirm email on confirmEmail action

4 years agoFix checking user status in RegisterNewActivationCodeForm
joshuaruesweg [Sun, 5 Jul 2020 08:26:31 +0000 (10:26 +0200)]
Fix checking user status in RegisterNewActivationCodeForm

4 years agoadapted tagInput template for multilingualism
Marcel Werk [Sat, 4 Jul 2020 16:27:04 +0000 (18:27 +0200)]
adapted tagInput template for multilingualism

4 years agoMerge pull request #3435 from xopez/patch-1
Alexander Ebert [Fri, 3 Jul 2020 23:03:22 +0000 (01:03 +0200)]
Merge pull request #3435 from xopez/patch-1

Remove unused Packageservers for 5.2

4 years agoUpdate install.sql
xopez [Fri, 3 Jul 2020 18:00:39 +0000 (20:00 +0200)]
Update install.sql

4 years agoMerge branch '5.2'
Tim Düsterhus [Fri, 3 Jul 2020 15:16:17 +0000 (17:16 +0200)]
Merge branch '5.2'

4 years agoMerge pull request #3434 from WoltLab/fix-shadow-groups
Tim Düsterhus [Fri, 3 Jul 2020 15:15:49 +0000 (17:15 +0200)]
Merge pull request #3434 from WoltLab/fix-shadow-groups

Properly support multiple instances of WoltLabSuite/Core/Ui/ItemList/User

4 years agoProperly support multiple instances of WoltLabSuite/Core/Ui/ItemList/User
Tim Düsterhus [Fri, 3 Jul 2020 14:46:26 +0000 (16:46 +0200)]
Properly support multiple instances of WoltLabSuite/Core/Ui/ItemList/User

WoltLabSuite/Core/Ui/ItemList/User is a singleton and thus only has a single
instance of each object member. This lead to the `_shadowGroups` value being
fixed to the first input used.

Move the `_shadowGroups` into the existing `data` object (where the regular
`shadow` resides) to fix this issue.

Introduced in 8faf6ea10ac894b87b3e357f5248f67b4fd7b716.
Fixes #3433.

4 years agoMerge pull request #3343 from WoltLab/parallel-worker
Tim Düsterhus [Fri, 3 Jul 2020 14:12:00 +0000 (16:12 +0200)]
Merge pull request #3343 from WoltLab/parallel-worker

Allow executing CLI worker in parallel

4 years agoMerge branch 'master' into parallel-worker
Tim Düsterhus [Fri, 3 Jul 2020 14:07:10 +0000 (16:07 +0200)]
Merge branch 'master' into parallel-worker

4 years agoMerge remote-tracking branch 'origin/master'
Tim Düsterhus [Fri, 3 Jul 2020 13:57:03 +0000 (15:57 +0200)]
Merge remote-tracking branch 'origin/master'

4 years agoMerge branch '5.2'
Tim Düsterhus [Fri, 3 Jul 2020 13:55:51 +0000 (15:55 +0200)]
Merge branch '5.2'

4 years agoMerge branch '3.1' into 5.2
Tim Düsterhus [Fri, 3 Jul 2020 13:55:33 +0000 (15:55 +0200)]
Merge branch '3.1' into 5.2

4 years agoMerge pull request #3432 from WoltLab/linked-blocked-img
Tim Düsterhus [Fri, 3 Jul 2020 13:53:39 +0000 (15:53 +0200)]
Merge pull request #3432 from WoltLab/linked-blocked-img

Fix markup for linked, blocked images in UGC

4 years agoFix markup for linked, blocked images in UGC
Tim Düsterhus [Fri, 3 Jul 2020 13:10:38 +0000 (15:10 +0200)]
Fix markup for linked, blocked images in UGC

Fixes #3384

4 years agoRemove --packageID from help in cli.php
Tim Düsterhus [Fri, 3 Jul 2020 09:35:23 +0000 (11:35 +0200)]
Remove --packageID from help in cli.php

see 476915c53fada2827fd381c974973371cc05c832
see #3425

4 years agoMerge pull request #3431 from WoltLab/comment-smileypicker
Tim Düsterhus [Fri, 3 Jul 2020 09:30:21 +0000 (11:30 +0200)]
Merge pull request #3431 from WoltLab/comment-smileypicker

Add smiley picker to comment WYSIWYG

4 years agoRemove --packageID option on cli.php
Tim Düsterhus [Fri, 3 Jul 2020 09:20:12 +0000 (11:20 +0200)]
Remove --packageID option on cli.php

Resolves #3425

4 years agoAdd smiley picker to comment WYSIWYG
Tim Düsterhus [Fri, 3 Jul 2020 09:04:53 +0000 (11:04 +0200)]
Add smiley picker to comment WYSIWYG

Resolves #3252

4 years agoMerge pull request #3426 from WoltLab/sql-graceful-drop
Tim Düsterhus [Fri, 3 Jul 2020 07:23:28 +0000 (09:23 +0200)]
Merge pull request #3426 from WoltLab/sql-graceful-drop

Ignore errors if a to-be-dropped key / column does not exist in DatabaseEditor

4 years agoMerge pull request #3417 from WoltLab/email-signature-html
Tim Düsterhus [Fri, 3 Jul 2020 07:23:17 +0000 (09:23 +0200)]
Merge pull request #3417 from WoltLab/email-signature-html

Add option for HTML based email signature

4 years agoMerge pull request #3412 from WoltLab/list-unsubscribe
Tim Düsterhus [Fri, 3 Jul 2020 07:22:55 +0000 (09:22 +0200)]
Merge pull request #3412 from WoltLab/list-unsubscribe

Add List-Unsubscribe header

4 years agoFix validating style when editing users in ACP
Matthias Schmidt [Thu, 2 Jul 2020 17:03:19 +0000 (19:03 +0200)]
Fix validating style when editing users in ACP

See #3254

4 years agoMerge branch '5.2'
Matthias Schmidt [Thu, 2 Jul 2020 16:46:40 +0000 (18:46 +0200)]
Merge branch '5.2'

4 years agoAdd missing closing quotation mark in English language item
Matthias Schmidt [Thu, 2 Jul 2020 16:46:13 +0000 (18:46 +0200)]
Add missing closing quotation mark in English language item

4 years agoFix Url::is()
Tim Düsterhus [Thu, 2 Jul 2020 14:40:16 +0000 (16:40 +0200)]
Fix Url::is()

`parse_url()` cannot be used to validate an URL, because it will accept
roughly everything. In fact this is documented in the parse_url() docs:

> This function is not meant to validate the given URL, it only breaks
> it up into the above listed parts. Partial URLs are also accepted,
> parse_url() tries its best to parse them correctly.

Fixes #3391

4 years agoCheck strings against '' instead of using empty when validating in DBO actions
Tim Düsterhus [Thu, 2 Jul 2020 14:32:12 +0000 (16:32 +0200)]
Check strings against '' instead of using empty when validating in DBO actions

`empty('0')` will return true, despite the string not actually being empty
which is undesired.

Fixes WoltLab/com.woltlab.wbb#387

4 years agoIgnore errors if a to-be-dropped key / column does not exist in DatabaseEditor
Tim Düsterhus [Thu, 2 Jul 2020 13:40:19 +0000 (15:40 +0200)]
Ignore errors if a to-be-dropped key / column does not exist in DatabaseEditor

Resolves #3166

4 years agoCorrectly handle non-numeric exception codes in core.functions.php
Tim Düsterhus [Thu, 2 Jul 2020 13:32:19 +0000 (15:32 +0200)]
Correctly handle non-numeric exception codes in core.functions.php

Database exceptions use the SQLSTATE as the error code. SQLSTATEs can
contains letters.

4 years agoFix indentation of signature in email_html.tpl
Tim Düsterhus [Thu, 2 Jul 2020 12:07:08 +0000 (14:07 +0200)]
Fix indentation of signature in email_html.tpl

Co-authored-by: Alexander Ebert <ebert@woltlab.com>
4 years agoMerge pull request #3421 from WoltLab/void-pip
Tim Düsterhus [Thu, 2 Jul 2020 11:57:42 +0000 (13:57 +0200)]
Merge pull request #3421 from WoltLab/void-pip

Add <void/> instruction

4 years agoMerge branch '5.2'
Tim Düsterhus [Thu, 2 Jul 2020 11:43:15 +0000 (13:43 +0200)]
Merge branch '5.2'

4 years agoResolve review requests for List-Unsubscribe
Tim Düsterhus [Thu, 2 Jul 2020 11:42:07 +0000 (13:42 +0200)]
Resolve review requests for List-Unsubscribe

Co-authored-by: Alexander Ebert <ebert@woltlab.com>
4 years agoMerge pull request #3413 from WoltLab/existingMapping
Alexander Ebert [Thu, 2 Jul 2020 11:20:39 +0000 (13:20 +0200)]
Merge pull request #3413 from WoltLab/existingMapping

Improve wording regarding existing import mapping

4 years agoPrefix WORKER_STATUS_FD with WCF_
Tim Düsterhus [Thu, 2 Jul 2020 10:48:58 +0000 (12:48 +0200)]
Prefix WORKER_STATUS_FD with WCF_

4 years agoPass the sessionID using the environment instead of argv
Tim Düsterhus [Thu, 2 Jul 2020 10:48:10 +0000 (12:48 +0200)]
Pass the sessionID using the environment instead of argv

4 years agoAdd missing language items for parallel workers
Tim Düsterhus [Thu, 2 Jul 2020 10:36:43 +0000 (12:36 +0200)]
Add missing language items for parallel workers

4 years agoPrevent windows users from using --threads=
Tim Düsterhus [Wed, 1 Jul 2020 10:37:57 +0000 (12:37 +0200)]
Prevent windows users from using --threads=

4 years agoAdd multithreading support to WorkerCLICommand
Tim Düsterhus [Wed, 1 Jul 2020 10:35:52 +0000 (12:35 +0200)]
Add multithreading support to WorkerCLICommand

4 years agoAdd WORKER_STATUS_FD to WorkerCLICommand
Tim Düsterhus [Wed, 1 Jul 2020 09:48:58 +0000 (11:48 +0200)]
Add WORKER_STATUS_FD to WorkerCLICommand

4 years agoAllow logging into cli.php by giving an existing sessionID
Tim Düsterhus [Wed, 1 Jul 2020 09:40:18 +0000 (11:40 +0200)]
Allow logging into cli.php by giving an existing sessionID