Tim Düsterhus [Tue, 15 Sep 2020 10:52:49 +0000 (12:52 +0200)]
Add HtmlOutputNodePre::guessHighlighter()
This nicely contains the guessing logic within a single function, improving
readability.
Tim Düsterhus [Tue, 15 Sep 2020 09:56:55 +0000 (11:56 +0200)]
Merge branch '5.2' into master
Tim Düsterhus [Tue, 15 Sep 2020 09:56:33 +0000 (11:56 +0200)]
Fix typo in setup_de.xml
Tim Düsterhus [Tue, 15 Sep 2020 09:51:22 +0000 (11:51 +0200)]
Remove isContentAuthor from UserProfileCommentManager
Defining the owner of the user profile as being the “author” of the profile is
a bit wonky and can cause confusion due to the object author badge.
see https://community.woltlab.com/thread/285649-5-3-autor-label-an-der-eigenen-pinnwand/
Tim Düsterhus [Mon, 14 Sep 2020 18:36:48 +0000 (20:36 +0200)]
Fix typo in error message in MultipleSelectionFormField
Marcel Werk [Mon, 14 Sep 2020 12:31:34 +0000 (14:31 +0200)]
Expired session during 3rd party auth led to a SystemException
Marcel Werk [Mon, 14 Sep 2020 11:51:37 +0000 (13:51 +0200)]
Expired session during google auth led to a SystemException
Tim Düsterhus [Fri, 11 Sep 2020 13:14:21 +0000 (15:14 +0200)]
Fix typo in en.xml
Alexander Ebert [Fri, 11 Sep 2020 11:42:16 +0000 (13:42 +0200)]
Removed the AJAX check of the password
Fixes #3497
Marcel Werk [Thu, 10 Sep 2020 13:32:06 +0000 (15:32 +0200)]
Removed mentions of Internet Explorer in description texts
Marcel Werk [Wed, 9 Sep 2020 15:55:29 +0000 (17:55 +0200)]
Made formNotice and formSuccess templates available in the frontend
Tim Düsterhus [Wed, 9 Sep 2020 14:27:53 +0000 (16:27 +0200)]
Do not error out if assets are missing in StyleEditForm
Resolves #3560
Tim Düsterhus [Wed, 9 Sep 2020 08:05:05 +0000 (10:05 +0200)]
Merge remote-tracking branch 'origin/master' into master
Tim Düsterhus [Wed, 9 Sep 2020 08:04:46 +0000 (10:04 +0200)]
Merge branch '5.2' into master
Sascha Greuel [Wed, 9 Sep 2020 08:03:04 +0000 (10:03 +0200)]
Fix PHP 8 compatibility in GDImageAdapter (#3558)
Fixed image resource validation
Resolves #3492
Sascha Greuel [Wed, 9 Sep 2020 08:01:20 +0000 (10:01 +0200)]
Fix PHP 8 compatibility in HTTPRequest (#3557)
Fixed PHP8 related error message (Argument #1 ($arg) must be passed by reference, value given)
Closes #3554
Marcel Werk [Tue, 8 Sep 2020 16:20:00 +0000 (18:20 +0200)]
Added an entry for facebook videos in the privacy policy
Alexander Ebert [Tue, 8 Sep 2020 15:23:41 +0000 (17:23 +0200)]
Prevent the setup callback for page actions to be executed twice
Marcel Werk [Tue, 8 Sep 2020 09:53:51 +0000 (11:53 +0200)]
Merge branch '5.2'
Marcel Werk [Tue, 8 Sep 2020 09:53:37 +0000 (11:53 +0200)]
Fixed icon alignment in the "login with google" button
Tim Düsterhus [Tue, 8 Sep 2020 08:55:08 +0000 (10:55 +0200)]
Merge branch '5.2' into master
Tim Düsterhus [Tue, 8 Sep 2020 08:54:51 +0000 (10:54 +0200)]
Merge branch '3.1' into 5.2
Tim Düsterhus [Tue, 8 Sep 2020 07:43:31 +0000 (09:43 +0200)]
Prevent Android from collapsing the keyboard on [Enter]
Somehow the linkify redactor plugin causes Android to collapse the on-screen
keyboard if a new line is entered.
This plugin was already removed for 5.2 in commit
19af26fc22bc31d699db6021dee2eda1d23b8a14,
so let's effectively disable it for 3.1 as well.
see https://community.woltlab.com/thread/285573-wsc-3-1-17-smartphone-tastatur-schlie%C3%9Ft-sich-unbeabsichtigt/?postID=
1816848#post1816848
Tim Düsterhus [Tue, 8 Sep 2020 08:11:16 +0000 (10:11 +0200)]
Use proper apostrophe in en.xml
Marcel Werk [Mon, 7 Sep 2020 21:27:36 +0000 (23:27 +0200)]
Added missing use of jslang tag
Marcel Werk [Mon, 7 Sep 2020 20:07:56 +0000 (22:07 +0200)]
Missing space in moderation dropdown before username
Closes #3552
Marcel Werk [Mon, 7 Sep 2020 13:26:13 +0000 (15:26 +0200)]
Merge branch 'master' of https://github.com/WoltLab/WCF
Marcel Werk [Mon, 7 Sep 2020 13:26:11 +0000 (15:26 +0200)]
Removed obsolete entries in default privacy policy
Media providers Imgur and Veoh have been removed and Google web fonts are no longer used.
woltlab.com [Mon, 7 Sep 2020 10:57:50 +0000 (10:57 +0000)]
Updating minified JavaScript files
Alexander Ebert [Mon, 7 Sep 2020 10:55:58 +0000 (12:55 +0200)]
Adjusted the call to the compiler
Thanks VS.Code for changing the formatting!
Alexander Ebert [Mon, 7 Sep 2020 10:32:53 +0000 (12:32 +0200)]
Release 5.3.0 Alpha 1
woltlab.com [Mon, 7 Sep 2020 10:24:31 +0000 (10:24 +0000)]
Updating minified JavaScript files
Matthias Schmidt [Sun, 6 Sep 2020 13:41:05 +0000 (15:41 +0200)]
Remove unused code
Matthias Schmidt [Sun, 6 Sep 2020 12:53:46 +0000 (14:53 +0200)]
Fix encoding of username in plain `user` output
Matthias Schmidt [Sun, 6 Sep 2020 12:48:10 +0000 (14:48 +0200)]
Disallow `href` attribute for `user` template plugin
Alexander Ebert [Sat, 5 Sep 2020 23:15:24 +0000 (01:15 +0200)]
Merge pull request #3551 from mutec/useronlinelistfix
fixed undefined variable in UserOnlineList::isVisibleUser()
mutec [Sat, 5 Sep 2020 21:44:50 +0000 (23:44 +0200)]
fixed undefined variable in UserOnlineList::isVisibleUser()
Matthias Schmidt [Sat, 5 Sep 2020 11:58:51 +0000 (13:58 +0200)]
Fix condition in `AnchorFunctionTemplatePlugin`
Matthias Schmidt [Thu, 3 Sep 2020 14:47:10 +0000 (16:47 +0200)]
Merge branch '5.2'
Matthias Schmidt [Thu, 3 Sep 2020 14:46:14 +0000 (16:46 +0200)]
Fix changing monolingual to multilingual package data via devtools
Close #3550
Matthias Schmidt [Thu, 3 Sep 2020 14:41:30 +0000 (16:41 +0200)]
Fix typo in German language item
Marcel Werk [Thu, 3 Sep 2020 12:48:03 +0000 (14:48 +0200)]
Merge pull request #3549 from ilouHD/patch-3
Update de.xml
ilou [Thu, 3 Sep 2020 11:44:36 +0000 (13:44 +0200)]
Update de.xml
Fixed sentence structure in contact html mail to match the sentence structure in plaintext mails
Alexander Ebert [Wed, 2 Sep 2020 13:50:05 +0000 (15:50 +0200)]
Merge branch '5.2'
Alexander Ebert [Wed, 2 Sep 2020 13:49:40 +0000 (15:49 +0200)]
Merge branch '3.1' into 5.2
Alexander Ebert [Wed, 2 Sep 2020 13:47:34 +0000 (15:47 +0200)]
Incorrect calculation of the last 2 digits of the year
Fixes #3547
Alexander Ebert [Wed, 2 Sep 2020 13:41:39 +0000 (15:41 +0200)]
Merge pull request #3545 from WoltLab/styleLogo-download
Add DownloadStyleLogoJob
Tim Düsterhus [Wed, 2 Sep 2020 09:53:19 +0000 (11:53 +0200)]
Merge branch '5.2' into master
Marcel Werk [Wed, 2 Sep 2020 09:51:05 +0000 (11:51 +0200)]
Merge pull request #3548 from WoltLab/acp-headContent
Add `$headContent` placeholder variable to header.tpl in ACP
Tim Düsterhus [Wed, 2 Sep 2020 09:46:56 +0000 (11:46 +0200)]
Add `$headContent` placeholder variable to header.tpl in ACP
This allows the developer to easily add page specific `<style>` tags in
the appropriate location.
Alexander Ebert [Tue, 1 Sep 2020 15:27:44 +0000 (17:27 +0200)]
Merge pull request #3546 from WoltLab/styleUpdate-idempotent
Support running the style update script multiple times
Tim Düsterhus [Tue, 1 Sep 2020 15:20:18 +0000 (17:20 +0200)]
Support running the style update script multiple times
Tim Düsterhus [Tue, 1 Sep 2020 14:46:17 +0000 (16:46 +0200)]
Queue DownloadStyleLogoJob during style upgrade
Tim Düsterhus [Tue, 1 Sep 2020 14:45:40 +0000 (16:45 +0200)]
Add DownloadStyleLogoJob
Alexander Ebert [Tue, 1 Sep 2020 14:45:06 +0000 (16:45 +0200)]
Merge branch 'master' of github.com:WoltLab/WCF
Alexander Ebert [Tue, 1 Sep 2020 14:44:53 +0000 (16:44 +0200)]
Report any duplicate usernames before applying the upgrade
Fixes #3544
Marcel Werk [Tue, 1 Sep 2020 14:43:56 +0000 (16:43 +0200)]
Unnecessary description removed
woltlab.com [Tue, 1 Sep 2020 14:24:30 +0000 (14:24 +0000)]
Updating minified JavaScript files
Alexander Ebert [Sat, 29 Aug 2020 23:20:00 +0000 (01:20 +0200)]
Merge pull request #3539 from mutec/53upgrade
WIP: Prepare upgrade instructions for 5.2 to 5.3
Alexander Ebert [Sat, 29 Aug 2020 21:37:42 +0000 (23:37 +0200)]
Resolved some issues during the upgrade, first successful upgrade
Alexander Ebert [Sat, 29 Aug 2020 16:54:53 +0000 (18:54 +0200)]
Deploy some files ahead of the upgrade
Alexander Ebert [Sat, 29 Aug 2020 16:49:48 +0000 (18:49 +0200)]
Set up the proper default package servers
Alexander Ebert [Sat, 29 Aug 2020 16:49:33 +0000 (18:49 +0200)]
Merge branch 'master' into pr/3539
Marcel Werk [Sat, 29 Aug 2020 14:43:07 +0000 (16:43 +0200)]
Added hover indicator in notification settings form
Alexander Ebert [Sat, 29 Aug 2020 13:50:27 +0000 (15:50 +0200)]
Merge branch '5.2'
Alexander Ebert [Sat, 29 Aug 2020 12:05:58 +0000 (14:05 +0200)]
Preserve the leading and trailing whitespace in `<kbd>` on output
Fixes #3536
Alexander Ebert [Fri, 28 Aug 2020 18:16:36 +0000 (20:16 +0200)]
Merge pull request #3495 from Krymonota/update-version-dev-config-file-name-5.3
Update version number in Devtools config file name to 5.3
mutec [Fri, 28 Aug 2020 14:01:25 +0000 (16:01 +0200)]
prepare upgrade instructions for 5.2 to 5.3
We need to provide `/lib/core.functions.php` and `/lib/system/api/*` before executing the complete file-PIP; otherwise we're getting issues with Guzzle being not found and causing an abortion.
Put the style and email-confirmation scripts into standalone-instructions since they might cause long execution times. In my test-environment I updated without that parameter.
Tim Düsterhus [Fri, 28 Aug 2020 14:11:01 +0000 (16:11 +0200)]
Merge pull request #3538 from mutec/53upgradeStyle
fix updating the styles to 5.3
mutec [Fri, 28 Aug 2020 13:46:54 +0000 (15:46 +0200)]
fix updating the styles to 5.3
If `Style::$imagePath` is empty, it resulted in copying the shole WSC-folder into a style-asset-folder - and doing this until we reache the timeout limits.
Including `global.php` ended up in trying to define the option-constants (especially the fixed-value-options like `MODULE_ATTACHMENTS`) again while they are already defined - which causes a Fatal Error-Message.
Alexander Ebert [Fri, 28 Aug 2020 13:27:09 +0000 (15:27 +0200)]
Release 5.2.9
Alexander Ebert [Fri, 28 Aug 2020 13:15:59 +0000 (15:15 +0200)]
Merge branch '3.1' into 5.2
Alexander Ebert [Fri, 28 Aug 2020 11:09:35 +0000 (13:09 +0200)]
Release 3.1.17
Alexander Ebert [Thu, 27 Aug 2020 17:56:38 +0000 (19:56 +0200)]
Merge pull request #3524 from WoltLab/package-server-refactor
Clean up package update server management
Tim Düsterhus [Thu, 27 Aug 2020 10:24:30 +0000 (12:24 +0200)]
Merge branch '5.2' into master
Tim Düsterhus [Thu, 27 Aug 2020 10:21:00 +0000 (12:21 +0200)]
Revert "Fix deprecation warnings in form builder in PHP 8"
This reverts commit
5ae5d6c5621c8fe1f30d6a2c787024b9bcadee87.
As commented on the original commit this change is not compatible with PHP
7.0 which is the lowest PHP version we support as of right now. Revert
this commit for now to not break compatibility with existing installations
of 5.2 until a proper solution for 5.3 and later is developed.
See #3489.
Alexander Ebert [Wed, 26 Aug 2020 17:05:45 +0000 (19:05 +0200)]
`http_build_query()` is now allowed for calls from within a template
joshuaruesweg [Wed, 26 Aug 2020 16:51:12 +0000 (18:51 +0200)]
Fix notifications with are triggered by merged users
Objects of merged users are rewritten to the new user. This is currently done but not by the notification authors. There the author is simply deleted from the notification. This works for most notifications, but not for reactions, because they always expect a concrete author (a guest cannot assign reactions). If users are deleted, it works as intended, since the corresponding reaction object is then also deleted.
Alexander Ebert [Wed, 26 Aug 2020 15:57:54 +0000 (17:57 +0200)]
Release 5.2.9
Marcel Werk [Wed, 26 Aug 2020 15:04:00 +0000 (17:04 +0200)]
Merge pull request #3531 from WoltLab/jslang-template-plugin
Template plugin for the assignment of language variables in javascrip…
Marcel Werk [Wed, 26 Aug 2020 15:03:46 +0000 (17:03 +0200)]
Added missing use of jslang
Marcel Werk [Wed, 26 Aug 2020 14:59:31 +0000 (16:59 +0200)]
Added missing use of jslang
Alexander Ebert [Wed, 26 Aug 2020 13:39:33 +0000 (15:39 +0200)]
Merge branch '5.2'
woltlab.com [Wed, 26 Aug 2020 13:37:07 +0000 (13:37 +0000)]
Updating minified JavaScript files
Alexander Ebert [Wed, 26 Aug 2020 13:34:52 +0000 (15:34 +0200)]
Merge branch '3.1' into 5.2
woltlab.com [Wed, 26 Aug 2020 13:29:47 +0000 (13:29 +0000)]
Updating minified JavaScript files
Marcel Werk [Mon, 24 Aug 2020 13:26:00 +0000 (15:26 +0200)]
Unified usage of the elseif tag in template scripting
Tim Düsterhus [Mon, 24 Aug 2020 09:54:19 +0000 (11:54 +0200)]
Fix selection of related articles for old MySQL versions
MySQL < 5.7 and apparently MariaDB up to at least 10.3 is unable to deduce
that there can only be exactly a single row from the `article` table, because
it is functionally dependent on `tag_to_object.objectID`.
Help them out by using `MAX` which effectively does nothing, because we're
taking the `MAX` of a single item.
Fixes #3528.
Tim Düsterhus [Mon, 24 Aug 2020 08:46:36 +0000 (10:46 +0200)]
Fix Guzzle following redirects with a custom temporary sink
When following redirects Guzzle copies over the request options for the next
iteration internally, including the bare `resource` that was passed to it.
This bare resource will then be wrapped into the Stream wrapper. This stream
wrapper explicitely calls `close()` for the underlying resource when it is
being closed.
The created Streams for the subrequests will be closed before the `send`
function returns, thus ultimately closing the resource for the “parent”
request.
Fix this issue by passing a Stream, instead of a bare resource. This one
will be passed along as-is.
Fixes #3529.
Marcel Werk [Sun, 23 Aug 2020 23:01:43 +0000 (01:01 +0200)]
Template plugin for the assignment of language variables in javascript code
Closes #3530
Alexander Ebert [Sat, 22 Aug 2020 21:05:23 +0000 (23:05 +0200)]
Improved the performance of reading tags without a specific language id
joshuaruesweg [Sat, 22 Aug 2020 14:31:49 +0000 (16:31 +0200)]
Merge branch '5.2'
joshuaruesweg [Sat, 22 Aug 2020 14:29:45 +0000 (16:29 +0200)]
Merge branch '3.1'
joshuaruesweg [Sat, 22 Aug 2020 14:26:44 +0000 (16:26 +0200)]
Remove fullscreen mode in template diff
The fullscreen mode does not have any advantage at this point because the diff is also displayed with a height of 700px (just like without fullscreen mode).
Alexander Ebert [Sat, 22 Aug 2020 13:37:01 +0000 (15:37 +0200)]
Merge branch '5.2'
Alexander Ebert [Sat, 22 Aug 2020 13:36:25 +0000 (15:36 +0200)]
Merge branch '3.1' into 5.2
Alexander Ebert [Sat, 22 Aug 2020 13:35:42 +0000 (15:35 +0200)]
Improved visuals of the fullscreen template comparison
Fixes #3473
joshuaruesweg [Sat, 22 Aug 2020 12:22:50 +0000 (14:22 +0200)]
Merge branch '3.1' into 5.2
joshuaruesweg [Sat, 22 Aug 2020 12:22:21 +0000 (14:22 +0200)]
Fix trophy icon size in badges on groupedUserTrophyList
Alexander Ebert [Sat, 22 Aug 2020 11:11:32 +0000 (13:11 +0200)]
Merge branch '5.2'