Malcolm Priestley [Thu, 27 Feb 2014 23:06:15 +0000 (23:06 +0000)]
staging: vt6656: s_nsBulkOutIoCompleteWrite Remove variable status.
Remove status and move debug messages to switch statement.
Remove duplicate second debug message.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 27 Feb 2014 23:06:14 +0000 (23:06 +0000)]
staging: vt6656: s_nsBulkOutIoCompleteWrite remove buf_len.
Use context->uBufLen directly which is unsigned int.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 27 Feb 2014 23:06:13 +0000 (23:06 +0000)]
staging: vt6656: Remove unused variables packets*
These variables are unused and don't reach user.
Remove them all.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 27 Feb 2014 23:06:12 +0000 (23:06 +0000)]
staging: vt6656: Remove unused variable bEventAvailable.
Flips from true to false but does nothing.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 27 Feb 2014 23:06:11 +0000 (23:06 +0000)]
staging: vt6656: struct vnt_usb_send_context remove sEthHeader.
In nsDMA_tx_packet and bRelayPacketSend s_vSaveTxPktInfo points
to sEthHeader.h_dest which is the wrong viable.
Correct and point to pDevice->sTxEthHeader.
This is only relevant in the non fuctioning hostapd access point
mode, shortly to be removed from driver.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 27 Feb 2014 23:06:10 +0000 (23:06 +0000)]
staging: vt6656: Remove all variables ulInt*
None of these variables reach user or used by debug messages.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 27 Feb 2014 23:06:09 +0000 (23:06 +0000)]
staging: vt6656: Remove all variables ulBulk*
None of these variables reach user or in any debug messages.
Remove them all.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Thu, 27 Feb 2014 22:42:23 +0000 (04:12 +0530)]
Staging: bcm: Replace bcm functions with equivalents
This patch removes unnecessary bcm functions and replaces them with
their equivalents defined in usb/ch9.h.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Thu, 27 Feb 2014 19:14:39 +0000 (00:44 +0530)]
Staging: slicoss: Fix unnecessary whitespace before a quoted newline in slicoss.c
This patch fixes the following checkpatch.pl issues in slicoss.c
WARNING: unnecessary whitespace before a quoted newline in slicoss.c
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Thu, 27 Feb 2014 19:13:20 +0000 (00:43 +0530)]
Staging: slicoss: Fix quoted string split across lines
This patch fixes the following checkpatch.pl issues in slicoss.c
WARNING: quoted string split across lines
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Thu, 27 Feb 2014 20:39:23 +0000 (02:09 +0530)]
Staging : rts5208: Fix code indent issue
This patch removes the checkpatch warning : suspect code indent for
conditional statements, by converting spaces to tabs.
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Thu, 27 Feb 2014 15:38:30 +0000 (21:08 +0530)]
Staging: line6: Fix no space before tabs in usbdefs.h
This patch fixes the following checkpatch.pl issues in usbdefs.h:
WARNING: no space before tabs
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Thu, 27 Feb 2014 15:36:58 +0000 (21:06 +0530)]
Staging: line6: Fix unnecessary space after function pointer in driver.h
This patch fixes the following checkpatch.pl issues in driver.h:
WARNING: unnecessary space after function pointer in driver.h
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Thu, 27 Feb 2014 15:35:18 +0000 (21:05 +0530)]
Staging: line6: Fix unnecessary space after function pointer in driver.c
This patch fixes the following checkpatch.pl issues in driver.c:
WARNING: unnecessary space after function pointer in driver.c
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Thu, 27 Feb 2014 18:22:48 +0000 (23:52 +0530)]
Staging: slicoss: Fix line over 80 characters in slic.h
This patch fixes the following checkpatch.pl issues in slic.h:
WARNING: line over 80 characters
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Thu, 27 Feb 2014 11:36:31 +0000 (20:36 +0900)]
staging: usbip: Fix format string mismatch in usbip_vhci_attach_device2
Argument type of sockfd is set as int, but format string
is set as unsigned int. Fix the mismatch.
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Thu, 27 Feb 2014 11:13:43 +0000 (20:13 +0900)]
staging: rtl8188eu: Fix typo in rtl8188eu/core
Fix spelling typo in comments and printk within
rtl8188eu/core
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Thu, 27 Feb 2014 10:26:52 +0000 (12:26 +0200)]
Staging: usbip: Fix the warning of unchecked sscanf return value.
The return value of sscanf in stub_dev.c is not checked. This patch
adds the checking of the return value.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Estevam [Wed, 26 Feb 2014 23:53:44 +0000 (20:53 -0300)]
imx-drm: imx-drm-core: Staticize imx_drm_find_crtc()
Fix the following static checker warning:
drivers/staging/imx-drm/imx-drm-core.c:89:21: warning: symbol 'imx_drm_find_crtc' was not declared. Should it be static?
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Estevam [Wed, 26 Feb 2014 23:53:43 +0000 (20:53 -0300)]
imx-drm: ipuv3-plane: Use %pad to print 'dma_addr_t'
Fix the following static checker warning:
drivers/staging/imx-drm/ipuv3-plane.c:75:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat]
Use %pad to print 'dma_addr_t'.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Estevam [Wed, 26 Feb 2014 23:53:42 +0000 (20:53 -0300)]
imx-drm: parallel-display: Check 'mode' pointer first
Fix the following static checker warnings:
drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes() error: potential null dereference 'mode'. (drm_mode_create returns null)
drivers/staging/imx-drm/parallel-display.c:73 imx_pd_connector_get_modes() error: potential null dereference 'mode'. (drm_mode_create returns null)
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fabio Estevam [Wed, 26 Feb 2014 23:53:40 +0000 (20:53 -0300)]
imx-drm: imx-ldb: Check 'mode' pointer first
Fix the following static checker warning:
drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error: potential null dereference 'mode'. (drm_mode_create returns null)
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Vinayak Menon [Wed, 26 Feb 2014 19:06:22 +0000 (00:36 +0530)]
staging: android: lowmemorykiller: neglect swap cached pages in other_file
With ZRAM enabled it is observed that lowmemory killer
doesn't trigger properly. swap cached pages are
accounted in NR_FILE, and lowmemorykiller considers
this as reclaimable and adds to other_file. But these
pages can't be reclaimed unless lowmemorykiller triggers.
So subtract swap pages from other_file.
Signed-off-by: Vinayak Menon <vinayakm.list@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Wed, 26 Feb 2014 14:32:23 +0000 (15:32 +0100)]
staging: rtl8187se: Convert _link_detect_t typedef into a struct.
The Documentation/CodingStyle doesn't recommend the use of typedef, convert
this to structure.
While at it, I have also renamed the variable names that were used in
this typedef not to use Hungarian notation.
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Wed, 26 Feb 2014 14:30:23 +0000 (15:30 +0100)]
staging: rtl8187se: Convert Stats typedef into a struct
The Documentation/CodingStyle doesn't recommend the use of typedef, convert
this to structure.
While at it, I have also renamed the variable names that were used in
this typedef not to use Hungarian notation.
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Wed, 26 Feb 2014 14:29:03 +0000 (15:29 +0100)]
staging: rtl8187se: Convert ChnlAccessSetting typedef into a struct.
The Documentation/CodingStyle doesn't recommend the use of typedef, convert
this to structure.
While at it, I have also renamed the variable names that were used in
this typedef not to use Hungarian notation.
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Wed, 26 Feb 2014 14:27:41 +0000 (15:27 +0100)]
staging: rtl8187se: Added parenthesis in a macro in r8180.h
This patch adds parentheses to enclose a complex value in a macro as a the
CodingStyle recommends.
This errors was found by checkpatch.pl script
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Wed, 26 Feb 2014 14:26:25 +0000 (15:26 +0100)]
staging: rtl8187se: Fixed a pointer declaration error in r8180.h
This patch fixes a pointer declaration error found by checkpatch.pl in
r8180.h
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Wed, 26 Feb 2014 14:24:13 +0000 (15:24 +0100)]
staging: rtl8187se: Fixed open brace in r8180.h
The open brace following struct have to go on the same line as a codingStyle of
the kernel recommends
This patch fixed errors with a open brace found by checkpatch.pl script in
r8180.h
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Wed, 26 Feb 2014 14:22:33 +0000 (15:22 +0100)]
staging: rtl8187se: Clean-up comment line style in r8180.h
This patch clean-up comment-line style in r8180 as the CodingStyle recommends.
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Wed, 26 Feb 2014 14:18:37 +0000 (15:18 +0100)]
staging: rtl8187se: Fixed whitespaces and indentations in r8180.h
This patch fixes whitespaces and converts some indentations to whitespaces and
whitespaces to indentations when it is necessary as the codingStyle of the
kernel recommends.
Thus, It deletes a lot of errors found by checkpatch.pl in r8180.h
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Wed, 26 Feb 2014 10:04:04 +0000 (15:34 +0530)]
Staging: sm7xxfb: Fix quoted string split across lines in sm7xxfb.c
This patch fixes the following checkpatch.pl issues in sm7xxfb.c:
WARNING: Quoted string split across lines
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Wed, 26 Feb 2014 23:42:15 +0000 (08:42 +0900)]
staging: lustre: make functions as static
These functions are only referenced in this file scope
so it can be marked static.
And remove space between function name and open parenthesis.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Wed, 26 Feb 2014 05:27:14 +0000 (10:57 +0530)]
Staging: sep: Fix line length over 80 characters in sep_main.c
This patch fixes the following checkpatch.pl warning in sep_main.c
WARNING: line length over 80 characters
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Wed, 26 Feb 2014 05:25:08 +0000 (10:55 +0530)]
Staging: sep: Fix quoted string split across lines in sep_main.c
This patch fixes the following checkpatch.pl warning in sep_main.c
WARNING: Quoted string split across lines
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Wed, 26 Feb 2014 05:22:36 +0000 (10:52 +0530)]
Staging: sep: Fix missing space after return type in sep_crypto.c
This patch fixes the following checkpatch.pl warning in sep_main.c
WARNING: Missing space after return type
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Thu, 27 Feb 2014 11:11:09 +0000 (20:11 +0900)]
staging: bcm: fix checkpatch error 'assignment in if condition'
clean up checkpatch errors and bClassificationSucceed is set to "TRUE"
proper location.
If protocal is not TCP or UDP, when it checks protocal, bClassificationSucceed
must be set to TRUE.
Also the end of do-while(0) loop, bClassificationSucceed is set to TRUE.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Thu, 27 Feb 2014 11:10:02 +0000 (20:10 +0900)]
staging: bcm: Remove unneeded set a variable
bClassificationSucceed is initialized with "false",
do not need to set "false" again.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 25 Feb 2014 20:51:52 +0000 (20:51 +0000)]
staging: vt6656: struct vnt_usb_send_context struct size optimization.
Reorder in size and remove dead member Next.
Reported-by: Joe Perches <joe@perches.com>
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 25 Feb 2014 20:51:51 +0000 (20:51 +0000)]
staging: vt6656: Remove pointer cast to urb->context.
Remove unnecessary cast to void * urb->context
Reported-by: Joe Perches <joe@perches.com>
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 25 Feb 2014 20:51:50 +0000 (20:51 +0000)]
staging: vt6656: Cleanup PIPEnsBulkInUsbRead
Remove camel case and white space.
Camel case changes
pDevice -> priv
pRCB -> rcb
ntStatus -> status
pUrb -> urb
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 25 Feb 2014 20:51:49 +0000 (20:51 +0000)]
staging: vt6656: clean up s_nsBulkInUsbIoCompleteRead
Clean up white space and camel case.
Camel case changes
pDevice -> priv
pRCB -> rcb
bReAllocSkb -> re_alloc_skb
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 25 Feb 2014 20:51:48 +0000 (20:51 +0000)]
staging: vt6656: s_nsBulkInUsbIoCompleteRead Replace error handling.
Use switch on urb->status
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 25 Feb 2014 20:51:47 +0000 (20:51 +0000)]
staging: vt6656: s_nsBulkInUsbIoCompleteRead Remove bytesRead/bIndicateReceive.
Replace with urb->actual_length.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 25 Feb 2014 20:51:46 +0000 (20:51 +0000)]
staging: vt6656: s_nsBulkInUsbIoCompleteRead get rid of status.
Just use urb->status directly.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 25 Feb 2014 20:51:45 +0000 (20:51 +0000)]
staging: vt6656: clean up PIPEnsSendBulkOut.
Remove commented out code, white space and camel case.
camel case changes
pDevice -> priv
pContext -> context
pUrb -> urb
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 25 Feb 2014 20:51:44 +0000 (20:51 +0000)]
staging: vt6656: usb_fill_bulk_urb get rid of void* cast.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 25 Feb 2014 20:51:43 +0000 (20:51 +0000)]
staging: vt6656: PIPEnsSendBulkOut reverse if statement
Get rid of unnessary else statement by !(MP_IS_READY(pDevice) &&
pDevice->Flags & fMP_POST_WRITES)
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 26 Feb 2014 15:18:26 +0000 (10:18 -0500)]
staging: dgap: fix kernel oops on port open
This patch addresses the follow error message followed
by a kernel oops:
dgap: driver does not set tty->port. This will crash the kernel later. Fix the driver
It also renames the main function this patch addresses because
its name is misleading.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Tue, 25 Feb 2014 14:54:43 +0000 (23:54 +0900)]
staging: rtl8821ae: Fix C99 style comments in pci.c and pci.h
This patch fix C99 style comments in pci.c and pci.h
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Tue, 25 Feb 2014 14:54:42 +0000 (23:54 +0900)]
staging: rtl8821ae: Fix C99 style comments in efuse.c
Fix C99 style comments in efuse.c.
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Tue, 25 Feb 2014 14:54:41 +0000 (23:54 +0900)]
staging: rtl8821ae: Fix typo in rtl8821ae/btcoexist
Fix spelling typo in rtl8821ae/btcoexist.
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Tue, 25 Feb 2014 14:54:40 +0000 (23:54 +0900)]
staging: rtl8821ae: Fix typo in rtl8821ae/rtl8821ae.
Fix spelling typo in comment and printk within
rtl8821ae/rtl8821ae.
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Tue, 25 Feb 2014 14:54:39 +0000 (23:54 +0900)]
staging: rtl8821ae: Fix typo in comment and printk in rtl8821ae
Fix spelling typo in comment and printk within rtl8821ae.
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Philipp Zabel [Tue, 25 Feb 2014 10:55:04 +0000 (11:55 +0100)]
imx-drm: parallel-display: Add drm_panel support
This patch allows to optionally attach the parallel-display to a panel
supported by a drm_panel driver instead of supplying the modes via
device tree.
Before:
parallel-display {
compatible = "fsl,imx-parallel-display";
...
display-timings {
native-timing = <&timing1>;
timing1: etm0700g0dh6 {
hactive = <800>;
vactive = <480>;
clock-frequency = <
33260000>;
hsync-len = <128>;
hback-porch = <88>;
hfront-porch = <40>;
vsync-len = <2>;
vback-porch = <33>;
vfront-porch = <10>;
hsync-active = <0>;
vsync-active = <0>;
...
};
};
...
};
After:
parallel-display {
compatible = "fsl,imx-parallel-display";
fsl,panel = <&panel>;
...
};
panel: panel {
compatible = "edt,etm0700g0dh6", "simple-panel";
};
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Philipp Zabel [Tue, 25 Feb 2014 11:43:42 +0000 (12:43 +0100)]
imx-drm: ipu-dc: Use usleep_range instead of msleep
Since msleep(2) can sleep up to 20ms anyway, make this explicit by using
usleep_range(2000, 20000).
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Philipp Zabel [Tue, 25 Feb 2014 11:43:41 +0000 (12:43 +0100)]
imx-drm: Move IPU_PIX_FMT_GBR24 definition into imx-ipu-v3.h
The IPU display controller supports a non-standard green-red-blue ordered
format that is used on the connection between IPU display interface 1 and
the TV encoder on i.MX53.
In preparation for the move of IPU core code out of staging, place the
IPU_PIX_FMT_GBR24 definition in imx-ipu-v3.h, so that both the IPU
display interface driver and the TVE encoder driver can access it.
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Tue, 25 Feb 2014 14:12:46 +0000 (19:42 +0530)]
Staging: panel: Fix quoted string split across line in panel.c
This patch fixes the following checkpatch.pl warning in panel.c:
WARNING: quoted string split across lines
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Tue, 25 Feb 2014 14:10:49 +0000 (19:40 +0530)]
Staging: panel: Fix space prohibited between function name and open paranthesis
This patch fixes the following checkpatch.pl issues in panel.c:
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Wed, 26 Feb 2014 09:06:00 +0000 (10:06 +0100)]
staging: rtl8187se: Clean-up comment line style in r8180_core.c
This patch clean-up comment-line style in r8180_core.c as the CodingStyle
recommends.
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Silvan Jegen [Tue, 25 Feb 2014 17:07:10 +0000 (18:07 +0100)]
Staging: rtl8192e: Replace min macro with min_t
Instead of an explicit cast the min_t macro should be used.
Signed-off-by: Silvan Jegen <s.jegen@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Tue, 25 Feb 2014 13:37:01 +0000 (14:37 +0100)]
staging: rtl8187se: Convert CHANNEL_LIST typedef into a struct.
The Documentation/CodingStyle doesn't recommend the use of typedef, convert
this to structure.
While at it, I have also renamed the variable names that were used in
this typedef not to use Hungarian notation.
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Tue, 25 Feb 2014 13:36:33 +0000 (14:36 +0100)]
staging: rtl8187se: Deleted rtl8180_len2duration functions in r8180_core.c
After the next warning messages by sparse tools:
drivers/staging/rtl8187se/r8180_core.c:1621:5: warning: symbol 'rtl8180_len2duration' was not declared. Should it be static?
drivers/staging/rtl8187se/r8180_core.c:1621:12: warning: ‘rtl8180_len2duration’ defined but not used [-Wunused-function]
static u16 rtl8180_len2duration(u32 len, short rate, short *ext)
^
And the next search:
$ grep -ir rtl8180_len2duration ./*
./r8180_core.c:u16 rtl8180_len2duration(u32 len, short rate, short *ext)
Binary file ./r8187se.ko matches
Binary file ./r8187se.o matches
I decided to delete rtl8180_len2duration function.
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
John Stultz [Wed, 26 Feb 2014 22:29:07 +0000 (14:29 -0800)]
staging: Fix build issues with new binder API
The new 64bit binder API causes build issues on 32bit ARM
due to the lack of 64bit __get_user_asm_* implementation.
Until that implementation is done, remove the choice for
32bit ARM, automatically enabling the old 32bit binder
protocol.
This can be reverted once a 64bit __get_user_asm_*
implementation is merged.
Cc: Colin Cross <ccross@android.com>
Cc: Arve Hjønnevåg <arve@android.com>
Cc: Serban Constantinescu <serban.constantinescu@arm.com>
Cc: Android Kernel Team <kernel-team@android.com>
Reported-by: Arnd Bergmann <arnd.bergmann@linaro.org>
Signed-off-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Tue, 25 Feb 2014 11:14:26 +0000 (16:44 +0530)]
Staging: cxt1e1: Fix line length over 80 characters in functions.c
This patch fixes the following checkpatch.pl warning in functions.c
WARNING: Line length over 80 characters
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Tue, 25 Feb 2014 10:42:44 +0000 (16:12 +0530)]
Staging: cxt1e1: Fix space prohibited between function name and open parenthesis '('
This patch fixes the following checkpatch.pl warning in functions.c
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Tue, 25 Feb 2014 09:16:04 +0000 (14:46 +0530)]
Staging: cxt1e1: Fix no spaces at the start of a line in functions.c
This patch fixes the following checkpatch.pl warning in functions.c
WARNING: please no spaces at the start of a line in
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Tue, 25 Feb 2014 01:13:49 +0000 (10:13 +0900)]
staging: ced401: fix double unlock bug
After spin_lock() is called, all of if-else conditions in this brace
should reach the end of else and spin_unlock() must be called.
So It doesn't need to call spin_unlock() without a return statement
for handling an error.
Also sparse says:
drivers/staging/
ced1401/usb1401.c:1080:28: warning:
context imbalance in 'Handle1401Esc' - unexpected unlock
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chase Southwood [Wed, 26 Feb 2014 09:09:44 +0000 (03:09 -0600)]
Staging: comedi: addi-data: clean-up variable use in hwdrv_apci035.c
The variable ui_Command is as of right now being cleared to a
value of zero between everytime that it writes to a port and then takes a
new value from a port. Seems like this zeroing is unnecessary, so we can
just remove these lines.
Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kumar Amit Mehta [Tue, 25 Feb 2014 23:04:45 +0000 (01:04 +0200)]
staging: comedi: drivers: fix for a potential NULL pointer dereference
Return -ENOMEM in ni_E_init if ni_gpct_device_construct returns NULL
Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Tue, 25 Feb 2014 09:21:26 +0000 (14:51 +0530)]
Staging: comedi: Fix unnecessary space after function pointer
This patch fixes the following checkpatch.pl warning in comedidev.h
WARNING: Fix unnecessary space after function pointer
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Tue, 25 Feb 2014 15:02:53 +0000 (10:02 -0500)]
staging: dgap: fix compile warnings by remove dead code
The last patch series exposed some dead code causing compile warnings.
This patch removes that dead code and fixes the warnings
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chase Southwood [Mon, 24 Feb 2014 16:35:09 +0000 (10:35 -0600)]
Staging: comedi: addi-data: fix a couple of lines that are too long
There are a couple of cases where a comment being on the same line as a
statement is causing the line to be over 80 characters long. This is an
easy fix, move these comments to the previous line.
Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chase Southwood [Mon, 24 Feb 2014 16:34:13 +0000 (10:34 -0600)]
Staging: comedi: addi-data: cleanup conditional blocks in hwdrv_apci035.c
There were some conditional blocks that had an unnecessary level of
indentation in them. We can remove this to improve code clarity.
Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chase Southwood [Sat, 22 Feb 2014 03:20:29 +0000 (21:20 -0600)]
Staging: comedi: addi-data: comment cleanup in hwdrv_apci035.c
This patch further cleans up the comments in hwdrv_apci035.c, converting
them to kernel style and removing some commented conditional statements
that are unused.
Signed-off-by: Chase Southwood <chase.southwood@yahoo.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Mon, 24 Feb 2014 16:49:42 +0000 (22:19 +0530)]
Staging: comedi: Fix line length exceeding 80 characters
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 19 Feb 2014 21:56:33 +0000 (21:56 +0000)]
staging: vt6656: Remove typedef enum _CONTEXT_TYPE
Replace with enum
assign as u8 type.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 19 Feb 2014 21:54:45 +0000 (21:54 +0000)]
staging: vt6656: clean up s_nsBulkOutIoCompleteWrite.
Remove commented out, white space and camel case.
Camel case changes
pContext -> context
pDevice -> priv
ContextType -> context_type
ulBufLen -> buf_len
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 19 Feb 2014 21:53:35 +0000 (21:53 +0000)]
staging: vt6656: s_nsBulkOutIoCompleteWrite add error handling,
change pContext->bBoolInUse to false on connection errors.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 19 Feb 2014 21:50:14 +0000 (21:50 +0000)]
staging: vt6656: s_nsBulkOutIoCompleteWrite reorganise variable order.
Declare in order of pointer use.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 19 Feb 2014 19:35:16 +0000 (19:35 +0000)]
staging: vt6656: vRunCommand remove multi calls to s_bCommandComplete.
Remove calls with break
s_bCommandComplete(pDevice);
spin_unlock_irq(&pDevice->lock);
return;
Add single call to s_bCommandComplete;
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 19 Feb 2014 19:34:18 +0000 (19:34 +0000)]
staging: vt6656: Move device_set_multi code call to vRunCommand
device_set_multi is an atomic call, in order to reduce atomic area of driver
move code to be called from vRunCommand.
Later the atomic area of vRunCommand can be reduced.
Change existing code in device_set_multi to new function
vnt_configure_filter minus its locks.
Change device_set_multi to call bScheduleCommand
device_set_multi is nolonger called from device open.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 19 Feb 2014 18:39:09 +0000 (18:39 +0000)]
staging: vt6656: Replace typedef struct INT_BUFFER, *PINT_BUFFER
Replace with struct vnt_interrupt_buffer.
Using only the live member of old structure
pDataBuf -> data_buf
bInUse -> in_use
uDataLen is unused and dropped.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 19 Feb 2014 18:37:32 +0000 (18:37 +0000)]
staging: vt6656: clean up PIPEnsInterruptRead.
Remove comments, white space and camel case.
Camel case changes
pDevice -> priv
ntStatus -> status
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 19 Feb 2014 18:36:37 +0000 (18:36 +0000)]
staging: vt6656: PIPEnsInterruptRead set intBuf.bInUse to false.
set intBuf.bInUse to false on return error.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 19 Feb 2014 18:35:22 +0000 (18:35 +0000)]
staging: vt6656: PIPEnsInterruptRead use usb_fill_int_urb
Change to usb_fill_int_urb which has int_interval.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jon Mason [Mon, 24 Feb 2014 20:08:20 +0000 (13:08 -0700)]
staging/rtl8192e: Remove unused code
Remove unused #defines, structure, and inlined functions for the
rtl8192e driver. Compile tested only.
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Thu, 20 Feb 2014 13:48:48 +0000 (08:48 -0500)]
staging: dgap: Add in-kernel firmware loading support
This patch adds in-kernel firmware loading support and removes
support for the original userland firmware loading process.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 19 Feb 2014 18:12:14 +0000 (13:12 -0500)]
staging: dgap: Rename driver
Renames driver file dgap_driver.c and dgap_driver.h to
dgap.c and dgap.h because we are now single source and
include file and better fits kernel naming conventions.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 19 Feb 2014 18:12:13 +0000 (13:12 -0500)]
staging: dgap: Make merged and local functions and variables static
This patch makes all merged and original functions static to dgap.c.
Doing so has revealed more dead code via gcc warnings.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 19 Feb 2014 18:12:12 +0000 (13:12 -0500)]
staging: dgap: Merge digi.h into dgap_driver.h
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 19 Feb 2014 18:12:11 +0000 (13:12 -0500)]
staging: dgap: Merge dgap_types.h into dgap_driver.h
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 19 Feb 2014 18:12:10 +0000 (13:12 -0500)]
staging: dgap: Merge dgap_kcompat.h into dgap_driver.h
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 19 Feb 2014 18:12:09 +0000 (13:12 -0500)]
staging: dgap: Merge dgap_parse.h into dgap_driver.h
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 19 Feb 2014 18:12:08 +0000 (13:12 -0500)]
staging: dgap: Merge dgap_conf.h into dgap_driver.h
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 19 Feb 2014 18:12:07 +0000 (13:12 -0500)]
staging: dgap: Merge dgap_pci.h into dgap_driver.h
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 19 Feb 2014 18:12:06 +0000 (13:12 -0500)]
staging: dgap: Merge dgap_fep5.h into dgap_driver.h
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 19 Feb 2014 18:12:05 +0000 (13:12 -0500)]
staging: dgap: Merge dgap_sysfs.h into dgap_driver.c
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 19 Feb 2014 18:12:04 +0000 (13:12 -0500)]
staging: dgap: Merge dgap_tty.h into dgap_driver.c
There is a lot of cleanup work to do on these digi drivers and merging as
much as is possible will make it easier. I also notice that many merged
drivers are single source and header.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 19 Feb 2014 18:12:03 +0000 (13:12 -0500)]
staging: dgap: Remove unneeded dgap_trace.c and dgap_trace.h
Removes unneeded files dgap_trace.c and dgap_trace.h
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / log