GitHub/WoltLab/WCF.git
4 years agoUse more user-friendly error message for MFA w/o setups
Tim Düsterhus [Thu, 3 Dec 2020 08:56:15 +0000 (09:56 +0100)]
Use more user-friendly error message for MFA w/o setups

This still MUST NOT ever happen, but in case it does the error message is more
useful and it was easy enough to implement.

4 years agoUse proper German title for AccountManagementForm
Tim Düsterhus [Wed, 2 Dec 2020 14:31:39 +0000 (15:31 +0100)]
Use proper German title for AccountManagementForm

4 years agoMerge pull request #3766 from WoltLab/mfa-migration
Tim Düsterhus [Mon, 30 Nov 2020 11:26:52 +0000 (12:26 +0100)]
Merge pull request #3766 from WoltLab/mfa-migration

Add update_com.woltlab.wcf_5.4_migrate_multifactor.php

4 years agoAdd update_com.woltlab.wcf_5.4_migrate_multifactor.php
Tim Düsterhus [Fri, 27 Nov 2020 09:34:10 +0000 (10:34 +0100)]
Add update_com.woltlab.wcf_5.4_migrate_multifactor.php

4 years agoFix validation of hashes in BackupMultifactorMethod
Tim Düsterhus [Fri, 27 Nov 2020 09:52:53 +0000 (10:52 +0100)]
Fix validation of hashes in BackupMultifactorMethod

4 years agoFix MFA SQL update instructions in update_com.woltlab.wcf_5.4_db.php
Tim Düsterhus [Fri, 27 Nov 2020 09:52:34 +0000 (10:52 +0100)]
Fix MFA SQL update instructions in update_com.woltlab.wcf_5.4_db.php

4 years agoDo not show the back up code description if codes are fresh
Tim Düsterhus [Thu, 26 Nov 2020 15:46:51 +0000 (16:46 +0100)]
Do not show the back up code description if codes are fresh

The phrasing does not really apply to the fresh set of codes.

4 years agoUse dedicated method for code generation for backup MF method
Tim Düsterhus [Thu, 26 Nov 2020 15:27:51 +0000 (16:27 +0100)]
Use dedicated method for code generation for backup MF method

This improves readability.

4 years agoUse a constant for the bytelength of the secret in TOTP
Tim Düsterhus [Thu, 26 Nov 2020 15:23:54 +0000 (16:23 +0100)]
Use a constant for the bytelength of the secret in TOTP

4 years agoMerge branch 'master' into mfa-meta
Tim Düsterhus [Thu, 26 Nov 2020 14:11:50 +0000 (15:11 +0100)]
Merge branch 'master' into mfa-meta

For the updated package.xml

4 years agoFix package check in update_com.woltlab.wcf_5.4_removeFiles.php
Tim Düsterhus [Thu, 26 Nov 2020 13:36:36 +0000 (14:36 +0100)]
Fix package check in update_com.woltlab.wcf_5.4_removeFiles.php

`fetchSingleColumn()` returns false for non-existing rows.

4 years agoUpdate the upgrade instructions from WoltLab Suite 5.3
Tim Düsterhus [Thu, 26 Nov 2020 13:18:56 +0000 (14:18 +0100)]
Update the upgrade instructions from WoltLab Suite 5.3

- A few PIPs were missing, most notably the language items.
- Additional commentary.
- Reordering for better resiliency.

4 years agoMerge branch '5.3'
Tim Düsterhus [Thu, 26 Nov 2020 12:51:39 +0000 (13:51 +0100)]
Merge branch '5.3'

4 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Thu, 26 Nov 2020 12:51:25 +0000 (13:51 +0100)]
Merge branch '5.2' into 5.3

4 years agoMerge pull request #3629 from WoltLab/session-update
Tim Düsterhus [Thu, 26 Nov 2020 12:31:10 +0000 (13:31 +0100)]
Merge pull request #3629 from WoltLab/session-update

Update instructions for new sessions

4 years agoImprove variable naming in update_com.woltlab.wcf_5.4_session_1_cookies.php
Tim Düsterhus [Thu, 26 Nov 2020 11:35:21 +0000 (12:35 +0100)]
Improve variable naming in update_com.woltlab.wcf_5.4_session_1_cookies.php

4 years agoMerge pull request #3763 from WoltLab/http-request-timeout
Tim Düsterhus [Thu, 26 Nov 2020 11:33:41 +0000 (12:33 +0100)]
Merge pull request #3763 from WoltLab/http-request-timeout

HTTP request timeouts

4 years agoSet an explicit timeout for ImageProxyAction's HttpClient
Tim Düsterhus [Thu, 26 Nov 2020 11:29:23 +0000 (12:29 +0100)]
Set an explicit timeout for ImageProxyAction's HttpClient

4 years agoSet an explicit timeout for FontManager's HttpClient
Tim Düsterhus [Thu, 26 Nov 2020 11:28:03 +0000 (12:28 +0100)]
Set an explicit timeout for FontManager's HttpClient

4 years agoReplace HTTPRequest's timeout by connect_timeout + read_timeout
Tim Düsterhus [Thu, 26 Nov 2020 11:26:00 +0000 (12:26 +0100)]
Replace HTTPRequest's timeout by connect_timeout + read_timeout

The timeout in 5.2 only applied to the connect() syscall. Guzzle's timeout
option applies to the total transfer. Replace it by connect_timeout +
read_timeout for backwards compatibility for code that expected the actual
transfer to take an arbitrary amount of time.

4 years agoDrop wcf1_session.sessionVariables
Tim Düsterhus [Thu, 26 Nov 2020 11:20:39 +0000 (12:20 +0100)]
Drop wcf1_session.sessionVariables

4 years agoAdd update instructions for session refactoring
Tim Düsterhus [Thu, 22 Oct 2020 12:47:56 +0000 (14:47 +0200)]
Add update instructions for session refactoring

4 years agoAdd skipStyleUpdate paramter to file PIP
Tim Düsterhus [Thu, 22 Oct 2020 12:37:53 +0000 (14:37 +0200)]
Add skipStyleUpdate paramter to file PIP

4 years agoAllow returning a Document in ScriptPackageInstallationPlugin
Tim Düsterhus [Thu, 22 Oct 2020 10:14:48 +0000 (12:14 +0200)]
Allow returning a Document in ScriptPackageInstallationPlugin

4 years agoDelete obsolete session_* options in option.xml
Tim Düsterhus [Thu, 22 Oct 2020 12:18:26 +0000 (14:18 +0200)]
Delete obsolete session_* options in option.xml

4 years agoUse a local variable to prevent parallel requests being mixed up
Alexander Ebert [Wed, 25 Nov 2020 23:57:03 +0000 (00:57 +0100)]
Use a local variable to prevent parallel requests being mixed up

Fixes #3760

4 years agoImproper serialization of `null` values
Alexander Ebert [Wed, 25 Nov 2020 23:25:31 +0000 (00:25 +0100)]
Improper serialization of `null` values

Fixes #3751

4 years agoMerge pull request #3759 from WoltLab/mfa-pending-expire
Tim Düsterhus [Wed, 25 Nov 2020 17:40:53 +0000 (18:40 +0100)]
Merge pull request #3759 from WoltLab/mfa-pending-expire

Expire pending user changes after 15 minutes

4 years agoReplace 'Multi-Factor' by 'Multi-factor'
Tim Düsterhus [Wed, 25 Nov 2020 17:39:53 +0000 (18:39 +0100)]
Replace 'Multi-Factor' by 'Multi-factor'

titlecase.com says that it should be 'Multi-factor' with a lowercase 'f'.

4 years agoExpire pending user changes after 15 minutes
Tim Düsterhus [Wed, 25 Nov 2020 17:24:37 +0000 (18:24 +0100)]
Expire pending user changes after 15 minutes

15 minutes should be plenty of time for the user to complete the MF
authentication flow. A user is not going to sit patiently for 15 minutes
without simply closing the browser window which de facto forces them to start
anew, because nothing leads back to the MF authentication flow except
performing yet another login.

Email codes are the only (default) method that could be slow without the user
being able to do anything about it (e.g. due to greylisting). These codes
already expire after 10 minutes, giving an implicit upper bound (when ignoring
the fact that a new code will be sent every 2 minutes during refreshing).

4 years agoAdd __multifactorAuthenticationLoginAs to syncTemplates.json
Tim Düsterhus [Wed, 25 Nov 2020 16:47:37 +0000 (17:47 +0100)]
Add __multifactorAuthenticationLoginAs to syncTemplates.json

4 years agoFix typo in de.xml
Tim Düsterhus [Wed, 25 Nov 2020 16:44:03 +0000 (17:44 +0100)]
Fix typo in de.xml

4 years agoRemove obsolete phrases used in the MF authentication process
Tim Düsterhus [Wed, 25 Nov 2020 16:43:31 +0000 (17:43 +0100)]
Remove obsolete phrases used in the MF authentication process

4 years agoAdd explanatory texts to backup MF method (#3754)
Tim Düsterhus [Wed, 25 Nov 2020 16:40:50 +0000 (17:40 +0100)]
Add explanatory texts to backup MF method (#3754)

* Add explanatory texts to backup MF method
* Improve phrasing of MF backup explanations

Co-authored-by: Alexander Ebert <ebert@woltlab.com>
4 years agoAdd explanatory texts to email MF method (#3755)
Tim Düsterhus [Wed, 25 Nov 2020 16:39:06 +0000 (17:39 +0100)]
Add explanatory texts to email MF method (#3755)

4 years agoSend a notification email when MFA is enabled (#3756)
Tim Düsterhus [Wed, 25 Nov 2020 16:38:10 +0000 (17:38 +0100)]
Send a notification email when MFA is enabled (#3756)

4 years agoRemoved the obsolete 2fa abort form
Alexander Ebert [Wed, 25 Nov 2020 14:24:23 +0000 (15:24 +0100)]
Removed the obsolete 2fa abort form

4 years agoSeparate form element for the login username
Alexander Ebert [Wed, 25 Nov 2020 14:21:46 +0000 (15:21 +0100)]
Separate form element for the login username

4 years agoMerge branch 'mfa-meta' of https://github.com/WoltLab/WCF into mfa-meta
Alexander Ebert [Wed, 25 Nov 2020 12:13:54 +0000 (13:13 +0100)]
Merge branch 'mfa-meta' of https://github.com/WoltLab/WCF into mfa-meta

4 years agoOverhauled the layout of the 2fa authentication page
Alexander Ebert [Wed, 25 Nov 2020 12:13:52 +0000 (13:13 +0100)]
Overhauled the layout of the 2fa authentication page

4 years agoExplain the choice of the backup code parameters
Tim Düsterhus [Wed, 25 Nov 2020 10:08:28 +0000 (11:08 +0100)]
Explain the choice of the backup code parameters

4 years agoFix typo in en.xml
Tim Düsterhus [Wed, 25 Nov 2020 09:35:15 +0000 (10:35 +0100)]
Fix typo in en.xml

4 years agoFix typo in de.xml
Tim Düsterhus [Wed, 25 Nov 2020 08:34:03 +0000 (09:34 +0100)]
Fix typo in de.xml

4 years agoUpdate the orphanedComments remark in package.xml
Tim Düsterhus [Wed, 25 Nov 2020 08:18:46 +0000 (09:18 +0100)]
Update the orphanedComments remark in package.xml

4 years agoMerge branch '5.3'
Tim Düsterhus [Wed, 25 Nov 2020 08:08:07 +0000 (09:08 +0100)]
Merge branch '5.3'

4 years agoFix typo in informal German phrases
Jannis Grimm [Wed, 25 Nov 2020 03:04:31 +0000 (04:04 +0100)]
Fix typo in informal German phrases

Verweide -> Vermeide

Closes #3752

[Tim: rephrased the commit message]

4 years agoMerge branch 'master' into mfa-meta
Alexander Ebert [Tue, 24 Nov 2020 18:36:50 +0000 (19:36 +0100)]
Merge branch 'master' into mfa-meta

4 years agoUpdated the `package-lock.json`
Alexander Ebert [Tue, 24 Nov 2020 18:35:44 +0000 (19:35 +0100)]
Updated the `package-lock.json`

The old version was outdated and prevented the `node_modules/.bin` from being created after running `npm i`

4 years agoImproved randomized sort order of related articles
Marcel Werk [Tue, 24 Nov 2020 17:44:34 +0000 (18:44 +0100)]
Improved randomized sort order of related articles

4 years agoMerge branch 'master' into mfa-meta
Alexander Ebert [Tue, 24 Nov 2020 17:34:49 +0000 (18:34 +0100)]
Merge branch 'master' into mfa-meta

4 years agoMerge branch '5.3'
Alexander Ebert [Tue, 24 Nov 2020 17:33:25 +0000 (18:33 +0100)]
Merge branch '5.3'

4 years agoMinor visual updates
Alexander Ebert [Tue, 24 Nov 2020 17:28:30 +0000 (18:28 +0100)]
Minor visual updates

4 years agoMerge pull request #3749 from WoltLab/mfa-backup-email
Tim Düsterhus [Tue, 24 Nov 2020 15:13:19 +0000 (16:13 +0100)]
Merge pull request #3749 from WoltLab/mfa-backup-email

Add email notification when using a backup code

4 years agoMerge pull request #3750 from WoltLab/emogrifier-5.0
Tim Düsterhus [Tue, 24 Nov 2020 14:58:34 +0000 (15:58 +0100)]
Merge pull request #3750 from WoltLab/emogrifier-5.0

Update pelago/emogrifier to 5.0

4 years agoUpdate pelago/emogrifier to 5.0
Tim Düsterhus [Tue, 24 Nov 2020 14:45:28 +0000 (15:45 +0100)]
Update pelago/emogrifier to 5.0

4 years agoAdd email notification when using a backup code
Tim Düsterhus [Tue, 24 Nov 2020 13:21:54 +0000 (14:21 +0100)]
Add email notification when using a backup code

4 years agoMerge pull request #3746 from WoltLab/mfa-conditions
Joshua Rüsweg [Tue, 24 Nov 2020 11:03:51 +0000 (12:03 +0100)]
Merge pull request #3746 from WoltLab/mfa-conditions

Integrate multi-factor authentication into the condition system

4 years agoRename condition to `multifactorActive`
joshuaruesweg [Mon, 23 Nov 2020 17:05:51 +0000 (18:05 +0100)]
Rename condition to `multifactorActive`

4 years agoFix typo in PHPDoc in \wcf\system\multifactor\totp\Totp
Tim Düsterhus [Tue, 24 Nov 2020 10:33:39 +0000 (11:33 +0100)]
Fix typo in PHPDoc in \wcf\system\multifactor\totp\Totp

4 years agoAdd multi-factor foreign keys to update_com.woltlab.wcf_5.4_db.php
Tim Düsterhus [Mon, 23 Nov 2020 15:57:40 +0000 (16:57 +0100)]
Add multi-factor foreign keys to update_com.woltlab.wcf_5.4_db.php

4 years agoAdd wcf1_user_multifactor_email to update_com.woltlab.wcf_5.4_db.php
Tim Düsterhus [Mon, 23 Nov 2020 15:55:18 +0000 (16:55 +0100)]
Add wcf1_user_multifactor_email to update_com.woltlab.wcf_5.4_db.php

4 years agoAdd missing usage of fully qualified function names for email MFA
Tim Düsterhus [Mon, 23 Nov 2020 15:53:29 +0000 (16:53 +0100)]
Add missing usage of fully qualified function names for email MFA

4 years agoRelease 5.3.1 5.3.1
Alexander Ebert [Mon, 23 Nov 2020 15:38:18 +0000 (16:38 +0100)]
Release 5.3.1

4 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Mon, 23 Nov 2020 15:34:03 +0000 (16:34 +0100)]
Merge branch '5.2' into 5.3

4 years agoMissing check for empty object ids 5.2.10
Alexander Ebert [Mon, 23 Nov 2020 15:11:56 +0000 (16:11 +0100)]
Missing check for empty object ids

4 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Mon, 23 Nov 2020 14:55:09 +0000 (15:55 +0100)]
Merge branch '5.2' into 5.3

4 years agorandomized sort order of related articles
Marcel Werk [Mon, 23 Nov 2020 14:19:48 +0000 (15:19 +0100)]
randomized sort order of related articles

4 years agoChanged related articles to new layout
Marcel Werk [Mon, 23 Nov 2020 14:19:02 +0000 (15:19 +0100)]
Changed related articles to new layout

4 years agoRelease 5.2.10
Alexander Ebert [Mon, 23 Nov 2020 13:43:06 +0000 (14:43 +0100)]
Release 5.2.10

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Mon, 23 Nov 2020 13:36:42 +0000 (14:36 +0100)]
Merge branch '3.1' into 5.2

4 years agoRelease 3.1.18 3.1.18
Alexander Ebert [Mon, 23 Nov 2020 13:29:11 +0000 (14:29 +0100)]
Release 3.1.18

4 years agoDeprecated PreparedStatement::fetchList()
Tim Düsterhus [Mon, 23 Nov 2020 11:45:43 +0000 (12:45 +0100)]
Deprecated PreparedStatement::fetchList()

Resolves #3742

4 years agoUse modified package servers when running in enterprise mode
Alexander Ebert [Mon, 23 Nov 2020 11:30:45 +0000 (12:30 +0100)]
Use modified package servers when running in enterprise mode

4 years agoMerge branch '5.3'
Tim Düsterhus [Mon, 23 Nov 2020 10:36:46 +0000 (11:36 +0100)]
Merge branch '5.3'

- Dropped update_com.woltlab.wcf_5.3_orphanedComments.php
- Replaced ts/WoltLabSuite/Core/Acp/Ui/Option/EmailSmtpTest.js with the file
  from 5.3, replacing WCF_CLICK_EVENT with 'click' and regenerated the compiled
  JavaScript.
- Manually applied 4ac5f76b4ee5804919a832729a7ab384ea9d9a4d to the already
  converted WoltLabSuite/Core/Ui/Screen.ts

4 years agoMerge branch '5.2' into 5.3
Tim Düsterhus [Mon, 23 Nov 2020 08:31:54 +0000 (09:31 +0100)]
Merge branch '5.2' into 5.3

4 years agoWhitelist `iterator_count` in enterprise mode
Tim Düsterhus [Mon, 23 Nov 2020 08:27:54 +0000 (09:27 +0100)]
Whitelist `iterator_count` in enterprise mode

4 years agoMerge pull request #3738 from WoltLab/emogrifier-4.0
Tim Düsterhus [Mon, 23 Nov 2020 08:10:25 +0000 (09:10 +0100)]
Merge pull request #3738 from WoltLab/emogrifier-4.0

Update to Emogrifier 4.0

4 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Sun, 22 Nov 2020 17:36:43 +0000 (18:36 +0100)]
Merge branch '5.2' into 5.3

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Sun, 22 Nov 2020 17:31:49 +0000 (18:31 +0100)]
Merge branch '3.1' into 5.2

4 years agoMerge pull request #3744 from Krymonota/patch-18
Alexander Ebert [Sun, 22 Nov 2020 16:58:44 +0000 (17:58 +0100)]
Merge pull request #3744 from Krymonota/patch-18

Add missing JSDoc to `EmailSmtpTest`

4 years agoMerge pull request #3745 from Krymonota/patch-19
Alexander Ebert [Sun, 22 Nov 2020 16:58:12 +0000 (17:58 +0100)]
Merge pull request #3745 from Krymonota/patch-19

Fix JSDoc module typo in `RewriteGenerator`

4 years agoAdd usesMultifactor condition for user search in acp
joshuaruesweg [Sun, 22 Nov 2020 11:03:34 +0000 (12:03 +0100)]
Add usesMultifactor condition for user search in acp

4 years agoAdd usesMultifactor condition for notices
joshuaruesweg [Sun, 22 Nov 2020 10:37:45 +0000 (11:37 +0100)]
Add usesMultifactor condition for notices

4 years agoAdd `$multifactorActive` property for user dbo
joshuaruesweg [Sun, 22 Nov 2020 10:25:57 +0000 (11:25 +0100)]
Add `$multifactorActive` property for user dbo

4 years agoMerge branch '5.2' into 5.3
joshuaruesweg [Sat, 21 Nov 2020 21:00:14 +0000 (22:00 +0100)]
Merge branch '5.2' into 5.3

4 years agoFix point calculation for removing reactions from an object
joshuaruesweg [Sat, 21 Nov 2020 20:56:27 +0000 (21:56 +0100)]
Fix point calculation for removing reactions from an object

4 years agoRelease 5.3.1
Alexander Ebert [Sat, 21 Nov 2020 18:59:08 +0000 (19:59 +0100)]
Release 5.3.1

4 years agoFix JSDoc module typo in `RewriteGenerator`
Niklas [Sat, 21 Nov 2020 18:41:47 +0000 (19:41 +0100)]
Fix JSDoc module typo in `RewriteGenerator`

4 years agoAdd missing JSDoc to `EmailSmtpTest`
Niklas [Sat, 21 Nov 2020 18:39:56 +0000 (19:39 +0100)]
Add missing JSDoc to `EmailSmtpTest`

4 years agoForce the removal of orphaned comments during the upgrade
Alexander Ebert [Sat, 21 Nov 2020 18:36:16 +0000 (19:36 +0100)]
Force the removal of orphaned comments during the upgrade

4 years agoUpdating minified JavaScript files
WoltLab [Fri, 20 Nov 2020 19:11:59 +0000 (19:11 +0000)]
Updating minified JavaScript files

4 years agoMerge branch '5.2' into 5.3
Alexander Ebert [Fri, 20 Nov 2020 19:08:26 +0000 (20:08 +0100)]
Merge branch '5.2' into 5.3

4 years agoUpdating minified JavaScript files
WoltLab [Fri, 20 Nov 2020 19:03:30 +0000 (19:03 +0000)]
Updating minified JavaScript files

4 years agoMerge branch '3.1' into 5.2
Alexander Ebert [Fri, 20 Nov 2020 18:59:24 +0000 (19:59 +0100)]
Merge branch '3.1' into 5.2

4 years agoUpdating minified JavaScript files
WoltLab [Fri, 20 Nov 2020 18:06:23 +0000 (18:06 +0000)]
Updating minified JavaScript files

4 years agoWorkaround for a Chromium bug on Windows
Alexander Ebert [Fri, 20 Nov 2020 17:39:33 +0000 (18:39 +0100)]
Workaround for a Chromium bug on Windows

4 years agoVerbose style compatibility for 5.2/5.3
Alexander Ebert [Fri, 20 Nov 2020 16:16:19 +0000 (17:16 +0100)]
Verbose style compatibility for 5.2/5.3

Fixes #3737

4 years agoMerge pull request #3743 from WoltLab/mfa-disable
Tim Düsterhus [Fri, 20 Nov 2020 14:39:11 +0000 (15:39 +0100)]
Merge pull request #3743 from WoltLab/mfa-disable

Support disabling the multi-factor authentication

4 years agoSupport disabling the multi-factor authentication
Tim Düsterhus [Fri, 20 Nov 2020 14:25:47 +0000 (15:25 +0100)]
Support disabling the multi-factor authentication

4 years agoUse U+2022 to black out backup code trailers
Tim Düsterhus [Fri, 20 Nov 2020 12:39:50 +0000 (13:39 +0100)]
Use U+2022 to black out backup code trailers