GitHub/WoltLab/WCF.git
3 years agoFix code formatting
Matthias Schmidt [Tue, 25 May 2021 06:17:30 +0000 (08:17 +0200)]
Fix code formatting

3 years agoMerge branch '5.3'
Matthias Schmidt [Tue, 25 May 2021 06:13:26 +0000 (08:13 +0200)]
Merge branch '5.3'

3 years agoFix media clipboard inserting when having multiple editors
Matthias Schmidt [Tue, 25 May 2021 06:01:52 +0000 (08:01 +0200)]
Fix media clipboard inserting when having multiple editors

Ensure that the clipboard insertion event listener is only added once and that the active media manager is set in the clipboard handler when opening a media manager window.

3 years agoEnsure uniqueness of media insert dialogs when having multiple editors
Matthias Schmidt [Tue, 25 May 2021 05:46:36 +0000 (07:46 +0200)]
Ensure uniqueness of media insert dialogs when having multiple editors

3 years agoMerge pull request #4234 from WoltLab/email-log-discard
Tim Düsterhus [Fri, 21 May 2021 13:57:36 +0000 (15:57 +0200)]
Merge pull request #4234 from WoltLab/email-log-discard

Add 'discarded' status to email log

3 years agoImprove phrasing of message when discarding emails for read notifications
Tim Düsterhus [Fri, 21 May 2021 13:54:46 +0000 (15:54 +0200)]
Improve phrasing of message when discarding emails for read notifications

Co-authored-by: Alexander Ebert <ebert@woltlab.com>
3 years agoMerge pull request #4235 from WoltLab/cover-webp
Tim Düsterhus [Fri, 21 May 2021 13:51:30 +0000 (15:51 +0200)]
Merge pull request #4235 from WoltLab/cover-webp

Check ->coverPhotoHasWebP in UserCoverPhoto::getFilename()

3 years agoCheck ->coverPhotoHasWebP in UserCoverPhoto::getFilename()
Tim Düsterhus [Fri, 21 May 2021 13:46:56 +0000 (15:46 +0200)]
Check ->coverPhotoHasWebP in UserCoverPhoto::getFilename()

3 years agoEvent listeners had been attached repeatedly
Alexander Ebert [Fri, 21 May 2021 13:42:39 +0000 (15:42 +0200)]
Event listeners had been attached repeatedly

3 years agoIncorrect check for ignored mutation events
Alexander Ebert [Fri, 21 May 2021 13:42:07 +0000 (15:42 +0200)]
Incorrect check for ignored mutation events

3 years agoUpdate email log status to discarded when dropping notification mails
Tim Düsterhus [Fri, 21 May 2021 13:18:55 +0000 (15:18 +0200)]
Update email log status to discarded when dropping notification mails

Fixes #4225

3 years agoAdd EmailLogEntry::STATUS_DISCARDED
Tim Düsterhus [Fri, 21 May 2021 12:27:13 +0000 (14:27 +0200)]
Add EmailLogEntry::STATUS_DISCARDED

3 years agoMake EmailDeliveryBackgroundJob::updateStatus() public
Tim Düsterhus [Fri, 21 May 2021 12:23:58 +0000 (14:23 +0200)]
Make EmailDeliveryBackgroundJob::updateStatus() public

3 years agoRelease 5.4.0 Alpha 3 5.4.0_Alpha_3
Alexander Ebert [Thu, 20 May 2021 15:04:39 +0000 (17:04 +0200)]
Release 5.4.0 Alpha 3

3 years agoMerge pull request #4232 from WoltLab/iusermailbox
Tim Düsterhus [Thu, 20 May 2021 13:20:48 +0000 (15:20 +0200)]
Merge pull request #4232 from WoltLab/iusermailbox

Add IUserMailbox interface

3 years agoAdd IUserMailbox interface
Tim Düsterhus [Thu, 20 May 2021 13:10:28 +0000 (15:10 +0200)]
Add IUserMailbox interface

This cleans up the OO design a bit, because consumers may check against the
interface instead of a concrete class. This allows for additional mailboxes
belonging to an user, e.g. for emergency contacts or separate billing
addresses.

3 years agoUpdating minified JavaScript files
WoltLab [Thu, 20 May 2021 12:23:10 +0000 (12:23 +0000)]
Updating minified JavaScript files

3 years agoMerge pull request #4231 from WoltLab/unfurl-user-agent-like
Marcel Werk [Thu, 20 May 2021 12:05:58 +0000 (14:05 +0200)]
Merge pull request #4231 from WoltLab/unfurl-user-agent-like

Add '; like Twitterbot' to URL Unfurling User-Agent

3 years agoImprove phrasing of success state in email log
Tim Düsterhus [Thu, 20 May 2021 09:26:08 +0000 (11:26 +0200)]
Improve phrasing of success state in email log

Resolves #4230

3 years agoAdd '; like Twitterbot' to URL Unfurling User-Agent
Tim Düsterhus [Thu, 20 May 2021 08:46:21 +0000 (10:46 +0200)]
Add '; like Twitterbot' to URL Unfurling User-Agent

3 years agoAllow commas and semicolons in the comment in HttpFactory::getDefaultUserAgent()
Tim Düsterhus [Thu, 20 May 2021 08:39:13 +0000 (10:39 +0200)]
Allow commas and semicolons in the comment in HttpFactory::getDefaultUserAgent()

3 years agoMerge branch '5.3'
Matthias Schmidt [Thu, 20 May 2021 07:45:11 +0000 (09:45 +0200)]
Merge branch '5.3'

3 years agoPreserve deleted filter when using article list pagination in ACP
Matthias Schmidt [Thu, 20 May 2021 07:43:46 +0000 (09:43 +0200)]
Preserve deleted filter when using article list pagination in ACP

3 years agoMerge pull request #4229 from WoltLab/bundle-exclude
Alexander Ebert [Wed, 19 May 2021 16:30:48 +0000 (18:30 +0200)]
Merge pull request #4229 from WoltLab/bundle-exclude

Exclude JS modules from bundles

3 years agoBundle two modules due to external dependency
Alexander Ebert [Wed, 19 May 2021 16:13:46 +0000 (18:13 +0200)]
Bundle two modules due to external dependency

3 years agoSkip the "Add Article" dialog for non authorized users
Alexander Ebert [Wed, 19 May 2021 15:57:49 +0000 (17:57 +0200)]
Skip the "Add Article" dialog for non authorized users

3 years agoShow disabled articles in categorized list
Marcel Werk [Wed, 19 May 2021 15:33:49 +0000 (17:33 +0200)]
Show disabled articles in categorized list

3 years agoMerge branch '5.3'
Marcel Werk [Wed, 19 May 2021 14:57:24 +0000 (16:57 +0200)]
Merge branch '5.3'

3 years agoMerge branch '5.3'
Marcel Werk [Wed, 19 May 2021 14:53:08 +0000 (16:53 +0200)]
Merge branch '5.3'

3 years agoIncorrect badge selector
Marcel Werk [Wed, 19 May 2021 14:49:38 +0000 (16:49 +0200)]
Incorrect badge selector

3 years agoRebuild JS files
Alexander Ebert [Wed, 19 May 2021 14:17:22 +0000 (16:17 +0200)]
Rebuild JS files

3 years agoExclude modules from (some) builds
Alexander Ebert [Wed, 19 May 2021 14:00:43 +0000 (16:00 +0200)]
Exclude modules from (some) builds

3 years agoMerge branch '5.3'
joshuaruesweg [Wed, 19 May 2021 12:31:19 +0000 (14:31 +0200)]
Merge branch '5.3'

3 years agoFix email in Apple Mail with darkmode enabled
joshuaruesweg [Wed, 19 May 2021 12:30:14 +0000 (14:30 +0200)]
Fix email in Apple Mail with darkmode enabled

Fix #4188

3 years agoUse whitespace as the separator after `@woltlabExcludeBundle`
Tim Düsterhus [Wed, 19 May 2021 10:32:05 +0000 (12:32 +0200)]
Use whitespace as the separator after `@woltlabExcludeBundle`

3 years agoMerge pull request #4226 from WoltLab/email-log-filter
Marcel Werk [Wed, 19 May 2021 10:22:58 +0000 (12:22 +0200)]
Merge pull request #4226 from WoltLab/email-log-filter

Add `email` filter to email log

3 years agoExclude `Ui/User/Multifactor/Totp/Qr` from all JS bundles
Tim Düsterhus [Wed, 19 May 2021 10:13:53 +0000 (12:13 +0200)]
Exclude `Ui/User/Multifactor/Totp/Qr` from all JS bundles

3 years agoExclude `Devtools/Style/LiveReload` from all JS bundles
Tim Düsterhus [Wed, 19 May 2021 10:10:48 +0000 (12:10 +0200)]
Exclude `Devtools/Style/LiveReload` from all JS bundles

3 years agoMerge pull request #4228 from WoltLab/js-bundle-optimize
Tim Düsterhus [Wed, 19 May 2021 09:58:02 +0000 (11:58 +0200)]
Merge pull request #4228 from WoltLab/js-bundle-optimize

Support excluding specific modules from bundles

3 years agoSupport excluding specific modules from bundles
Tim Düsterhus [Wed, 19 May 2021 09:46:54 +0000 (11:46 +0200)]
Support excluding specific modules from bundles

3 years agoMake require.build.js more flexible
Tim Düsterhus [Wed, 19 May 2021 09:20:47 +0000 (11:20 +0200)]
Make require.build.js more flexible

3 years agoUpdating minified JavaScript files
WoltLab [Wed, 19 May 2021 09:18:27 +0000 (09:18 +0000)]
Updating minified JavaScript files

3 years agoFix typo in comment in FloodControl.class.php
Tim Düsterhus [Wed, 19 May 2021 08:50:54 +0000 (10:50 +0200)]
Fix typo in comment in FloodControl.class.php

3 years agoStop using `elBySel` in emailLogList.tpl
Tim Düsterhus [Wed, 19 May 2021 07:40:40 +0000 (09:40 +0200)]
Stop using `elBySel` in emailLogList.tpl

3 years agoTrim filter values in EmailLogListPage
Tim Düsterhus [Wed, 19 May 2021 07:41:09 +0000 (09:41 +0200)]
Trim filter values in EmailLogListPage

3 years agoAdd `email` filter to EmailLogList
Tim Düsterhus [Wed, 19 May 2021 07:39:14 +0000 (09:39 +0200)]
Add `email` filter to EmailLogList

Resolves #4224

3 years agoFix code style issue
Matthias Schmidt [Wed, 19 May 2021 05:11:21 +0000 (07:11 +0200)]
Fix code style issue

3 years agoAdd `Database::prepare()` which replaces `app1_` with `app{WCF_N}_` (#4223)
Matthias Schmidt [Wed, 19 May 2021 05:08:01 +0000 (07:08 +0200)]
Add `Database::prepare()` which replaces `app1_` with `app{WCF_N}_` (#4223)

Close #2911

3 years agoMissing font stack for system font in emails
Alexander Ebert [Tue, 18 May 2021 16:19:42 +0000 (18:19 +0200)]
Missing font stack for system font in emails

3 years agoAdd missing `since` tag
joshuaruesweg [Tue, 18 May 2021 13:30:57 +0000 (15:30 +0200)]
Add missing `since` tag

3 years agoMerge pull request #4221 from WoltLab/session-legacy-duplicate
Tim Düsterhus [Tue, 18 May 2021 11:28:07 +0000 (13:28 +0200)]
Merge pull request #4221 from WoltLab/session-legacy-duplicate

Prevent duplicate key errors during creation of legacy sessions

3 years agoMerge pull request #4222 from mutec/pjsonfiles
Tim Düsterhus [Tue, 18 May 2021 10:33:35 +0000 (12:33 +0200)]
Merge pull request #4222 from mutec/pjsonfiles

provide files-property for `package.json`

3 years agoprovide files-property for package.json
mutec [Tue, 18 May 2021 10:23:43 +0000 (12:23 +0200)]
provide files-property for package.json

Prevent reading the whole repository when this repository is a dependency.

3 years agoPrevent duplicate key errors during creation of legacy sessions
Tim Düsterhus [Tue, 18 May 2021 09:06:11 +0000 (11:06 +0200)]
Prevent duplicate key errors during creation of legacy sessions

Fixes #4214.
see 7878eb77952c506e5818587b49f9a64773b87fb1

3 years agoGracefully handle missing legacy session in SessionHandler::__get()
Tim Düsterhus [Tue, 18 May 2021 08:48:00 +0000 (10:48 +0200)]
Gracefully handle missing legacy session in SessionHandler::__get()

3 years agoExplicitly `return null` in SessionHandler::__get()'s default case
Tim Düsterhus [Tue, 18 May 2021 08:45:42 +0000 (10:45 +0200)]
Explicitly `return null` in SessionHandler::__get()'s default case

3 years agoRevert "Ignore duplicate key errors when creating a legacy session"
Tim Düsterhus [Tue, 18 May 2021 08:11:07 +0000 (10:11 +0200)]
Revert "Ignore duplicate key errors when creating a legacy session"

This commit was incorrect, as `createOrIgnore()` might return `null` which is
disallowed by the return type and is undesired.

This reverts commit 7878eb77952c506e5818587b49f9a64773b87fb1.

3 years agoFix code style issues
Matthias Schmidt [Tue, 18 May 2021 06:51:47 +0000 (08:51 +0200)]
Fix code style issues

3 years agoProperly position errors below fields in `.inputAddon` elements
Matthias Schmidt [Tue, 18 May 2021 05:01:42 +0000 (07:01 +0200)]
Properly position errors below fields in `.inputAddon` elements

3 years agoMerge branch '5.3'
Matthias Schmidt [Tue, 18 May 2021 04:57:32 +0000 (06:57 +0200)]
Merge branch '5.3'

3 years agoProperly position errors below fields in `.inputAddon` elements (#4219)
Matthias Schmidt [Tue, 18 May 2021 04:56:48 +0000 (06:56 +0200)]
Properly position errors below fields in `.inputAddon` elements (#4219)

3 years agoMerge branch '5.3'
Alexander Ebert [Mon, 17 May 2021 17:05:22 +0000 (19:05 +0200)]
Merge branch '5.3'

3 years agoIncorrect redirect url after login in multi domain setups
Alexander Ebert [Mon, 17 May 2021 17:05:06 +0000 (19:05 +0200)]
Incorrect redirect url after login in multi domain setups

3 years agoUse `opacity` to fade out icons
Alexander Ebert [Mon, 17 May 2021 17:02:50 +0000 (19:02 +0200)]
Use `opacity` to fade out icons

3 years agoMerge branch '5.3'
Alexander Ebert [Mon, 17 May 2021 17:01:14 +0000 (19:01 +0200)]
Merge branch '5.3'

3 years agoIncorrect fade out effect in iOS Safari
Alexander Ebert [Mon, 17 May 2021 17:00:44 +0000 (19:00 +0200)]
Incorrect fade out effect in iOS Safari

3 years agoMerge pull request #4217 from WoltLab/readme_redactor
Matthias Schmidt [Mon, 17 May 2021 12:02:31 +0000 (14:02 +0200)]
Merge pull request #4217 from WoltLab/readme_redactor

Remove reference to specific WSC version in `README.md`

3 years agoSkip basic bbcodes when the selection is inside a code block
Alexander Ebert [Mon, 17 May 2021 10:10:49 +0000 (12:10 +0200)]
Skip basic bbcodes when the selection is inside a code block

3 years agoFix possible property access on `null` in `SessionHandler::applyPendingUserChange()`
Tim Düsterhus [Mon, 17 May 2021 10:01:08 +0000 (12:01 +0200)]
Fix possible property access on `null` in `SessionHandler::applyPendingUserChange()`

3 years agoStart each sentence in new line in `README.md`
Matthias Schmidt [Mon, 17 May 2021 06:14:11 +0000 (08:14 +0200)]
Start each sentence in new line in `README.md`

3 years agoRemove reference to specific WSC version in `README.md`
Matthias Schmidt [Mon, 17 May 2021 06:13:23 +0000 (08:13 +0200)]
Remove reference to specific WSC version in `README.md`

3 years agoSupport for lazy loading of rich embeds
Alexander Ebert [Fri, 14 May 2021 15:55:13 +0000 (17:55 +0200)]
Support for lazy loading of rich embeds

3 years agoThe title of rich embeds can now span two lines
Alexander Ebert [Fri, 14 May 2021 15:27:09 +0000 (17:27 +0200)]
The title of rich embeds can now span two lines

3 years agoIgnore duplicate key errors when creating a legacy session
Tim Düsterhus [Fri, 14 May 2021 11:44:55 +0000 (13:44 +0200)]
Ignore duplicate key errors when creating a legacy session

Fixes #4214

3 years agoMerge branch '5.3'
Matthias Schmidt [Fri, 14 May 2021 11:18:18 +0000 (13:18 +0200)]
Merge branch '5.3'

3 years agoFix attachment ids in metacode elements during import (#4213)
Matthias Schmidt [Fri, 14 May 2021 11:14:59 +0000 (13:14 +0200)]
Fix attachment ids in metacode elements during import (#4213)

* Fix attachment ids in metacode elements during import

Close #4212

* Update wcfsetup/install/files/lib/system/importer/AbstractAttachmentImporter.class.php

Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
Co-authored-by: Tim Düsterhus <duesterhus@woltlab.com>
3 years agoPreserve names of method arguments during inheritance
Matthias Schmidt [Fri, 14 May 2021 06:34:25 +0000 (08:34 +0200)]
Preserve names of method arguments during inheritance

Close #4211

3 years agoFix condition in `Dependency/Manager.isHiddenByDependencies()`
Matthias Schmidt [Fri, 14 May 2021 05:40:13 +0000 (07:40 +0200)]
Fix condition in `Dependency/Manager.isHiddenByDependencies()`

The checked node is considered hidden, if it (`node`) is in a hidden node (`hiddenNode`) .
The variables were mixed up in this condition during the transition to TypeScript.

3 years agoUpdating minified JavaScript files
WoltLab [Wed, 12 May 2021 13:38:12 +0000 (13:38 +0000)]
Updating minified JavaScript files

3 years agoAdd .gitignore for sourcemaps
Tim Düsterhus [Wed, 12 May 2021 13:11:13 +0000 (15:11 +0200)]
Add .gitignore for sourcemaps

3 years agoGenerate sourcemaps for WoltLabSuite.Core bundles
Tim Düsterhus [Fri, 30 Apr 2021 10:17:45 +0000 (12:17 +0200)]
Generate sourcemaps for WoltLabSuite.Core bundles

3 years agoIncorrect file path
Alexander Ebert [Wed, 12 May 2021 13:01:24 +0000 (15:01 +0200)]
Incorrect file path

3 years agoUse new instead of deprecated popover data attribute for mentions
Matthias Schmidt [Wed, 12 May 2021 11:19:00 +0000 (13:19 +0200)]
Use new instead of deprecated popover data attribute for mentions

See #3318

3 years agoUse BCrypt costs '9' for MFA backup codes
Tim Düsterhus [Wed, 12 May 2021 10:28:42 +0000 (12:28 +0200)]
Use BCrypt costs '9' for MFA backup codes

Resolves #4206

3 years agoAllow adjusting the '$cost' parameter for BCrypt hashes
Tim Düsterhus [Wed, 12 May 2021 10:25:42 +0000 (12:25 +0200)]
Allow adjusting the '$cost' parameter for BCrypt hashes

3 years agoAdd note regarding the upgrade from 5.4.0 Alpha 2 to package.xml
Tim Düsterhus [Wed, 12 May 2021 10:13:27 +0000 (12:13 +0200)]
Add note regarding the upgrade from 5.4.0 Alpha 2 to package.xml

3 years agoDo not change the userID of legacy sessions during update
Tim Düsterhus [Wed, 12 May 2021 09:49:52 +0000 (11:49 +0200)]
Do not change the userID of legacy sessions during update

This causes issues when combined with the `hideSession` parameter of
SessionHandler::changeUser() and is not required, because an existing session
will *never* change its userID.

1. During login (changing user to non-guest)
the previous user's session will be deleted together with the legacy session
matching the sessionID, a new session will be created, its assigned legacy
session will be deleted, then the userID will be adjusted and the session
reloaded, thus creating a legacy session with the appropriate userID (or
re-using an existing one of that newly logged-in user). The legacy session of
the previous user will never be reused as the legacy session for the new user.

2. During logout (changing user to guest)
the previous user session will simply be deleted together with the legacy
session matching the sessionID. A new session + legacy session for the guest
will be created for the next request. The legacy session of the user will never
be reused as the legacy session for the guest.

Resolves WoltLab/com.woltlab.pluginStore#39

3 years agoMerge branch '5.3'
Matthias Schmidt [Wed, 12 May 2021 08:41:26 +0000 (10:41 +0200)]
Merge branch '5.3'

3 years agoDo not delete media files if file is replaced with itself
Matthias Schmidt [Wed, 12 May 2021 08:31:10 +0000 (10:31 +0200)]
Do not delete media files if file is replaced with itself

3 years agoDo not open media manager dialog after replacing media file
Matthias Schmidt [Wed, 12 May 2021 08:23:58 +0000 (10:23 +0200)]
Do not open media manager dialog after replacing media file

… and always reload the media list page in the ACP after editing/replacing media file to ensure updated data.

3 years agoMerge branch '5.3'
Matthias Schmidt [Wed, 12 May 2021 07:49:01 +0000 (09:49 +0200)]
Merge branch '5.3'

3 years agoMerge branch '5.2' into 5.3
Matthias Schmidt [Wed, 12 May 2021 07:37:34 +0000 (09:37 +0200)]
Merge branch '5.2' into 5.3

3 years agoMerge branch '3.1' into 5.2
Matthias Schmidt [Wed, 12 May 2021 07:37:16 +0000 (09:37 +0200)]
Merge branch '3.1' into 5.2

3 years agoMerge pull request #4209 from WoltLab/comment_moderation_queue
Matthias Schmidt [Wed, 12 May 2021 07:33:29 +0000 (09:33 +0200)]
Merge pull request #4209 from WoltLab/comment_moderation_queue

Delete moderation queue entries after deleting comments/comment responses

3 years agoUse `InvalidObjectArgument` in more places (#4207)
Matthias Schmidt [Tue, 11 May 2021 17:14:40 +0000 (19:14 +0200)]
Use `InvalidObjectArgument` in more places (#4207)

3 years agoDelete moderation queue entries after deleting comments/comment responses
Matthias Schmidt [Tue, 11 May 2021 17:13:21 +0000 (19:13 +0200)]
Delete moderation queue entries after deleting comments/comment responses

Close #4208

3 years agoAdd missing `$definitionName` value for comment response moderation queue handlers
Matthias Schmidt [Tue, 11 May 2021 17:11:03 +0000 (19:11 +0200)]
Add missing `$definitionName` value for comment response moderation queue handlers

3 years agoPrevent invalid or done IPN from being sent again
Marcel Werk [Tue, 11 May 2021 15:53:49 +0000 (17:53 +0200)]
Prevent invalid or done IPN from being sent again

3 years agoBad package version 5.4.0_Alpha_2
Alexander Ebert [Tue, 11 May 2021 14:39:29 +0000 (16:39 +0200)]
Bad package version

3 years agoRelease 5.4.0 Alpha 2
Alexander Ebert [Tue, 11 May 2021 14:23:15 +0000 (16:23 +0200)]
Release 5.4.0 Alpha 2