GitHub/LineageOS/android_kernel_motorola_exynos9610.git
11 years agostaging: comedi: dt2814: remove disabled irq probe code
H Hartley Sweeten [Tue, 26 Nov 2013 17:21:28 +0000 (10:21 -0700)]
staging: comedi: dt2814: remove disabled irq probe code

The irq probe code in dt2814_attach() is disabled by an #if 0 block.
Just remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: c6xdigio: remove unnecessary c6xdigio_pwmo_insn_read()
H Hartley Sweeten [Tue, 26 Nov 2013 17:21:27 +0000 (10:21 -0700)]
staging: comedi: c6xdigio: remove unnecessary c6xdigio_pwmo_insn_read()

The pwm subdevice in this driver sets the subdev_flags to SDF_WRITEABLE
so the s->insn_read callback is not needed. Since this callback simply
outputs a printk(KERN_DEBUG ... message jsut remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcmmio: convert a KERN_DEBUG message to dev_dbg()
H Hartley Sweeten [Tue, 26 Nov 2013 17:21:26 +0000 (10:21 -0700)]
staging: comedi: pcmmio: convert a KERN_DEBUG message to dev_dbg()

Convert a printk(KERN_DEBUG ... message to dev_dbg().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dyna_pci10xx: convert a KERN_DEBUG message to dev_dbg()
H Hartley Sweeten [Tue, 26 Nov 2013 17:21:25 +0000 (10:21 -0700)]
staging: comedi: dyna_pci10xx: convert a KERN_DEBUG message to dev_dbg()

Convert a printk(KERN_DEBUG ... message to dev_dbg().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcmmio: remove commented out debug code
H Hartley Sweeten [Tue, 26 Nov 2013 17:21:24 +0000 (10:21 -0700)]
staging: comedi: pcmmio: remove commented out debug code

Remove the commented out code in init_asics() that enables the rising
edge interrupts on port0 of both asics.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcmmio: remove DAMMIT_ITS_BROKEN debug
H Hartley Sweeten [Tue, 26 Nov 2013 17:21:23 +0000 (10:21 -0700)]
staging: comedi: pcmmio: remove DAMMIT_ITS_BROKEN debug

These debug messages are just added noise. Remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: ni_pcimio: remove PCI_DEBUG
H Hartley Sweeten [Tue, 26 Nov 2013 17:21:22 +0000 (10:21 -0700)]
staging: comedi: ni_pcimio: remove PCI_DEBUG

This define is not used in the driver. Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: cb_pcimdas: remove CBPCIMDAS_DEBUG
H Hartley Sweeten [Tue, 26 Nov 2013 17:21:21 +0000 (10:21 -0700)]
staging: comedi: cb_pcimdas: remove CBPCIMDAS_DEBUG

This define is not used in the driver. Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: ni_at_a2150: remove A2150_DEBUG
H Hartley Sweeten [Tue, 26 Nov 2013 17:21:20 +0000 (10:21 -0700)]
staging: comedi: ni_at_a2150: remove A2150_DEBUG

The A2150_DEBUG define enables some development messages, specifically
the ni_dum_regs() function. These messages are just added noise. Remove
them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: gsc_hpdi: remove DEBUG_PRINT
H Hartley Sweeten [Tue, 26 Nov 2013 17:21:19 +0000 (10:21 -0700)]
staging: comedi: gsc_hpdi: remove DEBUG_PRINT

The DEBUG_PRINT macro in this driver is used to output development
debug tracing messages. These messages are just added noise. Remove
them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: cb_pcidas64: remove DEBUG_PRINT
H Hartley Sweeten [Tue, 26 Nov 2013 17:21:18 +0000 (10:21 -0700)]
staging: comedi: cb_pcidas64: remove DEBUG_PRINT

The DEBUG_PRINT macro in this driver is used to output development
debug tracing messages. These messages are just added noise. Remove
them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: mite: remove DEBUG_MITE code
H Hartley Sweeten [Tue, 26 Nov 2013 17:21:17 +0000 (10:21 -0700)]
staging: comedi: mite: remove DEBUG_MITE code

The code protected by the DEBUG_MITE define outputs some development
debug information. This information is just added noise in the final
driver. Remove the code.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: mite: remove MDPRINTK macro
H Hartley Sweeten [Tue, 26 Nov 2013 17:21:16 +0000 (10:21 -0700)]
staging: comedi: mite: remove MDPRINTK macro

This macro is used by the comedi drivers that usee the mite module to
output development function trace messages. These are just added noise.
Remove the messages as well as the macro.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: remove DPRINTK macro
H Hartley Sweeten [Tue, 26 Nov 2013 17:21:15 +0000 (10:21 -0700)]
staging: comedi: remove DPRINTK macro

All users of this macro have been converted to use dev_dbg(). Remove
the unused macro.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: ni_pcidio: remove use of DPRINTK
H Hartley Sweeten [Tue, 26 Nov 2013 17:21:14 +0000 (10:21 -0700)]
staging: comedi: ni_pcidio: remove use of DPRINTK

Remove the DPRINTK messages that are just function trace noise.

Use dev_dbg() instead of the DPRINTK macro to output the comedi
debugging information.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: ni_pcidio: remove debug_int()
H Hartley Sweeten [Tue, 26 Nov 2013 17:21:13 +0000 (10:21 -0700)]
staging: comedi: ni_pcidio: remove debug_int()

This function is not used by the driver. Just remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: ni_pcidio: remove DEBUG_FLAGS define and code
H Hartley Sweeten [Tue, 26 Nov 2013 17:21:12 +0000 (10:21 -0700)]
staging: comedi: ni_pcidio: remove DEBUG_FLAGS define and code

The DEBUG_FLAGS define enables some development code that outputs
interrupt flags and status information in the interrupt handler.
This information is just added noise. Remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: comedi_fops: remove use of DPRINTK
H Hartley Sweeten [Tue, 26 Nov 2013 17:21:11 +0000 (10:21 -0700)]
staging: comedi: comedi_fops: remove use of DPRINTK

Use dev_dbg(), or pr_debug() when dev is not valid, instead of the
DPRINTK macro to output the comedi debugging information.

Remove the debug messages for allocation failures. The failure will
have already generated a message.

Reword the messages that include the dev->minor number. This number
will already be displayed as part of the dev_dbg() output.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/mdt: HSM coordinator client interface
JC Lafoucriere [Tue, 26 Nov 2013 02:05:01 +0000 (10:05 +0800)]
staging/lustre/mdt: HSM coordinator client interface

This patch implements the HSM coordinator methods
used by client to add/remove/list HSM actions on
FID.

Lustre-change: http://review.whamcloud.com/6532
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3341
Signed-off-by: JC Lafoucriere <jacques-charles.lafoucriere@cea.fr>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Jinshan Xiong <jinshan.xiong@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/lu: shrink lu_object by 8 bytes on x86_64
John L. Hammond [Tue, 26 Nov 2013 02:05:00 +0000 (10:05 +0800)]
staging/lustre/lu: shrink lu_object by 8 bytes on x86_64

Remove the lo_depth member from struct lu_object.  This field is never
set and only read in lu_object_print().  Remove the lo_flags member.
This field was only used in lu_object_alloc() and can be replaced with
an on-stack mask to keep trace of which layers have been allocated.

Lustre-change: http://review.whamcloud.com/5890
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3059
Signed-off-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/ptlrpc: Fix race during exp_flock_hash creation
Andriy Skulysh [Tue, 26 Nov 2013 02:04:58 +0000 (10:04 +0800)]
staging/lustre/ptlrpc: Fix race during exp_flock_hash creation

During race exp_flock_hash can be created 2 times.
It is created & assigned without any lock.

Move hash initialization from ldlm_flock_blocking_link()
to ldlm_init_export()

Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2835
Lustre-change: http://review.whamcloud.com/5471
Signed-off-by: Andriy Skulysh <Andriy_Skulysh@xyratex.com>
Reviewed-by: Alexander Boyko <Alexander_Boyko@xyratex.com>
Reviewed-by: Vitaly Fertman <Vitaly_Fertman@xyratex.com>
Tested-by: Kyrylo Shatskyy <kyrylo_shatskyy@xyratex.com>
Reviewed-by: Keith Mannthey <keith.mannthey@intel.com>
Reviewed-by: Prakash Surya <surya1@llnl.gov>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/mdc: prevent fall through in mdc_iocontrol()
John L. Hammond [Tue, 26 Nov 2013 02:04:59 +0000 (10:04 +0800)]
staging/lustre/mdc: prevent fall through in mdc_iocontrol()

In mdc_iocontrol() add a goto to the end of the LL_IOC_HSM_STATE_SET
case, preventing fall through into the next case. In the same
function, replace the return statement in OBD_IOC_QUOTACTL with a
goto, so that a reference to the module is not leaked.

Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3576
Lustre-change: http://review.whamcloud.com/6962
Signed-off-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Aurelien Degremont <aurelien.degremont@cea.fr>
Reviewed-by: jacques-Charles Lafoucriere <jacques-charles.lafoucriere@cea.fr>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/nfs: writing to new files will return ENOENT
Patrick Farrell [Tue, 26 Nov 2013 02:04:57 +0000 (10:04 +0800)]
staging/lustre/nfs: writing to new files will return ENOENT

This happend with SLES11SP2 Lustre client, which in turn acts as an
NFS server, exporting a subtree of an Lustre fs through NFS.

We detected that whenever we are writing to a new file using, fx,
'echo blah > newfile', it will return ENOENT error. We found
out that this was caused by the anonymous dentry. In SLESS11SP2,
anonymous dentries are assigned '/' as the name, instead of an
empty string. When MDT handles the intent_open call, it will look
up the obj by the name if it is not an empty string, and thus
couldn't find it.

As MDS_OPEN_BY_FID is always set on this request, we never need
to send the name in this request.  The fid is already available
and should be used in case the file has been renamed.

Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3544
Lustre-change: http://review.whamcloud.com/6920
Signed-off-by: Cheng Shao <cheng_shao@xyratex.com>
Signed-off-by: Patrick Farrell <paf@cray.com>
Reviewed-by: Bob Glossman <bob.glossman@intel.com>
Reviewed-by: Alexey Shvetsov <alexxy@gentoo.org>
Reviewed-by: Lai Siyao <lai.siyao@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/server: use unified request handler for MGS
Mikhail Pershin [Tue, 26 Nov 2013 02:04:55 +0000 (10:04 +0800)]
staging/lustre/server: use unified request handler for MGS

- Unify request handler. It finds target for particular request and
  calls appropriate handler for it. Generic handlers are moved to
  the unified target code. The tgt_session_info is introduced to
  store all request-related data and passed to all handlers.
- Pack reply in llog server functions early and use err_serious()
- remove obsoleted llog_origin_handle_cancel(), it is not used
  anymore
- remove push_ctxt/pop_ctxt from llog server function, it is based
  on OSD now.

Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2145
Lustre-change: http://review.whamcloud.com/4826
Signed-off-by: Mikhail Pershin <mike.pershin@intel.com>
Reviewed-by: Fan Yong <fan.yong@intel.com>
Reviewed-by: Alex Zhuravlev <alexey.zhuravlev@intel.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
Reviewed-by: James Simmons <uja.ornl@gmail.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: Remove unused variable bAES.
Malcolm Priestley [Mon, 25 Nov 2013 22:18:31 +0000 (22:18 +0000)]
staging: vt6656: Remove unused variable bAES.

bAES flips from false to true but doesn't do anything.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: Remove unused variable bLongHeader
Malcolm Priestley [Mon, 25 Nov 2013 22:14:16 +0000 (22:14 +0000)]
staging: vt6656: Remove unused variable bLongHeader

Remove dead bLongHeader code.

In s_vFillTxKey use ieee80211_has_a4 to detect long headers for future use.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre: fix build error on i386-randconfig
Peng Tao [Tue, 26 Nov 2013 01:23:57 +0000 (09:23 +0800)]
staging/lustre: fix build error on i386-randconfig

kbuild test robot reported:

All error/warnings:

   In file included from drivers/staging/lustre/lustre/llite/llite_internal.h:41:0,
                    from drivers/staging/lustre/lustre/llite/dcache.c:48:
>> drivers/staging/lustre/lustre/llite/../include/lustre_disk.h:499:28: error: field 'lsi_bdi' has incomplete type
     struct backing_dev_info   lsi_bdi;     /* each client mountpoint needs
                               ^
--
   In file included from drivers/staging/lustre/lustre/llite/llite_lib.c:51:0:
>> drivers/staging/lustre/lustre/llite/../include/lustre_disk.h:499:28: error: field 'lsi_bdi' has incomplete type
     struct backing_dev_info   lsi_bdi;     /* each client mountpoint needs
                               ^
   drivers/staging/lustre/lustre/llite/llite_lib.c: In function 'll_bdi_register':
>> drivers/staging/lustre/lustre/llite/llite_lib.c:953:5: error: dereferencing pointer to incomplete type
     bdi->name = "lustre";
        ^
>> drivers/staging/lustre/lustre/llite/llite_lib.c:954:2: error: implicit declaration of function 'bdi_register' [-Werror=implicit-function-declaration]
     return bdi_register(bdi, NULL, "lustre-%d",
     ^
   drivers/staging/lustre/lustre/llite/llite_lib.c: In function 'll_fill_super':
>> drivers/staging/lustre/lustre/llite/llite_lib.c:990:2: error: implicit declaration of function 'bdi_init' [-Werror=implicit-function-declaration]
     err = bdi_init(&lsi->lsi_bdi);
     ^
>> drivers/staging/lustre/lustre/llite/llite_lib.c:994:30: error: 'BDI_CAP_MAP_COPY' undeclared (first use in this function)
     lsi->lsi_bdi.capabilities = BDI_CAP_MAP_COPY;
                                 ^
   drivers/staging/lustre/lustre/llite/llite_lib.c:994:30: note: each undeclared identifier is reported only once for each function it appears in
   drivers/staging/lustre/lustre/llite/llite_lib.c: In function 'll_put_super':
>> drivers/staging/lustre/lustre/llite/llite_lib.c:1101:3: error: implicit declaration of function 'bdi_destroy' [-Werror=implicit-function-declaration]
      bdi_destroy(&lsi->lsi_bdi);
      ^
   cc1: some warnings being treated as errors

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoMerge tag 'iio-for-3.14a' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23...
Greg Kroah-Hartman [Tue, 26 Nov 2013 02:42:40 +0000 (18:42 -0800)]
Merge tag 'iio-for-3.14a' of git://git./linux/kernel/git/jic23/iio into staging-next

Jonathan writes:

First set of new features, drivers and cleanups for IIO in the 3.14 cycle.
This mostly consists of patches that didn't quite make the last cycle. Lots
of interesting things under review currently.

Core:
- Add devm_iio_device_register/unregister.  I took some convincing on whether
  there would be many devices that really were simple enough to need no
  explicit actions on removal.  Turns out there are some.
- Move some stray docs to above the relevant implemenation.
- Drop a redundant repeated check on the fact the trigger has actually changed
  when there is a userspace attempt change it.

Drivers:
New drivers
- Freescale MPL3115A2 Pressure / temperature sensor

New functionality
- hid_sensors: add sensitivity support.

DT bindings
- tsl2563
- hmc5843

Cleanups
- Drop unused scan_type from viperboard adc driver.
- devm_iio_device_register used in viperboard, ad5421, ad5755, adis16130,
  adxrs450, vcnl4000, adis16220, ad7816, lpc32xx, adt7316, adis16060, isl29018
  and ad2s1200.  Note that this was proposed in a number of other drivers
  and this revealed a number of missorderings in remove functions.  Also for
  now I have blocked this on any device that any hardware suspend suport on
  the basis that we probably want to power down devices if they have no driver
  support loaded.

11 years agostaging: rts5208: add support for rts5208 and rts5288
Micky Ching [Tue, 12 Nov 2013 09:16:08 +0000 (17:16 +0800)]
staging: rts5208: add support for rts5208 and rts5288

There are still many rts5208/5288 card readers being used, but no
drivers are supported them in kernel now. This driver can make a
great convenience for people who use them.

Many other rts-series card reader are supported by mfd driver, but due
to much difference with others, rts5208/5288 can not add into mfd driver
pretty now, so we provide a separated driver here to support the device.

Signed-off-by: Micky Ching <micky_ching@realsil.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: ft1000: fix uninitialized return variable in request_code_segment
Adam Lee [Mon, 25 Nov 2013 07:07:36 +0000 (15:07 +0800)]
staging: ft1000: fix uninitialized return variable in request_code_segment

The return variable of request_code_segment() is used uninitialized if
the argument boot_case is false, this patch fixes it.

FYI, in ft1000_usb.h: STATUS_SUCCESS 0, and STATUS_FAILURE 0x1001.

Signed-off-by: Adam Lee <adam8157@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: vnt_beacon_buffer attach mac header.
Malcolm Priestley [Sun, 24 Nov 2013 13:27:32 +0000 (13:27 +0000)]
staging: vt6656: vnt_beacon_buffer attach mac header.

Attach ieee80211_hdr to vnt_beacon_buffer and remove pointer arithmetic.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: csBeacon_xmit merge structures.
Malcolm Priestley [Sun, 24 Nov 2013 13:25:25 +0000 (13:25 +0000)]
staging: vt6656: csBeacon_xmit merge structures.

Merge structures typedef struct tagSTxShortBufHead and the members of
struct vnt_tx_datahead_ab to form single structure vnt_tx_short_buf_head.

Remove the duplicate members in struct vnt_beacon_buffer already in
typedef struct tagSTxShortBufHead.

This removes the need for any pointer arithmetic.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6656: Remove always 0 variable dwDiagRefCount
Malcolm Priestley [Sun, 24 Nov 2013 11:51:49 +0000 (11:51 +0000)]
staging: vt6656: Remove always 0 variable dwDiagRefCount

Remove > 0 code.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/obdclass: add empty tailing member to ctl_table
Peng Tao [Thu, 21 Nov 2013 14:42:46 +0000 (22:42 +0800)]
staging/lustre/obdclass: add empty tailing member to ctl_table

This was mistakenly removed by commit 7fb3d1c5.
Now register_sysctl_table() complains about "No proc_handler".

Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/libcfs: remove LI_POISON
Peng Tao [Thu, 21 Nov 2013 14:28:31 +0000 (22:28 +0800)]
staging/lustre/libcfs: remove LI_POISON

The extactly same definition exitst in lustre_lib.h.

Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre: remove CFS_MODULE_PARM
Peng Tao [Thu, 21 Nov 2013 14:28:30 +0000 (22:28 +0800)]
staging/lustre: remove CFS_MODULE_PARM

Patch generated by coccinelle:

@generic_type@
declarer name CFS_MODULE_PARM;
declarer name module_param;
declarer name MODULE_PARM_DESC;
expression E1, E2, E3, E4;
type t;
@@
-CFS_MODULE_PARM(E1, E2, t, E3, E4);
+module_param(E1, t, E3);
+MODULE_PARM_DESC(E1, E4);

@charp@
expression E1, E2, E3, E4, E5;
@@
-CFS_MODULE_PARM(E1, E2, E3, E4, E5);
+module_param(E1, E3, E4);
+MODULE_PARM_DESC(E1, E5);

With manual modification to remove CFS_MODULE_PARM definition and
fix up checkpatch.pl warnnings.

Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/libcfs: remove lwt code
Peng Tao [Thu, 21 Nov 2013 14:28:29 +0000 (22:28 +0800)]
staging/lustre/libcfs: remove lwt code

It was never enabled.

Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/libcfs: remove linux-fs.h
Peng Tao [Thu, 21 Nov 2013 14:28:28 +0000 (22:28 +0800)]
staging/lustre/libcfs: remove linux-fs.h

Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/libcfs: remove flock wrappers
Peng Tao [Thu, 21 Nov 2013 14:28:27 +0000 (22:28 +0800)]
staging/lustre/libcfs: remove flock wrappers

Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre: move IFTODT/DTTOIF to lustre_idl.h
Peng Tao [Thu, 21 Nov 2013 14:28:26 +0000 (22:28 +0800)]
staging/lustre: move IFTODT/DTTOIF to lustre_idl.h

They are in fact definition of how client/server talks
to each other about file type.

Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/libcfs: remove filp_write
Peng Tao [Thu, 21 Nov 2013 14:28:25 +0000 (22:28 +0800)]
staging/lustre/libcfs: remove filp_write

Use vfs_write instead and call kmap/kunmap to ensure
that we can access high memory zone.

Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/libcfs: remove filp_read
Peng Tao [Thu, 21 Nov 2013 14:28:24 +0000 (22:28 +0800)]
staging/lustre/libcfs: remove filp_read

no users.

Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/libcfs: remove filp_fsync
Peng Tao [Thu, 21 Nov 2013 14:28:23 +0000 (22:28 +0800)]
staging/lustre/libcfs: remove filp_fsync

we can just call generic vfs_fsync().

Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/lustre/libcfs: remove filp_size/filp_poff
Peng Tao [Thu, 21 Nov 2013 14:28:22 +0000 (22:28 +0800)]
staging/lustre/libcfs: remove filp_size/filp_poff

Cc: Andreas Dilger <andreas.dilger@intel.com>
Signed-off-by: Peng Tao <bergwolf@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: gdm724x: fix leak at failure path in gdm_usb_probe()
Alexey Khoroshilov [Fri, 15 Nov 2013 20:46:24 +0000 (00:46 +0400)]
staging: gdm724x: fix leak at failure path in gdm_usb_probe()

Error handling code in gdm_usb_probe() deallocates all resources,
but calls usb_get_dev(usbdev) and returns error code after that.

The patch fixes it and, by the way, several other issues:
- no need to use GFP_ATOMIC in probe();
- return -ENODEV instead of -1;
- kmalloc+memset -> kzalloc

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dwc2: remove some indent levels
Dan Carpenter [Mon, 25 Nov 2013 14:14:14 +0000 (17:14 +0300)]
staging: dwc2: remove some indent levels

Instead of writing code like:

if (dwc2_qh_is_non_per(qh)) {
...
} else {
...
}
return;

write it like:

if (dwc2_qh_is_non_per(qh)) {
...
return;
}
...

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dwc2: cleanups in dwc2_hcd_qh_add()
Dan Carpenter [Mon, 25 Nov 2013 14:11:29 +0000 (17:11 +0300)]
staging: dwc2: cleanups in dwc2_hcd_qh_add()

I've made the success and error paths clearer and pulled some code in
one indent level.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dwc2: remove #ifdef DEBUG from a couple of places
Paul Zimmerman [Sat, 23 Nov 2013 00:43:52 +0000 (16:43 -0800)]
staging: dwc2: remove #ifdef DEBUG from a couple of places

Remove #ifdef DEBUG from a couple of places where it is not needed

Signed-off-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dwc2: rename dwc2_check_core_status()
Paul Zimmerman [Sat, 23 Nov 2013 00:43:51 +0000 (16:43 -0800)]
staging: dwc2: rename dwc2_check_core_status()

Rename dwc2_check_core_status() to dwc2_is_controller_alive(), and
make it a boolean function. Also change the message when the
controller is dead to say "dead" instead of "disconnected".

Signed-off-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dwc2: remove useless cast
Paul Zimmerman [Sat, 23 Nov 2013 00:43:50 +0000 (16:43 -0800)]
staging: dwc2: remove useless cast

Remove useless cast in dwc2_get_otg_version()

Signed-off-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dwc2: remove use of NO_FS_PHY_HW_CHECKS macro
Paul Zimmerman [Sat, 23 Nov 2013 00:43:49 +0000 (16:43 -0800)]
staging: dwc2: remove use of NO_FS_PHY_HW_CHECKS macro

NO_FS_PHY_HW_CHECKS is never defined, so remove the conditional
code that checks for it being set

Signed-off-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dwc2: make all the dwc2_set_param* functions void
Paul Zimmerman [Sat, 23 Nov 2013 00:43:48 +0000 (16:43 -0800)]
staging: dwc2: make all the dwc2_set_param* functions void

We were not checking the return value from any of these functions,
so make them void functions

Signed-off-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dwc2: rename DWC2_PARAM_TEST to DWC2_OUT_OF_BOUNDS
Paul Zimmerman [Sat, 23 Nov 2013 00:43:47 +0000 (16:43 -0800)]
staging: dwc2: rename DWC2_PARAM_TEST to DWC2_OUT_OF_BOUNDS

DWC2_PARAM_TEST is not a very good name for this macro, so rename
it to DWC2_OUT_OF_BOUNDS

Signed-off-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dwc2: fix potential use after free
Paul Zimmerman [Sat, 23 Nov 2013 00:43:46 +0000 (16:43 -0800)]
staging: dwc2: fix potential use after free

dwc2_process_non_isoc_desc() can potentially free the qtd, so null
out the qtd pointer if the call fails so we don't try to access it
later

Signed-off-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dwc2: fix some functions to return a proper error code
Paul Zimmerman [Sat, 23 Nov 2013 00:43:45 +0000 (16:43 -0800)]
staging: dwc2: fix some functions to return a proper error code

Fix some functions called by dwc2_hcd_qtd_add() to return either
a proper error code or 0, instead of somewhat random values.
Then change the caller of dwc2_hcd_qtd_add() to just check the
return value for 0.

Signed-off-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dwc2: add check on dwc2_core_reset return
Julien DELACOU [Wed, 20 Nov 2013 16:29:49 +0000 (17:29 +0100)]
staging: dwc2: add check on dwc2_core_reset return

If the GRSTCTL_CSFTRST self-clearing bit never comes
back to 0 for any reason, the controller is under reset
state and cannot be used. It's preferable to abort
initialization in such case.

Signed-off-by: Julien Delacou <julien.delacou@st.com>
Acked-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: dwc2: do not clear pending interrupts twice
Julien DELACOU [Fri, 15 Nov 2013 10:39:38 +0000 (11:39 +0100)]
staging: dwc2: do not clear pending interrupts twice

Pending interrupts clearing is done in dwc2_enable_common_interrupts
so we don't need to do it twice.

Signed-off-by: Julien Delacou <julien.delacou@st.com>
Acked-by: Paul Zimmerman <paulz@synopsys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging r8712u: Remove useless netdev_info slowly polluting dmesg
Alexandre Demers [Wed, 13 Nov 2013 04:56:22 +0000 (23:56 -0500)]
staging r8712u: Remove useless netdev_info slowly polluting dmesg

Remove useless netdev_info slowly flooding dmesg.
Fixes bug https://bugzilla.kernel.org/show_bug.cgi?id=64231

Signed-off-by: Alexandre Demers <alexandre.f.demers@gmail.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt2801: remove use of DPRINTK
H Hartley Sweeten [Fri, 22 Nov 2013 17:47:20 +0000 (10:47 -0700)]
staging: comedi: dt2801: remove use of DPRINTK

The DPRINTK messages in this driver are just added noise.
Remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: amplc_pci230: remove use of DPRINTK
H Hartley Sweeten [Fri, 22 Nov 2013 17:47:01 +0000 (10:47 -0700)]
staging: comedi: amplc_pci230: remove use of DPRINTK

Use dev_dbg() instead of the DPRINTK macro to output the comedi
debugging information.

The dev_dbg() will prefix the messages appropriately so remove the
"comedi%d: amplc_pci230: " portion and use __func__ to show the
actual function name for debugging.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: amplc_pci224: remove use of DPRINTK
H Hartley Sweeten [Fri, 22 Nov 2013 17:46:42 +0000 (10:46 -0700)]
staging: comedi: amplc_pci224: remove use of DPRINTK

Use dev_dbg() instead of the DPRINTK macro to output the comedi
debugging information.

The dev_dbg() will prefix the messages appropriately so remove the
"comedi%d: " DRIVER_NAME portion and use __func__ to show the actual
function name for debugging.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl816: remove use of DPRINTK
H Hartley Sweeten [Fri, 22 Nov 2013 17:46:21 +0000 (10:46 -0700)]
staging: comedi: pcl816: remove use of DPRINTK

Remove the DPRINTK messages that are just function trace noise.

Use dev_dbg() instead of the DPRINTK macro to output the comedi
debugging information.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: range: remove use of DPRINTK
H Hartley Sweeten [Fri, 22 Nov 2013 17:45:58 +0000 (10:45 -0700)]
staging: comedi: range: remove use of DPRINTK

Use dev_dbg() instead of the DPRINTK macro to output the comedi
debugging information.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: remove comedi_debug module parameter
H Hartley Sweeten [Fri, 22 Nov 2013 17:45:38 +0000 (10:45 -0700)]
staging: comedi: remove comedi_debug module parameter

Remove this module parameter and use the CONFIG_COMEDI_DEBUG option to
enable normal kernel debugging with -DDEBUG flag.

Remove the #undef DEBUG from all the comedi source files so they will
honour the -DDEBUG flag.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt3000: remove DEBUG define
H Hartley Sweeten [Fri, 22 Nov 2013 17:45:18 +0000 (10:45 -0700)]
staging: comedi: dt3000: remove DEBUG define

This define unables some debug code that prints the status flags
during the interrupt handler. These messages are just added noise
and it's probably not a good idea to spew them during the interrupt
anyway.

Remove the DEBUG define as well as the debug code.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: ni_pcidio: remove DEBUG define
H Hartley Sweeten [Fri, 22 Nov 2013 17:44:58 +0000 (10:44 -0700)]
staging: comedi: ni_pcidio: remove DEBUG define

This define is only used to enable some debug messages during the
board attach. These are just added noise, remove them as well as
the DEBUG define.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: ni_pcidio: remove DEBUG and DEBUG_FLAGS defines
H Hartley Sweeten [Fri, 22 Nov 2013 17:44:31 +0000 (10:44 -0700)]
staging: comedi: ni_pcidio: remove DEBUG and DEBUG_FLAGS defines

These defines are not used in the driver. Remove them.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: ni_pcidio: remove custom DPRINTK macro
H Hartley Sweeten [Fri, 22 Nov 2013 17:43:17 +0000 (10:43 -0700)]
staging: comedi: ni_pcidio: remove custom DPRINTK macro

The comedi core defines a DPRINTK macro in comedidev.h. Use that macro
instead of defining a private version in this driver.

Also, remove the DEBUG define since it was only used to enable the
DPRINTK macro.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: fl512: remove DEBUG define
H Hartley Sweeten [Fri, 22 Nov 2013 17:42:55 +0000 (10:42 -0700)]
staging: comedi: fl512: remove DEBUG define

This define is not used by the driver. Just remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt282x: remove DEBUG define
H Hartley Sweeten [Fri, 22 Nov 2013 17:42:34 +0000 (10:42 -0700)]
staging: comedi: dt282x: remove DEBUG define

This define is only used to enable a debug message during the board attach.
The message is just added noise, remove it as well as the DEBUG define.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: pcl816: remove DEBUG macro
H Hartley Sweeten [Fri, 22 Nov 2013 17:42:10 +0000 (10:42 -0700)]
staging: comedi: pcl816: remove DEBUG macro

This macro is only used to output some function tracing debug messages.
These messages are just added noise so remove the DEBUG macro as well
as the noise.

Also, remove pcl816_cmdtest_out() which was only called as part of the
DEBUG() in pcl816_ai_cmdtest().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: das6402: remove DEBUG noise
H Hartley Sweeten [Fri, 22 Nov 2013 17:41:39 +0000 (10:41 -0700)]
staging: comedi: das6402: remove DEBUG noise

The private data does not contain 'das6402_irqcount' or 'das6402_wordsread'
members so the printk noise produces build errors when DEBUG is defined.
The other printk is just added noise.

Remove the printk's to fix the build errors and remove the noise.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: comedi: remove MACRO pr_fmt in unioxx5.c
Conrad Gomes [Thu, 21 Nov 2013 19:57:58 +0000 (01:27 +0530)]
Staging: comedi: remove MACRO pr_fmt in unioxx5.c

This patch removes MACRO definition pr_fmt which was initially
required by pr_info and pr_err logging functions.

Signed-off-by: Conrad Gomes <conrad.s.j.gomes@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: comedi: change pr_err to dev_err in __unioxx5_analog_write
Conrad Gomes [Thu, 21 Nov 2013 19:57:57 +0000 (01:27 +0530)]
Staging: comedi: change pr_err to dev_err in __unioxx5_analog_write

This is a patch which subsitutes pr_err with the preferred dev_err
for device drivers in __unioxx5_analog_write.

The function definition of __unioxx5_analog_write has been changed
to take the pointer to the struct comedi_subdevice as a parameter
instead of the pointer to struct unioxx5_subd_priv.

The pointers to the stuct device and the struct unioxx5_subd_priv are
obtained through the pointer to the struct comedi_subdevice in this
function.

The function call to __unioxx5_analog_write in unioxx5_subdev_write
has been changed to pass the pointer to the struct comedi_subdevice

Signed-off-by: Conrad Gomes <conrad.s.j.gomes@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: comedi: change pr_err to dev_err in __unioxx5_digital_write
Conrad Gomes [Thu, 21 Nov 2013 19:57:56 +0000 (01:27 +0530)]
Staging: comedi: change pr_err to dev_err in __unioxx5_digital_write

This is a patch which subsitutes pr_err with the preferred dev_err
for device drivers in __unioxx5_digital_write.

The function definition of __unioxx5_digital_write has been changed
to take the pointer to the struct comedi_subdevice as a parameter
instead of the pointer to struct unioxx5_subd_priv.

The pointers to the stuct device and the struct unioxx5_subd_priv are
obtained through the pointer to the struct comedi_subdevice in this
function.

The function call to __unioxx5_digital_write in unioxx5_subdev_write
has been changed to pass the pointer to the struct comedi_subdevice

Signed-off-by: Conrad Gomes <conrad.s.j.gomes@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: comedi: change pr_err to dev_err in __unioxx5_analog_read
Conrad Gomes [Thu, 21 Nov 2013 19:57:55 +0000 (01:27 +0530)]
Staging: comedi: change pr_err to dev_err in __unioxx5_analog_read

This is a patch which subsitutes pr_err with dev_err in
__unioxx5_analog_read as it is the preferred way to log in device
drivers

Signed-off-by: Conrad Gomes <conrad.s.j.gomes@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: comedi: change printk to dev_err/dev_dbg in unioxx5.c
Conrad Gomes [Thu, 21 Nov 2013 19:57:54 +0000 (01:27 +0530)]
Staging: comedi: change printk to dev_err/dev_dbg in unioxx5.c

This is a patch which fixes coding style issues due to printk usage in
unioxx5.c found by checkpatch.pl in the following functions:
1) __unioxx5_digital_read
2) __unioxx5_analog_read
3) __unioxx5_digital_config

To subsitute printk with dev_err/dev_dbg, access to the struct device is
required. The function definitions of the above functions have been changed
to take the pointer to the struct comedi_subdevice as a parameter instead
of the pointer to struct unioxx5_subd_priv.

The pointers to the stuct device and the struct unioxx5_subd_priv are
obtained through the pointer to the struct comedi_subdevice in these functions.

The function calls of __unioxx5_digital_read and __unioxx5_analog_read in
unioxx5_subdev_read have been changed to pass the pointer to the struct
comedi_subdevice.

Signed-off-by: Conrad Gomes <conrad.s.j.gomes@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: comedi: fix line over 80 character warning in unioxx5.c
Conrad Gomes [Thu, 21 Nov 2013 19:57:53 +0000 (01:27 +0530)]
Staging: comedi: fix line over 80 character warning in unioxx5.c

This is a patch to fix a line over 80 character warning found by
checkpatch.pl in a comment. The comment was reworded to fix
the warning

Signed-off-by: Conrad Gomes <conrad.s.j.gomes@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: comedi: fix line over 80 character warning in unioxx5.c
Conrad Gomes [Thu, 21 Nov 2013 19:57:52 +0000 (01:27 +0530)]
Staging: comedi: fix line over 80 character warning in unioxx5.c

This is a patch to unioxx5.c that fixes the line over 80 character
warning found by checkpatch.pl by initializing n_subd before the
for loop

Signed-off-by: Conrad Gomes <conrad.s.j.gomes@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: iio: ad2s1200: Use devm_iio_device_register
Sachin Kamat [Tue, 29 Oct 2013 11:39:00 +0000 (11:39 +0000)]
staging: iio: ad2s1200: Use devm_iio_device_register

devm_iio_device_register simplifies the code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging: iio: isl29018: Use devm_iio_device_register
Sachin Kamat [Tue, 29 Oct 2013 11:39:00 +0000 (11:39 +0000)]
staging: iio: isl29018: Use devm_iio_device_register

devm_iio_device_register simplifies the code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging: iio: adis16060: Use devm_iio_device_register
Sachin Kamat [Tue, 29 Oct 2013 11:39:00 +0000 (11:39 +0000)]
staging: iio: adis16060: Use devm_iio_device_register

devm_iio_device_register simplifies the code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging: iio: addac: Use devm_iio_device_register
Sachin Kamat [Tue, 29 Oct 2013 11:39:00 +0000 (11:39 +0000)]
staging: iio: addac: Use devm_iio_device_register

devm_iio_device_register simplifies the code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging: iio: lpc32xx_adc: Use devm_iio_device_register
Sachin Kamat [Tue, 29 Oct 2013 11:39:00 +0000 (11:39 +0000)]
staging: iio: lpc32xx_adc: Use devm_iio_device_register

devm_iio_device_register simplifies the code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging: iio: ad7816: Use devm_iio_device_register
Sachin Kamat [Tue, 29 Oct 2013 11:39:00 +0000 (11:39 +0000)]
staging: iio: ad7816: Use devm_iio_device_register

devm_iio_device_register simplifies the code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging: iio: adis16220: Use devm_iio_device_register
Sachin Kamat [Tue, 29 Oct 2013 11:39:00 +0000 (11:39 +0000)]
staging: iio: adis16220: Use devm_iio_device_register

devm_iio_device_register simplifies the code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: light: vcnl4000: Use devm_iio_device_register
Sachin Kamat [Tue, 29 Oct 2013 11:39:00 +0000 (11:39 +0000)]
iio: light: vcnl4000: Use devm_iio_device_register

devm_iio_device_register simplifies the code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: gyro: adxrs450: Use devm_iio_device_register
Sachin Kamat [Tue, 29 Oct 2013 11:39:00 +0000 (11:39 +0000)]
iio: gyro: adxrs450: Use devm_iio_device_register

devm_iio_device_register simplifies the code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: gyro: adis16130: Use devm_iio_device_register
Sachin Kamat [Tue, 29 Oct 2013 11:39:00 +0000 (11:39 +0000)]
iio: gyro: adis16130: Use devm_iio_device_register

devm_iio_device_register simplifies the code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: dac: ad5755: Use devm_iio_device_register
Sachin Kamat [Tue, 29 Oct 2013 11:39:00 +0000 (11:39 +0000)]
iio: dac: ad5755: Use devm_iio_device_register

devm_iio_device_register simplifies the code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: dac: ad5421: Use devm_iio_device_register
Sachin Kamat [Tue, 29 Oct 2013 11:39:00 +0000 (11:39 +0000)]
iio: dac: ad5421: Use devm_iio_device_register

devm_iio_device_register simplifies the code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: adc: viperboard: Use devm_iio_device_register
Sachin Kamat [Tue, 29 Oct 2013 11:39:00 +0000 (11:39 +0000)]
iio: adc: viperboard: Use devm_iio_device_register

devm_iio_device_register simplifies the code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio:magnetometer:hmc5843 - add basic dt support
NeilBrown [Fri, 1 Nov 2013 05:35:00 +0000 (05:35 +0000)]
iio:magnetometer:hmc5843 - add basic dt support

Compatible string, documenation and an optional gpio
for the dataready pin.

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio:light:tsl2563: Add DT support
Sebastian Reichel [Fri, 25 Oct 2013 09:10:00 +0000 (10:10 +0100)]
iio:light:tsl2563: Add DT support

Add Device Tree support for the TSL2563 driver,
document the binding and add AMS-TAOS Inc. to the
list of vendor prefixes.

Signed-off-by: Sebastian Reichel <sre@debian.org>
Acked-by: Kumar Gala <galak@codeaurora.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: Add Freescale MPL3115A2 pressure / temperature sensor driver
Peter Meerwald [Tue, 12 Nov 2013 19:43:00 +0000 (19:43 +0000)]
iio: Add Freescale MPL3115A2 pressure / temperature sensor driver

I2C-controlled MEMS sensor with 20-bit pressure measurement (pascal) and
12-bit temperature measurement

driver only exposes basic functionality, see TODO remarks
datasheet: http://cache.freescale.com/files/sensors/doc/data_sheet/MPL3115A2.pdf

v2:
* store 20-bit value in 32-bit buffer element (instead of 24-bit)
* zero buffer to prevent kernel data leak to userspace
* fix mutex unlock in trigger handler (thanks Andi Shyti)

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Reviewed-by: Andi Shyti <andi@etezian.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: Remove redundant check that new trigger is different from old
Peter Meerwald [Tue, 12 Nov 2013 21:49:00 +0000 (21:49 +0000)]
iio: Remove redundant check that new trigger is different from old

same check is performed a new lines above

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: Minor kerneldoc fix for iio_trigger_write_current()
Peter Meerwald [Tue, 12 Nov 2013 21:49:00 +0000 (21:49 +0000)]
iio: Minor kerneldoc fix for iio_trigger_write_current()

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: adc: mcp3422: Use devm_iio_device_register
Sachin Kamat [Tue, 29 Oct 2013 11:39:00 +0000 (11:39 +0000)]
iio: adc: mcp3422: Use devm_iio_device_register

devm_iio_device_register simplifies the code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: core: Move kernel doc to the right location
Sachin Kamat [Tue, 29 Oct 2013 11:39:00 +0000 (11:39 +0000)]
iio: core: Move kernel doc to the right location

Documentation related to function should be placed above
its implementation. Move it accordingly.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: core: Implement devm_iio_device_{register,unregister}
Sachin Kamat [Tue, 29 Oct 2013 11:39:00 +0000 (11:39 +0000)]
iio: core: Implement devm_iio_device_{register,unregister}

Add device managed devm_iio_device_{register,unregister}()
to automatically unregister IIO drivers thus leading to
simplified IIO driver code.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Tested-by: Lars-Peter Clausen <lars@metafoo.de>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>